aboutsummaryrefslogtreecommitdiffstats
path: root/configure.ac
AgeCommit message (Collapse)AuthorFilesLines
2010-05-17Cache sound tarfiles in a common directory, such that a clean reinstall does ↵tilghman1-0/+1
not force a re-download of the tarballs. (closes issue #15370) Reported by: pprindeville Patches: asterisk-trunk-bugid15370.patch uploaded by pprindeville (license 347) Tested by: pprindeville, tilghman, seanbright git-svn-id: http://svn.digium.com/svn/asterisk/trunk@263724 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-13Remove "untested" feature PRI_VERSIONtzafrir1-1/+0
Nobody seems to actually test PRI_VERSION. It is only useful for failing PRI support in chan_dahdi. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@263028 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-13Add kqueue(2) implementation to Asterisk in various places.tilghman1-1/+24
This will save a considerable amount of CPU on the BSDs, including Mac OS X, as it eliminates several places in the code that we previously used a busy loop. Additionally, this adds a res_timing interface, using kqueue timers. Review: https://reviewboard.asterisk.org/r/543/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@262852 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-11Dialing an invalid extension causes incomplete hangup sequence.rmudgett1-0/+2
Revision -r1489 of the libpri 1.4 branch corrected a deviation from Q.931 Section 5.3.2. However, this resulted in an unexpected behaviour change to the upper layer (Asterisk). This change uses pri_hangup_fix_enable() to follow Q.931 Section 5.3.2 call hangup better if the version of libpri supports it. (issue #17104) Reported by: shawkris Tested by: rmudgett git-svn-id: http://svn.digium.com/svn/asterisk/trunk@262569 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-08Use CPPFLAGS to pass PTHREAD_CFLAGS for vpb onlytilghman1-3/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@262048 f38db490-d61c-443f-a65b-d21fe96a405b
2010-05-07Use the detected pthread building flags in every place, instead of ↵tilghman1-22/+34
hardcoding -lpthread. We nicely detect the right flags on each system for building Asterisk with pthreads, then ignore it for every other build option that requires us to build with pthreads. This caused some items to return a false negative. Also cleanup some minor naming issues that caused "library library" redundancy in the output. (closes issue #17303) Reported by: stuarth Patches: 20100507__issue17303.diff.txt uploaded by tilghman (license 14) Tested by: stuarth git-svn-id: http://svn.digium.com/svn/asterisk/trunk@261913 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-28Merged revisions 259847 via svnmerge from qwell1-0/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r259847 | qwell | 2010-04-28 15:30:21 -0500 (Wed, 28 Apr 2010) | 1 line Add AC_CONFIG_AUX_DIR to configure script, so systems without install can use install-sh from our source dir. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@259848 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-28Merged revisions 259748 via svnmerge from qwell1-1/+0
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r259748 | qwell | 2010-04-28 14:17:38 -0500 (Wed, 28 Apr 2010) | 7 lines Remove usage of `id` since it isn't useful and was causing breakge. Solaris `id` doesn't support the -u argument. Instead of figuring out how to fix this to work on Solaris, I decided to check why it was necessary and where else it was used. It was only used in one place, and it hasn't been needed for a very long time (I question whether it was ever needed). ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@259760 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-27Merged revisions 259352 via svnmerge from qwell1-2/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r259352 | qwell | 2010-04-27 14:29:26 -0500 (Tue, 27 Apr 2010) | 5 lines Support the silly OSes that don't have ar and strip. Since AC_PATH_TOOL is equiv to AC_CHECK_TOOL when path isn't specified, and AC_PATH_TOOLS doesn't exist, we'll just switch to AC_CHECK_TOOLS. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@259353 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-21Add ability to generate ASCII documentation from the TeX files.lmadsen1-0/+1
These changes add the ability to run 'make asterisk.txt' just like the existing 'make asterisk.pdf' commands to generate a text document from the TeX files we have in the doc/tex/ directory. I've also updated a few of the .tex files because they weren't properly escaping certain characters so they would show up as Unicode characters (like [U+021C]). Made changes to the configure scripts so it would detect the catdvi program which is required to convert the .dvi file generated by latex. I've also added a few lines to the build_tools/prep_tarball script so that the text documentation gets generated and added to future tarballs of Asterisk releases. (closes issue #17220) Reported by: lmadsen Patches: asterisk.txt.patch uploaded by lmadsen (license 10) asterisk.txt.patch-v4 uploaded by pabelanger (license 224) Tested by: lmadsen, pabelanger git-svn-id: http://svn.digium.com/svn/asterisk/trunk@258351 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-09Merge Call completion support into trunk.mmichelson1-0/+2
From Reviewboard: CCSS stands for Call Completion Supplementary Services. An admittedly out-of-date overview of the architecture can be found in the file doc/CCSS_architecture.pdf in the CCSS branch. Off the top of my head, the big differences between what is implemented and what is in the document are as follows: 1. We did not end up modifying the Hangup application at all. 2. The document states that a single call completion monitor may be used across multiple calls to the same device. This proved to not be such a good idea when implementing protocol-specific monitors, and so we ended up using one monitor per-device per-call. 3. There are some configuration options which were conceived after the document was written. These are documented in the ccss.conf.sample that is on this review request. For some basic understanding of terminology used throughout this code, see the ccss.tex document that is on this review. This implements CCBS and CCNR in several flavors. First up is a "generic" implementation, which can work over any channel technology provided that the channel technology can accurately report device state. Call completion is requested using the dialplan application CallCompletionRequest and can be canceled using CallCompletionCancel. Device state subscriptions are used in order to monitor the state of called parties. Next, there is a SIP-specific implementation of call completion. This method uses the methods outlined in draft-ietf-bliss-call-completion-06 to implement call completion using SIP signaling. There are a few things to note here: * The agent/monitor terminology used throughout Asterisk sometimes is the reverse of what is defined in the referenced draft. * Implementation of the draft required support for SIP PUBLISH. I attempted to write this in a generic-enough fashion such that if someone were to want to write PUBLISH support for other event packages, such as dialog-state or presence, most of the effort would be in writing callbacks specific to the event package. * A subportion of supporting PUBLISH reception was that we had to implement a PIDF parser. The PIDF support added is a bit minimal. I first wrote a validation routine to ensure that the PIDF document is formatted properly. The rest of the PIDF reading is done in-line in the call-completion-specific PUBLISH-handling code. In other words, while there is PIDF support here, it is not in any state where it could easily be applied to other event packages as is. Finally, there are a variety of ISDN-related call completion protocols supported. These were written by Richard Mudgett, and as such I can't really say much about their implementation. There are notes in the CHANGES file that indicate the ISDN protocols over which call completion is supported. Review: https://reviewboard.asterisk.org/r/523 git-svn-id: http://svn.digium.com/svn/asterisk/trunk@256528 f38db490-d61c-443f-a65b-d21fe96a405b
2010-04-06Mac OS X does not support comparing a mutex to its initializer. Create a ↵tilghman1-0/+14
test for this. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@256370 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-17Fix bamboo compile error by calculating an integer with the same size as a ↵tilghman1-1/+4
pointer. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@252980 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-08Remove portions that weren't meant to be committed for the OS X compat fixtilghman1-4/+0
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251263 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-08Change needed to make Mac OS X 10.6 happytilghman1-0/+4
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251262 f38db490-d61c-443f-a65b-d21fe96a405b
2010-03-05Remove pbx_gtkconsole and related gtk1 checks.russell1-4/+0
Review: https://reviewboard.asterisk.org/r/541/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@251022 f38db490-d61c-443f-a65b-d21fe96a405b
2010-02-10Solaris doesn't like outputting a NULL to a %s in format strings.tilghman1-0/+12
Detect all platforms that don't like that, either, and ensure that when documentation is missing, we pass a non-NULL pointer when outputting the corresponding documentation. (closes issue #16689) Reported by: bklang Patches: 20100209__issue16689__with_tests.diff.txt uploaded by tilghman (license 14) Review: https://reviewboard.asterisk.org/r/497/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@246030 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-25Merged revisions 242966 via svnmerge from tilghman1-0/+10
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r242966 | tilghman | 2010-01-25 15:36:33 -0600 (Mon, 25 Jan 2010) | 2 lines Only rebuild parsers by an option in menuselect ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@242967 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-25Merged revisions 242852 via svnmerge from tilghman1-0/+33
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r242852 | tilghman | 2010-01-25 14:15:45 -0600 (Mon, 25 Jan 2010) | 2 lines Restore FreeBSD to able-to-compile-ish-mode ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@242857 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-24Merged revisions 242520 via svnmerge from tilghman1-0/+2
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r242520 | tilghman | 2010-01-24 00:33:01 -0600 (Sun, 24 Jan 2010) | 8 lines Only rebuild bison and flex source files on demand, if bison and flex are detected by the configure script. Changed after discussion on the -dev list about possible unnecessary build failures, due to checkouts/untars causing these special source files to possibly be newer than their resulting C files. This should additionally ensure that nobody need learn about extra Makefile arguments to ensure the proper files get rebuilt when changes are made to these special source files. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@242521 f38db490-d61c-443f-a65b-d21fe96a405b
2010-01-21Merged revisions 241932 via svnmerge from seanbright1-2/+3
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r241932 | seanbright | 2010-01-21 10:25:46 -0500 (Thu, 21 Jan 2010) | 5 lines Fix configure check for PTHREAD_ONCE_INIT when manually adding -Wall to CFLAGS. (closes issue #16666) Reported by: romain_proformatique ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@241938 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-291. Updated for OSP Toolkit 3.6.0.transnexus1-1/+1
2. Added service type ported number query. 3. Formated code. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@236756 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-28Merged revisions 236585 via svnmerge from seanbright1-0/+20
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r236585 | seanbright | 2009-12-28 10:12:08 -0500 (Mon, 28 Dec 2009) | 7 lines Try a test compile to see if PTHREAD_ONCE_INIT requires extra braces. There was conditional code (based on build platform) to optioinally wrap PTHREAD_ONCE_INIT in braces that was removed since it is fixed in newer versions of Solaris/OpenSolaris, but I am still running into it on Solaris 10 x86 so add a configure-time check for it. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@236613 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-18Merged revisions 235652 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r235652 | tilghman | 2009-12-18 16:39:30 -0600 (Fri, 18 Dec 2009) | 2 lines Revise verbiage, per #asterisk-dev discussion ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@235656 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-18Merged revisions 235572 via svnmerge from tilghman1-1/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r235572 | tilghman | 2009-12-18 15:18:16 -0600 (Fri, 18 Dec 2009) | 2 lines Point to the typical missing package, not the cryptic "termcap support". ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@235573 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-04OS X does not define MSG_NOSIGNAL, but it does have a socket option ↵tilghman1-0/+4
SO_NOSIGPIPE. (closes issue #16178) Reported by: oej git-svn-id: http://svn.digium.com/svn/asterisk/trunk@232950 f38db490-d61c-443f-a65b-d21fe96a405b
2009-12-02So apparently, some platforms don't have ffsll(3).tilghman1-1/+1
The manpage lies; it says that the function is in POSIX, but that's only for ffs(3), not ffsll(3). git-svn-id: http://svn.digium.com/svn/asterisk/trunk@232164 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-04Expand codec bitfield from 32 bits to 64 bits.tilghman1-1/+1
Reviewboard: https://reviewboard.asterisk.org/r/416/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@227580 f38db490-d61c-443f-a65b-d21fe96a405b
2009-11-04chan_misdn will fail to compile if the redirect_dn member is missingtilghman1-0/+1
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@227579 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-26detect ARM Linux EABI OSARCH as linux-gnu instead of linux-gnueabitzafrir1-1/+4
* Set OSARCH to linux-gnu even if host_os is linux-gnueabi * When checking if we are Linux, check OSARCH rather than host_os The newer ARM ABI ("EABI") shows the OS name 'linux-gnueabi' rather than 'linux-gnu' . This patch sets OSARCH to be 'linux-gnu' even in such a case. OSARCH is tested for the value of 'linux-gnu' in one or two places in the tree. This patch also fixes the check libcap to check for $OSARCH rather than $host_os . See also: http://wiki.debian.org/ArmEabiPort Merged revisions 225957 via svnmerge from http://svn.digium.com/svn/asterisk/branches/1.4 git-svn-id: http://svn.digium.com/svn/asterisk/trunk@226018 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-23Add to chan_dahdi ISDN HOLD, Call deflection, and keypad facility support.rmudgett1-0/+6
* Added handling of received HOLD/RETRIEVE messages and the optional ability to transfer a held call on disconnect similar to an analog phone. * Added CallRerouting/CallDeflection support for Q.SIG, ETSI PTP, ETSI PTMP. Will reroute/deflect an outgoing call when receive the message. Can use the DAHDISendCallreroutingFacility to send the message for the supported switches. * Added ability to send/receive keypad digits in the SETUP message. Send keypad digits in SETUP message: Dial(DAHDI/g1[/K<keypad_digits>][/extension]) Access any received keypad digits in SETUP message by: ${CHANNEL(keypad_digits)} * Added support for BRI PTMP NT mode. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@225692 f38db490-d61c-443f-a65b-d21fe96a405b
2009-10-22Add support for calling and called subaddress. Partial support for COLP ↵rmudgett1-0/+6
subaddress. The Telecom Specs in NZ suggests that SUB ADDRESS is always on, so doing "desk to desk" between offices each with an asterisk box over the ISDN should then be possible, without a whole load of DDI numbers required. (closes issue #15604) Reported by: alecdavis Patches: asterisk_subaddr_trunk.diff11.txt uploaded by alecdavis (license 585) Some minor modificatons were made. Tested by: alecdavis, rmudgett Review: https://reviewboard.asterisk.org/r/405/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@225357 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-16Detect whether we actually have the long double type, before looking for ↵tilghman1-2/+11
those functions. (closes issue #15017) Reported by: tzafrir Patches: 20090916__issue15017.diff.txt uploaded by tilghman (license 14) Tested by: tzafrir git-svn-id: http://svn.digium.com/svn/asterisk/trunk@219007 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-10Verify support for wide ODBC character types before using them.tilghman1-0/+14
(closes issue #15870) Reported by: nic_bellamy git-svn-id: http://svn.digium.com/svn/asterisk/trunk@217638 f38db490-d61c-443f-a65b-d21fe96a405b
2009-09-08Ensure that the default autoconf CFLAGS are not used.kpfleming1-5/+11
A recent change to the configure script that allows the user to specify CFLAGS and/or LDFLAGS to the script had the unfortunate side effect of letting autoconf's default CFLAGS (-g -O2) feed in to the rest of the build system, thereby overriding the DONT_OPTIMIZE setting in menuselect. That problem is now corrected. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@217074 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-30If lua is detected with the lua5.1 prefix (or not), adjust the include path ↵tilghman1-0/+4
accordingly. Based upon feedback to a release announcement on the -users list. See http://lists.digium.com/pipermail/asterisk-users/2009-August/236954.html git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214819 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-28Ensure that CFLAGS and/or LDFLAGS provided to configure script are preserved.kpfleming1-0/+6
Cross-compilation environments want to provide 'defaults' for compiler and linker options, and frequently do this by specifying CFLAGS and LDFLAGS in the environment or as command-line arguments to the configure script. This patch modifies the configure script and Makefile to preserve these settings and ensure they are used in the build process. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214696 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-27Merged revisions 214517 via svnmerge from tilghman1-31/+1
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214517 | tilghman | 2009-08-27 16:45:34 -0500 (Thu, 27 Aug 2009) | 7 lines Use autoconf to detect libcurl, as this enables cross-compilation checks, something we didn't allow before. (closes issue #15714) Reported by: pprindeville Patches: 20090813__issue15714.diff.txt uploaded by tilghman (license 14) Tested by: pprindeville ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214518 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-27Merged revisions 214436 via svnmerge from tilghman1-50/+10
https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214436 | tilghman | 2009-08-27 11:53:58 -0500 (Thu, 27 Aug 2009) | 2 lines One more build system change, to make the descriptions look better, if we have better information. ........ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214466 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-25Not all versions of gnu-linux use glibc, which contains iconv. Some ↵tilghman1-5/+3
(especially embedded systems) don't have iconv at all. (closes issue #15169) Reported by: pprindeville git-svn-id: http://svn.digium.com/svn/asterisk/trunk@214152 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-21Update configure script for libpri COLP feature dependency requirements.rmudgett1-4/+5
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@213748 f38db490-d61c-443f-a65b-d21fe96a405b
2009-08-06Minor improvements to app_fax.kpfleming1-4/+0
This patch makes some small changes to handle watchdog timeouts in a better way, and also uses a 'cleaner' method of including the spandsp header files. (closes issue #14769) Reported by: andrew Patches: app_fax-20090406.diff uploaded by andrew (license 240) v1-14769.patch uploaded by dimas (license 88) Tested by: freh, deti, caspy, dimas, sgimeno, Dovid git-svn-id: http://svn.digium.com/svn/asterisk/trunk@210777 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-30Allow passing 'noisy' to configure's --enable-dev-mode argument to turn on ↵seanbright1-0/+5
verbose builds. (closes issue #15607) Reported by: mvanbaak Patches: 20090730_issue15607.patch uploaded by seanbright (license 71) Tested by: seanbright git-svn-id: http://svn.digium.com/svn/asterisk/trunk@209623 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-08Fix a few compilation problems found when building Asterisk against uClibc.seanbright1-0/+19
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@205214 f38db490-d61c-443f-a65b-d21fe96a405b
2009-07-03Add a configure check for Reverse Charging Indication support in LibPRI.seanbright1-0/+2
Also go back and wrap all of the places that use the specific reverse charge APIs with preprocessor conditionals. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@204919 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-30Move Asterisk-addons modules into the main Asterisk source tree.russell1-6/+12
Someone asked yesterday, "is there a good reason why we can't just put these modules in Asterisk?". After a brief discussion, as long as the modules are clearly set aside in their own directory and not enabled by default, it is perfectly fine. For more information about why a module goes in addons, see README-addons.txt. chan_ooh323 does not currently compile as it is behind some trunk API updates. However, it will not build by default, so it should be okay for now. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@204413 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-26Add a new module, cdr_syslog, which allows writing CDRs to syslog.seanbright1-0/+5
The original patch for this was written by Brett Bryant, and I split it out into it's own module. (closes issue #12876) Reported by: bbryant Patches: 06162008_cdr_custom_syslog.diff uploaded by bbryant (license 36) 05212009_cdr_syslog.patch uploaded by seanbright (license 71) Tested by: seanbright Review: https://reviewboard.asterisk.org/r/297/ git-svn-id: http://svn.digium.com/svn/asterisk/trunk@203846 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-26Add checks in configure for non-POSIX syslog facilities.seanbright1-0/+15
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@203569 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-16Explicitly test for 'static weakref' support.kpfleming1-1/+1
Since we use 'static' weakref symbols, and not all GCC versions support them, test for that combination explicitly. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@201137 f38db490-d61c-443f-a65b-d21fe96a405b
2009-06-16Another minor fix to compiler attribute checking.kpfleming1-1/+1
Defaulting to 'static' for the function scope was bad... so remove it. git-svn-id: http://svn.digium.com/svn/asterisk/trunk@201090 f38db490-d61c-443f-a65b-d21fe96a405b