aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2019-02-24[Automatic update for 2019-02-24]Gerald Combs3-27/+27
Update manuf, services enterprise numbers, translations, and other items. Change-Id: If37808291aca1f9bdd75d064bbfb738b89945eb8 Reviewed-on: https://code.wireshark.org/review/32180 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-21Qt: Add display information to the About dialog.Gerald Combs3-0/+31
Add ColorUtils::themeIsDark and use it to report our dark / light mode in the "About" dialog. Summarize the HiDPI capability of our displays as well. Change-Id: I242af1eb48017d49b90e71099bb753e67a8dd32b Reviewed-on: https://code.wireshark.org/review/32115 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-20Qt: Keep column width and align when edit custom fieldsStig Bjørlykke1-0/+5
Reapply the column width and alignment when editing the fields in a custom column. Bug: 14177 Change-Id: I581ea67505f9181c1e5133c9950f59ed0780b0ba Reviewed-on: https://code.wireshark.org/review/32121 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-02-20Qt: fix compilation without pcap on gcc-8 and clang-7.Dario Lombardo1-0/+2
Change-Id: Ica9793ed9da2332f70cfb783dad8200340be34bf Reviewed-on: https://code.wireshark.org/review/32119 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-02-20Qt: Fix restart capture when using a ring bufferStig Bjørlykke3-35/+1
Set capture_opts->restart before restart current capture. Update the restart handling in capture_input_closed() to not remove the current save file; this is either the last file in a ring buffer or a temporary file which will be reused later. Also remove the code which starts the capture again because this is now done in MainWindow::on_actionCaptureRestart_triggered(). Keep the code to restore the original save file when having a ring buffer. This will avoid the error message "Ring buffer requested, but capture isn't being saved to a permanent file" and a following unwanted capture stop. This fix will also avoid the "No packets captured" warning when restart capture without having any packets captured. Remove the unused capture_restart() function which was used in GTK. Change-Id: I80802217b71810eaa36b78a2eb4c32697ddc92ce Reviewed-on: https://code.wireshark.org/review/32110 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-20Qt: Fix removal of "Capture to a permanent file" settingStig Bjørlykke1-0/+5
Make it possible to remove the "Capture to a permanent file" setting in Capture Interfaces Output dialog by turning off saving_to_file in updateInterfaces(). Also make sure to free the old values for save_file and orig_save_file to avoid memory leaks. Set orig_save_file to the same as save_file from the '-w' option to fill in the current "Capture to a permanent file" value correctly. Change-Id: I1f4df8cfa279f934eff028f32838b9734b627af1 Reviewed-on: https://code.wireshark.org/review/32111 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-17[Automatic update for 2019-02-17]Gerald Combs10-1382/+1559
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I987de3e066ca86facb6c79ac3b233f05779f6423 Reviewed-on: https://code.wireshark.org/review/32068 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-16Re-implement "Map" feature for EndpointsPeter Wu4-21/+376
This feature was removed in v2.5.1rc0-427-gf529ab5d0a, anticipating that MaxMind would remove support for it in 2019. They have however changed their mind and maintained latitude and longitude information. They recommend displaying an accuracy radius, but the reported values are 50, 100, 200 and 1000km. When implemented literally, a marker in Ireland would cover the whole island plus mainland, so I have instead opted to use a fixed radius of 1km at deeper zoom levels. The old ipmap.html file was outdated and had broken tiles, I rewrote a new one from scratch using the light-weight Leaflet library combined with tiles from OpenStreetMap. This is more mobile-friendly and secure (https, SRI). To improve handling of nearby or overlapping nodes, clustering is used (individual nodes can still be inspected). Browser compatibility results: IE8 is unusable, IE9 partially works (tooltips sometimes disappear and the cluster radius control is gone), IE11 works. Of course Firefox 65 and Chromium 72 have no issues. The map popup description in the generated GeoJSON structure is now split in several properties, allowing presentation to be handled by the HTML page instead of the C code. Bug: 14693 Change-Id: If2ec9c518f7723ac0ab27b6272463356875a0ff2 Reviewed-on: https://code.wireshark.org/review/31952 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-02-15Replace Qsort with std::sortAnders Broman2-3/+3
Change-Id: Ia3741e7b3542524370ac69f731db072d19a44616 Reviewed-on: https://code.wireshark.org/review/32044 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-02-14Convert the FAQ to Asciidoctor and remove old help files.Gerald Combs1-1/+1
Convert our self-generating FAQ to Asciidoctor via the following steps: - `help/faq.py > /tmp/faq.html`. - `pandoc -t asciidoc -o docbook/faq.adoc /tmp/faq.html`. - Manually clean up the markup using a text editor. Question and answer content was left intact. Removing or updating obsolete content will have to be done in a separate change. The Asciidoctor project uses the .adoc extension, so start using it here as well. The contents of the "help" directory appear to have been used for offline support in help_url.c, but that functionality was removed in 2008 in 242e3b78bc. Its content is covered in the User's Guide and man pages so remove it. Change-Id: I9060eefe97cfc137f8b414077c30f814379b576a Reviewed-on: https://code.wireshark.org/review/32014 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-13Add macros for the pack_flags field.Guy Harris1-4/+4
Add macros to extract the direction, reception type, and FCS length fields of the pack_flags field, and add definitions for different directions and reception types. Add a macro to construct a pack_flags field value from subfields; this is for use by non-pcapng file readers (the pack_flags field is just a copy of the EPB flags option, so that's not needed for pcapng). Move some #defines for that field from packet-frame.c to wtap.h, and rename them to match the new macros. Use the macros rather than rolling our own code. Fix a variable name in text2pcap.c that apparently had the wrong name, given the value that was being tested. Change-Id: Ia788ca4e9f5fabd8d24e6ead5ff1817509f54827 Reviewed-on: https://code.wireshark.org/review/32010 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-02-11Qt: Fix Crash in empty Bluetooth windowsMichał Łabędzki3-20/+46
Avoid crashed in context menu in Bluetooth windows when there is no any items. Also add missing last column in "Copy All" in HCI Summary (fix console warning). Change-Id: I28af0208c3b1c813d43305f3c0a4bf19f66d3e31 Reviewed-on: https://code.wireshark.org/review/31977 Petri-Dish: Michal Labedzki <michal.labedzki@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-02-11Change maxmind_db_lookup_ipv4 to look more like maxmind_db_lookup_ipv6Peter Wu1-3/+1
Both functions accept an address in network byte order, but maxmind_db_lookup_ipv4 does not accept a pointer. Add an indirection and remove unnecessary memcpy calls. This removes some confusion for me. Change-Id: I291c54c8c55bc8048ca011b84918c8a5d3ed1398 Reviewed-on: https://code.wireshark.org/review/31951 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-10[Automatic update for 2019-02-10]Gerald Combs10-770/+1093
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I3ac8fcfec83e5d35ee07e07cd0d1d04a17cc2ac5 Reviewed-on: https://code.wireshark.org/review/31954 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-02-08Fixing some implicit coversations (-Wshorten-64-to-32)Uli Heilmeier3-13/+13
Fixing some "implicit conversion loses integer precision" warnings reported by clang with -Wshorten-64-to-32 option Change-Id: Icd641d5f4fd8ff129f03f1b9e1da0fc86329f096 Reviewed-on: https://code.wireshark.org/review/31901 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-07Qt: move packet list cache from record to modelMichał Łabędzki4-20/+16
Change-Id: Idf6a10374382c8521eb205c801a72af329e5d0d2 Reviewed-on: https://code.wireshark.org/review/31528 Petri-Dish: Michal Labedzki <michal.labedzki@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-05Accept protocol aliases in Decode As (-d tcp.port==4433,ssl)Peter Wu1-2/+8
Change-Id: Idb2e4f9964cf0b5c1237a0d4b5e0954adfd5e6b6 Reviewed-on: https://code.wireshark.org/review/31895 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-02-04Qt: Add missing main menu mnemonics.Gerald Combs1-29/+29
The GTK+ main menu had quite a few keyboard mnemonics which were missing in the Qt UI, most notably File → Open, File → Close, and File → Quit. Update ui/qt/main_window.ui from a list generated by running `grep -E 'NULL, +".*_.*"' ui/gtk/main_menubar.c` in a current master-2.6 checkout. BTW, the proper terminology to use here is unclear. Most places use "mnemonics": GTK+: Access keys https://developer.gnome.org/hig/stable/keyboard-input.html.en Qt: Mnemonics or accelerator keys http://doc.qt.io/qt-5/qkeysequence.html http://doc.qt.io/qt-5/accelerators.html Wikipedia: Mnemonics https://en.wikipedia.org/wiki/Keyboard_shortcut Windows: Menu access keys or mnemonics https://docs.microsoft.com/en-us/windows/desktop/menurc/about-menus Bug: 15475 Change-Id: Ibacbe066d4acfcea91125a980977d1610e3c0908 Reviewed-on: https://code.wireshark.org/review/31871 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-03[Automatic update for 2019-02-03]Gerald Combs10-82/+1062
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ied5443aa5e45bb0d2b59ad33f1aa0195fafb70f3 Reviewed-on: https://code.wireshark.org/review/31859 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-31wireshark: Free the if_stat_cache_t when dumpcap is not forkedVasil Velichkov1-5/+7
Fixes ASAN test failures for test_wireshark_capture_from_stdin and test_wireshark_capture_from_fifo tests. Change-Id: I196fe2a299761f95e07b3091b934a566403e3e3f Reviewed-on: https://code.wireshark.org/review/31844 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-31Fix build without GnuTLSPeter Wu4-2/+16
The RSA Keys API and GUI are only functional when GnuTLS support is available. Be sure to hide the functions in the header and hide the preferences panel when GnuTLS support is missing. Change-Id: I0a52ab142c4d45b8186780ea9b1645542dcc6305 Fixes: v2.9.1rc0-585-gec8f506c4b ("Qt: add initial RSA Keys preference frame") Reviewed-on: https://code.wireshark.org/review/31837 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-31Qt: Restore column width and visibility when switching profilesStig Bjørlykke1-0/+3
In some cases the column width and/or hidden setting is not correctly applied when switching between profiles having different hidden settings. Unhiding the column before applying width and hidden setting fixes this issue. Bug: 15466 Change-Id: I09e3451612ba6dd0510b19f7f4d84d281b0188b5 Reviewed-on: https://code.wireshark.org/review/31812 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-01-29Qt: Add support for RSA private key file selectionPeter Wu3-0/+44
Update release notes now that this GUI is mostly functional. Change-Id: I118fbbe879e366643084f0e7ac3e437a29f21d5f Reviewed-on: https://code.wireshark.org/review/31797 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-29Qt: implement addition of a new pkcs11 token in the RSA Keys dialogPeter Wu3-0/+113
Load the list of key URIs, strip known keys, ask for a PIN, add valid results to the list. Apply this list on pressing OK in the preferences dialog or revert the changes on pressing Cancel. Change-Id: Id48cd9b876b4d272eb6dbdadf8a0859190cc0ce8 Reviewed-on: https://code.wireshark.org/review/31796 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-29Qt: add initial RSA Keys preference framePeter Wu8-0/+312
The RSA Keys frame is intended to configure RSA keys (both key files and PKCS #11 tokens). Add a new "RSA Keys" item to the preferences menu. Implement addition and removal of PKCS #11 libraries and add an initial version that displays configured RSA keys. The "Add new token…" button will be implemented later. Change-Id: Ie5b9eb403afc7bebeb7be8bd53d4d4b30842204c Reviewed-on: https://code.wireshark.org/review/31795 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-29Qt: move method to apply/undo UAT changes to UatModelPeter Wu5-51/+90
UatModel could be constructed with a name instead of an epan_uat type. To allow those users to save/revert the uat, make sure to expose a method that does not require access to the underlying epan_uat type. Change-Id: I1d1a5811c1025bd9c2a2ea1722f460e6ac33b9aa Reviewed-on: https://code.wireshark.org/review/31793 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-29Qt: Fix memory leak of QMenu.Stig Bjørlykke2-4/+6
Set the push button as parent to the save menu so it will be deleted when that parent is destroyed. Change-Id: Ic396dcf25092c90cd305a010be3d551d8ad8397c Reviewed-on: https://code.wireshark.org/review/31802 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-27[Automatic update for 2019-01-27]Gerald Combs1-336/+398
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I2a887e9f0d6aa73fee4046a77271a55be48b1864 Reviewed-on: https://code.wireshark.org/review/31759 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-25wiretap: fix memleaks with wtap_rec::opt_commentPeter Wu1-0/+3
The memory ownership of wtap_rec::opt_comment was not clear. Users of wtap were leaking memory (editcap.c). wtap readers were not sure about freeing old comments (erf) or simply ignored memleaks (pcapng). To fix this, ensure opt_comment is owned by wtap_rec and free it with wtap_rec_cleanup. The erf issue was already addressed since cf_get_packet_comment properly duplicates wth.opt_comment memory. - wtap file formats (readers): - Should allocate memory for new comments. - Should free a comment from an earlier read before writing a new one. - Users of wth: - Can only assume that opt_comment remains valid until the next read. - Can assume that wtap_dump does not modify the comment. - For random access (wtap_seek_read): should call wtap_rec_cleanup to free the comment. The test_tshark_z_expert_comment and test_text2pcap_sip_pcapng tests now pass when built with ASAN. This change was created by carefully looking at all users opt "opt_comment" and cf_get_packet_comment. Thanks to Vasil Velichkov for an initial patch which helped validating this version. Bug: 7515 Change-Id: If3152d1391e7e0d9860f04f3bc2ec41a1f6cc54b Reviewed-on: https://code.wireshark.org/review/31713 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Vasil Velichkov <vvvelichkov@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-25Fix memory ownership when using cf_get_packet_commentPeter Wu2-4/+3
cf_get_packet_comment already has one code path that returns duplicated memory. Be sure to document the requirement to free this memory and adjust Qt to avoid memory leaks. Be firm and assume that wth.opt_comment is owned by wth, so duplicate it before returning it from cf_get_packet_comment. Change-Id: I91f406296c9db5ea21b90fc2e108c37de4528527 Ping-Bug: 7515 Reviewed-on: https://code.wireshark.org/review/31712 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Vasil Velichkov <vvvelichkov@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-24wiretap: fix leak of options_buf and document memory handlingPeter Wu1-1/+3
Manually checked all callers of wtap_seek_read to ensure that wtap_rec_cleanup is called. Added missing wtap_rec_cleanup to: - Completion of sequential read: wtap_sequential_close - Callers of wtap_seek_read: - users of cf_read_record_r: - PacketListRecord::dissect This fixes one of the two ASAN memleak reports while running test_tshark_z_expert_comment and test_text2pcap_sip_pcapng (the other is about opt_comment which is still unfixed). Vasil Velichkov also found this issue and came up with a similar fix. Change-Id: I54a6aa70bfdb42a816d03ad4861d0ad821d0ef88 Reviewed-on: https://code.wireshark.org/review/31709 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-23text import: cleanup type usageJaap Keuter1-7/+7
The glib gboolean and integer types are used interchangably, while a proper use is easily achievable. Change-Id: I8943bb90c9f23c0e58c296ad3b45153d0364953c Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/31708 Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-22Qt: Include current word in filter completion listStig Bjørlykke2-4/+2
Include the current word in the filter completion list to give the user a more complete picture of what constitutes a valid single-token protocol name. Bug: 15431 Change-Id: I77cfc78f19623d9aefd4441a67ed3ae72068034e Reviewed-on: https://code.wireshark.org/review/31654 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-21Text Import: update code comments and help textsJaap Keuter2-13/+13
From the updates to text2pcap take the updates to the code comments and apply them here as well. This also applies to the User Guide help texts. Change-Id: I4e73fb1372ea0c1866c6d0fee7c14bc645fbe1b1 Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/31636 Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-20CMake: Replace PACKAGELIST magicJoão Valverde2-0/+21
This is more explicit and easier to read with slightly better locality while using less code. Also less awkward when the package doesn't fit the narrow package list expectations. The ws_find_package() macro doesn't include all the status messages. The choice was to rely on standard find_package() and feature_summary() output and be less verbose. Avoid polluting the CLI build interface. Per target include paths and macro definitions are preferred. Because this patch intentionally removes the global CMAKE_*_FLAGS and include_directories() usage in favor of target properties, some untested build configurations may inadvertently break because of missing ${PACKAGE}_INCLUDE_DIRS or ${PACKAGE}_DEFINITIONS. This required a manual review of dependencies that might have been incomplete. ${PACKAGE_VAR}_LINK_FLAGS seems to be unused. Changing the CMake Qt code to use more modern CMake component syntax is left as future work. Change-Id: I3ed75252189a6e05a23ed6e619088f519cd7ed78 Reviewed-on: https://code.wireshark.org/review/31496 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-20[Automatic update for 2019-01-20]Gerald Combs9-192/+183
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I18a5419a2953f5893aa76e2823c50d48e284b270 Reviewed-on: https://code.wireshark.org/review/31625 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-18CMake: avoid including file modification time for RCCPeter Wu1-0/+9
Resources such as translations (autogenerated qm files) and SVG images resulted in non-reproducible builds. Be sure to disable this to make the resources reproducible on Qt < 5.8 or Qt >= 5.9 (excluding Qt 5.8.x). With this change, the Wireshark build is reproducible invariant of the build directory (but not the source directory). Bug: 15163 Change-Id: I9240d2aa6e7298e1928c0f1d97ce83673320024d Reviewed-on: https://code.wireshark.org/review/31593 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-16Qt: IO Graph correct color selectionRoland Knall5-164/+16
The correct method of selection of colors is just using the QColorDialog not a specialized object. Implementing it just that way, to correct bug on Linux Bug: 15399 Change-Id: I3c4785d352888ec34c34534667c3f7df182f9fd7 Reviewed-on: https://code.wireshark.org/review/31465 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-01-13[Automatic update for 2019-01-13]Gerald Combs10-401/+385
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ic7f6b5dd91ca6404909b941c0b4844cb17ef4820 Reviewed-on: https://code.wireshark.org/review/31522 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-12CMake: change static qtui library into an object libraryPeter Wu1-4/+1
Save 800ms and avoids a synchronization point (improves build parallelism) by directly adding object files to the wireshark binary. Change-Id: I7d1484c65a26f3f6874474b61d38ba474aba8347 Reviewed-on: https://code.wireshark.org/review/31512 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-09Clarify the name and description for a link-layer encapsulation type.Guy Harris2-4/+4
What we were calling the "name" is actually a description to show to users; what were calling the "short name" is just the name to use on the command line. Rename some routines and structure members, and put the name first and description second in the table. Expand some descriptions to give more details (e.g., to be more than just a capitalized version of the name). Fix the CamelCase capitalization of InfiniBand. Change-Id: I060b8bd86573880efd0fab044401b449469563eb Reviewed-on: https://code.wireshark.org/review/31472 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-09Qt: Cleanup deletion of CopyFromProfileMenuStig Bjørlykke10-35/+19
Set the push button as parent to the profile list menu so it will be deleted when that parent is destroyed. Change-Id: Ide4a234e039a3e27d9ee4732a3800906c80be173 Reviewed-on: https://code.wireshark.org/review/31446 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-08Qt: Fix copy ASCII characters from ByteViewStig Bjørlykke2-7/+8
Only copy ASCII characters when doing "Copy Bytes as Hex + ASCII Dump" from the ByteView. This is what we do in all other Hex Dumps. Also change the parameter name to reflect this. Change-Id: I63cc79ffa014fd9aa50c84d765ee168f0b1ea44a Reviewed-on: https://code.wireshark.org/review/31442 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-08Qt: Pluralize "Export TLS Session Keys (%Ln key(s))"Stig Bjørlykke1-2/+2
Properly pluralize "Export TLS Session Keys (%Ln key(s))" in the window caption. Change-Id: Ida7d725a2b8daa356cb44aec4d4475151916a425 Reviewed-on: https://code.wireshark.org/review/31432 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-01-08Qt: Add syntax line edit feedback symbols.Gerald Combs6-10/+58
Draw a circle+backslash or a warning triangle in the far right of the line edit entry for invalid and deprecated filters respectively. This should provide an additional clue for color blind users. Bug: 15326 Change-Id: I55a1e214834a340ccda3bfe8880bba12c5e274e9 Reviewed-on: https://code.wireshark.org/review/30936 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-08Qt: Clarify Remove action from the welcome pageStig Bjørlykke1-1/+1
Rename the Remove action in the welcome page to "Remove from list" to indicate that the file is only removed from the list, not from disk. Change-Id: I4a47c9852203596cc601bf254a4bcfc700ccd025 Reviewed-on: https://code.wireshark.org/review/31433 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-01-06[Automatic update for 2019-01-06]Gerald Combs10-871/+1048
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I0e282baebc0cda0e54e49eff60827eec02f6f797 Reviewed-on: https://code.wireshark.org/review/31402 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-01-04Qt: Add "Show in Finder/Folder" for plugins.Stig Bjørlykke2-0/+29
Add a menu item for "Show in Finder/Folder" for plugins in cases where Wireshark loads plugins from other folders than is listed in "Folders". Change-Id: I8cc42d9992d885f1ca37f5769d7292bed1584f4b Reviewed-on: https://code.wireshark.org/review/31270 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-01-02Don't fall out of the loop on a write error.Guy Harris1-1/+1
Doing so means we'd close the FD, but we've already closed it. Addresses Coverity CID 1442274. Change-Id: I5aab1bd4b82e9ac0901bcdbc1ddb6b16eec30573 Reviewed-on: https://code.wireshark.org/review/31312 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-01-01No need to report "some files could not be saved".Guy Harris6-34/+12
We've already reported the files that couldn't be saved; no need to tell the user something they already know by that point. Change-Id: I8251a46134342df6b40a6324aa76a5237fde7c93 Reviewed-on: https://code.wireshark.org/review/31298 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-22 20:14:57 +0000