diff options
| author | Guy Harris <guy@alum.mit.edu> | 2000-11-12 21:23:53 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2000-11-12 21:23:53 +0000 |
| commit | 5018d8fecb814ef60b6f58ae2bcee0710572fd8b (patch) | |
| tree | 4ab6adf49447109b723c688cda9e0f3c95ec5606 /packet-rtsp.c | |
| parent | e8c75b74bfdfd876330fe3107865a5eb120349be (diff) | |
As RFC 2327 says, "SDP is purely a format for session description - it
does not incorporate a transport protocol, and is intended to use
different transport protocols as appropriate including the Session
Announcement Protocol [4], Session Initiation Protocol [11], Real- Time
Streaming Protocol [12], electronic mail using the MIME extensions, and
the Hypertext Transport Protocol."
As such, it shouldn't set the protocol column to SDP, as that means
the protocol column won't indicate what the transport protocol was;
instead, it should append "/SDP" to the protocol column - RTSP was,
after calling "dissect_sdp()", setting the protocol column to
"RTSP/SDP", and this change means that all protocols using SDP will have
the protocol column set in that fashion, and that the RTSP dissector
doesn't have to explicitly set the protocol column to cause that to
happen.
svn path=/trunk/; revision=2624
Diffstat (limited to 'packet-rtsp.c')
| -rw-r--r-- | packet-rtsp.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/packet-rtsp.c b/packet-rtsp.c index 62e2a26b13..b2d6de0266 100644 --- a/packet-rtsp.c +++ b/packet-rtsp.c @@ -4,7 +4,7 @@ * Jason Lango <jal@netapp.com> * Liberally copied from packet-http.c, by Guy Harris <guy@alum.mit.edu> * - * $Id: packet-rtsp.c,v 1.23 2000/11/10 06:50:36 guy Exp $ + * $Id: packet-rtsp.c,v 1.24 2000/11/12 21:23:53 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@zing.org> @@ -361,8 +361,6 @@ dissect_rtsp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) new_tvb = tvb_new_subset(tvb, offset, -1, -1); dissect_sdp(new_tvb, pinfo, tree); } - if (check_col(pinfo->fd, COL_PROTOCOL)) - col_add_str(pinfo->fd, COL_PROTOCOL, "RTSP/SDP"); } else { if (datalen > 0) { proto_tree_add_text(rtsp_tree, tvb, offset, datalen, |