diff options
author | Vadim Yanitskiy <axilirator@gmail.com> | 2018-12-07 05:00:26 +0700 |
---|---|---|
committer | Vadim Yanitskiy <axilirator@gmail.com> | 2018-12-07 05:36:20 +0700 |
commit | 6bab6acee634fcd05a175428e1077ab00188829a (patch) | |
tree | c2cc2f8231efd29991f71b027323dbd5c10f7906 /src/target/trx_toolkit/burst_send.py | |
parent | 72c8296bfe22eab749f9f29fe91f30d2588ded9c (diff) |
trx_toolkit: use generic logging module instead of print()
There are multiple advantages of using Python's logging module:
- advanced message formatting (file name, line number, etc.),
- multiple logging targets (e.g. stderr, file, socket),
- logging levels (e.g. DEBUG, INFO, ERROR),
- the pythonic way ;)
so, let's replace multiple print() calls by logging calls,
add use the following logging message format by default:
[%(levelname)s] %(filename)s:%(lineno)d %(message)s
Examples:
[INFO] ctrl_if_bts.py:57 Starting transceiver...
[DEBUG] clck_gen.py:87 IND CLOCK 26826
[DEBUG] ctrl_if_bts.py:71 Recv POWEROFF cmd
[INFO] ctrl_if_bts.py:73 Stopping transceiver...
[INFO] fake_trx.py:127 Shutting down...
Please note that there is no way to filter messages by logging
level yet. This is to be introduced soon, together with argparse.
Change-Id: I7fcafabafe8323b58990997a47afdd48b6d1f357
Diffstat (limited to 'src/target/trx_toolkit/burst_send.py')
-rwxr-xr-x | src/target/trx_toolkit/burst_send.py | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/target/trx_toolkit/burst_send.py b/src/target/trx_toolkit/burst_send.py index f6c85ba0..787e0fc3 100755 --- a/src/target/trx_toolkit/burst_send.py +++ b/src/target/trx_toolkit/burst_send.py @@ -25,6 +25,7 @@ from copyright import print_copyright CR_HOLDERS = [("2017-2018", "Vadim Yanitskiy <axilirator@gmail.com>")] +import logging as log import signal import getopt import sys @@ -60,6 +61,10 @@ class Application: # Set up signal handlers signal.signal(signal.SIGINT, self.sig_handler) + # Configure logging + log.basicConfig(level = log.DEBUG, + format = "[%(levelname)s] %(filename)s:%(lineno)d %(message)s") + # Open requested capture file self.ddf = DATADumpFile(self.capture_file) @@ -88,7 +93,7 @@ class Application: if not self.msg_pass_filter(l12trx, msg): continue - print("[i] Sending a burst %s to %s..." + log.info("Sending a burst %s to %s..." % (msg.desc_hdr(), self.conn_mode)) # Send message @@ -209,7 +214,7 @@ class Application: sys.exit(2) def sig_handler(self, signum, frame): - print("Signal %d received" % signum) + log.info("Signal %d received" % signum) if signum is signal.SIGINT: sys.exit(0) |