Age | Commit message (Collapse) | Author | Files | Lines |
|
enabled
Change-Id: I5244cb9304adef3aa612b8126bf95e77562c801c
|
|
Change-Id: I9f686404517bf8a2044cf59dd5bfaf90eb4f798f
|
|
Change-Id: I581f40da47614223219800e97a334f8b5e06b13f
|
|
Change-Id: I281964935312161d1da49e8035c5bf3bb7bf9c5c
|
|
Otherwise we end up in a weird state where we have timers set up but
osmux is still flagged as not enabled.
Change-Id: I15c3a1a6bdf2566b03d1d543d8d15e4117a53622
|
|
According to verify_chan_comb(), nanoBTS supports SDCCH8 only in TS1.
Change-Id: I37b91745ddf7000add3c24f6bb782ae0c61d2978
|
|
Since that define is already used to allocate size of osmux_cid_bitmap,
let's use it here too instead of hardcoding its value.
Change-Id: I768ca1b510bf44508ae064dc31620e739260470b
|
|
A previous commit merged today fixed array size boundary (multiple of 8
bits), but removed a required +1 which should be kept on top, because
OSMUX_CID_MAX specified the maximum number used by a CID, that is
(0,OSMUX_CID_MAX), and as a result we require OSMUX_CID_MAX+1 slots.
Fixes: 65f422ad5878165be0a1eb05605aa3099536f0c8
Change-Id: I182c9c1a6dd28a4c5c0d8107d53852cf47541592
|
|
It shows up all the time in logs while using "logging level all info",
let's move it to debug.
Change-Id: I51274dad5afef16e466921c5d58672427d23fd3b
|
|
Right now it's not a big issue since OSMUX_CID_MAX is 255, so 255+1 is
256 which fits array boundaries correctly (multiple of 8). However, if
for example OSMUC_CID_MAX was modified to be 12, 12+1/8 = 1, so we'd
have an undesired memory access when accessing last 4 CIDs.
Change-Id: I5908ee44404686e68d61f255b7014af39c8f5703
|
|
The .tarball-version file should contain the *source version* uniquely
identifying the git commit, and not the Debian package name.
With https://gerrit.osmocom.org/#/c/osmo-ci/+/10343/ there is a correct
.tarball-version file in the .tar.xz of the nightly source packages.
Related: OS#3449
Change-Id: Ice1875bbd051f78b4a3bcadef48e639419b55e8f
|
|
bsc_msc_lost will close the current fd (without freeing it), so let's
skip possible writes to an already closed fd
bsc_msc_lost will close the current fd (without freeing it), so let's
skip possible writes to an already closed fd..
Change-Id: I55c1a88f6524e897c70abf8ba18f1bb2b1f650aa
|
|
PONG is being sent a as an answer to PING a few lines above in same
function.
Change-Id: I88ca95d46f4ace1da4025d12302422dbfa578354
|
|
Code is already doing stuff with the connection (fd).
Change-Id: Ieeaa0e024b9542d1a22a8e3ab4c3229a6f8a0b49
|
|
Change-Id: Ib36b8937d1210488784ebae6917cb1b4c871c9d4
|
|
Change-Id: I080ae6a4c4f92dd8df055efd25e308f8a3377d34
|
|
Change-Id: I9bc40cf9e9a901d28d1f1629f6f1d55e8ba0c0b6
|
|
osmux_xfrm_input_open_circuit returns 0 on success and -1 on error.
Confusion comes from that function being implemented by calling
osmux_batch_add_circuit which returns NULL on error.
Change-Id: I98700aa1e2fab9784706bfac1a47cc84635172b7
|
|
Change-Id: I88ba349e547c8f85e12e1ad80a2724086c489c02
|
|
Change-Id: Ic8259aa9f2fe1d9a5631ab102e429347bf39ceb1
|
|
Change-Id: I29d719fbe059e38fde97371efc5e562901529b7c
|
|
Back-port from osmo-bsc.git 9862bcb5cdb9ece0acfdfb7c81e00c05fcd33ad3.
ipaccess_drop_oml was being called inside an osmo_fd cb context, were
-EBADF must be returned if the structure holding the osmo_fd is freed.
In the middle of the path (see OS#3495 for path tree) it goes through a
signal dispatch, so it's impossible to make sure we return some value to
the osmo_fd cb. As a result, it is required to defer dropping the OML
Link from current code path and do it through a timer.
Fixes following ASan report:
20180822124927913 <0004> abis_nm.c:787 OC=RADIO-CARRIER(02) INST=(00,00,ff): CHANGE ADMINISTRATIVE STATE NACK CAUSE=Message cannot be performed
20180822124927913 <0004> osmo_bsc_main.c:186 Got CHANGE ADMINISTRATIVE STATE NACK going to drop the OML links.
20180822124927913 <0015> bts_ipaccess_nanobts.c:406 (bts=0) Dropping OML link.
...
=================================================================
==17607==ERROR: AddressSanitizer: heap-use-after-free on address 0x62e000060a68 at pc 0x7f5ea8e27086 bp 0x7ffde92b6d80 sp 0x7ffde92b6d78
READ of size 8 at 0x62e000060a68 thread T0
#0 0x7f5ea8e27085 in handle_ts1_write input/ipaccess.c:371
#1 0x7f5ea8e27085 in ipaccess_fd_cb input/ipaccess.c:391
#2 0x7f5ea9147ca8 in osmo_fd_disp_fds libosmocore/src/select.c:217
#3 0x7f5ea9147ca8 in osmo_select_main libosmocore/src/select.c:257
#4 0x555813ab79d6 in main osmo-bsc/osmo_bsc_main.c:922
#5 0x7f5ea76d02e0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202e0)
#6 0x555813ab84e9 in _start (/bin/osmo-bsc+0x34d4e9)
Fixes: OS#3495
Change-Id: If9e73a3251547625a2372d58f1d8b87210d9f312
|
|
Back-port from osmo-bsc.git 24f2f55132f7230e387aef85612dcd6fc59cebe5.
Change-Id: I134a3da3700381043bc93aed300ce4ec263e8698
|
|
The '.' is illegal character in counter names, as they are exported
via CTRL interface, where '.' has a special meaning that cannot be
used by strings comprising the variable name.
Change-Id: I075c0f992e2e31226bd04b9c036ca125467f840e
|
|
Some distributions (archlinux) or versions of libgsm install gsm.h in
/usr/include/gsm/gsm.h
Since libgsm doesn't come with a pkfconfig, let's first check if gsm.h
and take the correct path in the build setup.
Backport from osmo-mgw.git
Change-Id: I07d3c03903e0d4bb80e843c7ed917a27b791ea53
|
|
Ensure that all msgb were cleaned up, then free the overall msgb_ctx, in order
to not leave any memory leaks the sanitizer build complains about.
Backport from osmo-mgw.git
Change-Id: I84e0ac7f0928f04ffddd7da18200466841589c25
|
|
Backport from osmo-mgw.git.
Change-Id: Ife3f034ddaaba993bf27c1f9a34a1d57d1bf3e05
|
|
Change-Id: I2b0953eb6ea2d92c95406f66ba59e1c2db6be814
|
|
Backport from osmo-mgw.git 020e89bce914d394352dddb8186b65a319562b20.
Change-Id: Ibfc80f06b2811cc32fe38518b11efd6764b347ee
|
|
Currently the force_realloc feature is turnd on and of in a
hardcoded way. This patch makes the option available via VTY.
Backport from osmo-mgw.git.
Change-Id: Ic8740512c5ea0766ff6ceb1c28b9c2b3fe46e75f
|
|
Backport partially (related parts) of osmo-mgw.git
a1756f320acb7021c501d56252db133012ad479f ["Implement IuCS (large
refactoring and addition)"]
Change-Id: I375e67874ccfaadd92d203a911444294d40dfc22
|
|
Backport from osmo-mgw.git.
Change-Id: I4f84a13b7fa6ec4173bdc155e6114d4d7328b619
|
|
Change-Id: I83948ce626b924802d1963411a3f40c5fed24355
|
|
This check is not in all our repos that use git-version-gen. Indeed it
seems to be a leftover of openbsc where I think it wanted to ensure
being called in the openbsc subfolder or something? libosmocore e.g.
doesn't have it.
In any case .git being a directory is not always true (if using git
worktree) so remove this check.
Change-Id: Ibc8c0d8e74bb03bfe87d6f8b9ef6e74c0c889d0f
|
|
Change-Id: Ib5963e4d15a4a6b077d7a97fbbde6e5134c77e9a
|
|
We only send back if we had an error parsing the message locally. If we
receive an ERROR message from a bsc, we try to forward it if the ID is
valid, otherwise only log the received error description locally.
Related: OS#3394
Change-Id: I7b4d20aea7a16c4b4e5add7c274a4ed34a7f6b8d
|
|
In some cases id can be non-digit such as "err" for ERROR cmds generated
from parsing failures.
Change-Id: Ief0b203efbcf2be04253b5056840be94d58a9994
|
|
Instead of always logging/sending same error, use the new
ctrl_cmd_parse2 API which always returns a cmd structure with a specific
error description.
Change-Id: Ie111bec46b664768fe3c3feff906f91e8ee8b1d4
|
|
Instead of always logging/sending same error, use the new
ctrl_cmd_parse2 API which always returns a cmd structure with a specific
error description.
Change-Id: I6ef2b6e309632ed9cb296e8a1e71f879007a36ae
|
|
This command controls forward/drop of BSS paging messages from MSC to
all BSCs connected to BSC-NAT.
In situations in which MS don't generally roam from one BSC to another
under the BSC-NAT, it may be beneficial (bandwidth wise) to drop these
global paging commands, which are usually issued by the MSC if the
location of the MS isn't known and LAC paging has failed.
Change-Id: I737774543e0a8734d79b072e66e3c09e82b001d3
|
|
Previous to this commit, an error message was printed and the paging
message was dropped:
openbsc/openbsc/src/osmo-bsc_nat/bsc_nat.c:618 Could not parse paging message: -3
Related: OS#3325
Change-Id: I3125ba0e67d2965c0be3089748dd113b1bf615af
|
|
Change-Id: Ib03681cf91550846af0d487c11cc90b6f700b340
|
|
Back-port from osmo-bsc.git 653bee7d02a1a1c827b54d235b644fec6a6f4683.
Change-Id: Id89febbd84beba8a0c083cbf83649bb4672684c4
|
|
Back-port from osmo-bsc.git d99182c01037f4dd14fb72b2b06497e0c1bebb49.
Change-Id: I0b951a9c3dbe245c3813fc91ceb9118a0de779b8
|
|
Back-port from osmo-bsc.git a0f1196eda79de0e838b29eb91d9f31839f2f447.
Change-Id: I519fb945a99206dff6c4aeb476d527e632b7e751
|
|
Previous state is harmless because the pointer is stored but not used in
that function. However, it's more clear this way.
Back-port from osmo-bsc.git 9ab47eb52da73d25c4f94869385a4f836032362a.
Change-Id: Ic17c38578587a774da29266302e7b201ecacd3a3
|
|
Other VTY commands already exist which provides each a subset of these
features, but while operating bsc-nat it became interesting to have all
this info easily reachable for a specific BSC.
Change-Id: I47bfd4fb800390505bdeb0f1d0bd1306fb888a59
|
|
Fixes following runtime warning:
libosmocore/src/rate_ctr.c:219 counter group 'nat:filter' already exists for index 0, instead using index 1. This is a software bug that needs fixing.
Change-Id: Ibe615379dc44a3a68cf9037630891ebf9b03a06d
|
|
The '.' is illegal character in counter names, as they are exported
via CTRL interface, where '.' has a special meaning that cannot be
used by strings comprising the variable name.
Change-Id: I55470ae74d350e4020209921fd8a09b51b120a41
|
|
Change-Id: I83988d90a1dd0a65d84ef990f83e34ac2f588252
|