diff options
| author | Pau Espin Pedrol <pespin@sysmocom.de> | 2018-09-17 12:22:10 +0200 |
|---|---|---|
| committer | Pau Espin Pedrol <pespin@sysmocom.de> | 2018-09-17 12:22:12 +0200 |
| commit | 65f422ad5878165be0a1eb05605aa3099536f0c8 (patch) | |
| tree | 19ab2be63c9d2108cf11acb4df1ad00df8993627 | |
| parent | 769d19118baed77e74067a734478a6e5591c30d6 (diff) | |
mgcp: Fix osmux_cid_bitmap static array size calculation
Right now it's not a big issue since OSMUX_CID_MAX is 255, so 255+1 is
256 which fits array boundaries correctly (multiple of 8). However, if
for example OSMUC_CID_MAX was modified to be 12, 12+1/8 = 1, so we'd
have an undesired memory access when accessing last 4 CIDs.
Change-Id: I5908ee44404686e68d61f255b7014af39c8f5703
| -rw-r--r-- | openbsc/src/libmgcp/mgcp_osmux.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/openbsc/src/libmgcp/mgcp_osmux.c b/openbsc/src/libmgcp/mgcp_osmux.c index 8a802f53c..ca0ed30e3 100644 --- a/openbsc/src/libmgcp/mgcp_osmux.c +++ b/openbsc/src/libmgcp/mgcp_osmux.c @@ -545,7 +545,7 @@ int osmux_send_dummy(struct mgcp_endpoint *endp) } /* bsc-nat allocates/releases the Osmux circuit ID */ -static uint8_t osmux_cid_bitmap[(OSMUX_CID_MAX + 1) / 8]; +static uint8_t osmux_cid_bitmap[(OSMUX_CID_MAX + 7) / 8]; int osmux_used_cid(void) { |