aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-09-01debian/control: remove dh-systemd build-dependHEADmasterOliver Smith1-1/+0
Related: OS#5223 Change-Id: Ieb8669a9a43ea1acc6b2d8d2e363f2466c51697a
2021-03-22add README.md to indicate what this repo is aboutHarald Welte1-0/+22
Change-Id: I0544a2d8016d1d5a2d264dd9c7662fd78f6a49d6
2021-02-22tests: Replace deprecated API log_set_print_filenamePau Espin Pedrol4-4/+4
Change-Id: I2bd75313daab58704625245af2dd39d88ee42872
2021-02-22gitignore: Ignore configure~ filePau Espin Pedrol1-0/+1
Change-Id: Ie2ec89307ca941e52cb898ce045e423c44f32658
2021-02-22tests: Explicitly drop category from logPau Espin Pedrol4-0/+7
Let's disable category here since we don't care about its formatting here. In any case, every test relying on logging output validation should always explicitly state the config to avoid issues in the future if default values change. Change-Id: I2697ec547468019a544b66daf9dbb58aa8d9772b Related: OS#5034
2021-01-13contrib/jenkins: don't build osmo-gsm-manualsOliver Smith1-1/+0
Related: OS#4912 Change-Id: Idb3b05412b99484f7f7de91ee96c69bfb4e3d511
2020-12-10Bump version: 1.3.3.4-e5e69 → 1.4.01.4.0Pau Espin Pedrol1-0/+12
Change-Id: I80698b962666b94310a84306149d67ae09153c8e
2020-12-10Add very clear obsolescence / unmaintained warningsHarald Welte8-8/+62
* add messages at start-up and to the VTY * users must explicitly confirm they want to run osmo-nitb Change-Id: I5d5c0ff386dbc2e7b7dd02d6c33d1f9fec70707b
2020-11-25osmo-nitb: generate coredump and exit upon SIGABRT receivedPau Espin Pedrol1-5/+14
Previous code relied on abort() switching sigaction to SIG_FDL + retriggering SIGABRT in case the signal handler returns, which would then generate the coredump + terminate the process. However, if a SIGABRT is received from somewhere else (kill -SIGABRT), then the process would print the talloc report and continue running, which is not desired. Change-Id: I3371783e04c7bce12d11d6f9cc7021bf290489ea Fixes: OS#4865
2020-11-25bsc-nat: generate coredump and exit upon SIGABRT receivedPau Espin Pedrol1-4/+12
Previous code relied on abort() switching sigaction to SIG_FDL + retriggering SIGABRT in case the signal handler returns, which would then generate the coredump + terminate the process. However, if a SIGABRT is received from somewhere else (kill -SIGABRT), then the process would print the talloc report and continue running, which is not desired. Change-Id: Ie884be1f3e1d5ead912aafd0a78e1a0a97258ab8 Fixes: OS#4865
2020-10-18Migrate from BSC_FD_* to OSMO_FD_*Harald Welte15-48/+48
Change-Id: If45434eb0d7da69feb4001e0ac35f0e297bdeef5
2020-09-18Bump version: 1.3.2.4-4e53b → 1.3.31.3.3Pau Espin Pedrol1-0/+17
Change-Id: I86a0c484aeb4eb0fe8df38d20e7c5aa93f2dc6e1
2020-09-18db_test: Disable using color in log outputPau Espin Pedrol2-2/+2
It's really not used and only adds unneeded variabilities to output. Older libosmocore versions had a bug where extra color format characters were printed while newer versions have that fixed. Fixes: OS#4759 Change-Id: Idce85aa355d334929d8abdf5b99dad0622ecff58
2020-07-20doc: Copy {bsc,bts}.adoc from osmo-gsm-manualsPau Espin Pedrol3-3/+611
Those adoc files are only used by osmo-bsc.git and openbsc.git (osmo-nitb), and the later is deprecated and no longer maintained, which means new features are only added to BSC. Hence it makes no sense to keep the doc shared between both. As a result, they will be dropped from osmo-gsm-manuals.git and we keep an unmodified copy here. Change-Id: Ic3b4192238be3147f61779845521eae84511fb7e
2020-06-02fix typo in osmo_bts_variant_names: s/omso/osmo/Vadim Yanitskiy1-1/+1
Change-Id: I4645da18fde48165c846ba714cd03e604aef5ad6
2020-04-20fix compilation with gcc-10Harald Welte2-4/+8
See also: https://alioth-lists.debian.net/pipermail/debian-mobcom-maintainers/Week-of-Mon-20200413/000648.html Change-Id: I0e9596c3ef26231999c729b5cc408fcaca3790fc
2020-03-27rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messagesKeith1-0/+7
Backport of osmo-bsc 6b9e0e4e8834428f85f169106ed7b6141f5b185b (1) and 60d6d530ac6883db4f5c0394541ad654ddfd526c (2) (1) TS 48.058 sec 8.4.1 CHANNEL ACTIVATION and state: """ The BS and MS Power Parameters elements are included to indicate that BS and/or MS power control is to be performed by BTS. The maximum power to be used is indicated in the BS and MS Power elements respectively. """ Since we always want the BTS to do autonomous MS power control, let's add it. (2)Send IE MS Power Param to osmocom BTS models only Since MS Power Param IE content is operator dependant, it's currently not known which kind of content non-osmocom BTS support/allow, so let's avod possibily breaking those BTS until each BTS has been checked separately. Change-Id: Ieb51d5f2202ebd2861d3c33f2b5598e6b29d78eb
2020-01-03Bump version: 1.3.1 → 1.3.21.3.2Pau Espin Pedrol1-0/+10
Change-Id: I4f7b6c0f18fd1f11e04ae34275645b439d3613fb
2019-12-12osmoappdesc.py, tests, ipa.py: switch to python 3Oliver Smith5-442/+452
Make build and external tests work with python3, so we can drop the python2 dependency. This should be merged shortly after osmo-python-tests was migrated to python3, and the jenkins build slaves were (automatically) updated to have the new osmo-python-tests installed. Related: OS#2819 Depends: osmo-python-tests I3ffc3519bf6c22536a49dad7a966188ddad351a7 Change-Id: Id7d006f892198bb8a7c0d4a8a8ea00b8d0e62df4
2019-12-01manual: Fix copy+paste errorHarald Welte1-1/+1
Change-Id: I260946d39f78cf2713dc26860935ab29b83a5532
2019-08-08Bump version: 1.3.0.5-38ea → 1.3.11.3.1Pau Espin Pedrol1-0/+13
Change-Id: I3d06a8f8b7645803b581e8651f20497f80959ec0
2019-08-08debian/control: Match dependency versions against configure.acPau Espin Pedrol1-6/+6
Change-Id: Ib789ee75ab14f2af9869c7259e278942fd5f2c75
2019-08-05Remove undefined param passed to {logging,osmo_stats}_vty_add_cmdsPau Espin Pedrol3-5/+5
Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However, definition in C file doesn't contain "(void)", which means number of parameters is undefined and thus compiler doesn't complain. Let's remove parameters from all callers before enforcing "(void)" on it. API osmo_stats_vty_add_cmds never had a param list but has seem problem (no "void"), so some users decided to pass a parameter to it. Change-Id: I7d9d477b983b0d62f01237d90acaa7ce455c3c3d Related: OS#4138
2019-08-05nat: Remove unused func bsc_vty_init()Pau Espin Pedrol1-8/+0
The function is never called in osmo-bsc-nat, and logging_vty_add_cmds() is called directly in main(). Change-Id: Ie13cf5dc7f8dfa6fc6c3953dfcacaed7d5feb114
2019-07-18manuals: Generate vty/counter documentation for osmo-bscnatDaniel Willmann3-2064/+2345
Change-Id: Ice7f15192a57e2c964d07d364732af888972ba0f Depends: I44bb395009582f5e1399f277e15203553c2dcf78 (docker-playground.git) Depends: I52c3cb2cdcfb143e71ac2c1aa40bb466e41a0f5c (docker-playground.git) Related: OS#1700
2019-07-18manuals: Update osmonitb counter/vty documentationDaniel Willmann4-4724/+4176
Change-Id: Ia598124fbb98b3ec8dee606f9d028bb3cc6ff002 Related: OS#1700
2019-07-14Bump version: 1.2.0.20-cf711 → 1.3.01.3.0Harald Welte1-0/+36
Change-Id: I4654650ae90463442dc7017ea86b6910732e30bb
2019-07-10contrib/jenkins.sh: run "make maintainer-clean"Oliver Smith1-0/+1
Related: OS#3047 Change-Id: I3324f96ea0ec25b210562e0523b21f1a94db12ec
2019-06-21bsc-nat: Remove whitespace at the end of CTR descriptionsPau Espin Pedrol1-13/+13
Change-Id: Ia7ff352de1fb1997066f72e84a7d517c7642853a
2019-06-19manuals: Add script to regenerate counter/vty documentationDaniel Willmann2-0/+23
Related: OS#1700 Change-Id: I3e6e6603300d2d7f6221720fa7ce35b3a6aa0b7a
2019-05-26mgcp: Handle CI and X-Osmux param name as case insensitivePau Espin Pedrol2-13/+66
RFC3435 states most text (except SDP) must be handled as case insensitive. Since we are no longer using strstr(msg->l2h), we need to iterate per line and call related extract/handle function for that line. Call to bsc_mgcp_osmux_confirm() is left at the end because it needs to be called too in case no matching line is found. In that case, it will release the CID. Similar stuff ocurrs for bsc_mgcp_extract_ci(). Related: OS#4001 Change-Id: Iadc004064a5a237c93009f242cb943ebc4d2d7e6
2019-05-23tests: Mute stdout during db_prepare()Keith1-1/+21
libdbi on debian unstable (at least) outputs: "no table in statement !" breaking the db_test. Redirect stdout to /dev/null and restore after the function completes. Closes OS#4016 Change-Id: I8227aa8fa44d3237019db52dd0825f827797261b
2019-05-16nat: Allocate bsc_nat_parsed on the stack instead of heapPau Espin Pedrol6-174/+136
There's no real need to allocate it using talloc. Allocating it on the stack simplifies the code, avoids mem leaks and makes it faster. Change-Id: I66c44890952339f15131081e2f629a2824b6d3ba
2019-05-08nat: Fix crash (double-free) in forward_sccp_to_mscPau Espin Pedrol1-2/+2
In bsc_nat_parse(), parsed is allocated this way: """parsed = talloc_zero(msg, struct bsc_nat_parsed);""" So parsed is a child of msg, and so it's freed when msg is freed. Since libosmocore c7f52c4c84d6a8898048738c4db9266289c40b45, osmo_wqueue_enqueue() correctly detects queue full and returns an error, and then queue_for_msc() calls msgb_free(). Code in osmo-bsc-nat was probably written before that change in behavior, so that's why probably the bug was not hit before. The "if (parsed)" condition is removed since it's actually fine to talloc_free(NULL). Related: SYS#4548 Change-Id: I209d3e2d809a67915ec43c874e68f7f746a565f0
2019-05-03tests: Fix selection of python versionPau Espin Pedrol5-9/+12
According to documentation (and personal experience), AM_PATH_PYTHON selects the highest version of python, no matter if major version is different, which means if both python2 and 3 are available, 3 will be chosen an PYTHON will point to "/.../python" which is python3. Apparently, the macro cannot be easily used to pick highest python2 version. chosen an PYTHON will point to "/.../python" which is python3. Apparently, the macro cannot be easily used to pick highest python2 version. As {vty,ctrl}_test_runner.py require python2 and are incompatible with python3, let's instead rely on the system having a "python2" binary available, which is the case in most distros. cherry-picked from: osmo-bsc.git 7e78681f0f740bd68ed5255b506a1efa08a231b1. Change-Id: Icc147c8457116ad551d166313f3a79e1c2107a22
2019-05-02nat: Return error code in queue_for_mscPau Espin Pedrol1-4/+8
Might be useful in the future for its callers, since sometimes actions need to be taken place based on whether enqueuing failed (and msg was freed). Change-Id: I9f172f9c9ca9db18f6adcf9267db23c73e9d5bc6
2019-04-30libmgcp: Parse CI as hex string in verify_ci()daniel/wipDaniel Willmann1-1/+1
In verify_ci CI needs to be parsed as hex instead of dec number as well. Fixes: OS#3951 Change-Id: I687b467756fa30cbc454e3583c86159d9abcc7d9
2019-04-23osmo-bsc_nat: Parse MGCP Connection ID as hexDaniel Willmann4-8/+11
Our ttcn3-bscnat-tests would randomly fail. After the CRCX ACK returns from the MSC the bsc-nat reports it could not find a CI it it and deletes the connection on the BSC-side. This happens because the field is parsed as a decimal value instead of hexadecimal. So a value of 00FED122 is parsed as '0' which is a reserved value in our program. This fix parses the field as hexadecimal value and also logs an error if the value happens to be 0. make check will now test if a hexadecimal CI is parsed correctly. Fixes: OS#3951 Change-Id: I49b8b61644bf706162102dce268cae2265536fc5
2019-04-21Fixed MNCC_RTP_CREATE after MNCC_DISC_IND.Rafael Diniz1-0/+3
Change-Id: I3690acebf882d3a8abbeabe0e3aefdfcd066a052
2019-03-29Write configuration correctly from vty (alert notifications)Keith1-2/+2
The default is [yes] alert-notifications, therefore write "no alert-notifications" in the case that this has been set, in order to preserve configuration after write is called from vty. Change-Id: I4b0363fa34dd9ac0a221844974e4ebf7465b56f4
2019-03-28vty_test_runner: Handle MGCP message recv len dynamicallyPau Espin Pedrol1-1/+12
Change-Id: I536d78a2a1962240e5e369cda9927d8c9955ab86
2019-03-28Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id onesPau Espin Pedrol4-12/+10
ipa_ccm_idtag_parse_off is broken, and can only be used with len_offset=1 on ID Request messages, otherwise won't work correctly. Modify ipa_ccm_idtag_parse to at least parse those correctly, and document the limitations. Those two functions are already deprecated and only used in openbsc by 3 callers: * ipa_ccm_idtag_parse in ussd_read_cb(): Broken, that function can only work for Requests and it's used to parse a Response. * ipa_ccm_idtag_parse_off in forward_sccp_to_msc (NAT): Broken, it can only be used to parse Requests and it's used to parse a Response. Furthermore, len_offset=2 is passed which makes no sense and most probably it fails always, or can even make the program crash. * ipa_ccm_idtag_parse_off in (answer_challenge): This one is fine and could actually be replaced with ipa_ccm_id_get_parse after libosmocore commit (see below) is merged. See libosmocore I6efc852dfc041192f554e41a58290a0f63298021 for more information. As a consequence of the fixes, osmo-bsc-nat now parses messages sent from VTY test correctly and thus it goes into processing them instead of silently dropping them. As a result, some VTY tests fail because they are sending incorrect format (missing NULL char in unit id strings) and osmo-bsc-nat closses its connection (due to bad auth). Change-Id: I3b995f8ef0b48c0a5b3375e42926641934359cd2
2019-03-26Drop Iu*S support and related dependenciesMax8-935/+1
There's optional libiu for Iu*S support but it's just a leftover from pre repo-split times: * it's not used by any code * it's not checked by gerrit verification in osmo-ci * it's disabled by default * it's not supported in .deb packages Instead of dragging old code in unknown stage of bit-rotting, let's just drop it completely. Change-Id: Id5678a74504b4456aba0438ccc34731770801128
2019-03-26Drop openggsn from build dependenciesMax1-2/+0
We don't have SGSN-related code here anymore so we don't need libgtp from openggsn any longer. Change-Id: I6725d39449a3d498adcd83fb8c3fe892367df0e8
2019-03-22talloc_ctx_init: Use public API osmo_signal_talloc_ctx_initPau Espin Pedrol1-2/+2
There's already a public API to allocate libosmocore's signal ctx, so let's use it instead of accessing the global variable. This will allow to eventually Make the global variable in libosmocore static and private. Change-Id: I8dab0ef810adba17fdd242e3a127908dd09b2b42
2019-03-20osmo-bsc-mgcp.service: Fix parsing of cmdline option sPau Espin Pedrol1-1/+1
From journald output: /usr/bin/osmo-bsc_mgcp: invalid option -- 's' Change-Id: I995d2f5909640fc007aa39dd6c6b54ff97ee45f7
2019-02-28Don't deliver alert notifications to an ESME thatKeith3-5/+10
is not yet bound. We create a new ESME in smsc->esme_list on establishment of a TCP connection, yet we do not know the system id or anything else, until the ESME identifies and authenticates. So do not send alert notifications until we know the bind status (and system_id) Change-Id: I0e5d55d3fb6ac46d253902df2fe304e1b0fc8bbf
2019-01-30Bump version: 1.1.0.120-9981 → 1.2.01.2.0Pau Espin Pedrol2-9/+154
Change-Id: I33e1c83a0000789f65acc0b7584d1629a50b384c
2019-01-24Remove osmocom-ipaccess-utils-dbg packageMax1-8/+0
The rest was dropped in I9c04f9b469e60802461a2a6e421d3ba27e6dafa1. Change-Id: If56c288121bd26fead9a921c1f04f9958468e1b6
2019-01-24Remove openbsc-dev packageMax5-28/+0
There're no external utilities which rely on it anymore so we can simplify our packaging by removing it. Change-Id: I9a96c217999416099aa7ce690845f56fc132274c