aboutsummaryrefslogtreecommitdiffstats
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2020-01-09Qt: remove codecs from about Wireshark dialogPascal Quantin1-21/+0
Codecs were moved to plugins in g63af1da7e7, they are no more embedded in a library. Change-Id: Id5448d2f83b1b4f7b1aac2620390f99da9327167 Reviewed-on: https://code.wireshark.org/review/35701 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-08rtp_player_dialog: Route audio for a stream to left/right speaker in RTP playerJirka Novak5-27/+219
Column 'Play' added to player. Double click on a stream in the column changes audio routing for the stream. When soundcard supports only one channel, there are Mute/Play option. When soundcard supports two or more channels, there are Mute/L/L+R/R options. Muted channel is drawn with dotted line. Change-Id: If120c902195da46f98a1663c589f20c6a1da0ba7 Reviewed-on: https://code.wireshark.org/review/35687 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07Qt: Don't plot zero values in I/O scatter plotsGerald Combs2-7/+19
We don't currently distinguish between missing and zero values in I/O graphs. This can be problematic in scatter plots since the plot points tend to show up as chartjunk which overwhelms the X axis. In plain, non-calculated plots assume that zero values mean "missing" and omit those points. Describe this in the User's Guide, but comment the text out for now pending a full update to the I/O Graph section. Switch to title case in our default graphs. Make the TCP Errors graph red by default. Change-Id: I92dcbf05f58ae0b7b7734fa8dfc342424bbea114 Reviewed-on: https://code.wireshark.org/review/35645 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07rtp_player: Player is able to set start of audio play by double clickJirka Novak9-60/+212
Patch adds ability to set start of audio play by double clicking on waveform. Patch fixes unreported issue with placing waveform at incorrect place when switched relative/absolute time mode (check/uncheck Time of Day). Change-Id: Ib8ce24aea870e2443e033afbb6d6e9fbcf222431 Reviewed-on: https://code.wireshark.org/review/35621 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07rtp_analysis_dialog: Improved codec recognition during saving of audio to .auJirka Novak2-26/+34
I found that when codec is negotiated to nonstandard payload id, it was reported as unsupported even was supported. Patch fixes it. Change-Id: I4eb14fc22f83eb42300fc67baee8456dff65d191 Reviewed-on: https://code.wireshark.org/review/35575 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07voip_calls_dialog/voip_calls: Fix for duplicated entries after retapJirka Novak1-0/+4
Issue seen from 2.6: 1) Open pcap with any VoIP call 2) Open Telephony->VoIP calls 3) Select one or more calls 4) Press Flow Sequence - sequence is shown 5) Close Flow Sequence 6) Press Play Streams - Play dialog is shown 7) Close Play dialog 8) Press Flow Sequence - sequence is shown, but all entries are duplicated If you repeat 6-7 multiple times, all entries are shown multiple times in 8 Patch adds missing clear of graph_analysis before retaping the stream. Tested on master, but should be backported to as many stable branches as possible. Change-Id: I9793f6e874defde2f377732d78689e957df71b33 Reviewed-on: https://code.wireshark.org/review/35672 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-06Qt: don't use monospace fonts for licence dialog.Dario Lombardo1-2/+0
Authors and licence dialogs were using monospace fonts to resemble GTK interface. Authors is not monospace anymore. Not using monospace for license dialog makes the text look more similar to other dialogs and more readable. Change-Id: I5a62f0993d579af5b1db7dea351d9a10175a069d Reviewed-on: https://code.wireshark.org/review/35663 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-06voip_calls_dialog: avoiding of 'remove_tap_listener(): no listener ...' warningJirka Novak2-4/+15
When voip_calls_dialog is opened and then closed, mentioned warning is shown because voip_calls_remove_all_tap_listeners is called twice in two different methods. Removing of the call from one of method is not possible therefore I introduced variable which tracks whether voip_calls_remove_all_tap_listeners was already called or not. Change-Id: Ic3c206cb7baf6612958d383880af296af019ffd8 Reviewed-on: https://code.wireshark.org/review/35660 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-05[Automatic update for 2020-01-05]Gerald Combs9-16/+7
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I871629b91d38be26bfe448bf90dfbb47a97acdfa Reviewed-on: https://code.wireshark.org/review/35652 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-03Qt: Update translations.Gerald Combs1-4750/+1426
We added wireshark_es.ts in gd832145366 / change 35620. Sync up with Transifex by running `tools/update-tx`. Change-Id: I3e565cbc227b124e79bc759ab6a6a095fed8ce5d Reviewed-on: https://code.wireshark.org/review/35635 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-03Qt: Add Spanish (es) translation assets.Gerald Combs2-0/+16669
Add an initial "es" Qt translation file and an accompanying flag image. The image came from https://en.wikipedia.org/wiki/File:Flag_of_Spain.svg and is in the public domain. (We already had a debian/po/es.po.) Change-Id: I5378ad2cbffb2267389fc8ae6af6d591071e0144 Reviewed-on: https://code.wireshark.org/review/35620 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-30codecs API: Added description of API usageJirka Novak1-1/+1
Added API description clarifies when bytes/samples are used. New variable names proposed and all existing codecs are adapted to it. Change is just renaming... Change-Id: I75dba64a49eb3f4369ec7160cb793dda4b44c810 Reviewed-on: https://code.wireshark.org/review/35576 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-12-29[Automatic update for 2019-12-29]Gerald Combs10-17/+26
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Iedf3b088beab75195cbf442854b1cae4d675db95 Reviewed-on: https://code.wireshark.org/review/35580 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-28Qt: Use a neutral tone in an error message.Gerald Combs1-1/+1
Don't yell at the user. Change-Id: Ibedb0a1bf7ea13feeaf6fe4f2c78bd7f3d1e65b8 Reviewed-on: https://code.wireshark.org/review/35572 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-12-25Qt: Create directories recursivelydennisschagt1-1/+1
Bug: 16143 Change-Id: Ibdd888157919315775637eb639158ea2e6cb26f0 Reviewed-on: https://code.wireshark.org/review/35561 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-12-24Additional styles for IO GraphAlexander Meier2-1/+20
This patch adds the styles Cross, Plus and Circle to IO Graph. Change-Id: I72ff0134cd34a7e9b88a3e9c6a685526a0bca1db Reviewed-on: https://code.wireshark.org/review/35555 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-23Qt: Fix the Capture File Properties dropped format.Gerald Combs1-5/+5
Fixup the formatting for the "Dropped packets" portion of the Capture File Properties dialog. Fix a couple of other issues flagged by clang. Change-Id: Ia1fad4bee37525a1a0cc25849abe34a0495f1ac8 Reviewed-on: https://code.wireshark.org/review/35552 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-22Revert "Qt: Fix dangling delete for sequence diagramm"Jim Young1-3/+0
This reverts commit aa2145982f3aec7320f33d201a17d0fdbea2a6c0. Each of the three delete calls added to the deconstructor SequenceDialog::~SequenceDialog() results in Wireshark crashing when the Flow dialog is closed. Bug: 16260 Change-Id: Iecbd5dcc16be6eb451b8920b22ca2b9ccef7c7b0 Reviewed-on: https://code.wireshark.org/review/35521 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-12-21UI: Fix compilation with Qt 5.14Orgad Shaneh26-135/+152
Change-Id: I8adae4609ff2857cb12bc803839ebb2c6afbd264 Reviewed-on: https://code.wireshark.org/review/35517 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-20Use g_file_open_tmp within create_tempfileMichael Mann2-17/+24
Much better to use a known library than create it ourselves. Also remove get_tempfile_path as it's not used. Bug: 15992 Change-Id: I17b9bd879e8bdb540f79db83c6c138f8ee724764 Reviewed-on: https://code.wireshark.org/review/34420 Reviewed-by: Tomasz Moń <desowin@gmail.com> Petri-Dish: Tomasz Moń <desowin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-12-19Protobuf: add dissecting protobuf fields as wireshark fields preferences, etc.Huang Qiangxiong3-0/+16
Two enhancements and one fixed bug: 1. Add dissecting protobuf fields as wireshark (header) fields preferences. User can input the full names of protobuf fields or messages in Filter toolbar for searching. 2. Add 'protobuf_field' dissector table. Dissector based on protobuf can register itself to 'protobuf_field' keyed with the full names of fields of BYETS or STRING types. 3. A bug about search MESSAGE or ENUM type in context is fixed. 4. Another small enhancement is adding prefs_set_preference_effect_fields() which can mark a preference that affects fields change (triggering FieldsChanged event). See the linked bug for sample capture file and .proto files. Ping-Bug: 16209 Change-Id: Ibc3c45a6d596a8bb983b0d847dd6a22801af7e04 Reviewed-on: https://code.wireshark.org/review/35111 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-18Qt: Don't crash when disabling all protocols.Gerald Combs1-0/+3
Ensure that a protocol can be disabled before attempting to do so. Fixes crash described at https://ask.wireshark.org/question/13573/wireshark-crashes-in-the-enabled-protocols-dialog-box/ Change-Id: Ib774bb6d636e82b79c5a922272a39126da85b71d Reviewed-on: https://code.wireshark.org/review/35489 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-18De-camel-ize "Wireshark" in a few places.Gerald Combs3-7/+7
The _wslua_main struct / WireShark class appears to have never been used, so remove it. Change-Id: Id80fb2c2065accedf632ea4cc467d566d10870de Reviewed-on: https://code.wireshark.org/review/35480 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-17CMake: fix CMake 3.16 warning about CMP0071Peter Wu1-0/+6
Prevent a file from being processed by moc/uic as it is not needed. This addresses a new CMake warning "Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files." Change-Id: I8ed458099cdf29472dad29168786cf16b95595fa Reviewed-on: https://code.wireshark.org/review/35468 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-16profiles: Try to better sync on disk config stateJim Young5-8/+16
Profile specific column settings are split across the `preferences' file and the `recent' file. At any given moment the GUI column settings held within the `preferences' file and the `recent' file may be inconsistent with one another and with the GUI itself. These inconsistencies occur because of when the GUI chooses to write config changes to disk. If Wireshark is not shutdown gracefully (for example when killed or should crash) the column preferences saved on disk may not be consistent between the current profile's `preferences` and `recent` files and the most recently used profile may not be recorded within the `recent_common' file. On restarting Wireshark these config file inconsistencies can lead to unexpected artifacts. Normally the column config state saved within the current profile's `preferences' and `recent` files are made consistent when a different profile is selected or when Wireshark is closed gracefully. This patch set attempts to improve the constancy of the on disk config state with the GUI state by invoking the functions to write the `recent' and `recent_common' files in a more timely manner. Fix a typo while here. Change-Id: I2af9d9eb2dcf9cc0d422e9840aa05f4f6b1aa086 Reviewed-on: https://code.wireshark.org/review/35407 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-15Reorganize long option valuesJaap Keuter4-29/+21
For long options, without corresponding short options, to be processed they need to be assigned a value, preferably outside of the range of all possible short options. The code in various places tries to stay clear of these low values, but further coordination is missing, easily leading to issues when option processing code gets extended and/or reorganized. This change introduces a single location from where each catagory of command line long option can derive a base value, which should minimize potential option value collisions. Change-Id: Ic8861a347d0050f74002de3aa1fcfb01202866e5 Reviewed-on: https://code.wireshark.org/review/35459 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-15[Automatic update for 2019-12-15]Gerald Combs9-3183/+564
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Id1d9cd2c1f311247df53f41397169ce0490bf7a7 Reviewed-on: https://code.wireshark.org/review/35443 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-13cmdline: cleanup option string definitionsJaap Keuter1-1/+1
Option string composition has grown organically over time and is depending on compilation options also. This results in somewhat complex macro definitions and the use of the string concatenation feature of the C compiler. This change tries to clean up some of this magic by removing definitions of empty strings and merging of adjacent strings. Change-Id: I968449ea9b564915bee468a0cac0e114983ceebe Reviewed-on: https://code.wireshark.org/review/35429 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-11Qt: Add some null checks.Gerald Combs2-13/+24
Add some null checks identified by scan-build. Switch some dynamic_casts to qobject_casts. Change-Id: I2b97ee8cb71db4fc883b4081568f9a5db8af85b3 Reviewed-on: https://code.wireshark.org/review/35403 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-12-10Qt: Remove a comment.Gerald Combs1-4/+0
Remove a comment that's no longer relevant as of g14e4759b56. Change-Id: I919631810c37e34ebc0cf5b78ab4dfbee5f5c687 Reviewed-on: https://code.wireshark.org/review/35390 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-10Qt: Bump our minimum Qt version from 5.2. to 5.3.Gerald Combs4-14/+0
Change-Id: Id6b39125a56b95b94d6a0bb6436bf7b2d131f924 Reviewed-on: https://code.wireshark.org/review/35385 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-10Win32: Remove win32_save_as_statstree.Gerald Combs2-84/+0
win32_save_as_statstree was GTK+-only. Change-Id: Ief029cd1a702b0c17d9602bee8a2d75ee4c3c393 Reviewed-on: https://code.wireshark.org/review/35384 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-10Win32: Fixup our file dialog titles.Gerald Combs4-20/+27
Add a "title" argument to each of the Win32 file dialog routines, and pass in one constructed using wsApp->windowTitleString. Change-Id: I5ff862bd28cd16093d99ae1559ecbaca907350da Reviewed-on: https://code.wireshark.org/review/35383 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-10Qt: fix wrong checks.Dario Lombardo2-2/+2
If actions_ is NULL, it will be dereferenced in the next check. Found by clang. Change-Id: I11f1620fae0e330dbbb7e0cc57b398f473261899 Reviewed-on: https://code.wireshark.org/review/35373 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-10Win32: Remove some unused code.Gerald Combs1-122/+3
Remove some code that's been #if 0'ed out since 2006 and 2012. Include file.h instead of globals.h. Change-Id: Ib4a84c03e112d732b25df4b7b26b54e029f717a4 Reviewed-on: https://code.wireshark.org/review/35378 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-10Win32: Factor out win32_check_save_as_with_comments.Gerald Combs3-115/+9
Stop using win32_check_save_as_with_comments and just use the Qt equivalent on Windows. It started out as a static funtion in file_dlg_win32.c and using the native Windows event loop may have been required for GTK+, but neither of those apply now. Change-Id: I66d7f1c6346df65b0fadb3aa9cba823c0e457703 Reviewed-on: https://code.wireshark.org/review/35382 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-12-08Win32: Fix the Export Packet Dissections dialog title.Gerald Combs1-1/+1
Change-Id: I25c40511b369ce93e1be2887488fc5389fdafd07 Reviewed-on: https://code.wireshark.org/review/35346 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-08[Automatic update for 2019-12-08]Gerald Combs10-753/+3270
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I0e2ac1a7ba3c512926a8a66255416ef74dc59591 Reviewed-on: https://code.wireshark.org/review/35348 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-06recent.c: cfield might be NULLJim Young1-2/+6
Avoid crash in GUI when using Edit Column widget. Bug: 16245 Change-Id: Ic98be3f98144dcfa9796fadd142180e3aaf84a9e Reviewed-on: https://code.wireshark.org/review/35301 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Craig Jackson <cejackson51@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-05WSUG: Update the capture chapter.Gerald Combs1-1/+1
Update the capture interface and options portions of the capture chapter. Change-Id: Ie50731264dacba2663e1de8ae5fdda7f5fbae1e9 Reviewed-on: https://code.wireshark.org/review/35281 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-04Qt: We show preference panes using their module names.Gerald Combs10-35/+38
PreferencesDialog::setPane takes a preference module name. Fix a comparison in PrefModuleTreeView::setPane and update some variable names in order to make things a bit more obvious. Modernize some related code while we're here. Bug: 16250 Change-Id: I8f4c7e5261a219e3f32e6e9a71574d81b1852219 Reviewed-on: https://code.wireshark.org/review/35304 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-12-03Use human-readable numbers for conversation statsMichael Mann1-14/+24
Bug: 15360 Change-Id: Iceaa5c2336cfb58966ef12f4267fcd09ae48bfe7 Reviewed-on: https://code.wireshark.org/review/31234 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-03Qt: Rename the Capture Interfaces dialog to Capture Options.Gerald Combs12-87/+91
Rename Capture Interfaces to Capture Options to match its main menu item. "Options" also more closely matches what the dialog actually does. Fixup a help item URL while we're here. Change-Id: Iec8bdfc9f7ae6fc4fd9e97bb366b63cff139f3a6 Reviewed-on: https://code.wireshark.org/review/35294 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-12-01[Automatic update for 2019-12-01]Gerald Combs9-281/+191
Update manuf, services enterprise numbers, translations, and other items. Change-Id: I3baf4cf43786b1680c02514f10c526cf8dca8536 Reviewed-on: https://code.wireshark.org/review/35269 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2019-11-28Qt: Remove a couple of private variables.Gerald Combs4-11/+8
ByteViewText and ProtoTree only use mono_font_ in setMonospaceFont, so there's not much use in declaring it private in each case. Change-Id: I3ad986052f6e013988ce851420f7f6e7b47b7ea8 Reviewed-on: https://code.wireshark.org/review/35255 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2019-11-28Qt: Remove unneeded methodRoland Knall1-3/+0
This is no longer needed, as it is handled by setMonospaceFont Change-Id: I9834bcd1a188cd6f1cb8ad1abe568a9a50d831bc Reviewed-on: https://code.wireshark.org/review/35253 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-28Qt: fix erratic expansion of tree item when switching packetsPeter Wu2-11/+15
ProtoTree::setRootNode() is designed to update the model with the new packet tree, and additionally expand tree items in its view. When the current selected packet is changed, it must use this method to ensure that collapsed trees are properly expanded. Fix this regression. It was not entirely clear that framesSelected can no longer use previous state, so document it explicitly. Remove the call to QTreeView::reset(), it ends up calling QAbstractItemView::reset() which touches the selection model that refers invalidated proto_node memory. The reset function of the view is automatically called the model is reset, so the call was not needed anyway. Test: open test/captures/tls13-rfc8446.pcap, expand TLS, TLS Record, and select "Content Type". Change from frame 1 to 2, and then 3. Observe that the expanded state remains constant with no flickering. In frame 3, observe that the tree remains expanded even if no item is selected. Change-Id: I0c820711f1a62aa51ac100f8ac5c89265c51eb18 Fixes: v3.3.0rc0-6-gcfee0f8082 ("Qt: Remove frameSelect signal") Reviewed-on: https://code.wireshark.org/review/35230 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-27Qt: focus the correct field when switching packetsPeter Wu1-1/+1
Instead of just visually marking a field after switching packets, make sure that it is also focused such that arrow up/down keys select the expected fields instead of the root node (the Frame layer). Change-Id: Ic16462198fb2189496f0cceeb5a5e885673636d2 Reviewed-on: https://code.wireshark.org/review/35236 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2019-11-26Qt+macOS: Add /Volumes to the file dialog sidebar.Gerald Combs6-12/+40
/Volumes is hidden on macOS, which means that it doesn't show up in Qt's non-native file dialog. Add a constructor to WiresharkFileDialog that adds /Volumes to the file dialog sidebar. Make CaptureFileDialog and ExportDissectionDialog subclasses of WiresharkFileDialog. Bug: 13840 Change-Id: I4d7da3948b203eb11fb64fa056eb42a448edf914 Reviewed-on: https://code.wireshark.org/review/35201 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-11-25Qt: fix packet selection when modifiers are pressedPeter Wu1-11/+11
When the Conversation Shortcut (Ctrl-1) was pressed, the current packet suddenly became deselected. Similarly for Go to First Packet (Ctrl-Home) and Go To Next Packet (Ctrl-.). Changing the selection mode to ExtendedSelection has as side-effect that setCurrentIndex is affected by modifiers such as Ctrl and Shift. Since Ctrl acts as a toggle, the current selection becomes empty and no packets are selected. Fix this by explicitly requesting the selection to be replaced. Tested as follows: 1. wireshark -r test/captures/dhcp.pcap 2. Select packet 3. 3. Press Ctrl-1, Ctrl-2. (Colors change, the packet remains selected.) 4. Press Ctrl-Home, Ctrl-Down, Ctrl-. 5. Observe that the packet details list is populated. Change-Id: I17f00e7fbc6e63ad52b6a0543fd850b473e506a2 Fixes: v3.1.1rc0-762-gb3f240dbf8 ("Qt: Multiselection in PacketList") Reviewed-on: https://code.wireshark.org/review/35203 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Roland Knall <rknall@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-02 03:17:45 +0000