aboutsummaryrefslogtreecommitdiffstats
path: root/ui
diff options
context:
space:
mode:
authorJim Young <jyoung@gsu.edu>2019-12-20 08:16:18 -0500
committerRoland Knall <rknall@gmail.com>2019-12-22 12:08:44 +0000
commit31570163d14da6de4a1b7fde4fdde2ff9b9d20a9 (patch)
tree3f77001c5a9cca068b5fc4b80935337fa8bbdb55 /ui
parent2a1d27bcbf0d1dc55017d14b0073acc1c39deb5a (diff)
Revert "Qt: Fix dangling delete for sequence diagramm"
This reverts commit aa2145982f3aec7320f33d201a17d0fdbea2a6c0. Each of the three delete calls added to the deconstructor SequenceDialog::~SequenceDialog() results in Wireshark crashing when the Flow dialog is closed. Bug: 16260 Change-Id: Iecbd5dcc16be6eb451b8920b22ca2b9ccef7c7b0 Reviewed-on: https://code.wireshark.org/review/35521 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
Diffstat (limited to 'ui')
-rw-r--r--ui/qt/sequence_dialog.cpp3
1 files changed, 0 insertions, 3 deletions
diff --git a/ui/qt/sequence_dialog.cpp b/ui/qt/sequence_dialog.cpp
index 3c60767a70..39c90b5193 100644
--- a/ui/qt/sequence_dialog.cpp
+++ b/ui/qt/sequence_dialog.cpp
@@ -191,9 +191,6 @@ SequenceDialog::SequenceDialog(QWidget &parent, CaptureFile &cf, SequenceInfo *i
SequenceDialog::~SequenceDialog()
{
- delete key_text_;
- delete comment_text_;
- delete seq_diagram_;
info_->unref();
delete ui;
}