aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-cfm.c
AgeCommit message (Collapse)AuthorFilesLines
2023-12-29CFM: Fix check for Management Address [Domain] when Chassis ID Len is 0John Thacker1-4/+22
According to IEEE 802.1Q 21.5.3.2, if the Chassis ID Length field is 0, then the Chassis ID Subtype is not present. Thus the number of octets used for the Chassis ID is 1 (the length field itself) if the length is 0, and 2 plus the length value if the length is > 0. According to 21.5.3.6, the Management Address Length field should not be present if the Management Address Domain Length has the value zero. If it is present anyway (as in the file provided in #13720), handle it but add an expert info. Fix #13720
2023-11-20Remove init of proto variablesStig Bjørlykke1-272/+272
Remove init of proto, header field, expert info and subtree variables. This will reduces the binary size by approximate 1266320 bytes due to using .bss to zero-initialize the fields. The conversion is done using the tools/convert-proto-init.py script.
2023-09-19cfm: fix typo for tlv senter_id mgmt IPv6 addressAlexis La Goutte1-1/+1
'cfm.tlv.sender_id.management_addr.ipv4' exists multiple times with incompatible types: FT_IPv6 and FT_IPv4
2023-08-16Misc dissector fixesMartin Mathieson1-1/+1
2023-07-10cfm: Test ID TLV has unusual length (bits not octets)John Thacker1-2/+32
ITU-T G.8013/Y.1731 9.14.2 indicates that the Length field of a Test ID TLV "must be 32" even though the Value is a 4-octet Test ID, and IEEE 802.1Q 21.5 "TLV Format" indicates that the "16 bits of the Length field indicate the size, in octets, of the Value field." For this specific TLV type, then, if it is 32, treat it as 4 and add a note. Fix #19198
2023-05-31CFM: overhaul dissectorJaap Keuter1-733/+2019
2022-03-22CFM: Unindent dissector code by restructuring loop conditionsJaap Keuter1-317/+331
Include missing default switches to handle incorrect protocol values.
2022-02-28CFM: clean up proto_item encoding, white space and some comments.Jaap Keuter1-284/+274
2022-02-15Tools: Fix fix-encoding-args.pl ASCII string validationJoão Valverde1-2/+2
Do not require a useless ENC_NA parameter for string encodings. FT_STRING and FT_STRINGZ types don't have any ndianness. Follow-up to 6ec429622c9258eefd388caf21ce92ab5b9f54b4.
2022-01-11CFM: Add 1SL PDU dissectionJaap Keuter1-0/+63
2022-01-09CFM: Add CSF PDU dissectionJaap Keuter1-1/+74
2020-08-30More spelling fixes, start of second pass of dissectors.Martin Mathieson1-1/+1
Now easier to find errors due to script improvements and more complete dictionary file.
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-04MPLS: link CFM to designated G-ACh channel typeJaap Keuter1-1/+2
RFC 6671 allocates a G-ACh channel type to MPLS-TP OAM, which basically boils down to what is provided in the CFM dissector. Let the CFM dissector therefore register for this channel type. Bug: 15887 Change-Id: Ib23b046b3e8d79d4b3d51f10b83892333f593235 Reviewed-on: https://code.wireshark.org/review/33837 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-15Add support for BASE_OUIMichael Mann1-19/+7
Modeled after BASE_PT_XXX, this will format a FT_UINT24 to look a OUI, in the form of: XX:XX:XX (Manufacturer Name) for display. For display filtering, it will treat the value as hexadecimal. It requires that FT_UINT24 be the field type. Change-Id: I8716ae4dfcd4e854764a2425e2ff13c50f571d52 Reviewed-on: https://code.wireshark.org/review/23869 Reviewed-by: Richard Sharpe Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-27cfm: fix 'pinfo' was marked unused but was used [-Wused-but-marked-unused]Alexis La Goutte1-1/+1
Change-Id: I046a37a07cdaad6db2132efbfbbc9dbfa0055bec Reviewed-on: https://code.wireshark.org/review/23240 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-06-29Added General Notification Message opcode to CFMGabor Vaszkun1-0/+105
Change-Id: Ieeb3f9ae6b9b261bb68917005d15822197e37b4e Reviewed-on: https://code.wireshark.org/review/22462 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-18Fix typo.Guy Harris1-1/+1
Change-Id: Ie28490c93736c7e95f0b1eaed1e075e61f005e16 Reviewed-on: https://code.wireshark.org/review/18289 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-05-03Decode OUI as Ethernet Vendor ID.Joerg Mayer1-9/+22
Change-Id: I17bca31d383dbbf5c29d7a28f16f4aa0dad9f945 Reviewed-on: https://code.wireshark.org/review/15252 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-13register_dissector -> new_register_dissectorMichael Mann1-2/+3
Picking off "easy" dissectors that only have one or two exit points at most. Change-Id: I3d5e576b796556ef070bb36d8b55da0b175dcba8 Reviewed-on: https://code.wireshark.org/review/11805 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-06-23CFM: fix CFM Type Test signal (TST) without CRC dissectionJustinKu1-1/+1
Bug: 11286 Change-Id: I8efce21e2bab55f9fea50a234419082cdc288f4e Reviewed-on: https://code.wireshark.org/review/9048 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-1/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-12Add Decode As functionality for MPLS PW Associated Channel Type.Michael Mann1-0/+1
Add CFM and MPLS dissector as possible decoders. Bug: 10574 Change-Id: Ic39c6b8d68b965ff9d342f5ee789a8eff3134a5a Reviewed-on: https://code.wireshark.org/review/4935 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-26CFM: display MEP ID in decimal in OAM Y.1731 Synthetic Loss Message and ↵Pascal Quantin1-8/+8
Reply PDU Bug: 10500 Change-Id: I70dab8fb86965fedbe8739e265db81fe310518cf Reviewed-on: https://code.wireshark.org/review/4289 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-11packet-cfm.c: Update some comments; Add editor modelines.Bill Meier1-11/+21
- Indicate that ITU-T G.8013/Y.1731 (11/2013) is the latest spec (and that the cfm dissector has not been updated to reflect same). - Remove a comment about a "discrepancy in the recommendation ITU-T Y.1731". The discrepancy has been corrected in the latest spec. Change-Id: I5a5f873d2a0a5fdee3aef1688403bb317a155cdf Reviewed-on: https://code.wireshark.org/review/4081 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-11packet-cfm.c: Fix Bug 10385: "Ethernet OAM (CFM) frames including TLV's are ↵Bill Meier1-1/+1
wrongly decoded as malformed" Regression introduced in ga06cccb (svn #50352) [Jul 3 16:43:40 2013] Bug 10385 Change-Id: I3f5c5518a5804a1f31cac554323a6fa8d3d55d5d Reviewed-on: https://code.wireshark.org/review/4078 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-06-24convert to proto_tree_add_subtree[_format]Michael Mann1-4/+2
Change-Id: I5f573dffabb8685a8e5a334ff2bfb24d9838daa6 Reviewed-on: https://code.wireshark.org/review/2601 Tested-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-09-03From Andreas Urke via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9091 :Pascal Quantin1-43/+86
Add support for CFM R-APS/G.8032 version 2 From me: convert a few value_string to true_false_string svn path=/trunk/; revision=51744
2013-08-05Keep result of [new_]register_dissector in some dissectors. [2 of x]Jakub Zawadzki1-3/+3
(don't create new dissector handle if we can use already existing one) svn path=/trunk/; revision=51159
2013-07-03Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-13/+10
svn path=/trunk/; revision=50352
2013-03-15[-Wmissing-prototypes]Anders Broman1-0/+3
Use explicit casts. svn path=/trunk/; revision=48334
2012-11-07Get rid of a non ASCII char.Anders Broman1-1/+1
svn path=/trunk/; revision=45960
2012-11-07From Wim Leflere:Anders Broman1-17/+114
Updated the APS dissection and improved the dissection information. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7962 svn path=/trunk/; revision=45959
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-01-19Fix some duplicate display filter names.Chris Maynard1-11/+11
svn path=/trunk/; revision=40586
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-20Use ENC_NA as proto_tree_add_item() encoding arg for FT_ETHER hf[] field type.Bill Meier1-11/+11
(Some minor whitespace cleanup). svn path=/trunk/; revision=39488
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵Bill Meier1-2/+2
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39426
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-87/+87
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39260
2011-09-26Get rid of check_col, while at it set ENC.Anders Broman1-215/+213
svn path=/trunk/; revision=39147
2011-06-24From Peter Nahas:Jaap Keuter1-1/+114
This patch adds support for the two-way Sythetic Loss Measurement opcodes (SLM & SLR) defined in the latest ITU-T Y.1731. svn path=/trunk/; revision=37781
2010-12-23Fix for bug 5517:Jaap Keuter1-1/+2
MEG ID, ICC-based format is text, not binary. svn path=/trunk/; revision=35252
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-1/+1
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-10-02Minor cleanup:Bill Meier1-694/+724
- packet-cfm.h not used elsewhere: incorporate into packet-cfm.c; - Move proto_register and proto_reg_handoff to the end of the file; - Localize some variables; - Remove some unneeded initializers; - Cleanu some whitesace. svn path=/trunk/; revision=34334
2010-04-06#include <string.h> not needed.Bill Meier1-1/+0
svn path=/trunk/; revision=32410
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-15 06:09:29 +0000