aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-01-12[Automatic update for 2020-01-12]HEADmasterGerald Combs17-211/+671
Update manuf, services enterprise numbers, translations, and other items. Change-Id: Ie93b6e343a90ab33b15e5be1814e9b988101ee28 Reviewed-on: https://code.wireshark.org/review/35750 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-11S1AP: upgrade dissector to v15.8.0Pascal Quantin9-3840/+3841
Change-Id: I53d1a30f02f8325472a7fd63cb16ca2b1917f9a1 Reviewed-on: https://code.wireshark.org/review/35748 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-11Compilation fixes when CMAKE_BUILD_TYPE = MinSizeRel (-Os flag).Roman Koshelev6-7/+11
Compiler - gcc 8.3.0 These are mostly errors 'may be used uninitialized in this function' Change-Id: I6a8f7172c99024fd449570937b030e37c0ea5c3d Reviewed-on: https://code.wireshark.org/review/35746 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-11ber: display x509af.utcTime year in 4 digitsAndre Luyer19-33/+88
Because: - the 2-digit year can only be in the range 1950..2049 according to https://tools.ietf.org/html/rfc5280#section-4.1.2.5.1 - to avoid confusion, interpreting the year/month/day in a different order may still represent a valid date. - now both utcTime and GeneralizedTime are displayed in exactly the same way. - some tools, like Perl, apply a different date range when converting 2-digit years. In packet-ber.c two parameters are added to the function dissect_ber_UTCTime: datestrptr: if not NULL return datetime string instead of adding to tree or NULL when packet is malformed tvblen: if not NULL return consumed packet bytes Also the memory allocation for outstr is now done using the recommended method as described in the README.developer document. The calling function in x509af/x509sat uses this to prepend the century. Added generated files. Change-Id: I714c2e8e7f899211caaa1f4136ca0d27cb1aba4a Reviewed-on: https://code.wireshark.org/review/35414 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-11Add Cisco Miscabling ProtocolJoerg Mayer3-0/+309
Change-Id: Iab98bfeb2ab8aa2314e74ff4330b85e7f6533a48 Reviewed-on: https://code.wireshark.org/review/35116 Petri-Dish: Jörg Mayer <jmayer@loplof.de> Tested-by: Petri Dish Buildbot Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2020-01-11Implement all mapping macros for the new proto tree APIJaap Keuter3-32/+224
The new proto tree API uses mapping macros to map calls to the proto_tree_add_* functions. These were defined for the up til then in use functions. In the mean time functions have been added and workarounds for non mapped functions were used. This change adds the missing mapping macros so that now all proto_tree_add_* functions taking a hfi address are mapped properly. Also fix two dissectors that failed the mapping. Change-Id: I91d800439fe2c4487ca53c00c44d7aa46ce70e1d Reviewed-on: https://code.wireshark.org/review/35743 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Jörg Mayer <jmayer@loplof.de> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2020-01-11travis: add gcc-9 builds.Dario Lombardo1-0/+13
Ping-Bug: 16319 Change-Id: I255355cc2d9173cbb4c6afc11f38f7c173a55872 Reviewed-on: https://code.wireshark.org/review/35742 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-10Use symbolic values for Cisco's LLC PIDsJoerg Mayer10-30/+79
Change-Id: I4cc99cef1e52fcce308608dd95befa2286787b16 Reviewed-on: https://code.wireshark.org/review/35728 Petri-Dish: Jörg Mayer <jmayer@loplof.de> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2020-01-10DOIP: Trivial typo fixedDr. Lars Völker1-1/+1
In doip_versions is a trivial typo "identifcation", which is fixed by this patch. Bug: 16325 Change-Id: Ia432d505fdf57606cd72ac63c80fca5066c37ff3 Signed-off-by: Dr. Lars Völker <lars.voelker@technica-engineering.de> Reviewed-on: https://code.wireshark.org/review/35736 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2020-01-10DLT: Fixing parsing of multiple DLT message in a single UDP packet.Dr. Lars Völker1-6/+7
The current implementation of DLT will only dissect the first message and skips all other messages in an UDP packet. Wireshark will mark all bytes in the UDP payload belonging to the first message. This is wrong and being fixed in this patch. Bug: 16321 Change-Id: I7929caaf415e59220c29a8481d8671e71b00db0c Signed-off-by: Dr. Lars Völker <lars.voelker@technica-engineering.de> Reviewed-on: https://code.wireshark.org/review/35731 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-10NAS 5GS: correction of QoS Rules with the length of two octetsJoakim Karlsson1-4/+7
Change-Id: I2d5c2e714067ec3198e24c54145315c009b56198 Reviewed-on: https://code.wireshark.org/review/35729 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-10Fix build and deprecation warnings with Qt 5.14Orgad Shaneh5-17/+10
Change-Id: I1fa6b5d3105288d25717a9fe4ae93ad3f471aaca Reviewed-on: https://code.wireshark.org/review/35727 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2020-01-10Add initial version of a dissector for the Paloalto heartbeat backup protocol.Joerg Mayer2-0/+123
Change-Id: I79b6c42df983c6dae6cce866f3cfdd673a6a7f0b Reviewed-on: https://code.wireshark.org/review/35721 Petri-Dish: Jörg Mayer <jmayer@loplof.de> Tested-by: Petri Dish Buildbot Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2020-01-10BGP: MPLS label for EVPN Extented communityUli Heilmeier1-1/+19
Dissect MPLS label fields for EVPN Extented Community. RFC7432 section-8.2.1 defines only a SHOULD for ESI label set to a MPLS label when Single-Active redundancy mode is desired. Therefore and not break current implemntation we only add the additional dissection of the MPLS label bits. Bug: 16313 Change-Id: Iad2561b90aeace212f79a874efb59af917aca3f1 Reviewed-on: https://code.wireshark.org/review/35692 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-10tpncp: replace stack variable with dynamic allocation.Dario Lombardo1-3/+1
The size of the stack triggers an error on clang: ../epan/dissectors/packet-tpncp.c:410:1: error: stack frame size of 26152 bytes in function 'init_tpncp_data_fields_info' [-Werror,-Wframe-larger-than=] init_tpncp_data_fields_info(tpncp_data_field_info *data_fields_info, FILE *file) ^ 1 error generated. Change-Id: Ia7d1d609b339eff6ffa023d9c0bf47caf6bd9851 Reviewed-on: https://code.wireshark.org/review/35715 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-10Qt: Fix related packet delegateRoland Knall2-2/+12
Recent updates broke the related packet delegate in such a way, that the direction arrow for the current packet was shown, but no indicator for any other packet. This fix resets the packet indicator properly, if a new frame is selected. Note: This means, that the caller has to reset the delegate, but this was the original behavior anyway Bug: 16316 Change-Id: Ief2396c65303a2226ad9fdd87969b667b2f1274d Reviewed-on: https://code.wireshark.org/review/35720 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-10Qt+Win32: Tell the user to install Npcap/WinPcap if needed.Gerald Combs2-10/+27
If we don't have local interfaces on Windows, show a message in the main welcome screen and link to Npcap and WinPcap. Use consistent wording and layout in the macOS equivalent. Change-Id: Ifc9ee2e29ba197667bd95f39390be5684bb334ae Reviewed-on: https://code.wireshark.org/review/35724 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-10Qt: Add elements back to the tcptrace graph.Gerald Combs2-40/+57
Segment and SACK elements in the tcptrace graph are plotted using QCustomPlot's error bars. This part of QCP's API changed from version 1 to 2, and were #ifdef'ed out as part of the switch to QCP 2.0.1. Update our code to use the new API. Bug: 16281 Change-Id: Ieae2808686ddc631e0cd18c0c32fc7a2c0f396b7 Reviewed-on: https://code.wireshark.org/review/35726 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-10Netlink: Properly interpret and mask out attribute typeJaap Keuter1-5/+10
The netlink attribute type is a 16 bit field, of which the two top most bits are booleans. Interpret them as such. The remaining 14 bits form the attribute type value. Due to the flexible way the interpretation is setup, through the use of family specific code, the header field for the attribute type value has to have a proper mask. Otherwise the two top bits are taken (incorrectly) as part of the value. Since this may not be obvious to the netlink family dissector creator better enforce it by adding the masked value in the underlying netlink dissector, using whatever header field is given for this. Change-Id: I791f9b1de01505d4a4793abbcf62e596b864e2f0 Reviewed-on: https://code.wireshark.org/review/35725 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-10packet-kerberos: try to fix the build on macOS 10.14Gerald Combs4-17/+43
/usr/lib/libkrb5.dylib doesn't have krb5_pac_verify(). This hopefully fixes the build problem introduced by commit d9aab840a75ededc286b8e9894e5af7ce6298bbc Change-Id: Ib354a59cbc20c6bf97ddc029d8b042d4aea6dae9 Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35713 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-09NR RRC: upgrade dissector to v15.8.0Pascal Quantin6-192/+323
Change-Id: I2001239b765ab766c31c0e4181e25e43d8d9c761 Reviewed-on: https://code.wireshark.org/review/35723 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-09LTE RRC: upgrade dissector to v15.8.0Pascal Quantin11-1116/+1115
Change-Id: Ib480626891c1796623902c6dfe24183ead59112e Reviewed-on: https://code.wireshark.org/review/35722 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2020-01-09AUTHORS: reword a bit some acknowledgements.Dario Lombardo1-2/+3
Lines in the generated AUTHORS-SHORT file are processed as they were "Name" <email>. This means that any line going to this file must start with that format. After lines have been merged, the name/email must be at the very beginning of its line. Fix a regression introduced in g1e0fa912d4. Add Roman Koshelev while here as result of automatic authors generation. Change-Id: I82ad403a68aa081cf63d6444953edecf2b7e813b Reviewed-on: https://code.wireshark.org/review/35714 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09packet-ip.c: The return value is already calculated and returned by the ↵Joerg Mayer1-4/+2
previous call. Change-Id: I9471e4f823d82d31d41ccd21728358ab363854cd Reviewed-on: https://code.wireshark.org/review/35719 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2020-01-09Add Ethertype 8988 used on the heartbeatlink inside a Paloalto firewall clusterJoerg Mayer2-1/+6
Change-Id: Id1aef0ba84e17ee15c51af3110a1af4636fd6e4d Reviewed-on: https://code.wireshark.org/review/35718 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2020-01-09wka: Add Cisco ACI gleaning src MACJoerg Mayer1-0/+2
Change-Id: Ib3ed85b20463d8dc0757ac743890dbd7a0d13e70 Reviewed-on: https://code.wireshark.org/review/35717 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2020-01-09tvbuff.h: Fix formatting inside a comment.Joerg Mayer1-1/+0
Change-Id: Idec8da435bd45a559ad802cb7c9080a7ab5013e3 Reviewed-on: https://code.wireshark.org/review/35716 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2020-01-09Qt: Fix PacketListHeader columnRoland Knall6-4/+37
Due to changes in #35206, if you have a lot of columns the display of all columns may be hindered depending on your screen resolution. With this change, displaying the column information can be disabled via a Preferences->Layout checkbox element. Additionaly, the column information will always be displayed as a tooltip element Bug: 16317 Change-Id: Ib8c0fc0a84deaca96631270b320f3a530ba87d89 Reviewed-on: https://code.wireshark.org/review/35706 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2020-01-09TPNCP: Update from downstreamOrgad Shaneh2-445/+407
* Support little-endian systems * Improve error reporting * Implement some new features in the protocol Change-Id: I73e07a588c4a028fd0c22e1570adb7957ba2d52f Reviewed-on: https://code.wireshark.org/review/35467 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2020-01-09TCP: fix DESEGMENT_UNTIL_FIN handling in combination with OoO trackingPeter Wu1-2/+27
For dissectors that expect reassembly at FIN (for example, the WHOIS dissector), the expected end of the reassembly is not known until the FIN packet is received. We cannot rely on 'nxtseq' being valid, and certainly not use it to set the end of the reassembly using fragment_reset_tot_len. Since (1) OoO segments before FIN are already properly handled without extra care, and (2) OoO FIN is already broken, just disable OoO handling when DESEGMENT_UNTIL_FIN is requested. This ensures that reassembly at FIN is not skipped due to lack of data. Explicitly calculate 'nxtpdu' for the FIN case. Previously it happened to work because streams were often smaller than DESEGMENT_UNTIL_FIN (0x0ffffffe, 256MiB), but that was not obvious. Bug: 16289 Change-Id: I9b9468925d49765e21e58136c8a2366da082eeba Fixes: v2.9.0rc0-1097-gca42331437 ("tcp: add support for reassembling out-of-order segments") Reviewed-on: https://code.wireshark.org/review/35543 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09GSUP/SMS: also dissect ToN/NPI header in SM-RP-DA/OAVadim Yanitskiy1-4/+8
Unlike IMSI, both MSISDN and SMSC Address in SM-RP-OA/DA not only contain the BCD encoded digits, but also a little header with NPI (Numbering Plan Identification), ToN (Type of Number), and Extension fields. IE: SM-RP-DA (Destination Address) Information Element Identifier: SM-RP-DA (Destination Address) (65) Information Element Length: 8 Address Type: SMSC Address (3) 1... .... = Extension: No Extension .001 .... = Nature of number: International Number (0x1) .... 0001 = Number plan: ISDN/Telephony Numbering (Rec ITU-T E.164) (0x1) E.164 number (MSISDN): 447785016005 Country Code: United Kingdom of Great Britain and Northern Ireland (44) Let's dissect that header and following address bytes using the public API from MAP dissector - dissect_gsm_map_msisdn(). Change-Id: Idc8a098926d38770002ba689efcf2c794c6b18d9 Reviewed-on: https://code.wireshark.org/review/35664 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09DCERPC: display various driver version fields as hexGünther Deschner1-4/+4
Guenther Change-Id: I39eecf3e864df401dff9236d9614a5bd6ca68427 Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/35693 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09WSDG: Update the libraries chapter.Gerald Combs1-30/+45
C-ares is required, so don't mark it as optional. Add Win64 download URLs and list them first. Zlib is part of our vcpkg bundle. Change-Id: I232f4df988aa12afde0b66fff203187136504e94 Reviewed-on: https://code.wireshark.org/review/35700 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09packet-kerberos: try to verify the PAC checksums and display the used keysStefan Metzmacher2-7/+239
This makes it much easier to analyze how PAC signing is supposed to work with trusted domains. Change-Id: I9993e5d92b7efee5aa91cd0e2005787f7d384444 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35704 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09Qt: remove codecs from about Wireshark dialogPascal Quantin1-21/+0
Codecs were moved to plugins in g63af1da7e7, they are no more embedded in a library. Change-Id: Id5448d2f83b1b4f7b1aac2620390f99da9327167 Reviewed-on: https://code.wireshark.org/review/35701 Reviewed-by: Pascal Quantin <pascal@wireshark.org> Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09BGP: Add EVPN Layer 2 Attributes Extended Community (RFC 8214)Jaap Keuter1-0/+76
Bug: 16287 Change-Id: Ic76972c2c99d0206c68703bee924c0e16ffdeae7 Reviewed-on: https://code.wireshark.org/review/35702 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09packet-kerberos: add a hint to the used decryption key into the proto treeStefan Metzmacher2-15/+33
This makes it much easier to understand which key is used were. Change-Id: I6f4bb1e46abb30212a87be2b574dc2679d8b7aed Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35695 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09packet-kerberos: re-add dissection of ntstatus (KERB_EXT_ERROR) in PA-PW-SALTStefan Metzmacher3-62/+188
We autodetect the length a 12 bytes and the 0 (4 bytes) and 1 (4 bytes) values after the 4 bytes NTSTATUS field. See [MS-KILE] 2.2.1 KERB-EXT-ERROR. Change-Id: I19345cb3f9c863e54a8f16002987912487f7d76a Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/35694 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-09NSIS: Fix a dangling output path.Gerald Combs1-0/+2
The updates to windeployqt-to-nsis.ps1 g7a09c78f12 added SetOutPath calls to qt-dll-manifest.nsh. This means we need to reset the output path before adding our translation files. Change-Id: I4b4ede72efa67cc4617aaae5baf8d38df6952df7 Reviewed-on: https://code.wireshark.org/review/35705 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-08Netlink: remove encoding copies and, by extension, nl_data copiesJaap Keuter7-177/+136
The underlying netlink dissector sets up a data structure to help maintain information about the netlink packet. This contains the encoding information as determined for this packet. Use this value in place of the copy that every netlink dissector makes in its private data structure. As a consequence the encoding field can be removed from these private data structures. Since the encoding field is now directly available from the data structure setup by the underlying netlink dissector, the private data structures also do not need to keep a pointer to this underlying netlink dissector data structure. This change replaces the use of the local copy of encoding with the original one. This change, by extension, also removes the encoding field and the pointer to the underlying netlink dissector data structure as these are no longer needed. The exception is the generic netlink dissector, which implements the dynamic netlink famiily subdissector table. Change-Id: Ida0065379c19ae68caf6d87860828b48766c1998 Reviewed-on: https://code.wireshark.org/review/35698 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-08rtp_player_dialog: Route audio for a stream to left/right speaker in RTP playerJirka Novak5-27/+219
Column 'Play' added to player. Double click on a stream in the column changes audio routing for the stream. When soundcard supports only one channel, there are Mute/Play option. When soundcard supports two or more channels, there are Mute/L/L+R/R options. Muted channel is drawn with dotted line. Change-Id: If120c902195da46f98a1663c589f20c6a1da0ba7 Reviewed-on: https://code.wireshark.org/review/35687 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-08packet-smb2: add support for SMB2_FILE_NORMALIZED_NAME_INFOStefan Metzmacher1-0/+31
Change-Id: I58d9db510181c5872be14e9feb4f35c2e6e41a39 Reviewed-on: https://code.wireshark.org/review/35595 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2020-01-08packet-dcerpc-netlogon: relax the data model for netlogon_auth_keyStefan Metzmacher1-70/+34
This is a change into the correct direction and allows decryption even if DCERPC security context multiplexing is not used. The final design is added as comment, which would make it possible to do decryption in all cases allowed by the protocol. Change-Id: Ided40e0028967f2a047bf2722e627800ca77054d Reviewed-on: https://code.wireshark.org/review/35680 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-08Netlink: stop hiding packet_netlink_data pointerJaap Keuter8-230/+244
The underlying netlink dissector sets up a data structure to help maintain information about this netlink packet. It gets passed through the familiy specific netlink dissectors private data structures to reappear when support funtions of the underlying netlink dissector are needed. In the mean time a copy of data (the value 'encoding' to be precise) in this structure is also maintained in these familiy specific netlink dissectors, adding to the confusion. This change is to make the underlying netlink dissector data structure a normal part of the function interfaces, so that it is present without being dependant on another private data structure. This change is a first step towards removing the unnessesary copy of the encoding value. Change-Id: I69e78a2b15e58e149e82e89c19e519ef041ee6b1 Reviewed-on: https://code.wireshark.org/review/35688 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-08NSIS: Make the licensing page match reality.Gerald Combs1-6/+5
The NSIS licensing page is centered around making the user agree to a EULA. We don't have one of those. Replace the "you must accept" and "I agree" text with something more neutral. We could alternatively omit with the licensing page altogether, but the GPL is an important aspect of the project and deserves some sort of mention. Bug: 1115 Change-Id: I5fd5beac2188b61a90c2842de7d7547aa815ff4f Reviewed-on: https://code.wireshark.org/review/35624 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-07Docs: Ensure that the API reference has the proper permissions.Gerald Combs1-1/+14
Set our file permissions before building the wsar_html_zip target. Change-Id: I660bf87891a0c8bbebfd497984617bd1d294bf10 Reviewed-on: https://code.wireshark.org/review/35685 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-07Docbook: Fix some file permissions.Gerald Combs3-0/+0
Make the release notes and some PNGs non-executable. Change-Id: Iecd52e782258f6d7a485138f8f965b7dce52a0dc Reviewed-on: https://code.wireshark.org/review/35689 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-07NSIS: Build Unicode installers / uninstallers.Gerald Combs1-0/+2
Recent versions of NSIS have deprecated ANSI installers, so enable Unicode. Change-Id: I263568f83b7f96871e056ba590db300b23dbdc80 Reviewed-on: https://code.wireshark.org/review/35681 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs <gerald@wireshark.org>
2020-01-07AUTHORS: remove newlines.Dario Lombardo3-61/+25
The text is used in a Qt widget that handles the newlines itself. The change makes the text appear with a better look in the about dialog. Change-Id: I1dc9fdd1f401384f4ce2d6c2c0764adaa810a654 Reviewed-on: https://code.wireshark.org/review/35662 Reviewed-by: Guy Harris <guy@alum.mit.edu> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2020-01-07dcerpc-netlogon: fix compilation with older gcrypt versions.Dario Lombardo1-1/+9
GCRY_CIPHER_MODE_CFB8 has been introduced in gcrypt 1.8.0: https://abi-laboratory.pro/?view=changelog&l=libgcrypt&v=1.8.0 Add conditional compilation code for older versions. Change-Id: I756cc118fce261a6e1a580f4a6a244c8ff0b381f Reviewed-on: https://code.wireshark.org/review/35678 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>