aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-11-25LTE RLC Stats: make display filter field work.Martin Mathieson2-1/+15
Change-Id: Ic3c9ebb176bcc7c3973aca382c270aacac7283af TODO: the same for LTE MAC Stats.. Reviewed-on: https://code.wireshark.org/review/24577 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-25RLC LTE stats: show UE and channel bw properlyMartin Mathieson1-7/+10
Change-Id: I49edf405d61b15ba451f291c32b8fc3126a7e9d7 Reviewed-on: https://code.wireshark.org/review/24575 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-25packet-iwarp-mpa.c: Stop FPDU dissection if the ULPDU_LENGTH field does NOT ↵Michael Mann1-6/+3
contain what is expected Bug: 14236 Change-Id: I15f1bc70978d1e5ae3b4bba1ff87b590726cfaa1 Reviewed-on: https://code.wireshark.org/review/24578 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-24Re-sync with osmocom version of the file with new typesMartin Heusse1-0/+4
Change-Id: Iae231de172eabe135ca3acd7f82b1683eebaee38 Reviewed-on: https://code.wireshark.org/review/24574 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-11-24Qt: About - implement copy&paste and urlsRoland Knall3-3/+100
Make the URLs clickable again, and allow the copy/paste of selected entries via context menu Change-Id: I619059ca77c54314df31364de8ee7fce9dbc3ed3 Reviewed-on: https://code.wireshark.org/review/24569 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-24TDS: Fix packet reassembly for TDS 4.x/TDS5.x streams.Craig Jackson1-28/+87
The existing TDS "netlib" packet reassembly code only handles situations where the netlib header has a valid non-zero packet number. This does not always occur for older clients, in particular when TDS 7 is not in use. This has been tested with: DB-Library 4.6 talking to Sybase CT-Library 5.0 talking to Sybase jConnect 5.0 talking to Sybase .NET 4.5 talking to SQL Server with TLS login Freetds CT-Library talking to SQL Server with unencrypted login - I'm not sure of the version of this, in the protocol it appears as 8.0.341. Change-Id: I1690ba191ba3f4bd10569ab1a26dae82c5bbf260 Reviewed-on: https://code.wireshark.org/review/24470 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-24DTLS: fix decryption with EMS and client authPeter Wu1-16/+22
Similar to the TLS fix in v2.5.0rc0-1805-gd790c524b4, ensure that the correct master secret is calculated when extended_master_secret is enabled with client auth and a decrypted RSA premaster secret. Bug: 14243 Change-Id: I3d8cecef0f0cc3ec73537053489adc2d0d45c947 Reviewed-on: https://code.wireshark.org/review/24564 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-24packet: ensure consistent layer number for heuristics dissectorPeter Wu1-1/+16
DTLS decryption works for single-pass dissection, but breaks in the second pass. Turns out that "curr_layer_num" has decremented in the second pass, resulting in a failure to lookup the decrypted data. This decryption issue was triggered by v2.3.0rc0-3740-ge1f84f985e ("Fix Decode As for protocols that may use tunneling."). The first time the UDP dissector invokes "dissector_try_heuristic", the second time "call_heur_dissector_direct". The first one increments "curr_layer_num", so do the same in the second case. Change-Id: I62679b817b02f42d073cfc07b88ec36d5bec5f04 Bug: 14243 Fixes: v1.11.4-rc1-468-g2cfda31ff0 ("Change the signature of dissector_try_heuristic() to return hdtbl_entry") Reviewed-on: https://code.wireshark.org/review/24565 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-24Qt: Add key event to reject changes in AddressEditorFrameStig Bjørlykke2-8/+28
Also give focus to the name field. Change-Id: I409d48e513c04b510f1e3d838c05e1518e6d2e9d Reviewed-on: https://code.wireshark.org/review/24547 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-24Qt: Rewrite the About dialog to use modelsRoland Knall11-241/+843
Rewrite of the about dialog, to use QTableView and Models instead of HTML files. Everything is now model based, and the model is generic enough to support any variation which can be put into a QStringList row. Change-Id: Ie32bf66b2fe2a7754c0bf07205a7b068d46b0070 Reviewed-on: https://code.wireshark.org/review/24534 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-24GTK: Remove packet editorJoão Valverde12-940/+3
Removes limited experimental feature for deprecated UI. Change-Id: Ib3ccfae89dd2a674ebbde346a442fa1cf6587f26 Reviewed-on: https://code.wireshark.org/review/24563 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-24LTE RLC graph: 'r' should reset, not zoom outMartin Mathieson1-1/+1
Change-Id: I34ad795b5c4f3f5d47b357d3af1de1f4b5fe481b Reviewed-on: https://code.wireshark.org/review/24561 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-24make-dissectors: Use more shell for build recipeJoão Valverde3-104/+1
Change-Id: Ib7b5c74c0cca5bd6b9036a36a2df85ed0d0dcabb Reviewed-on: https://code.wireshark.org/review/24562 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2017-11-23ZigBee ZCL Price Cluster dissectorIvan Ermakov1-36/+1957
Added Price cluster payload dissectors. Change-Id: I4771221e1260e446a7708adb9c862cddb8755d59 Reviewed-on: https://code.wireshark.org/review/24549 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-11-23Qt: Add menu option to remove all packet commentsMichael Mann5-0/+49
Bug: 14186 Change-Id: I8793078ea50379b2f9697787e6b7a8ab2d9e3e0e Reviewed-on: https://code.wireshark.org/review/24558 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-23BGP: display ESI 10bytes value (and not a decoded value)Alexis La Goutte1-21/+9
Bug: 14200 Change-Id: I6d8ac6aae952db21e69fa323fb1e74782d95d1c4 Reviewed-on: https://code.wireshark.org/review/24362 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-23BGP: Add Path Identifier to IPv6 NLRIMichael Mann1-13/+20
Bug: 14241 Change-Id: I5e66b034cf5cd14e2557e5b7bfa3045c2232d1ae Reviewed-on: https://code.wireshark.org/review/24553 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-23[make-dissectors] Need to link with wsutilAndersBroman1-1/+2
Change-Id: I033352dfb1836d646db5a3db04b125d2058867c9 Reviewed-on: https://code.wireshark.org/review/24556 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-23make-dissectors: Another attempt to use newlines instead of spacesJoão Valverde3-3/+9
Change-Id: I7ff5a0ea3eb3f7f56debc54aee6d5147815acc1b Reviewed-on: https://code.wireshark.org/review/24552 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2017-11-23checkAPIs: Skip make-dissectors.cJoão Valverde1-0/+1
Change-Id: Ief976c2958b98dc2a5b637bc20dd5f7f993b7124 Reviewed-on: https://code.wireshark.org/review/24551 Reviewed-by: João Valverde <j@v6e.pt>
2017-11-23make-dissectors: Fallback to the newly introduced glib-compat replacementJoão Valverde1-7/+1
Change-Id: Ieb7ea23d8109a60dce7dd0c848438e93d671a3c9 Reviewed-on: https://code.wireshark.org/review/24546 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-23Qt: Make InterfaceFrame use QFrameStig Bjørlykke2-4/+2
It's no need for InterfaceFrame to use AccordionFrame. Change-Id: Iccef1bcf919d7e5ec2bf818802ef68c1faf4e4a3 Reviewed-on: https://code.wireshark.org/review/24548 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
2017-11-23[glib-compat] g_async_queue_timeout_pop() needed for older glibsAndersBroman3-0/+24
(2.31.18) Change-Id: I727c8548c29b3409fab819dce072e86153232911 Reviewed-on: https://code.wireshark.org/review/24550 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-23make-dissectors: Don't use stdoutJoão Valverde3-17/+44
This will prevent the file from being created with shell redirection in case of error and allow printing informational messages to stdout instead of stderr. Also improve dissectorc.c Makefile recipe to abort on errors. Change-Id: I64722927721887b57a7dbe69fd2625c2e4648ad4 Reviewed-on: https://code.wireshark.org/review/24545 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: João Valverde <j@v6e.pt>
2017-11-23[glib-compat] Add g_ptr_array_new_full().AndersBroman2-2/+39
Change-Id: Ic0e054cbb28106cc02f229ad4f2476b39e544378 Reviewed-on: https://code.wireshark.org/review/24544 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-23[make-dissectors] g_ptr_array_new_full() is glib 2.30.0 which we do notAndersBroman1-0/+7
require. Add alternate code to fix the build for our minimum required version. Change-Id: Ia0911c5a6be3af68330ac41a3336d7d47b87b7a9 Reviewed-on: https://code.wireshark.org/review/24535 Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-23TLS: fix decryption with EMS and client authPeter Wu1-1/+7
When extended_master_secret is enabled with client authentication, decryption using an RSA private key file would fail because the wrong master secret is derived. This happens due to an excess CertificateVerify message in the handshake hash. Bug: 14243 Change-Id: I02f8302ac4a85422f7df52a234bdddfcb5fe3307 Reviewed-on: https://code.wireshark.org/review/24543 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-23zbee_parse_uint -> proto_tree_add_item[_ret_uint]Michael Mann5-421/+442
We don't need to unnecessarily wrap proto_tree_* functions. Change-Id: Id2853cfb9059cd90af81e529bcec57eba10e6ab3 Reviewed-on: https://code.wireshark.org/review/24540 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-23Add comment with motive for dissectors.c.inJoão Valverde2-0/+7
Change-Id: I825d4654aa76fee7288dc98eb7a92fe136d7542e Reviewed-on: https://code.wireshark.org/review/24542 Reviewed-by: João Valverde <j@v6e.pt>
2017-11-23make-dissectors: Print the number of functions successfully parsedJoão Valverde1-0/+2
Change-Id: I7364571ddc9b86efd41dcade97f843037e09f0ac Reviewed-on: https://code.wireshark.org/review/24541 Reviewed-by: João Valverde <j@v6e.pt>
2017-11-23RTPS: Topic Information feature now available for all the submessagesJuanjo Martin1-56/+107
Before, the topic information feature showed the topic information only for DATA submessages. Now it is working for all the submessages. Change-Id: Ic2fe0ac1de2377a1db627f6498ac6d5159c9cb13 Reviewed-on: https://code.wireshark.org/review/24442 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-23ssl(-utils.h): fix parameter 'src' not found in the function declaration ↵Alexis La Goutte1-1/+1
[-Wdocumentation] Change-Id: I922a1a12d2b562594354a18af5f92b21df3ce906 Reviewed-on: https://code.wireshark.org/review/24539 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-23wisun: fix no previous prototype for function ↵Alexis La Goutte1-0/+3
'proto_register_wisun/proto_reg_handoff_wisun' [-Wmissing-prototypes] Change-Id: I44751363b2e1f16a2463d7e798bedb6f59995e13 Reviewed-on: https://code.wireshark.org/review/24538 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-23802154: fix no previous prototype for function 'ieee802154_create_psie_tree' ↵Alexis La Goutte1-1/+1
[-Wmissing-prototypes] Change-Id: I7755753aab9737967c355f4969cefc7871406b9c Reviewed-on: https://code.wireshark.org/review/24537 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-22ZigBee ZDP cluster displayIvan Ermakov3-13/+37
Added cluster names to binding requests and match descriptor. Cluster IDs now display in HEX. Change-Id: I1be4339e324ba4c98ce65016f5a2e60590235d71 Reviewed-on: https://code.wireshark.org/review/24437 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-22ZigBee ZCL Calendar Cluster dissectorIvan Ermakov1-20/+756
Added dissectors for payloads of Calendar cluster. Change-Id: I5c71078714521e25ad4db82b7ffe5166965d5280 Reviewed-on: https://code.wireshark.org/review/24201 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-22sshdump: remove extra option check.Dario Lombardo1-5/+0
This looked a bit odd since the capture filter is variable length. Removing it makes sshdump work. Change-Id: I454c6263c04019d5e8ecbecd2490dd10185f5c67 Reviewed-on: https://code.wireshark.org/review/24531 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-22sshdump: add option to prevent promiscuous mode.Dario Lombardo1-9/+23
Bug: 14237 Change-Id: I5cecca8ed638c3935c7c77e3a304e4b0527d7fa3 Reviewed-on: https://code.wireshark.org/review/24530 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-22TRANSUM: Fix DNS-related bug and improve performancePaul Offord4-308/+446
These changes significantly improve the speed and accuracy of TRANSUM. I have removed the concept of rrpd status as it wasn't being used in any significant way and created unnecessary code. The find_latest_rrpd(...) function was becoming very complex which made it difficult to optimise performance for certain protocols. To overcome this, I have introduced an equivalent function for each protocol e.g. find_latest_rrpd_smb2(...). each of these new functions has a loop that steps through the rrpd_list. I could have placed this loop one level up in the nested call and so had one loop in the code that calls the new function. However, I have found that this area is the prime cause of delays in TRANSUM execution and so I want to avoid calling these new functions with each step through the rrpd_list. Finally, I have added code to improve the handling of retransmissions. Bug: 14210 Change-Id: I038097f22a45ee74173aad1ae5732347f769b9bd Reviewed-on: https://code.wireshark.org/review/24506 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-22make-dissectors: Remove dependency on GNU Make >= 4.0João Valverde2-10/+5
The $(file ...) function is only available since version 4.0. Until something breaks or someone complains use the shell to write dissectors.c.in. Change-Id: Icfe260004ca04d825c370bb642fcdc4b4be8516f Reviewed-on: https://code.wireshark.org/review/24532 Reviewed-by: João Valverde <j@v6e.pt>
2017-11-22Add Zigbee encoding, ENC_ZIGBEEMichael Mann5-157/+60
Add the "special handling" of length = 0xFF for single byte or 0xFFFF for uint16 value means size of field to follow is 0. Ping-Bug: 14138 Change-Id: I0baa40f63152b9420a6569ca6cc5eba638fbc790 Reviewed-on: https://code.wireshark.org/review/24428 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Craig Jackson <cejackson51@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-22Add support to handle DNS retransmissionsMichael Mann1-20/+95
Add a preference to the DNS dissector to specify how many seconds can elapse before a DNS query is considered a retransmission because the transaction ID is shared with a previous request. If retransmission is found, add expert info and hf_ field linking to the original request. If a retransmission of a response is found, add expert info and hf_ field linking to the original response. Bug: 14178 Bug: 13313 Change-Id: Idd77ab7f7638f5056d5690633c787a4d52285aee Reviewed-on: https://code.wireshark.org/review/24525 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-22Enable TCP Calculate Conversation Timestamp by defaultMichael Mann1-1/+1
It doesn't appear to be too expensive of a calculation, so have preference enable it by default. Bug: 14182 Change-Id: I330dc99d871424d17c60ab8cff59ba0828dd069a Reviewed-on: https://code.wireshark.org/review/24529 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-22ZigBee ZCL DRLC Cluster dissectorIvan Ermakov2-0/+241
Added DRLC cluster dissector: cluster, attribute and command names. Change-Id: Ic678052aaecffce3a4b8fd99d4e2b1eb91051f11 Reviewed-on: https://code.wireshark.org/review/24440 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-22ZigBee ZCL Energy Management Cluster dissectorIvan Ermakov2-0/+230
Added Energy Management cluster dissector: cluster, attribute and command names. Change-Id: If6985ca59c314de4eb3d439999ea31fe167bb3e7 Reviewed-on: https://code.wireshark.org/review/24441 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-21Add support for MongoDB 3.6's OP_MSG to dissectorDerick Rethans1-4/+173
Bug: 14230 Change-Id: I008a0fb60c441c5f71788d695b398b73b76c0d69 Reviewed-on: https://code.wireshark.org/review/24450 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-21CMake: Remove duplicate PIDL files from CMakeLists.txtJoão Valverde2-6/+0
Change-Id: I108a95aa4da80de6c96bf83d083b5ac4acd1a6ab Reviewed-on: https://code.wireshark.org/review/24528 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2017-11-21BGP: enhance displayAlexis La Goutte1-6/+6
Display LACP Port Key/root Bridge Priority in Dec and Hex mSTP => MSTP Change-Id: I7079250da134e4bb60d2d5373bfdf2f31235f07a Ping-Bug: 14200 Reviewed-on: https://code.wireshark.org/review/24401 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-21Move the protocol registration routines back into libwiresharkJoão Valverde21-28/+26
Follow-up to b695b3e2f72998d66ca4b7a6826d4ce1688060c8. Change-Id: I7e36519f2c3806c1205d05437671325080974257 Reviewed-on: https://code.wireshark.org/review/24524 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot Reviewed-by: João Valverde <j@v6e.pt>
2017-11-21configure: Downgrade GNU Make message to a warningJoão Valverde1-1/+1
There might be compatible make versions installed or the program might have a non-standard name. Change-Id: Ie9304e07da71f1f55522a0dfc539fbe9f557731d Reviewed-on: https://code.wireshark.org/review/24526 Reviewed-by: João Valverde <j@v6e.pt>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-23 07:49:17 +0000