aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-02-03.mailmap: Update (of december)Alexis La Goutte2-3/+5
Change-Id: Id96ce391b9957ac37705c503bea35395ee3d358d Reviewed-on: https://code.wireshark.org/review/19207 Reviewed-by: Paul Williamson <paul@mustbeart.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-03Add support for Couchbase LWW *_with_meta commandsolivermd1-0/+87
Decodes the options and meta length fields added with LWW for {set,del}_with_meta request commands. Decodes get_meta responses extra field. Please see https://issues.couchbase.com/browse/MB-22003 Change-Id: Ie5205e8188a32d59145c4f9c499b16c7a7997274 Reviewed-on: https://code.wireshark.org/review/19928 Reviewed-by: Dave Rigby <daver@couchbase.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-02-03MKA: Padding support for basic-param-set dissection addedsamsaha1-0/+4
* It must be multiple of 4 Octets otherwise NULL padding should be there Change-Id: I7563b0407bd70d1f0b7aac8597ce3a757a08925e Reviewed-on: https://code.wireshark.org/review/19893 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-03BTLE: check connection_info presence before trying to perform reassemblyPascal Quantin1-48/+52
Bug: 13379 Change-Id: Idafa780f24bf9f181c0913cbe16a0cfa9bce382e Reviewed-on: https://code.wireshark.org/review/19927 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-03extcap: destroy hash tables on exit.Dario Lombardo1-0/+10
Change-Id: Ia6a1d8a45c36aff7f2bea8bde2ed5f308bddd2e1 Reviewed-on: https://code.wireshark.org/review/19919 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-02-03sharkd: fix warning C4090: 'function' : different 'const' qualifiersPascal Quantin2-2/+15
According to https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).aspx the lpCommandLine argument must not be const as is may cause an access violation. Change-Id: Iedd77663cd21ca8df542595890fbc7023f2c9c2b Reviewed-on: https://code.wireshark.org/review/19922 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-03dfilter-macro: add cleanup routine.Dario Lombardo3-0/+9
Change-Id: I3de59c0366e9bec058de144eb136abaca24b5911 Reviewed-on: https://code.wireshark.org/review/19918 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-03stream: clean up reassembly table.Dario Lombardo1-0/+1
Change-Id: I71bc19eed5de342cd794938e3eb21545249d4853 Reviewed-on: https://code.wireshark.org/review/19917 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-03Fix builds without libpcap.Guy Harris1-0/+2
capture_opts_cleanup() doesn't exist if we're building without libpcap, so don't call it if we're building without libpcap. Change-Id: I9ae33b0c13af2785b5adb380a5b03e89116f67df Reviewed-on: https://code.wireshark.org/review/19925 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-03Fix builds without libpcap.Guy Harris2-0/+4
capture_opts_cleanup() doesn't exist if we're building without libpcap, so don't call it if we're building without libpcap. Change-Id: I6c9defea15fac7df5533269c4945b965d9a67c25 Reviewed-on: https://code.wireshark.org/review/19924 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-02capture_opts: free memory on exit to avoid leak.Dario Lombardo7-102/+221
This required a restyle of the way the different apps exit. Change-Id: Iedf728488954cc415b620ff0284d2e60f38f87d2 Reviewed-on: https://code.wireshark.org/review/19780 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2017-02-02NFSv4.2 mode_umask supportAndreas Gruenbacher1-0/+19
Add support for the NFSV4.2 mode_umask attribute which will be initially supported by Linux v4.10. Change-Id: Id98e20cd0ed93bf7ad9b2246e9e05299f3d7a9fc Reviewed-on: https://code.wireshark.org/review/19921 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-02dtls: Support Decode As for selecting appdata dissectorPeter Wu1-1/+41
Being able to override (set) the application data dissector without hacks (RSA keys dialog) would be nice. Modelled after v2.3.0rc0-481-gafa2605e43 ("Support Decode As for {SSL,TLS}-over-TCP.") Change-Id: Ic4c5ca55e8f20ad599c41c1df58b24f3bced2281 Reviewed-on: https://code.wireshark.org/review/19869 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-02-02wsutil/sober128: remove unused macros and functionsPeter Wu2-429/+4
Removed unused macros/functions that are apparently imported from LibTomCrypt, only LOAD32L and STORE32L are needed. Remove code that tries to distinguish between little/big endian, since WORDS_BIGENDIAN was never defined, this would never have worked on big endian anyway. Remove the special ROR "optimization" for GCC on i386, modern compilers are able to optimize it to exactly the same thing. The generic LOAD32L/STORE32L macros are less optimized (as can be seen in the generated code), but this was not noticable in the mean running time. Tested with the packet capture from bug 3232, the result is the same: tshark -ocorosync_totemnet.private_keys:example.com -r corosync-totemsrp--key:example.com--2nodes.pcap -Vx Bug: 13368 Change-Id: I59bf27d7dd990bbcd5ad34a1797f4a6c8a04512d Reviewed-on: https://code.wireshark.org/review/19894 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-02-02xml: use wmem allocators and replace GHashTable with wmem_map_t.Dario Lombardo2-109/+87
Change-Id: I9dbddc6fd4a5eaa458843343b3e9b8e1832bde8f Reviewed-on: https://code.wireshark.org/review/19630 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-02-02sharkd: make it compile without libGeoIP.Dario Lombardo1-2/+1
Change-Id: Ief867ce8552136298bd6bd6879ec482cc5b38b6f Reviewed-on: https://code.wireshark.org/review/19887 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
2017-02-02imf: convert GHashTable to wmem_mapDario Lombardo1-4/+4
Change-Id: Ia5bd6af88db76bbe4e0a267c30b6f7749b23e299 Reviewed-on: https://code.wireshark.org/review/19903 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2017-02-02Rawshark: Add a memory limit (-m) option.Gianluca Borello2-1/+29
Add an option to rawshark that lets the user set a maximum memory limit. Change-Id: Ie102ee5f6ba5aec90a35bd63297184c7dc37662c Reviewed-on: https://code.wireshark.org/review/19911 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-02-02ncp: convert GHashTable to wmem_map_t.Dario Lombardo2-39/+11
Change-Id: I0de1c332a6052c20f6afbe1e51dfb14e18485891 Reviewed-on: https://code.wireshark.org/review/19899 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2017-02-02GHashtable -> wmem_map conversionsMichael Mann30-721/+289
Many of the register_init_routine/register_cleanup_routine functions are for initializing and cleaning up a GHashtable. wmem_map_new_autoreset can do that automatically, so convert many of the simple cases. Change-Id: I93e1f435845fd5a5e5286487e9f0092fae052f3e Reviewed-on: https://code.wireshark.org/review/19912 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-02iso15765: convert GHashTable to wmem_map.Dario Lombardo1-18/+5
Change-Id: I25fd598f3c2bd75548213140e93198b611f30d4b Reviewed-on: https://code.wireshark.org/review/19900 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2017-02-02tools: add a Gtk/GNOME suppression file.Dario Lombardo2-0/+295
As described here https://wiki.gnome.org/Valgrind valgrind can be tuned for Gtk/GNOME (glib) software by this official (or so) suppression file. Add it to the standard valgrind script to reduce the output for those functions out of Wireshark scope. Change-Id: I5dbc91ce82a890c9c02b624289ced96909be5f84 Reviewed-on: https://code.wireshark.org/review/19910 Reviewed-by: Dario Lombardo <lomato@gmail.com>
2017-02-02Qt: Add extcap placeholder parameterStig Bjørlykke5-4/+17
Added a parameter to set placeholder text in textBox. Change-Id: Iccf92fe60abc78be8f0fa112c0c9eb78890674b5 Reviewed-on: https://code.wireshark.org/review/12463 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2017-02-02Make some more protocols into pinos.Michael Mann7-29/+24
Change-Id: I87d842e3efe9f82eaaab81347dfb79d6c0932792 Reviewed-on: https://code.wireshark.org/review/19491 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-01Use INVALID_SOCKET for an invalid socket handle.Guy Harris1-14/+14
-1 is fine on UN*X, but, on Windows, it's INVALID_SOCKET. We define INVALID_SOCKET as (-1) on UN*X, so it can be used on both platforms. Change-Id: Ib2269ddf98c352a1d3c85e44006cc49d80750a78 Reviewed-on: https://code.wireshark.org/review/19909 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-01Fix some more UN*X-vs-Windows issues.Guy Harris1-3/+3
Change-Id: Ie9ad31289f0572a7e7249fcb3305849673536f05 Reviewed-on: https://code.wireshark.org/review/19908 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-01frame: use wmem instead of glib allocator.Dario Lombardo1-1/+2
Change-Id: Ibed5c2418d1dd400fe586d40681fb5ba90efbd9f Reviewed-on: https://code.wireshark.org/review/19906 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-01h460: use wmem for strdup.Dario Lombardo2-8/+8
Change-Id: Iac6027e4b1449a77bc6b0a3d089634a296b8e802 Reviewed-on: https://code.wireshark.org/review/19904 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-01h248: convert GTree to wmem_tree.Dario Lombardo2-25/+17
Change-Id: Ia8d1a7ca4ce7e8754ab97ffe5f6e11181f08b264 Reviewed-on: https://code.wireshark.org/review/19905 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-01ipmi: use wmem instead of glib allocator.Dario Lombardo1-1/+1
Change-Id: I739e0cd9ebe35049b6633a9cfa0f793d66823f9a Reviewed-on: https://code.wireshark.org/review/19901 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-01hdcp2: convert GHashTable to wmem_map.Dario Lombardo1-4/+4
Change-Id: If68a73c05bfc301e1cfdba75c090305a5b454979 Reviewed-on: https://code.wireshark.org/review/19902 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-01proto: free memory on cleanup.Dario Lombardo1-5/+6
Change-Id: Ia6cb39cbf6d5b50d39746f38758433a7541219a2 Reviewed-on: https://code.wireshark.org/review/19896 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-01ieee802a: add shutdown routine.Dario Lombardo1-2/+9
Change-Id: I21d0ab5619cde9a43b96eaff351fa338e317f4f9 Reviewed-on: https://code.wireshark.org/review/19897 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-01ndps: convert GHashtable to wmem_map.Dario Lombardo1-28/+6
Change-Id: Id1f46ed533980e67bf18aa13fcc828bf1f5e7f6e Reviewed-on: https://code.wireshark.org/review/19898 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-01dtls: avoid possible NULL derefPeter Wu1-9/+3
"decoder->flow" could result in a NULL pointer dereference if a null cipher was in use (caught by Clang static analyzer). Answering the questions: - DTLS records fragments do not need to be reassembled, thus there is no flow. The Handshake messages have their own fragment_offset field and thus there is no need to maintain an extra flow. - Actually one datagram can contain multiple records (RFC 6347, 4.1.1), but this is not implemented yet. The key can however not be "0" though, it must match the offsets from ssl_get_record_info. Fixes: v2.3.0rc0-2152-g77404250d5 ("(D)TLS: consolidate and simplify decrypted records handling") Change-Id: Iac367a68a2936559cd5d557f877c5598114cadca Reviewed-on: https://code.wireshark.org/review/19892 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-02-01GSM A / NAS-EPS: detect missing mandatory information elementsPascal Quantin4-66/+8
Current code is not able to detect missing mandatory information elements because the macro will return once the end of the payload is reached. Remove this check from all mandatory IE macros, and put it at the beginning of optional IE ones. It should allow to detect any missing mandatory IE while still stopping message dissection in case optional IEs are not present. Change-Id: Ie820740e25c1d03ee3462fa4a913c3a7870fcc2d Reviewed-on: https://code.wireshark.org/review/19816 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-02-01Bluetooth 5.0, HCI command/event PHY update dissectionAllan Møller Madsen3-4/+262
Dissection of all new HCI command/events related with Bluetooh 5.0 feature 'PHY update - LE 2M and LE Coded' Change-Id: I212cb368d3295ba36eb0ca34329df566cae1611b Signed-off-by: Allan Møller Madsen <almomadk@gmail.com> Reviewed-on: https://code.wireshark.org/review/19849 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.tomasz.labedzki@gmail.com>
2017-02-01packet-btle.c: If frame information is missing, provide a default.Michael Mann1-1/+4
"default" frame information sets no retransmission or more fragments. Bug: 13015 Change-Id: I1c8a29fe06d0b38abc789c8e454dc484490186f9 Reviewed-on: https://code.wireshark.org/review/19891 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-01Expand a comment to give more details.Guy Harris1-1/+14
(Dear Microsoft: why did you choose not to support line buffering in the MSVC "standard I/O library" routines?) Change-Id: I5add94d2c83e73e9845fea0f355a1923fddf2deb Reviewed-on: https://code.wireshark.org/review/19890 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-01sharkd: windows supportJakub Zawadzki2-26/+98
Change-Id: I6581bacdea49416cc26431f66b093f36b39c5a67 Reviewed-on: https://code.wireshark.org/review/19829 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-01ssl-utils: fix format specifies type 'void *' but the argument has type ↵Alexis La Goutte1-1/+1
'SslFlow *' (aka 'struct _SslFlow *') [-Wformat-pedantic] Change-Id: Iec574db8c28d2e02136e6c4119e5688b21112299 Reviewed-on: https://code.wireshark.org/review/19889 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-01Openflow (v5): fix redundant redeclaration of ↵Alexis La Goutte1-5/+0
‘dissect_openflow_message_v5’ [-Wredundant-decls] Change-Id: I6340f0b903af1371e69172b05650c49fc18b8890 Reviewed-on: https://code.wireshark.org/review/19888 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-31Don't provide GTK setup by default.Joerg Mayer1-5/+6
Update comments to reflect the behaviour as well. Update comment inside the Change-Id: Id3629b217a2adc096fd6b0cb0221270e92ebd5da Reviewed-on: https://code.wireshark.org/review/19875 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2017-01-31Add Decode As capabilities to MoldUDP dissectorJustin Helgesen2-2/+34
Per the Nasdaq TotalView-ITCH v2/3 protocol specifications the NASDAQ-ITCH dissector needs be able to dissect a MoldUDP payload. Change-Id: Id5194930025a9abdfb1663234233fd51e525a34b Reviewed-on: https://code.wireshark.org/review/19847 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-31Also show BGP Shutdown communication on admin resetArjen Zonneveld1-1/+1
Shutdown communication is now also allowed on Admin Reset NOTIFICATION messages: https://tools.ietf.org/rfcdiff?url2=draft-ietf-idr-shutdown-04.txt Change-Id: I6450d3d5de5aef4bd709ba2b211ca717784b00a7 Reviewed-on: https://code.wireshark.org/review/19886 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-01-31PAPI: Add dissection of Licence ManagerAlexis La Goutte1-3/+271
Change-Id: I1b7dd1835fe60852b8c90f0ce5e240813cad89d1 Reviewed-on: https://code.wireshark.org/review/15574 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-31Add wmem allocator parameter to format_uriMichael Mann4-31/+33
Change-Id: Ic6de84a37b501e9c62a7d37071b2b081a1a1dd50 Reviewed-on: https://code.wireshark.org/review/19885 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-31format_text_wmem -> format_textMichael Mann46-322/+205
All cases of the "original" format_text have been handled to add the proper wmem allocator scope. Remove the "original" format_text and replace it with one that has a wmem allocator as a parameter. Change-Id: I278b93bcb4a17ff396413b75cd332f5fc2666719 Reviewed-on: https://code.wireshark.org/review/19884 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-31Enable some more tests.Gerald Combs1-2/+2
The "Microsecond pcap-ng via stdin" and "Nanosecond pcap-ng via stdin" tests work here on macOS and Windows (likely due to g8a141fe), so enable them. Change-Id: I148d02f0cc23162d782457e1d8f0e7c2c0dc6932 Reviewed-on: https://code.wireshark.org/review/19877 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2017-01-31TLS13: partial update of CertificateRequest for draft -18Peter Wu1-18/+48
Document structure, did not put much effort in there as the format is subject to change (untested, no pcap available). Change-Id: I2da8c4e005d65314158d038bc0af7411773d8fba Ping-Bug: 12779 Reviewed-on: https://code.wireshark.org/review/19865 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>