aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rsl.c
AgeCommit message (Collapse)AuthorFilesLines
2023-11-20Remove init of proto variablesStig Bjørlykke1-219/+219
Remove init of proto, header field, expert info and subtree variables. This will reduces the binary size by approximate 1266320 bytes due to using .bss to zero-initialize the fields. The conversion is done using the tools/convert-proto-init.py script.
2023-07-08SDP & RTP: Pass the channels information to RTPJohn Thacker1-1/+1
Add the number of channels from the SDP rtpmap information to the RTP dynamic payload information.
2023-07-07GSM A-bis/RSL: Fix Huawei paging PS according to patentJohn Thacker1-18/+7
According to the patent, the Huawei PS Paging Group Paras are each 1 byte long, not 2 bytes long. ( https://patents.google.com/patent/EP2192796B1/en ) This prevents some Malformed packet errors on some sample data.
2023-05-27RSL: correct wrong value in rsl_data_rte_vals[]Vadim Yanitskiy1-1/+1
In change 795db5c60e I fixed a wrong string in rsl_data_rte_vals[], but I did not notice that the corresponding value was wrong too. From 3GPP TS 48.058 (V16.0.0), section 9.3.6: For the transparent service, bits 6-1 indicate the data rate: 65 4321 ------- 11 1000 32 kbit/s 11 1001 29 kbit/s 01 1000 14.4 kbit/s ... Related: 795db5c60e "RSL: correct wrong string in rsl_data_rte_vals[]"
2023-03-22RSL: correct wrong string in rsl_data_rte_vals[]Vadim Yanitskiy1-1/+1
Section 9.3.6 in 3GPP TS 48.058 contains no encoding variant for data rate of 39 kbit/s, the value 0x22 is actually for 29 kbit/s.
2023-03-22RSL: fix wrong value-string used for transparent CSD serviceVadim Yanitskiy1-3/+1
Section 9.3.6 in 3GPP TS 48.058 defines two sets of values for CSD data rate, which are represented by the following value-string arrays: * rsl_ra_if_data_rte_vals[] - the non-transparent service, * rsl_data_rte_vals[] - the transparent service. For some reason, the rsl_ra_if_data_rte_vals[] is used for both non-transparent and transparent services, resulting in wrong dissection results for the later. Probably a copy-paste error.
2022-10-17GSM A-bis/RSL: dissect and show RFN using parse_reduced_frame_number()Vadim Yanitskiy1-0/+17
3GPP came up with a special encoding of TDMA frame number, which reduces the amount of bits needed to carry it from 32 to 16. This encoding is not only employed on the radio interface (GSM RR), but also on the A-bis/RSL interface which is used between BTS and BSC nodes. From the user perspective, parsed RFN value is a lot more meaningful than the T1/T2/T3 variables used on the wire. The GSM RR dissector does show parsed RFN value together with these variables, while the RSL dissector does not. Let's show it in the RSL dissector too.
2022-09-25packet-rsl: Support osmocom extension IE Osmux CIDPau Espin Pedrol1-16/+35
Osmux protocol [1] has historically been used as a replacement of RTP in the SCCPLite or AoIP interfaces over satellite links, since usually the satellite link is placed between the BSS (BSC) and the CN (MSC. However, some network operators found need for Osmux in the Abis interface, that is, between BTS and BSC. Hence, an Osmocom extension IE "Osmux CID" was added to the IPAC CRCX/MDCX ip.access Abis implementation, which is understood by osmo-bts and osmo-bsc. This new extension IE is similar to the already existing extension IE in the BSSMAP protocol spoken in AoIP (see BE_OSMOCOM_OSMUX_CID in wireshark code). More information on how this IE is used can be found in OsmoBTs and OsmoBSC user manuals [2][3] (search for "Osmux" keyword). This patch adds the new IE to the RSL dissector and avoids informing the RTP subsystem to follow this conversation if the IE is found, since marking it as an RTP conversation overrides the default or user configured osmux dissector (UDO port 1984). [1] https://ftp.osmocom.org/docs/latest/osmux-reference.pdf [2] https://ftp.osmocom.org/docs/latest/osmobts-usermanual.pdf [3] https://ftp.osmocom.org/docs/latest/osmobsc-usermanual.pdf
2022-08-06Prefs: Convert some SCTP port preferences to auto prefsJohn Thacker1-1/+1
Convert SCTP port preferences in dissectors starting m-z. Preferences that were already the name of the table can just be removed from the dissector and they will migrate. Preferences with a different name are added to deprecated_port_prefs in epan/prefs.c (Since that function handles them there is no need to mark them as obsolete.) Also change a few TCP and UDP single ports reigstered with preferences and callbacks that used the sample dissector as a template. Uses more auto preferences, makes more port preferences ranges, and reduces the number of preference callbacks. Ping #14319
2022-01-12packet-rsl: Fix dissect of RLM Cause IE with length 0Pau Espin Pedrol1-0/+3
The IE is defined in 3GPP TS 48.058 section 8.3.3 "ERROR INDICATION" as being a TLV of size 2-4, which means length=0 is an accepted form. Avoid showing "Malformed packet" error if such packet is found.
2021-12-19Replace g_snprintf() with snprintf() (dissectors)João Valverde1-2/+2
Use macros from inttypes.h with format strings.
2021-10-26GSM A-bis/RSL: dissect more fields in RSL_IE_OSMO_TOP_ACCH_CAPVadim Yanitskiy1-0/+21
2021-10-13GSM A-bis/RSL: dissect some more Osmocom specific IEsVadim Yanitskiy1-0/+124
2021-10-13GSM A-bis/RSL: add a checkbox for Osmocom specific definitionsVadim Yanitskiy1-9/+25
2021-10-13GSM A-bis/RSL: fix wrong tree/length in dissect_rsl_ie_message_id()Vadim Yanitskiy1-2/+2
2021-07-08RSL: Fix mask of eMLPP Priority field.Martin Mathieson1-1/+1
9.3.49 in 48.058wq
2021-05-04GSM A-bis/RSL: add Osmocom specific channel rate and type valuesVadim Yanitskiy1-0/+3
2021-05-04GSM A-bis/RSL: handle Osmocom specific Training Sequence IEVadim Yanitskiy1-0/+69
2021-01-23GSM A-bis/RSL: fix SRR bit dissection in L1 Information IEVadim Yanitskiy1-1/+1
2021-01-12GSMTAP: dissect SRO/SRR (SACCH Repetition) bit in L1 SACCH headerVadim Yanitskiy1-0/+8
For more details, see 3GPP TS 44.004: - section 6.1 "Physical layer protocol fields and procedures", - figures 7.1.1-2 "SACCH downlink block format", - figures 7.2.1-2 "SACCH uplink block format".
2020-12-20A-bis/RSL: fix handling of MS/BS Power IEs in dissct_rsl_ipaccess_msg()Vadim Yanitskiy1-0/+9
These IEs can optionally be included in ip.access specific MEASurement PREPROCessing DeFauLT message. Let's dissect them properly.
2020-12-02GSM A-bis/RSL: fix buffer overrun in dissct_rsl_msg()Vadim Yanitskiy1-2/+2
Before accessing at offset+3, we need to make sure that the buffer is large enough. In some cases, e.g. when only the MS Timing Offset IE is left in the tail, the dissector would crash and mark the packet as malformed, leaving the rest undissected.
2020-08-31More spelling fixes, part 2 of 2nd pass of dissectors.Martin Mathieson1-1/+1
There will likely be one for for this pass. Further improvements to the script are possible, i.e. filtering out (usually filter) strings such as 'onetwothree' - may not be worth it though.
2020-08-07Find and fix dissectors that should be using a default tfs.Martin Mathieson1-6/+3
Found using tools/check_tfs.py, included in this commit. Here are the reports that were fixed here: Examining: All dissector modules epan/dissectors/packet-assa_r3.c tfs_mortisepins_flags - could have used tfs_high_low from tfs.c instead: {High,Low} epan/dissectors/packet-btle.c tfs_present_bit - could have used tfs_present_not_present from tfs.c instead: {Present,Not Present} epan/dissectors/packet-dhcp.c tfs_fqdn_s - could have used tfs_server_client from tfs.c instead: {Server,Client} epan/dissectors/packet-docsis-macmgmt.c mdd_tfs_on_off - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-docsis-macmgmt.c mdd_tfs_en_dis - could have used tfs_enabled_disabled from tfs.c instead: {Enabled,Disabled} epan/dissectors/packet-docsis-macmgmt.c req_not_req_tfs - could have used tfs_requested_not_requested from tfs.c instead: {Requested,Not Requested} epan/dissectors/packet-docsis-tlv.c on_off_tfs - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-docsis-tlv.c activation_tfs - could have used tfs_active_inactive from tfs.c instead: {Active,Inactive} epan/dissectors/packet-docsis.c ena_dis_tfs - could have used tfs_enabled_disabled from tfs.c instead: {Enabled,Disabled} epan/dissectors/packet-ecmp.c tfs_not_expected_expected - could have used tfs_odd_even from tfs.c instead: {Odd,Even} epan/dissectors/packet-erf.c erf_link_status_tfs - could have used tfs_up_down from tfs.c instead: {Up,Down} epan/dissectors/packet-h263.c on_off_flg - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-h263.c cpm_flg - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-interlink.c flags_set_notset - could have used tfs_set_notset from tfs.c instead: {Set,Not set} epan/dissectors/packet-ip.c tos_set_low - could have used tfs_low_normal from tfs.c instead: {Low,Normal} epan/dissectors/packet-ip.c tos_set_high - could have used tfs_high_normal from tfs.c instead: {High,Normal} epan/dissectors/packet-isakmp.c flag_r - could have used tfs_response_request from tfs.c instead: {Response,Request} epan/dissectors/packet-isis-lsp.c tfs_metric_supported_not_supported - could have used tfs_no_yes from tfs.c instead: {No,Yes} epan/dissectors/packet-kerberos.c supported_tfs - could have used tfs_supported_not_supported from tfs.c instead: {Supported,Not supported} epan/dissectors/packet-kerberos.c set_tfs - could have used tfs_set_notset from tfs.c instead: {Set,Not set} epan/dissectors/packet-mac-lte.c mac_lte_scell_status_vals - could have used tfs_activated_deactivated from tfs.c instead: {Activated,Deactivated} epan/dissectors/packet-p_mul.c no_yes - could have used tfs_no_yes from tfs.c instead: {No,Yes} epan/dissectors/packet-pgm.c opts_present - could have used tfs_present_not_present from tfs.c instead: {Present,Not Present} epan/dissectors/packet-rsl.c rsl_ms_fpc_epc_mode_vals - could have used tfs_inuse_not_inuse from tfs.c instead: {In use,Not in use} epan/dissectors/packet-sita.c tfs_sita_on_off - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-vines.c tfs_vine_rtp_no_yes - could have used tfs_no_yes from tfs.c instead: {No,Yes} epan/dissectors/packet-vnc.c button_mask_tfs - could have used tfs_pressed_not_pressed from tfs.c instead: {Pressed,Not pressed} 27 issues found Change-Id: I7e53b491f20289955c9e9caa8357197d9010a5aa Reviewed-on: https://code.wireshark.org/review/38087 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-07-02A-bis/RSL: fix dissection of Mobile Allocation in CHANnel ACTIVationVadim Yanitskiy1-6/+21
According to 3GPP TS 48.058 (version 15.0.0), section 9.3.5, 3GPP TS 44.018 "Mobile Allocation" IE shall for compatibility reasons be included but empty, i.e. the length shall be zero. It does not mean that the Mobile Allocation IE should not be decoded by Wireshark though. Some BSC implementations may still be sending it with length greather than 0. Let's expose de_rr_mob_all() and use it in dissect_rsl_ie_ch_id(). If the length is greather than 0, raise a protocol warning. Change-Id: Idd0f2b3cd1e684f2c812b566fde71a1cc727c2c4 Signed-off-by: Vadim Yanitskiy <vyanitskiy@sysmocom.de> Reviewed-on: https://code.wireshark.org/review/37575 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-06-27A-bis/RSL: fix wrong parent tree in dissect_rsl_ie_cause()Vadim Yanitskiy1-3/+3
Cause specific fields belong to the 'Cause IE', so they should be correctly displayed in the tree hierarchy. Before this change: 0111 111. = Message discriminator: ip.access Vendor Specific messages (63) .... ...0 = T bit: Not considered transparent by BTS .111 0110 = Message type: ip.access DLCX INDication (0x76) Channel number IE Element identifier: Channel Number (0x01) 0000 1... = C-bits: Bm + ACCH (1) .... .010 = Time slot number (TN): 2 Cause IE Element identifier: Cause (0x1a) Length: 1 0... .... = Extension: No Extension .000 .... = Class: Normal event (0) .000 1111 = Cause Value: normal event, unspecified (15) After: 0111 111. = Message discriminator: ip.access Vendor Specific messages (63) .... ...0 = T bit: Not considered transparent by BTS .111 0110 = Message type: ip.access DLCX INDication (0x76) Channel number IE Element identifier: Channel Number (0x01) 0000 1... = C-bits: Bm + ACCH (1) .... .010 = Time slot number (TN): 2 Cause IE Element identifier: Cause (0x1a) Length: 1 0... .... = Extension: No Extension .000 .... = Class: Normal event (0) .000 1111 = Cause Value: normal event, unspecified (15) Change-Id: I9dc3a35dff19fc824b69f66ef137f0346247af3a Signed-off-by: Vadim Yanitskiy <vyanitskiy@sysmocom.de> Reviewed-on: https://code.wireshark.org/review/37565 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-06-01Fix some cppcheck issues:Martin Mathieson1-1/+1
- Some redundant assignments or tests. - Some declarations were changed to match definitions in terms of including _U_ for the same parameters - Some parenthesis added/changed to made precedence more obvious epan/color_filters.c:533: style: Variable 'name' is reassigned a value before the old one has been used. epan/color_filters.c:534: style: Variable 'filter_exp' is reassigned a value before the old one has been used. asn1/tcap/packet-tcap-template.c:2199: warning: Function 'dissect_tcap_ITU_ComponentPDU' argument order different: declaration '_U_, tvb, offset, _U_, tree, _U_' definition '_U_, tvb, offset, actx, tree, _U_' epan/dissectors/packet-aim.c:2546: warning: Function 'dissect_aim_tlv_value_icq' argument order different: declaration 'ti, subtype, tvb, _U_' definition 'ti, _U_, tvb, pinfo' epan/dissectors/packet-arp.c:1133: style: Clarify calculation precedence for '&' and '?'. epan/dissectors/packet-arp.c:1143: style: Clarify calculation precedence for '&' and '?'. epan/dissectors/packet-arp.c:1158: style: Clarify calculation precedence for '&' and '?'. epan/dissectors/packet-arp.c:1168: style: Clarify calculation precedence for '&' and '?'. epan/dissectors/packet-gtpv2.c:5997: warning: Function 'dissect_gtpv2_mbms_service_area' argument order different: declaration 'tvb, _U_, tree, _U_, _U_, _U_, _U_, _U_' definition 'tvb, _U_, tree, item, _U_, _U_, _U_, _U_' epan/dissectors/packet-gtpv2.c:6291: warning: Function 'dissect_gtpv2_mbms_time_to_data_xfer' argument order different: declaration 'tvb, _U_, tree, _U_, _U_, _U_, _U_, _U_' definition 'tvb, _U_, tree, item, _U_, _U_, _U_, _U_' epan/dissectors/packet-gtpv2.c:6369: warning: Function 'dissect_gtpv2_epc_timer' argument order different: declaration 'tvb, _U_, tree, _U_, _U_, _U_, _U_, _U_' definition 'tvb, _U_, tree, item, _U_, message_type, _U_, _U_' epan/dissectors/packet-knxip.c:2939: style: Condition 'mac_error' is always false (just added comment) epan/dissectors/packet-mac-lte.c:4386: style: Clarify calculation precedence for '&' and '?'. epan/dissectors/packet-nas_5gs.c:1828: style: Variable 'nas5gs_data->payload_container_type' is reassigned a value before the old one has been used. (noted confusing recursion) epan/dissectors/packet-rpcrdma.c:587: warning: Identical condition 'offset>max_offset', second condition is always false epan/dissectors/packet-rsl.c:2098: style: Assignment of function parameter has no effect outside the function. Change-Id: Ib5c9a04cfb6e6233972bc041434601c8ef09c969 Reviewed-on: https://code.wireshark.org/review/37343 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2020-01-11Compilation fixes when CMAKE_BUILD_TYPE = MinSizeRel (-Os flag).Roman Koshelev1-1/+1
Compiler - gcc 8.3.0 These are mostly errors 'may be used uninitialized in this function' Change-Id: I6a8f7172c99024fd449570937b030e37c0ea5c3d Reviewed-on: https://code.wireshark.org/review/35746 Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-09-09rsl: Add support for non-standard RSL_MSG_TYPE_OSMO_ETWS_CMDHarald Welte1-1/+49
3GPP sadly has forgotten to specify how the ETWS Primary Notification is to be communicated over Abis to the BTS. Osmocom has introduced a non-standard RSL message type "RSL_MSG_TYPE_OSMO_ETWS_CMD" for this purpose to the OsmoBTS and OsmoBSC implementations. It contains a single Information Element which in turn contains the 56-byte primary notification of the Earthquake and Tsunami Warning system. This patch adds wireshark dissector support to it. Change-Id: Icce5b06bfd00c0a7ef0f21283cc57473fa34f034 Reviewed-on: https://code.wireshark.org/review/34464 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-06-05packet-rsl.c: Adds dissector stub of MS/BS Power ParametersEric Wild1-0/+76
While the actual power parameters are vendor specific and can't be dissected the mere _presence_ of the MS/BS Power Parameters IE itself is rather important, since it implies that dynamic MS/BS power control is active, and does therefore have an impact upon the interpretation of the (preceding) MS/BS Power IE, too. Change-Id: I0c6f73ca41d63887a52dcde05b59d5177971f1d0 Reviewed-on: https://code.wireshark.org/review/33439 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-05-20Fix for incorrectly decoded RSL ERR REP/BCCH INFORMATION optional IEsEric Wild1-6/+6
This patch adjusts the inconsistent usage of the is_mandatory flag passed to the dissect_* functions for optional IEs, which fixes the issue of incorrectly parsed RSL ERR REP optional IEs and the equally broken BCCH INFORMATION optional IE parsing. Bug: 15789 Change-Id: I94ea8fe110d8d6aa6ebd0cec5013d3cc8fd55311 Reviewed-on: https://code.wireshark.org/review/33269 Reviewed-by: Harald Welte <laforge@gnumonks.org> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-10packet-rsl: Add Establishment Cause from Channel Request to proto treePau Espin Pedrol1-2/+84
Change-Id: I41709466bdb8427b759d236406505081d7d6f283 Reviewed-on: https://code.wireshark.org/review/30996 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-12-06packet-rsl: Show cause value string of Cause IEPau Espin Pedrol1-3/+66
Related: https://osmocom.org/issues/3705 Change-Id: Ib7f985c2107d33b01640f31673c23d7fb4e54627 Reviewed-on: https://code.wireshark.org/review/30934 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06packet-rsl: Move rsl_class_vals into its correct spec sectionPau Espin Pedrol1-4/+3
Change-Id: Ia7554ed4d9926159ab3dbcdc6fd64d5bd09efc67 Reviewed-on: https://code.wireshark.org/review/30933 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06packet-rsl: Parse missing Cause IE in ip.access specific messagesPau Espin Pedrol1-0/+3
Related: https://osmocom.org/issues/3705 Change-Id: I4c05387a952dd07344d373f4abe0f03b456439a5 Reviewed-on: https://code.wireshark.org/review/30932 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06packet-rsl: Fix parsing values of some IE in ip.access specific messagesPau Espin Pedrol1-6/+11
Those IEs have specific dissect methods that expect offset to point to the IE type, not to its value. Furthermore, those methods already add a subtree, so no need to create it for them. Related: https://osmocom.org/issues/3705 Change-Id: Ia63253b95678b799f59ed945d1381f4eb01be636 Reviewed-on: https://code.wireshark.org/review/30931 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05packet-rsl: Use defines for ip.access value_stringPau Espin Pedrol1-38/+38
Change-Id: I447a30068e5a4b9a510abec75498691e17cbaa32 Reviewed-on: https://code.wireshark.org/review/30927 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-17packet-rsl: Fix dissection of "CB Command Type" IEHarald Welte1-2/+47
The "CB Command Type" IE is described in 3GPP TS 48.058 Section 9.3.41, and consists of three fields. Prior to this patch, the dissector would decode none of them and instead produce a non-applicable "channel type" dissection. Change-Id: Ibb97432871df1276524fe96512ac1b67d5c5d3f0 Reviewed-on: https://code.wireshark.org/review/29683 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-04RSL: Fix bug in dissector for RELEASE REQUESTHarald Welte1-1/+1
The RSL RELEASE MODE IE is two bytes long, so we cannot call proto_tree_add_subtree() with a length of 4. Change-Id: I7ee3cfd7a7d64d14704b1f6b11ab7631ff9b0939 Reviewed-on: https://code.wireshark.org/review/27993 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-17rsl: Fix treatment of SACCH FILL / SACCH INFO MODIFYHarald Welte1-2/+4
The RSL SACCH INFO MODIFY / RSL SACCH FILL messages contain a SI5 / SI6 / SI5bis / SI5ter message. Those SI are (like the SI on CCCH) sent as UI frame in downlink direction. Since Phase 2, the "L2 pseudo-length field is part of the L3 message, and not stripped / interpreted at L2. 3GPP TS 44.006 states that a special B4 frame format is used on the SACCH downlink for UI frames, which is basically a normal B frame, but with no length field at L2, shifting the length field into L3 where it becomes the L2 pseudo-length. From RSL, we need to call a variant of the RR dissector that is able to decode a L3 message that includes a L2 pseudo-length. This is, paradoxically, not the "gsm_a_sacch" dissector, as that one is only used for B-frames, i.e. actual LAPDm ABM frames. We must use the "gsm_a_ccch" dissector. See also the discussion in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14105 as well as https://lists.osmocom.org/pipermail/openbsc/2017-December/011545.html and https://osmocom.org/issues/3059 for further background information. Ping-Bug: 14105 Change-Id: Icdad2b7698d5d7d613cacceec6a3d848b946306c Reviewed-on: https://code.wireshark.org/review/26797 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-22packet-rsl: Add RLL UNITDATA INDICATIONHarald Welte1-0/+11
I'm not quite sure why this message is missing from the wireshark dissector. It's not particularly new, at least I don't recall ever having seen a spec document in the past decade or so that was missing this message type. Perhaps a simple oversight. Change-Id: Idb6c53ff6dc6d65f6ca7ce30a89499d8383d01f6 Reviewed-on: https://code.wireshark.org/review/25974 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-30packet-rsl.c: Use value-string in RXLEV and RXQUAL fieldsPau Espin Pedrol1-4/+4
RXLEV and RXQUAL fields in RSL "Uplink Measurements" use same scale format (0-63, 0-7) as RXLEV and RXQUAL in RR. RXQUAL value-string is moved to packet-gsm_a_common.c in order to use it in both protocols. Change-Id: Idadd9505225353fec76b9605e2045a5222669475 Reviewed-on: https://code.wireshark.org/review/24663 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-11packet-rsl.c: Adds dissection of Physical Context field.Piotr Tulpan1-3/+195
Added as option with the default value set to TRUE. Dissection is based on file generated from Tektronix Monitoring Solution for Mobile Networks. Change-Id: Iedb2e742d1d406bc68e41334cac4a15da443cf3f Reviewed-on: https://code.wireshark.org/review/22507 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-07rsl: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+0
Change-Id: I0ab6056a5241c53dba8b569905e29a9ab9d9f265 Reviewed-on: https://code.wireshark.org/review/22001 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Piotr Tulpan <piotr.tulpan@netscan.pl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-02packet-rsl.c: add Encapsulating paging messages into a packet EP2192796 - ↵Piotr Tulpan1-0/+234
proprietor Huawei Adding dissection RSL message that corresponds to patent EP2192796 owned by Huawei. Change-Id: I9fe32370d9b1330f78ac96c1203b6fde3f7784cd Reviewed-on: https://code.wireshark.org/review/21788 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-29packet-rsl.c: fixed emlpp priority bit rangePiotr Tulpan1-1/+1
Based on 3GPP TS 48.058 eMLPP Priority takes bits 1-3 not 1-2. There is also decalred value_string rsl_emlpp_prio_vals (line 2605) that contains 8 values not 4 as expected for 1-2 bits. Change-Id: Iea77f8dbff9af3b25fd298f1a9703c1e34c06d30 Reviewed-on: https://code.wireshark.org/review/21797 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-12-18RTP: RTP dissector is able to decode RTP over TCP (RFC 4571)Jiri Novak1-1/+1
Bug: 13251 Change-Id: I56a01e779f7f0eadc8a078f88543269a91148f00 Reviewed-on: https://code.wireshark.org/review/19293 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-25packet-rsl: Add some extensions to RSL shared by Osmocom + EricssonHarald Welte1-1/+7
Activation of (dynamic) PDCH uses some slight extensions of the definitions found in 3GPP TS 48.058 when used on Ericsson RBS2000 or Osmocom OsmoBTS. The extensions are backwards-compatible, so I don't think it's worth to introduce a preference for this. Change-Id: I8e28d75bd8be15044a605ced8825b9b074ffbb22 Reviewed-on: https://code.wireshark.org/review/18457 Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-21 11:07:44 +0000