aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-rsl.c
AgeCommit message (Collapse)AuthorFilesLines
2018-04-17rsl: Fix treatment of SACCH FILL / SACCH INFO MODIFYHarald Welte1-2/+4
The RSL SACCH INFO MODIFY / RSL SACCH FILL messages contain a SI5 / SI6 / SI5bis / SI5ter message. Those SI are (like the SI on CCCH) sent as UI frame in downlink direction. Since Phase 2, the "L2 pseudo-length field is part of the L3 message, and not stripped / interpreted at L2. 3GPP TS 44.006 states that a special B4 frame format is used on the SACCH downlink for UI frames, which is basically a normal B frame, but with no length field at L2, shifting the length field into L3 where it becomes the L2 pseudo-length. From RSL, we need to call a variant of the RR dissector that is able to decode a L3 message that includes a L2 pseudo-length. This is, paradoxically, not the "gsm_a_sacch" dissector, as that one is only used for B-frames, i.e. actual LAPDm ABM frames. We must use the "gsm_a_ccch" dissector. See also the discussion in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14105 as well as https://lists.osmocom.org/pipermail/openbsc/2017-December/011545.html and https://osmocom.org/issues/3059 for further background information. Ping-Bug: 14105 Change-Id: Icdad2b7698d5d7d613cacceec6a3d848b946306c Reviewed-on: https://code.wireshark.org/review/26797 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-22packet-rsl: Add RLL UNITDATA INDICATIONHarald Welte1-0/+11
I'm not quite sure why this message is missing from the wireshark dissector. It's not particularly new, at least I don't recall ever having seen a spec document in the past decade or so that was missing this message type. Perhaps a simple oversight. Change-Id: Idb6c53ff6dc6d65f6ca7ce30a89499d8383d01f6 Reviewed-on: https://code.wireshark.org/review/25974 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-30packet-rsl.c: Use value-string in RXLEV and RXQUAL fieldsPau Espin Pedrol1-4/+4
RXLEV and RXQUAL fields in RSL "Uplink Measurements" use same scale format (0-63, 0-7) as RXLEV and RXQUAL in RR. RXQUAL value-string is moved to packet-gsm_a_common.c in order to use it in both protocols. Change-Id: Idadd9505225353fec76b9605e2045a5222669475 Reviewed-on: https://code.wireshark.org/review/24663 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-11packet-rsl.c: Adds dissection of Physical Context field.Piotr Tulpan1-3/+195
Added as option with the default value set to TRUE. Dissection is based on file generated from Tektronix Monitoring Solution for Mobile Networks. Change-Id: Iedb2e742d1d406bc68e41334cac4a15da443cf3f Reviewed-on: https://code.wireshark.org/review/22507 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-07rsl: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+0
Change-Id: I0ab6056a5241c53dba8b569905e29a9ab9d9f265 Reviewed-on: https://code.wireshark.org/review/22001 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Piotr Tulpan <piotr.tulpan@netscan.pl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-02packet-rsl.c: add Encapsulating paging messages into a packet EP2192796 - ↵Piotr Tulpan1-0/+234
proprietor Huawei Adding dissection RSL message that corresponds to patent EP2192796 owned by Huawei. Change-Id: I9fe32370d9b1330f78ac96c1203b6fde3f7784cd Reviewed-on: https://code.wireshark.org/review/21788 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-05-29packet-rsl.c: fixed emlpp priority bit rangePiotr Tulpan1-1/+1
Based on 3GPP TS 48.058 eMLPP Priority takes bits 1-3 not 1-2. There is also decalred value_string rsl_emlpp_prio_vals (line 2605) that contains 8 values not 4 as expected for 1-2 bits. Change-Id: Iea77f8dbff9af3b25fd298f1a9703c1e34c06d30 Reviewed-on: https://code.wireshark.org/review/21797 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-12-18RTP: RTP dissector is able to decode RTP over TCP (RFC 4571)Jiri Novak1-1/+1
Bug: 13251 Change-Id: I56a01e779f7f0eadc8a078f88543269a91148f00 Reviewed-on: https://code.wireshark.org/review/19293 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-25packet-rsl: Add some extensions to RSL shared by Osmocom + EricssonHarald Welte1-1/+7
Activation of (dynamic) PDCH uses some slight extensions of the definitions found in 3GPP TS 48.058 when used on Ericsson RBS2000 or Osmocom OsmoBTS. The extensions are backwards-compatible, so I don't think it's worth to introduce a preference for this. Change-Id: I8e28d75bd8be15044a605ced8825b9b074ffbb22 Reviewed-on: https://code.wireshark.org/review/18457 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-09-28proto_tree_add_item_ret_(u)int/proto_tree_add_bitmask_with_flags_ret_uint64: ↵Pascal Quantin1-1/+0
return real value Apply mask and bit shift on the returned value. Change-Id: I00aebc854756f01a25199a259d6d5252abea4349 Reviewed-on: https://code.wireshark.org/review/17958 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-09packet-rsl: Track RTP pt and codec for rslDaniel Willmann1-5/+43
Save the RTP payload type and codec and add a dynamic payload. This allows AMR streams to be correctly analyzed. Together with the AMR codec support you can listen to the AMR stream as well. Sponsored-by: On-Waves ehf Change-Id: If859fd3707b5aa1c9743830f903abe8e1f12ff95 Reviewed-on: https://code.wireshark.org/review/16352 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-20Manually add protocol dependencies derived from find_dissector.Michael Mann1-5/+5
Started by grepping call_dissector_with_data, call_dissector_only and call_dissector and traced the handles passed into them to a find_dissector within the dissector. Then replaced find_dissector with find_dissector_add_dependency and added the protocol id from the dissector. "data" dissector was not considered to be a dependency. Change-Id: I15d0d77301306587ef8e7af5876e74231816890d Reviewed-on: https://code.wireshark.org/review/14509 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-19rsl: avoid buffer overreadPeter Wu1-1/+1
Fixes a buffer overrun in dissct_rsl_ipaccess_msg when the tag is exactly 0xff: tag = tvb_get_guint8(tvb, offset); tdef = &rsl_att_tlvdef.def[tag]; Bug: 11829 Change-Id: I25a3c6948242a52f59431ce84c108b2e52008930 Reviewed-on: https://code.wireshark.org/review/14011 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris1-2/+2
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-13Use result of register_dissectorPeter Wu1-4/+2
Assign result of `register_dissector(..., func, proto)` to FOO_handle and remove `FOO_handle = create_dissector_handle(func, proto)`. Found by looking for files named packet-FOO.c having the above create_dissector_handle pattern. Some files (with different dissect routines for the two functions) remain unchanged. Change-Id: Ifbed8202c6dbc63a1dae9acc03313980ffbbbb90 Reviewed-on: https://code.wireshark.org/review/13247 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-08Fix a lot of typos and misspellingsmoshekaplan1-1/+1
Change-Id: I8512cfa1d424f82a873a0e0e1d22c7b075fdd7f3 Reviewed-on: https://code.wireshark.org/review/13069 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-12[RSL] Just return rest of packet if TLV type is unknownMichael Mann1-2/+1
Bug: 11829 Change-Id: Id31ec9ee970c3a1e1fe64e3bf823f9ab78f7cd9e Reviewed-on: https://code.wireshark.org/review/12558 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_create_dissector_handle -> create_dissector_handle for dissector directory.Michael Mann1-1/+1
Some of the ASN.1 dissectors still generate a new_create_dissector_handle from the tool itself, so leave those for now. Change-Id: Ic6e5803b1444d7ac24070949f5fd557909a5641f Reviewed-on: https://code.wireshark.org/review/12484 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-06-22Fix typo caused assertionMichal Labedzki1-1/+1
Invalid character ')' in filter name 'gsm_abis_rsl.llsdu.sacch)' ** ERROR:wireshark/epan/wmem/wmem_core.c:50:wmem_alloc: assertion failed: (allocator->in_scope) Aborted Change-Id: Ie22035cf9a9d1d29354a64cd5b085f1c2e18b1d3 Reviewed-on: https://code.wireshark.org/review/9017 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-06-22Eliminate proto_tree_add_text from some dissectors.Michael Mann1-19/+59
Change-Id: I979990e9385182870ce4809a7e6fa16e598cb2be Reviewed-on: https://code.wireshark.org/review/9016 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-30Cleanup:Bill Meier1-238/+236
Including: tvb_length...() ==> tvb_reported_length...() Remove some dead initializers; Localize some variables; Whitespace. Change-Id: Ide9490f248d558bb7e3af96a1fc17d8f911de4ef Reviewed-on: https://code.wireshark.org/review/6862 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-01-25pana, gsm_abis_oml, rsl, netrom: Remove 'if (tree)'Bill Meier1-1/+1
Thou shalt call col_...() and/or a dissector under 'if(tree)' Change-Id: Ibe62bc8229cb759d5f8b092aa7143d8e2f799037 Reviewed-on: https://code.wireshark.org/review/6781 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-07-06convert to proto_tree_add_subtree[_format]Michael Mann1-144/+56
Change-Id: Ia2567695ffed30c990eda3740b08bfab101cea96 Reviewed-on: https://code.wireshark.org/review/2883 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-56/+56
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-56/+56
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-7/+7
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-05-28Minor: use VALS macro (as per convention); Add editor modelines; Do ↵Bill Meier1-6/+19
whitespace changes. Change-Id: I6007c1b2098d06e4a892474dd07f06a7538f94ef Reviewed-on: https://code.wireshark.org/review/1843 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-14Fix [-Wmissing-prototypes]Jakub Zawadzki1-2/+1
svn path=/trunk/; revision=54095
2013-12-13Fix [-Wmissing-prototypes]Anders Broman1-1/+0
svn path=/trunk/; revision=54025
2013-12-12- Make local functions static.Anders Broman1-0/+3
- Forward declaration of register functions. svn path=/trunk/; revision=53958
2013-10-23#if 0 numerous "unused const variables" (mostly value-string-arrays);Bill Meier1-0/+2
Also; fix a few "set but not used" warnings. svn path=/trunk/; revision=52780
2013-07-15Fix warnings: comma at end of enumerator list.Chris Maynard1-1/+1
svn path=/trunk/; revision=50640
2013-01-31Fix dissection of SI6 when carried in a SACCH Info Modify messagePascal Quantin1-19/+25
Issue reported by damker: http://www.wireshark.org/lists/wireshark-users/201301/msg00067.html svn path=/trunk/; revision=47401
2012-12-20Try to determine wether it is MEAS REP, EXT MEAS REP or ENH MEAS REP.Anders Broman1-2/+9
svn path=/trunk/; revision=46630
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-1/+1
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-08-23Fix incorrect value (typo) in value-string array.Bill Meier1-1/+1
svn path=/trunk/; revision=44639
2012-07-31Follow-up of r44162: A-bis interface is not the same thing as A interface; ↵Pascal Quantin1-89/+89
update filters and protocol names accordingly svn path=/trunk/; revision=44172
2012-07-31Updated GSM dissectors display filters per checkfiltername.plMichael Mann1-89/+89
Tried to provide consistency with GSM dissector (protocol) names, even if the filenames now don't match the dissector name. svn path=/trunk/; revision=44162
2012-07-22Update display filter names per Bug 2794. Part 1 of many.Michael Mann1-1/+1
svn path=/trunk/; revision=43907
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-05-10Use the defines in IE value_stringAnders Broman1-85/+85
svn path=/trunk/; revision=42541
2012-05-07General minor cleanup including:Bill Meier1-625/+625
- remove unneeded #includes; - use val_to_str_const() as appropriate; - reformat hf[] entries; - reformat long lines; - use #if 0/#endif to coment out code instead of /* ... */; - remove boilerplate comments; - whitespace & indentation svn path=/trunk/; revision=42487
2012-05-07Use defines in value_string values.Anders Broman1-64/+76
svn path=/trunk/; revision=42461
2012-05-04value_string_ext: Reorder entries in value_string arrays to get Binary ↵Jakub Zawadzki1-3/+3
Search instead of Linear Search. svn path=/trunk/; revision=42418
2012-03-10Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-13/+8
svn path=/trunk/; revision=41470
2012-02-05From Harald Welte:Anders Broman1-6/+513
This is an enhancement for the existing A-bis RSL protocol dissector for GSM networks (as specified in Technical Specification 12.21 of the 3GPP). Basically, this patch adds ip.access vendor-specific RSL extensions. - Fixed the encoding argument to proto_add_item() - Do not default to ip.accsess RSL. - u_int8_t -> guint8 https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7549 svn path=/trunk/; revision=40850
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-28 08:59:41 +0000