aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-kafka.c
AgeCommit message (Collapse)AuthorFilesLines
2019-12-02kafka: don't use an empty tvb list.Dario Lombardo1-3/+2
Bug: 16242 Change-Id: I1a7cfa504d46cab681c7803227102cafcda519fa Reviewed-on: https://code.wireshark.org/review/35277 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-10-27Add more checks, fail for negative byte block lengths.Guy Harris1-19/+50
Have dissect_kafka_string_new() set a flag if the length was negative. If the length is negative, don't try to process what comes afterwards. Make the length argument to decompression routines unsigned, and do various checks. Don't try to decompress a zero-length block, and quit if the decompressed block is zero-length. Bug: 16082 Change-Id: I34c2ea99aa096b3f5724d9b113171b105bd6c60b Reviewed-on: https://code.wireshark.org/review/34867 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-10-18Kafka: Fix a length check.Gerald Combs1-1/+1
Skip past our chunk size before checking our available length. Bug: 16117 Change-Id: I39ddf1f6861de3b3adea59df2f30abfe3a4f7295 Reviewed-on: https://code.wireshark.org/review/34795 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-09Kafka: Fix Dead StoreAlexis La Goutte1-1/+1
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I013c1bdc943033550f497b1be0dfc7979ca49517 Reviewed-on: https://code.wireshark.org/review/34484 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-09Kafka: Fix Dead StoreAlexis La Goutte1-5/+5
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I3ac2e2b6a1ed7621f65f1a98e8b7b3704e8b299d Reviewed-on: https://code.wireshark.org/review/34481 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-05kafka: Cleanup to use "native" APIs.Michael Mann1-143/+65
Add "native" support for the "zig-zag" version of a varint in proto.[ch] and tvbuff.[ch]. Convert the use of varint in the KAFKA dissector to use the (new) "native" API. Ping-Bug: 15988 Change-Id: Ia83569203877df8c780f4f182916ed6327d0ec6c Reviewed-on: https://code.wireshark.org/review/34386 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-27Kafka: fixed OffsetForLeaderEpoch dissectionPiotr Smolinski1-132/+155
Bug: 16023 Change-Id: I78e1354ac5509707c818d7968c7067583fb469ba Reviewed-on: https://code.wireshark.org/review/34379 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2019-08-27kafka: remove unused hf/ei entries.Dario Lombardo1-15/+0
Change-Id: I98a3a1456fbfeb726a1a81a0b46714556fe951cd Reviewed-on: https://code.wireshark.org/review/34383 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20Kafka: include zstd compression in Kafka message batchesPiotr Smolinski1-0/+42
Change-Id: I1d06486ccf7b174ee9aa621fa3d8acb8b3673777 Reviewed-on: https://code.wireshark.org/review/34222 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20Kafka: fix the name shadowingPiotr Smolinski1-4/+8
Post-merge fix. Change-Id: I712d275f90c5a1e425865654143ead7c3a04998b Reviewed-on: https://code.wireshark.org/review/34332 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-20Kafka: add support for Kafka 2.3+ dissectionPiotr Smolinski1-516/+5318
Existing Apache Kafka support in Wireshark ends at version 0.10. The version 0.11 (June 2017) brought significant changes to the message format. This change makes the Wireshark Kafka dissector obsolete. The recently released Kafka 2.3 has a lot of additions to the wire protocol, which should be also addressed. Major changes: * Applied Kafka protocol changes since 0.10 * Zstd-packed message decompression (since Kafka 2.1) * Added support for Kafka over TLS decryption Bug: 15988 Change-Id: I2bba2cfefa884638b6d4d6f32ce7d016cbba0e28 Reviewed-on: https://code.wireshark.org/review/34224 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs1-7/+7
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-01Apply port preferences during dissector handoff registrationJaap Keuter1-0/+1
Handling of preferences is often done in the dissector handoff registration. Therefore this function is often registered as callback while registering preference handling for the module. In this way the preferences are processed both when registering the dissector and when changes happen. Some dissectors opt to register a seperate callback function to be called when preferences change. Now these have to be called from the dissector handoff function explicitly, in order to have the preferences processed during dissector registration. This becomes explicitly apparent when the port registration comes into play. With the migration to using dissector registration on ports with preference this port (range) is often retrieved from the preferences to match against the ports in a packet to determine an incoming or outgoing packet of a server. In case the callback function is not called from the dissector registration this determination fails, until the preferences are applied/changed, causing the preference handling callback to be called. This change add the calling of the callback during dissector registration, fixing some dissector port registrations in the process. Change-Id: Ieaea7f63f8f9062c56582a042a3a5a862e286406 Signed-off-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-on: https://code.wireshark.org/review/30848 Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-01kafka: fix builds without Snappy or LZ4 supportDario Lombardo1-8/+8
Avoid passing an uninitialized "raw" pointer to "proto_tree_add_item". Change-Id: Ic7d3542b4aa5650f452aad7ac3b783769cb44eb7 Reviewed-on: https://code.wireshark.org/review/28922 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-08-01Kafka: add info when we lack decompression supportTim Cuthbertson1-2/+8
Change-Id: I4c1b5d84bd1a6dfa811fd8ffbd576ac8dfd448af Reviewed-on: https://code.wireshark.org/review/28749 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-21Kafka: add support for additional Produce, Fetch, OffsetCommit and Heartbeat ↵Tim Cuthbertson1-4/+106
API versions Change-Id: I5bd41ed299e586b953042683acf2f05c678a7e93 Reviewed-on: https://code.wireshark.org/review/28748 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Evan Huus <eapache@gmail.com>
2018-04-15Check for HAVE_LZ4FRAME_H in the LZ4 detection process and use itJoerg Mayer1-8/+5
Change-Id: I919621b8c4c809eb181d563251eeb099b767ad82 Reviewed-on: https://code.wireshark.org/review/26940 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Jörg Mayer <jmayer@loplof.de> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-13kafka: raise the required version to 1.5.0 for lz4_frame.Dario Lombardo1-3/+3
Change-Id: I25619260572163872915c56bcf242e8ff8190b47 Reviewed-on: https://code.wireshark.org/review/26890 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Tested-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-04-11kafka: check lz4 version in a single point.Dario Lombardo1-4/+5
This allows a better check of the required version. Change-Id: I6c4aab67c73434aff4ad744caa2d0add9ec6225c Reviewed-on: https://code.wireshark.org/review/26889 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-08Fix typo: Heatbeat --> HeartbeatJeff Widman1-1/+1
Change-Id: I864850b29f9c816a4d1592cd5bba2b9d0159b139 Reviewed-on: https://code.wireshark.org/review/24289 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-05Fix unitialized variable warnings that popped up with -OgJoão Valverde1-1/+1
Using GCC version 7.1.1. Change-Id: I7447a48fc97efb1eb15a016a29165f69d37f40a6 Reviewed-on: https://code.wireshark.org/review/23399 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2017-05-16[Kafka] The inclusion of LZ4 broke building on Ubuntu 14.04, since it has ↵AndersBroman1-4/+7
lz4-r114. But the lz4 frame API was introduced in [r123](https://github.com/lz4/lz4/blob/r123/lz4frame.h). Put the code behind a lz4 version check. Change-Id: If8a7e5f7f2e7c9beac89eec334368a5b95a1bc3f Reviewed-on: https://code.wireshark.org/review/21684 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-05-16kafka: fix -Wmissing-field-initializers by removing unneeded codePeter Wu1-3/+1
LZ4F_decompress accepts a NULL parameter to apply default parameters, do not bother setting a parameter (this also avoids -Wmissing-field-initializers warnings from clang). Change-Id: Id2cd8d58cd9339dd5af395092a8104b559b6e194 Reviewed-on: https://code.wireshark.org/review/21675 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-15Explicitly initialize the current only member of dec_opts.Guy Harris1-1/+2
At least some compilers will warn about not initializing the reserved values. Change-Id: Id907468be757a1cd3137140d285803f3e9f1724a Reviewed-on: https://code.wireshark.org/review/21674 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-05-13Kafka: add LZ4 decompressionPascal Quantin1-1/+211
Change-Id: Idf2f63782c8751778ad88f46a7f65fe7d5d49f3b Reviewed-on: https://code.wireshark.org/review/21577 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-07Fix kafka build error by castingMartin Mathieson1-2/+2
Change-Id: I34a5f60c49d09a8cec4a2c9ab49ea48ef67527cd Reviewed-on: https://code.wireshark.org/review/21540 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2017-05-07Kafka: show decompressed messages more clearlyMartin Mathieson1-13/+58
Change-Id: I8edf251d9ab26f93bf54d8032706ac7b9e4f6dd1 Reviewed-on: https://code.wireshark.org/review/21538 Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2017-03-19dissector: fix typo reponse -> responseAlexis La Goutte1-1/+1
Change-Id: I5d12b7038c0ed602cd5b3b416c35893986018f85 Reviewed-on: https://code.wireshark.org/review/20626 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-07Convert range API to always use wmem memory.Michael Mann1-1/+0
This is mostly to address memory leaks in range preferences (the biggest user of range functionality) on shutdown. Now range preferences must use epan scoped memory when referencing internal preference structures to keep consistency. Change-Id: Idc644f59b5b42fa1d46891542b53ff13ea754157 Reviewed-on: https://code.wireshark.org/review/19387 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-20Cast larger types to time_tYour Name1-1/+1
Resolves truncation warnings on the x86 clang build Change-Id: I14ebbe39b8235bd1b909c488c0402b77deb6dde1 Reviewed-on: https://code.wireshark.org/review/19354 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-17kafka: add expert info about unsupported api key and versionDmitry Lazurkin1-42/+186
Change-Id: I622e6f06529377e089cbeeb83d926135f983d3f3 Reviewed-on: https://code.wireshark.org/review/19194 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-12-10Add a preference to control whether string and byte lengths appear in ↵Martin Mathieson1-14/+39
protocol tree Change-Id: I6be13d9adb8871cbbf4604155e8e7175a74ddaa3 Reviewed-on: https://code.wireshark.org/review/19188 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dmitry Lazurkin <dilaz03@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-12-05kafka: add dissection for rest of api keysDmitry Lazurkin1-129/+2061
- support rest of api keys - dissect kafka.required_acks with constants - dissect kafka.message_timestamp_type - add expert info about missing request Change-Id: I3d18936adac6702a61f545385bdec1b75b564bd9 Reviewed-on: https://code.wireshark.org/review/18954 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-11-22Add prefs_get_uint_value and prefs_get_range_valueMichael Mann1-4/+2
This allows dissectors to not need to know about the internal preference structure. Change-Id: I1ae67248cd0b0132aefc225ea0a9befaf9afdde2 Reviewed-on: https://code.wireshark.org/review/18864 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-21Kafka: show API versions in root, and don't show bogus size for GZIP messages.Martin Mathieson1-5/+21
Change-Id: Ib8182537a791ed24bcc417594713dd6c206ce0ce Reviewed-on: https://code.wireshark.org/review/18885 Reviewed-by: Dmitry Lazurkin <dilaz03@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-11-20kafka: fix mac build breakage by adding int castMartin Mathieson1-1/+1
Change-Id: Ic57d49f7408f041b60b719a3da4971c499122930 Reviewed-on: https://code.wireshark.org/review/18888 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-11-19kafka: Update supported api keys to latest specDmitry Lazurkin1-132/+360
Details: - update supported api keys - add api key ApiVersions - change api key names according to documentation - add pcapng files for supported api keys - add new documentation link - add declaration of lz4 message codec Change-Id: I943dc31144890dcd3dd333981a86754668c2bec4 Reviewed-on: https://code.wireshark.org/review/18861 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-10-19Kafka: add Snappy decompression supportPascal Quantin1-2/+67
Change-Id: Ida8d941809a4e0f2fd4d9f142363187a757d0278 Reviewed-on: https://code.wireshark.org/review/18288 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-10-08Combine Decode As and port preferences for tcp.port dissector table.Michael Mann1-27/+14
This patch introduces new APIs to allow dissectors to have a preference for a (TCP) port, but the underlying data is actually part of Decode As functionality. For now the APIs are intentionally separate from the regular APIs that register a dissector within a dissector table. It may be possible to eventually combine the two so that all dissectors that register with a dissector table have an opportunity to "automatically" have a preference to adjust the "table value" through the preferences dialog. The tcp.port dissector table was used as the guinea pig. This will eventually be expanded to other dissector tables as well (most notably UDP ports). Some dissectors that "shared" a TCP/UDP port preference were also converted. It also removed the need for some preference callback functions (mostly when the callback function was the proto_reg_handoff function) so there is cleanup around that. Dissectors that has a port preference whose default was 0 were switched to using the dissector_add_for_decode_as_with_preference API rather than dissector_add_uint_with_preference Also added comments for TCP ports used that aren't IANA registered. Change-Id: I99604f95d426ad345f4b494598d94178b886eb67 Reviewed-on: https://code.wireshark.org/review/17724 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-04kafka: remove unused assignment.Dario Lombardo1-6/+0
Found by valgrind: ==21035== 12 bytes in 1 blocks are definitely lost in loss record 279 of 2,696 ==21035== at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==21035== by 0xAAA2728: g_malloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.1) ==21035== by 0x72A361F: range_convert_str_work.part.0 (range.c:109) ==21035== by 0x6AACBEC: proto_register_kafka (packet-kafka.c:1459) ==21035== by 0x71BA055: register_all_protocols (register.c:2769) ==21035== by 0x7296E67: proto_init (proto.c:529) ==21035== by 0x7272A76: epan_init (epan.c:128) ==21035== by 0x1160F2: main (tshark.c:804) ==21035== Change-Id: I3249925acd3ed26d40be992fd228447d1b381b66 Reviewed-on: https://code.wireshark.org/review/16880 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2016-06-08Kafka: pass api_version to response and start to use itMartin Mathieson1-8/+47
Change-Id: Idc43e37d113e5b598cd5b1a8875ede335f9534de Reviewed-on: https://code.wireshark.org/review/15776 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2016-06-06Kafka: add more error codesMartin Mathieson1-0/+19
Change-Id: Idcbe44bfe0730e42a30107414a7912a6aa50f411 Reviewed-on: https://code.wireshark.org/review/15757 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-04-20Kafka: several minor improvementsMartin Mathieson1-87/+233
Use a range preference for TCP ports rather than single value. Show interesting values in tree roots and/or the Info column. Use common functions to dissect some protocol fields. Change-Id: I9f5ca2565f47fc84d9c82a31511fae813542482e Reviewed-on: https://code.wireshark.org/review/14949 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-01-25Move the proto data stuff out of frame_data.[ch].Guy Harris1-0/+1
It's not tied to the frame_data structure any more, so it belongs by itself. Clean up some #includes while we're at it; in particular, frame_data.h doesn't use anything related to tvbuffs, so don't have it gratuitiously include tvbuff.h. Change-Id: Ic32922d4a3840bac47007c5d4c546b8842245e0c Reviewed-on: https://code.wireshark.org/review/13518 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris1-3/+3
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-09new_create_dissector_handle -> create_dissector_handle for dissector directory.Michael Mann1-1/+1
Some of the ASN.1 dissectors still generate a new_create_dissector_handle from the tool itself, so leave those for now. Change-Id: Ic6e5803b1444d7ac24070949f5fd557909a5641f Reviewed-on: https://code.wireshark.org/review/12484 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-03-05kafka: misc minor tweaksEvan Huus1-7/+7
Use the new request/response framenum hints. Replace some deprecated APIs. Change-Id: Ia58c49da7e12d01477dadfc7f5a42b152730dc71 Reviewed-on: https://code.wireshark.org/review/7547 Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-01-30kafka: fill in some expert infoEvan Huus1-9/+16
Change-Id: I94e655fc56fd1534d57f6917d9e5f4189e08838a Reviewed-on: https://code.wireshark.org/review/6858 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-23 07:31:29 +0000