diff options
| author | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2019-09-08 18:48:01 +0000 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2019-09-09 04:31:57 +0000 |
| commit | 3ebf2e2d51576eac21363b25af47396f893c9294 (patch) | |
| tree | 51c8b67d7b93ecaf101c9887fc88c385f445fafe /epan/dissectors/packet-kafka.c | |
| parent | de4efb6af781969cd8fd9d5ca4815f20ce0674ed (diff) | |
Kafka: Fix Dead Store
Fix dead store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I3ac2e2b6a1ed7621f65f1a98e8b7b3704e8b299d
Reviewed-on: https://code.wireshark.org/review/34481
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-kafka.c')
| -rw-r--r-- | epan/dissectors/packet-kafka.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/epan/dissectors/packet-kafka.c b/epan/dissectors/packet-kafka.c index e250b2205d..1f1260be66 100644 --- a/epan/dissectors/packet-kafka.c +++ b/epan/dissectors/packet-kafka.c @@ -1079,10 +1079,10 @@ dissect_kafka_string_new(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree pi = proto_tree_add_item(tree, hf_item, tvb, offset+len, (gint)val, ENC_NA | ENC_UTF_8); } else if (val == 0) { // there is empty payload (0 octets) - pi = proto_tree_add_string_format_value(tree, hf_item, tvb, offset+len, 0, NULL, "<EMPTY>"); + proto_tree_add_string_format_value(tree, hf_item, tvb, offset+len, 0, NULL, "<EMPTY>"); } else if (val == -1) { // there is no payload (null) - pi = proto_tree_add_string_format_value(tree, hf_item, tvb, offset+len, 0, NULL, "<NULL>"); + proto_tree_add_string_format_value(tree, hf_item, tvb, offset+len, 0, NULL, "<NULL>"); val = 0; } else { pi = proto_tree_add_string_format_value(tree, hf_item, tvb, offset+len, 0, NULL, "<INVALID>"); @@ -1134,13 +1134,13 @@ dissect_kafka_bytes_new(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tree, val = 0; } else if (val > 0) { // there is payload available, possibly with 0 octets - pi = proto_tree_add_item(tree, hf_item, tvb, offset+len, (gint)val, ENC_NA); + proto_tree_add_item(tree, hf_item, tvb, offset+len, (gint)val, ENC_NA); } else if (val == 0) { // there is empty payload (0 octets) - pi = proto_tree_add_bytes_format_value(tree, hf_item, tvb, offset+len, 0, NULL, "<EMPTY>"); + proto_tree_add_bytes_format_value(tree, hf_item, tvb, offset+len, 0, NULL, "<EMPTY>"); } else if (val == -1) { // there is no payload (null) - pi = proto_tree_add_bytes_format_value(tree, hf_item, tvb, offset+len, 0, NULL, "<NULL>"); + proto_tree_add_bytes_format_value(tree, hf_item, tvb, offset+len, 0, NULL, "<NULL>"); val = 0; } else { pi = proto_tree_add_bytes_format_value(tree, hf_item, tvb, offset+len, 0, NULL, "<INVALID>"); |