aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gsm_a_common.c
AgeCommit message (Collapse)AuthorFilesLines
2016-12-16Remove proto_item_append_text calls in favor of BASE_UNIT_STRING.Michael Mann1-14/+8
Many proto_item_append_text calls were just adding a unit string to a field. There's a better way to do that now. Change-Id: Id18d5ac1ea4d8ecdc4cbe7ebaec07fbd2eab6e78 Reviewed-on: https://code.wireshark.org/review/19289 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-08GSM A: allow a length of 3 bytes when using the 'no identity' typePascal Quantin1-1/+1
As stated in 3GPP 24.008 §10.5.1.4, for GMM and EMM procedures the length should be set to 3 when using the 'no identity' type. Change-Id: Ib2d5930416b0d26853f4cc430df0ce2f29488877 Reviewed-on: https://code.wireshark.org/review/18707 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-02GSM MAP: Add OSM URI for locationEstimateUli Heilmeier1-3/+20
As requested by bug 10969 add a link to OSM for locationEstimate. Bug: 10969 Change-Id: I715b3b5eae9728999d5c8f8c155bbcef3911ee93 Reviewed-on: https://code.wireshark.org/review/17375 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-07-14packet-gsm_a_common.c: Create typedef declaration for elem_func signature.Michael Mann1-9/+11
This should keep VS Code Analysis happy. Change-Id: I99ebdc644ba353d5986d6509da784eeaa37dcc8f Reviewed-on: https://code.wireshark.org/review/16420 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-16qt: move free_stat_tables from SimpleStatisticsDialog::fillTree to ↵Dario Lombardo1-10/+20
~SimpleStatisticsDialog. Add a reference count to stat_tap_table_ui to prevent bad deallocations. Bug: 12437 Change-Id: Ib9b1f929d08a574c306dc755ec416ab94a3fd6d3 Reviewed-on: https://code.wireshark.org/review/15920 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-04-15GSM: add a sanity checkPascal Quantin1-0/+3
Like the one added in gcfc47c1 Change-Id: Ieb6aaa406ad141502980d4447d5ee9f03044acbe Reviewed-on: https://code.wireshark.org/review/14930 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-12-29Rename new_stat_tap_ui to stat_tap_table_ui.Guy Harris1-31/+31
A "new" statistics tap UI is a statistics tap UI where the statistics are maintained as tables and common code handles the tables; what matters is the tables, not that it's "new". Change-Id: I7a0e63cfac98c24cd5e7dce973b9a0cc5b6a03ba Reviewed-on: https://code.wireshark.org/review/12897 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-29There's no "old" stat_tap_table, so remove "new_" from the name.Guy Harris1-5/+5
Change-Id: I1a0349d5d9d47210a97ff7a99fb358e59fd70e72 Reviewed-on: https://code.wireshark.org/review/12896 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-07Spelling fixes for errors found by lintianBalint Reczey1-1/+1
Change-Id: I889283902875193f4d3f3fd59788f59f8d9bcc20 Reviewed-on: https://code.wireshark.org/review/11945 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-29Fix bugs introduced in gcfc47c1Pascal Quantin1-2/+1
Bug: 11797 Change-Id: I2574e19aa2b86f7c72370d98dd6a2b72b471da25 Reviewed-on: https://code.wireshark.org/review/12280 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-29Replace my_dgt_tbcd_unpack with the safer tvb_bcd_dig_to_wmem_packet_str.Michael Mann1-58/+6
Bug: 11797 Change-Id: I07fdf3f7564424eac053f4c17de17f0d96597cca Reviewed-on: https://code.wireshark.org/review/12239 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-04Don't include "file.h" if you don't need it.Guy Harris1-0/+1
It ends up dragging in libwireshark headers, which programs not linking with libwireshark shouldn't do. In particular, including <epan/address.h> causes some functions that refer to libwireshark functions to be defined if the compiler doesn't handle "static inline" the way GCC does, and you end up requiring libwireshark even though you shouldn't require it. Move plurality() to wsutil/str_util.h, so that non-libwireshark code can get it without include epan/packet.h. Fix includes as necessary. Change-Id: Ie4819719da4c2b349f61445112aa419e99b977d3 Reviewed-on: https://code.wireshark.org/review/11545 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-08-10GSM (a_common): fix indent (replace tab by 8 spaces)Alexis La Goutte1-142/+142
Change-Id: Id1d6bfcb04ac75d767fe6f09454dc8235de7bc75 Reviewed-on: https://code.wireshark.org/review/9928 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-08-08GSM (a_common): fix no previous prototype for 'gsm_a_*_init' ↵Alexis La Goutte1-11/+11
[-Wmissing-prototypes] Change-Id: I2990cb3432ad377cbed7039ad8fe15019eb7e7f5 Reviewed-on: https://code.wireshark.org/review/9927 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-08-08GSM (a_common): fix comma at end of enumerator list [-Wpedantic]Alexis La Goutte1-1/+1
Change-Id: I0ea06451861412b642d033a70e0a639aae753beb Reviewed-on: https://code.wireshark.org/review/9926 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-08-06Fixup stat_tap table freeing.Gerald Combs1-4/+16
As it turns out we *do* need to free table elements. We also need to free the tables themselves and clear the table array. Do so. Change-Id: Ic1c81388eac8f47f74caea0169c79685a83aaff9 Reviewed-on: https://code.wireshark.org/review/9901 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-08-04Convert the GSM A stats to new "generic stat API".Gerald Combs1-0/+363
These are largely untested, but the two abis captures on the wiki seem to work OK. The menu item names could also use some work. Patches welcome. Change-Id: I19a5b5fe3476b49d1dd0b684cbb7f367c6ebd4b4 Reviewed-on: https://code.wireshark.org/review/9869 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-07-013GPP NAS: upgrade dissector to v12.10.0Pascal Quantin1-1/+14
Change-Id: Ia89e49d098f86450245c73c4d06a4359a25e3d53 Reviewed-on: https://code.wireshark.org/review/9444 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-13GSM A: force display of the bits sequence corresponding to "Degrees of ↵Pascal Quantin1-1/+1
longitude" field It makes the display more consistent with other fields of Location Estimate IE Bug: 11114 Change-Id: Ib31c61a34f419cf97601a660f3b807454b1becd9 Reviewed-on: https://code.wireshark.org/review/8049 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-04GSM: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-2/+0
Change-Id: If10a9902c231b87995562fd0c687a25dcab3e250 Reviewed-on: https://code.wireshark.org/review/7910 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-033GPP NAS: upgrade dissector to v12.9.0Pascal Quantin1-1/+14
Change-Id: I6bffe7b5b95d72031df5aecac66129d2ceff517e Reviewed-on: https://code.wireshark.org/review/7889 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-033GPP NAS: display Short Element Identifier as it was done prior to ge74cb41Pascal Quantin1-1/+1
Change-Id: Ie001b420eb1fd29c8f5c941e69f4e2929250d887 Reviewed-on: https://code.wireshark.org/review/7885 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-01Remove proto_tree_add_text from GSM dissectors.Michael Mann1-135/+103
Change-Id: I72a7c1a44bda7755d8b1376dd5e57c46f137ff31 Reviewed-on: https://code.wireshark.org/review/7870 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-14[E212]Modify dissect_e212_mcc_mnc() to take E212 number type as anAndersBroman1-2/+2
argument. While at it remove deprecated APIs Change-Id: Ib1a7e9d7aeba6379fb4492816a0ac602e67493c6 Reviewed-on: https://code.wireshark.org/review/6534 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-02Replace proto_tree_add_text in dissector header files where it was used in a ↵Michael Mann1-18/+20
macro that should be expert info. Change-Id: I045368a0a91586231fc4b1e2700c2275088b76af Reviewed-on: https://code.wireshark.org/review/6244 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-23Deleting unneccessary #includes from dissectors.Martin Mathieson1-2/+0
Second batch (packet-eth.c -> packet-icmpv6.d). Will look at cleaning up and committing script afterwards. Change-Id: I14295758b81a59115d8c88899f166cc3d5d17594 Reviewed-on: https://code.wireshark.org/review/6013 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-4/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-043GPP: upgrade 2G/3G NAS dissector to v12.7.0 and NAS EPS dissector to v12.6.0Pascal Quantin1-3/+57
Change-Id: I1e5bc5d28cb956b333c302b1cb18335b59d096a8 Reviewed-on: https://code.wireshark.org/review/5621 Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-11-26Remove sccp_info member from packet_info structure.Michael Mann1-1/+0
sccp_msg_info_t* is now passed from SCCP dissector to its subdissectors through dissector data parameter. Change-Id: Iab4aae58f8995e844f72e02e9f2de36e83589fc0 Reviewed-on: https://code.wireshark.org/review/5442 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-29Add editor modelines; fix indentation as needed.Bill Meier1-0/+12
Change-Id: I1ad94654343e5a018a0b3159481d45ffb3a91263 Reviewed-on: https://code.wireshark.org/review/4363 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-08-19Use dissect_e212_imsi() to dissect IMSIAndersBroman1-23/+19
fix offset in dissect_e212_mcc_mnc_in_address(). Change-Id: I68006ea3e2c79e2549e6f2d2c8a997e44fc3cdf1 Reviewed-on: https://code.wireshark.org/review/3722 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-29convert to proto_tree_add_subtree[_format]Michael Mann1-79/+67
Change-Id: If110de1e0555637264f86f1508858d569871a9c7 Reviewed-on: https://code.wireshark.org/review/2675 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-02-23Fix dissection of BCD numbersPascal Quantin1-5/+3
Do not use of tvb_get_string(): what we really want is the byte string, not an ASCII string Change-Id: I8b9a8b7ccacbdaf6d9525771ff8ed883ba01ad34 Reviewed-on: https://code.wireshark.org/review/329 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2013-12-18Add a sixteenth element to all BCD digit sets to avoid garbage values whenEvan Huus1-2/+2
decoding corrupt bytes. Some of these digit sets could probably be deduplicated... svn path=/trunk/; revision=54224
2013-12-15Fix [-Wmissing-prototypes]Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=54135
2013-12-13Fix (presumably) a VS Code analysis warning:Bill Meier1-45/+45
C6385: Invalid data: accessing 'dgt->out', the readable size is '15' bytes, but '18' bytes might be read Also: Do some trivial whitespace and formatting changes. svn path=/trunk/; revision=54048
2013-11-09Include <epan/to_str.h> only when needed.Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53189
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-1/+1
svn path=/trunk/; revision=52591
2013-09-22More emem -> wmem conversion:Pascal Quantin1-1/+1
- tvb_get_g_stringz()/tvb_get_ephemeral_stringz()/tvb_get_seasonal_stringz() -> tvb_get_stringz() - tvb_get_g_stringz_enc()/tvb_get_ephemeral_stringz_enc() -> tvb_get_stringz_enc() - tvb_get_ephemeral_unicode_stringz() -> tvb_get_unicode_stringz() - tvb_bcd_dig_to_ep_str() -> tvb_bcd_dig_to_wmem_packet_str() - update docs accordingly svn path=/trunk/; revision=52180
2013-09-22emem -> wmem conversion:Pascal Quantin1-1/+1
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-03Code cleanup:Pascal Quantin1-11/+16
- remove some useless trees - prettify the dissection of a few IEs - use ELEM_MAND_VV_SHORT macro where applicable svn path=/trunk/; revision=51741
2013-09-03Batch of filterable expert info.Michael Mann1-8/+19
svn path=/trunk/; revision=51689
2013-08-30Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9085 :Pascal Quantin1-1/+1
GSM A-I/F DTAP - Detach Request - Detach type is not displayed svn path=/trunk/; revision=51599
2013-08-30Convert a few dissectors from EMEM to WMEM APIPascal Quantin1-10/+11
svn path=/trunk/; revision=51597
2013-07-16Replace some tabs with spaces.Jeff Morriss1-7/+7
svn path=/trunk/; revision=50674
2013-07-16Fix the fuzz failure reported in ↵Jeff Morriss1-21/+70
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8940 : Test whether idx is in range or not (by seeing if it was found in the value_string) before using it as an index into any of the elem_var arrays. This fuzz failure was in elem_telv() but apply the fix to all the elem_*() functions. svn path=/trunk/; revision=50672
2013-07-10Upgrade NAS disssectors to v11.7.0Pascal Quantin1-1/+14
svn path=/trunk/; revision=50494
2013-03-28Properly dissect lat and long according to 3GPP TS 23.032. Fix incorrect ↵Chris Maynard1-15/+20
display filters for hf_gsm_a_geo_loc_deg_of_lat and hf_gsm_a_geo_loc_deg_of_long. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8532 #BACKPORT(1.6,1.8) svn path=/trunk/; revision=48613
2013-03-19Upgrade NAS disssectors to v11.6.0Pascal Quantin1-1/+45
svn path=/trunk/; revision=48427
2013-03-18Add a missing staticPascal Quantin1-1/+1
svn path=/trunk/; revision=48410
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-24 16:19:33 +0000