aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gsm_a_common.c
AgeCommit message (Collapse)AuthorFilesLines
2024-08-07Add a UNS() macro, similar to TFS().Guy Harris1-2/+2
As "TFS" stands for "true_false_string", "UNS" stands for "unit_name_string".
2024-08-06Dissectors: Include what we use.Anders Broman1-1/+4
2024-07-20convert-tvb_get_guintxAnders Broman1-18/+18
2024-07-16epan: convert dissectors G to C99 typesJoakim Karlsson1-189/+189
Ping #19116
2024-06-26Fix some spelling errorsMartin Mathieson1-1/+1
2024-05-31Change the Telephony stat groups names to reflect their current positionJohn Thacker1-10/+10
The telephony menu items were originally under Statistics, but were moved to a top level menu (5375b5f4762c2f7a6ca7aaefac77d955433efe79). Change the name to reflect that, which also changes the Lua names. For Lua, enable use of the older, deprecated names, because Lua scripts are used across versions without recompiling. Fix #17448
2024-05-22Use array_length instead of "sizeof arr / sizeof (TYPE)".Darius Davis1-24/+24
One increment in the process of converting manual array-length computations to the array_length macro. This change converts about 200 instances in a small number of files. Another (approx.) 170 instances remain, scattered throughout a larger number of separate files. Comparison of the built object files before and after this commit confirms that the only net effect of this change is in the .debug_line section, so this commit will not actually change any program behavior. This also helps assure that all the removed "(TYPE)" expressions did indeed correctly reflect the array type.
2024-04-05Remove init to zero for static variablesStig Bjørlykke1-1/+1
The C standard requires that objects with static storage duration is initialized to zero.
2024-01-31Fix more spellings - mostly commentsMartin Mathieson1-2/+2
2023-12-06Remove init of tap variablesStig Bjørlykke1-1/+1
A tap_id is never 0, so initializing tap variables to -1 is not necessary.
2023-11-20Remove init of proto variablesStig Bjørlykke1-218/+218
Remove init of proto, header field, expert info and subtree variables. This will reduces the binary size by approximate 1266320 bytes due to using .bss to zero-initialize the fields. The conversion is done using the tools/convert-proto-init.py script.
2023-11-18dissectors: Remove init of hf and ett variable arraysStig Bjørlykke1-1/+0
Manually remove init of hf and ett variable arrays because this cannot be easily done using the convert script.
2023-09-22Make tfs_true_false the default for booleansJoão Valverde1-34/+34
Instead of adding a TFS(&tfs_true_false) to every boolean field, make it the default if "strings" is NULL. This seems to match the already existing documentation: If the Boolean field is to be displayed as "False" or "True", the 'strings' field would be set to NULL.
2022-12-30gsm_common: Update geographical_descriptionJoakim Karlsson1-9/+54
2022-07-28gsm_a_common: Use common E212 MCC MNC functionJohn Thacker1-114/+7
Use the common functions to dissect the MCC and MNC from packet-e212.c Remove some now no longer used static functions, arrays, and fields.
2022-07-27gsm_a_common: Fix cut and paste errorJohn Thacker1-1/+1
The field description and filter for type of ciphering algorithm was copied from the previous field.
2022-06-10tap: Adding flags for tap_packetRoland Knall1-10/+10
This allows flags to be passed by the registering listener to the collection of information
2021-12-19Replace g_strdup_printf() with ws_strdup_printf()João Valverde1-1/+1
Use macros from inttypes.h.
2021-12-19Replace g_snprintf() with snprintf() (dissectors)João Valverde1-6/+6
Use macros from inttypes.h with format strings.
2021-10-06gsm_a: Fix dissect_description_of_velocity()Stig Bjørlykke1-33/+27
Several improvements to dissect_description_of_velocity() - Velocity Type is first 4 bits, do not increase offset after this - Direction of Vertical Speed is bit 7 - Only increase curr_offset in this function
2021-09-01tvbuff: convert helper methods to pinfo->poolEvan Huus1-2/+2
A few of them just needed scratch memory, so allocate and free it manually after doing any exception-raising checks. A few others were returning memory, and needed conversion to accept a wmem scope argument.
2021-07-21First pass pinfo->pool conversion, part 2Evan Huus1-20/+20
Automated find/replace of wmem_packet_scope() with pinfo->pool in all files where it didn't cause a build failure.
2021-06-09geographical-description: Fixes to the high accuracy dissection.Anders Broman1-16/+23
2021-05-28Geographical description, correct the bitmask.Anders Broman1-2/+2
2021-02-14Make some more variables and functions static.Martin Mathieson1-5/+5
2021-02-10gsm_a_common: free stat table itemsMartin Kaiser1-9/+9
The init functions of the gsm statistics tables call gsm_a_stat_init, which allocates some strings. We have to register gsm_a_stat_free_table_item to free these table items again. This is already done correctly for gsm_a_bssmap_stat_table. Fix it for the other tables.
2021-02-10gsm_a_common: create and populate the stats table only onceMartin Kaiser1-0/+8
Use the new stat_tap_find_table function during init to check if our statistics table already exists. If so, we can safely assume that its rows have already beend initialized. All we have to do is clear the data that was collected by the tap.
2021-01-14gsm_a_common: remove a variable that is always 0Martin Kaiser1-2/+1
All of the stat_tap_table_ui structs use a single table at offset 0.
2020-11-22Spelling improvementsMartin Mathieson1-1/+1
Improve script by ignoring common contractions, dealing with e.g. \n within strings, and finding multiple concatenated words even when no camelCase is used. Also includes some actual spelling fixes.
2020-11-18GSM A Common: Dissect polygon pointsAnders Broman1-20/+51
2020-10-31GSM A: Uncertainty speed is only 1 byte.Martin Mathieson1-3/+3
2020-10-143GPP: add 5G-TMSI to 3gpp.tmsi common filterPascal Quantin1-2/+2
2020-10-14Create a cross protocol filter 3gpp.tmsiAnders Broman1-6/+21
It can be useful to track a "call" trough multiple protocols to make that easier create a cross protocol filter, more may come.
2020-10-11check_tfs.py: Also match case insensitivelyMartin Mathieson1-44/+36
Fix up some issues where the words were the same except for captitalisation.
2020-10-03Fix more filter field strings.Martin Mathieson1-1/+1
These appear to be copy/paste errors detected by running ./tools/check_typed_item_calls.py --consecutive Quite a few issues still remain after this batch.
2020-09-07Yet more spelling fixes.Martin Mathieson1-10/+10
Includes small updates to the script and wireshark dictionary. Probably the last spelling fixes from me for a while.
2020-06-08GSM A Common: Advance offset after reading type_of_shape.Anders Broman1-1/+1
Change-Id: Ic72c679ccacd707129574d62d20719e35746a3bf Reviewed-on: https://code.wireshark.org/review/37401 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-06-04gsm_a_common: Fix Dead StoreAlexis La Goutte1-1/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ic4af292bf494355a78f75df7e00d3c06bfc6eb50 Reviewed-on: https://code.wireshark.org/review/37373 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-05-19gsm_common: Update geographical_descriptionAnders Broman1-4/+131
Change-Id: I53b24f55427af53b17233897a71cf5fd70131404 Reviewed-on: https://code.wireshark.org/review/37248 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-04-283GPP: Update Geographical Area Description (GAD).Anders Broman1-7/+13
Change-Id: I1ad8a4bd21ed590eae4d64b7a287256860e597ca Reviewed-on: https://code.wireshark.org/review/36963 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-22geographical_description: Don't mask Orientation of major axis octet 12Anders Broman1-2/+1
Change-Id: I7034cb6304bc7bab5f344b7438ffee6c5ea8844c Reviewed-on: https://code.wireshark.org/review/35897 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-21Diameter: Fix Location estimate.Anders Broman1-4/+4
- The AVP should be an OctetString - Orientation of major axis should not be multiplied by 2 according to the latest standard. Change-Id: I68532108cc36f4699c10b35ffdbcfaef0c29d9fe Reviewed-on: https://code.wireshark.org/review/35890 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-21GSM A DTAP: Try to ensure that global variable sccp_assoc is cleared.Anders Broman1-1/+1
Change-Id: I970e9314724c55c19d0b98578e54a5d1b598e307 Reviewed-on: https://code.wireshark.org/review/34336 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-06-20NAS 5GS: Framwork for dissecting UPDP messages.Anders Broman1-0/+6
Change-Id: Id08fe25cdf118e6912fa3f201dfd07bde5ebdaf9 Reviewed-on: https://code.wireshark.org/review/33679 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs1-2/+2
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-01Add a "failed" return for tap packet routines.Guy Harris1-15/+15
This allows taps that can fail to report an error and fail; a failed tap's packet routine won't be called again, so they don't have to keep track of whether they've failed themselves. We make the return value from the packet routine an enum. Don't have a separate type for the per-packet routine for "follow" taps; they're expected to act like tap packet routines, so just use the type for tap packet routines. One tap packet routine returned -1; that's not a valid return value, and wasn't one before this change (the return value was a boolean), so presume the intent was "don't redraw". Another tap routine's early return, without doing any work, returned TRUE; this is presumably an error (no work done, no need to redraw), so presumably it should be "don't redraw". Clean up some white space while we're at it. Change-Id: Ia7d2b717b2cace4b13c2b886e699aa4d79cc82c8 Reviewed-on: https://code.wireshark.org/review/31283 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-12GSM A: detect buffer overrun when decoding MS Classmark 3 IEPascal Quantin1-2/+7
Change-Id: I12d372afd8a50b9a04f92c53077e79116db6c255 Reviewed-on: https://code.wireshark.org/review/31024 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-10-04Revert "gsm-a-common: Use expert info on "to few bytes left""Anders Broman1-26/+1
This test does not work when looking for optional elements. This reverts commit 0cc8feb4b6bd5c2576ae5f11e947d172fe1e6cb1. Change-Id: Ib6794c647f6e1541b7257a59c4717a6a497c3a8a Reviewed-on: https://code.wireshark.org/review/30013 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-27gsm-a-common: Use expert info on "to few bytes left"AndersBroman1-1/+26
Change-Id: Iaa84d52c28fcb65cd65963f04a389f5902536eeb Reviewed-on: https://code.wireshark.org/review/29884 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-26 20:42:02 +0000