diff options
author | Guy Harris <guy@alum.mit.edu> | 2004-01-25 21:55:17 +0000 |
---|---|---|
committer | Guy Harris <guy@alum.mit.edu> | 2004-01-25 21:55:17 +0000 |
commit | d6cd61061efe7207b298b5ac40a92e7b86b00b3e (patch) | |
tree | 392720e018248f9cf2b46db00a4a9740ff7d1fca /wiretap/file_access.c | |
parent | 34bddb3c1a932632fd0515f7999ed96ef9974611 (diff) |
Have the Wiretap open, read, and seek-and-read routines return, in
addition to an error code, an error info string, for
WTAP_ERR_UNSUPPORTED, WTAP_ERR_UNSUPPORTED_ENCAP, and
WTAP_ERR_BAD_RECORD errors. Replace the error messages logged with
"g_message()" for those errors with g_strdup()ed or g_strdup_printf()ed
strings returned as the error info string, and change the callers of
those routines to, for those errors, put the info string into the
printed message or alert box for the error.
Add messages for cases where those errors were returned without printing
an additional message.
Nobody uses the error code from "cf_read()" - "cf_read()" puts up the
alert box itself for failures; get rid of the error code, so it just
returns a success/failure indication.
Rename "file_read_error_message()" to "cf_read_error_message()", as it
handles read errors from Wiretap, and have it take an error info string
as an argument. (That handles a lot of the work of putting the info
string into the error message.)
Make some variables in "ascend-grammar.y" static.
Check the return value of "erf_read_header()" in "erf_seek_read()".
Get rid of an unused #define in "i4btrace.c".
svn path=/trunk/; revision=9852
Diffstat (limited to 'wiretap/file_access.c')
-rw-r--r-- | wiretap/file_access.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/wiretap/file_access.c b/wiretap/file_access.c index 47d475a198..b6cb870ded 100644 --- a/wiretap/file_access.c +++ b/wiretap/file_access.c @@ -1,6 +1,6 @@ /* file_access.c * - * $Id: file_access.c,v 1.8 2003/12/02 19:37:05 guy Exp $ + * $Id: file_access.c,v 1.9 2004/01/25 21:55:13 guy Exp $ * * Wiretap Library * Copyright (c) 1998 by Gilbert Ramirez <gram@alumni.rice.edu> @@ -91,7 +91,7 @@ * should be discovered as a libpcap file, not a toshiba file. */ -static int (*const open_routines[])(wtap *, int *) = { +static int (*const open_routines[])(wtap *, int *, char **) = { /* Files that have magic bytes in fixed locations. These * are easy to identify. */ @@ -156,7 +156,8 @@ static int (*const open_routines[])(wtap *, int *) = { so that it can do sequential I/O to a capture file that's being written to as new packets arrive independently of random I/O done to display protocol trees for packets when they're selected. */ -wtap* wtap_open_offline(const char *filename, int *err, gboolean do_random) +wtap* wtap_open_offline(const char *filename, int *err, char **err_info, + gboolean do_random) { struct stat statb; wtap *wth; @@ -257,7 +258,7 @@ wtap* wtap_open_offline(const char *filename, int *err, gboolean do_random) return NULL; } wth->data_offset = 0; - switch ((*open_routines[i])(wth, err)) { + switch ((*open_routines[i])(wth, err, err_info)) { case -1: /* I/O error - give up */ |