aboutsummaryrefslogtreecommitdiffstats
path: root/ui
diff options
context:
space:
mode:
authorMartin Kaiser <wireshark@kaiser.cx>2020-04-12 20:09:06 +0200
committerAnders Broman <a.broman58@gmail.com>2020-04-13 10:20:06 +0000
commit7044c6101d79292753af84eb358a6c4561dec15e (patch)
tree24aa152a5b22630879af687016635504dcd7be65 /ui
parent71f6d9411a38a3e98598b4c7b68f3f94917fcb86 (diff)
PacketList: markFrame: remove write-only variable
The "rows" variable is populated with the indices of all selected rows. It seems that rows is never read and can be removed. (In parallel, there's QModelIndexList frames. This list is used when it comes to actually marking the selected packets.) Change-Id: If2b97a2f5d87fe24717b9ad56444e2a779e0b3fc Reviewed-on: https://code.wireshark.org/review/36804 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui')
-rw-r--r--ui/qt/packet_list.cpp2
1 files changed, 0 insertions, 2 deletions
diff --git a/ui/qt/packet_list.cpp b/ui/qt/packet_list.cpp
index 71a68a7a76..2139b38ed1 100644
--- a/ui/qt/packet_list.cpp
+++ b/ui/qt/packet_list.cpp
@@ -1561,14 +1561,12 @@ void PacketList::markFrame()
if (selectionModel() && selectionModel()->hasSelection())
{
- QList<int> rows;
QModelIndexList selRows = selectionModel()->selectedRows(0);
foreach (QModelIndex idx, selRows)
{
if (idx.isValid())
{
frames << idx;
- rows << idx.row();
}
}
}