diff options
| author | Tomasz Moń <desowin@gmail.com> | 2019-04-14 13:14:27 +0200 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2019-04-15 04:17:27 +0000 |
| commit | 75a6897b0f574df6c8d983e45f2eecb014a4bdc1 (patch) | |
| tree | 95f4253f07a93e87182dfef10a929e0cce5bc787 /ui/tap-rlc-graph.c | |
| parent | 6560179d934d486930a1add306df7b579ae24deb (diff) | |
Qt: Do not pass empty values for extcap boolflags
For extcap boolean flags inserted into arguments hash table, the key should
be the "call" option and value should be NULL.
extcap_add_arg_and_remove_cb() takes care of NULL values by simply
omitting them from generated argument list.
ws_pipe_spawn_async() appends arguments until either:
* argument string is NULL
* argument string points directly to NULL terminator (empty string)
This bug resulted in extcap arguments being "cut off" after the first
"boolflag" present in the commandline arugments. Because arugments hash
table is unordered the actual commandline passed to extcap depended on
the order in which options were changed in extcap configuration dialog.
Bug: 15586
Change-Id: I00f136d3b627064cbfb539b3429aa5e4aef319e1
Reviewed-on: https://code.wireshark.org/review/32848
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui/tap-rlc-graph.c')
0 files changed, 0 insertions, 0 deletions