diff options
| author | Dario Lombardo <lomato@gmail.com> | 2017-12-23 21:31:41 +0100 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2017-12-25 03:09:25 +0000 |
| commit | 340fc6f08aa4282440df4038721a2153fc7ebb12 (patch) | |
| tree | 8d5755461bb009c86962b2e35817ccc5a6c4cf24 /ui/qt/widgets | |
| parent | 7ca62cc8159ba6e62a81aba712e79792f78318f8 (diff) | |
Qt: rework ByteViewText::addFormatRange to avoid dead code (CID: 1426074).
Change-Id: I8341a6106cd38118f0bf1bdb87aa87cc90e89eee
Reviewed-on: https://code.wireshark.org/review/24966
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'ui/qt/widgets')
| -rw-r--r-- | ui/qt/widgets/byte_view_text.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/ui/qt/widgets/byte_view_text.cpp b/ui/qt/widgets/byte_view_text.cpp index 4997936447..6a0e1b7046 100644 --- a/ui/qt/widgets/byte_view_text.cpp +++ b/ui/qt/widgets/byte_view_text.cpp @@ -432,9 +432,8 @@ void ByteViewText::drawLine(QPainter *painter, const int offset, const int row_y bool ByteViewText::addFormatRange(QList<QTextLayout::FormatRange> &fmt_list, int start, int length, HighlightMode mode) { - if (length < 1 || mode == ModeNormal) { + if (length < 1) return false; - } QTextLayout::FormatRange format_range; format_range.start = start; @@ -442,7 +441,7 @@ bool ByteViewText::addFormatRange(QList<QTextLayout::FormatRange> &fmt_list, int format_range.format.setProperty(QTextFormat::LineHeight, line_height_); switch (mode) { case ModeNormal: - break; + return false; case ModeField: format_range.format.setBackground(palette().highlight()); break; |