diff options
author | Gerald Combs <gerald@wireshark.org> | 2014-11-12 14:24:16 -0800 |
---|---|---|
committer | Gerald Combs <gerald@wireshark.org> | 2014-12-09 19:02:41 +0000 |
commit | bcaa5d84b1e6637927faf6066d6e57a92c94146e (patch) | |
tree | 40fec9b3acb8e127708819c7a0ab0d83f5ad099c /ui/qt/main_window.h | |
parent | 9681bddaa60fd7cdfdba00ebd87903a860c4166c (diff) |
Qt: Update and rename the summary dialog.
Go back to a single view similar to the GTK+ UI. Apply layouts using Qt
Designer.
Rename the menu item and class to "Capture File Properties". It's not
really a summary if it contains details such as "marked average bits
per second". We might want to move this to a "Properties" item under
the "File" menu similar to other applications.
Add the GTK+ summary icon (for now) to the toolbar and open the
properties dialog on clicking.
Singleton dialogs delenda est[1]. Let the user open as many summaries on
as many capture files as he or she wishes. Also, global cfile delenda
est[2].
Don't blindly include QtGui. Add specific components instead.
Use consistent method names, variable names, and patterns. Try to
document what "consistent" means.
Adjust the way we display some statistics to match the summary bar, e.g.
displayed = captured if we don't have a filter applied.
[1] Not really.
[2] Yes, really.
Change-Id: I11793b1d79dd0c3f70414ac8592b86181da59916
Reviewed-on: https://code.wireshark.org/review/5274
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'ui/qt/main_window.h')
-rw-r--r-- | ui/qt/main_window.h | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/ui/qt/main_window.h b/ui/qt/main_window.h index 2815347f83..6bf613d97b 100644 --- a/ui/qt/main_window.h +++ b/ui/qt/main_window.h @@ -55,7 +55,6 @@ #include "file_set_dialog.h" #include "filter_action.h" #include "capture_file_dialog.h" -#include "summary_dialog.h" #include "follow_stream_dialog.h" #include "capture_interfaces_dialog.h" #include "about_dialog.h" @@ -63,9 +62,6 @@ class QAction; class QActionGroup; -Q_DECLARE_METATYPE(ts_type) -Q_DECLARE_METATYPE(ts_precision) - namespace Ui { class MainWindow; } @@ -120,7 +116,6 @@ private: ProtoTree *proto_tree_; QWidget *previous_focus_; FileSetDialog file_set_dialog_; - SummaryDialog summary_dialog_; ByteViewTab *byte_view_tab_; QWidget empty_pane_; QActionGroup *show_hide_actions_; @@ -366,7 +361,7 @@ private slots: void on_actionCaptureStart_triggered(); void on_actionCaptureStop_triggered(); - void on_actionSummary_triggered(); + void on_actionStatisticsCaptureFileProperties_triggered(); void on_actionStatisticsFlowGraph_triggered(); void openTcpStreamDialog(int graph_type); void on_actionStatisticsTcpStreamStevens_triggered(); |