diff options
| author | Jeff Morriss <jeff.morriss@ulticom.com> | 2011-02-11 02:43:07 +0000 |
|---|---|---|
| committer | Jeff Morriss <jeff.morriss@ulticom.com> | 2011-02-11 02:43:07 +0000 |
| commit | d8659693eff66f7e89c53871776c455cd11b4cae (patch) | |
| tree | add1992656e851b438ee6b2abe2c452a5479b260 /tools/checkAPIs.pl | |
| parent | 8d03f63e1762609119ce81e55132c0d8c17f3433 (diff) | |
Check for places where tvb_bytes_to_str() or tvb_get_bytes_to_str_punct()
should be used (instead of the non-tvb functions with a call to tvb_get_ptr()).
Use those functions in a bunch of places.
svn path=/trunk/; revision=35911
Diffstat (limited to 'tools/checkAPIs.pl')
| -rwxr-xr-x | tools/checkAPIs.pl | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/tools/checkAPIs.pl b/tools/checkAPIs.pl index dde3eb349d..acba8b34ab 100755 --- a/tools/checkAPIs.pl +++ b/tools/checkAPIs.pl @@ -976,9 +976,10 @@ sub findAPIinFile($$$) } } +# APIs which (generally) should not be called with an argument of tvb_get_ptr() my @TvbPtrAPIs = ( - # Use NULL for the value_ptr instead of tvb_get_ptr() - # (Only if the given offset and length are equal) with these: + # Use NULL for the value_ptr instead of tvb_get_ptr() (only if the + # given offset and length are equal) with these: 'proto_tree_add_bytes_format', 'proto_tree_add_bytes_format_value', # Use the tvb_* version of these: @@ -986,7 +987,10 @@ my @TvbPtrAPIs = ( 'ip_to_str', 'ip6_to_str', 'fc_to_str', - 'fcwwn_to_str' + 'fcwwn_to_str', + # Use tvb_bytes_to_str[_punct] instead of: + 'bytes_to_str', + 'bytes_to_str_punct', ); sub checkAPIsCalledWithTvbGetPtr($$$) |