aboutsummaryrefslogtreecommitdiffstats
path: root/packet-dcerpc-spoolss.c
diff options
context:
space:
mode:
authorTim Potter <tpot@samba.org>2003-02-05 00:36:35 +0000
committerTim Potter <tpot@samba.org>2003-02-05 00:36:35 +0000
commit74d71933ec6d94c647e400fb1ff6a5ca5beeeeb8 (patch)
tree9a711c3503e5345c3e6b6fe4eee75cb55afe9e9c /packet-dcerpc-spoolss.c
parentfa05c0bf235c2421329f729247f2ea2c86347a8e (diff)
Fixed bug in dissect_printerdata_data()
Display something useful in COL_INFO when dissecting REG_BINARY printerdata. Display the value needed field in value subtree. svn path=/trunk/; revision=7073
Diffstat (limited to 'packet-dcerpc-spoolss.c')
-rw-r--r--packet-dcerpc-spoolss.c16
1 files changed, 9 insertions, 7 deletions
diff --git a/packet-dcerpc-spoolss.c b/packet-dcerpc-spoolss.c
index 098a2e5073..f0aff7d16f 100644
--- a/packet-dcerpc-spoolss.c
+++ b/packet-dcerpc-spoolss.c
@@ -2,7 +2,7 @@
* Routines for SMB \PIPE\spoolss packet disassembly
* Copyright 2001-2003, Tim Potter <tpot@samba.org>
*
- * $Id: packet-dcerpc-spoolss.c,v 1.78 2003/02/03 02:14:01 tpot Exp $
+ * $Id: packet-dcerpc-spoolss.c,v 1.79 2003/02/05 00:36:35 tpot Exp $
*
* Ethereal - Network traffic analyzer
* By Gerald Combs <gerald@ethereal.com>
@@ -1016,16 +1016,18 @@ static int dissect_printerdata_data(tvbuff_t *tvb, int offset,
break;
}
+ case DCERPC_REG_BINARY:
+ if (check_col(pinfo->cinfo, COL_INFO))
+ col_append_fstr(
+ pinfo->cinfo, COL_INFO,
+ " = <binary data>");
+ break;
+
default:
break;
}
}
- if (size)
- offset = dissect_ndr_uint8s(
- tvb, offset, pinfo, subtree, drep,
- hf_spoolss_printerdata_data, size, NULL);
-
proto_item_set_len(item, size + 4);
return offset;
@@ -4060,7 +4062,7 @@ static int SpoolssEnumPrinterData_r(tvbuff_t *tvb, int offset,
proto_item_set_len(value_item, value_len * 2 + 4);
offset = dissect_ndr_uint32(
- tvb, offset, pinfo, tree, drep,
+ tvb, offset, pinfo, value_subtree, drep,
hf_enumprinterdata_value_needed, NULL);
offset = dissect_ndr_uint32(