diff options
author | Guy Harris <guy@alum.mit.edu> | 2017-08-05 15:50:46 -0700 |
---|---|---|
committer | Guy Harris <guy@alum.mit.edu> | 2017-08-05 22:51:37 +0000 |
commit | f63b68f7078a482d31d6bc22569756c09a0a2202 (patch) | |
tree | 7bbc8134b63489ed609d81043250cb79357998f2 /ipmap.html | |
parent | 1d457701c5d969f3912d763c3e912b913497b97c (diff) |
Further cleanups.
If a variable is initialized in a loop body or an if clause or a switch
clause, declare it inside the loop body/clause, and de-initialize it
before leaving the loop body/clause.
De-initialize the gnutls_pkcs12_t before leaving rsa_load_pkcs12(), so
as not to leak it.
Always leave the per-bag loop by "goto done", even if we're not within
an inner loop, to make it clearer what we're doing.
We initialize the bag structure at the beginning of that loop body;
de-initialize it at the end.
If we leave the loop without a private key, and we don't have an error
message, the error is "we didn't find a PKCS8 key"; report that.
Change-Id: I87cf296876c8f1879f69d01ce67ca2829b4f8d16
Reviewed-on: https://code.wireshark.org/review/22958
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'ipmap.html')
0 files changed, 0 insertions, 0 deletions