diff options
| author | Tomasz Moń <desowin@gmail.com> | 2019-08-27 17:49:53 +0200 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2019-08-28 03:51:32 +0000 |
| commit | 5f5a934bca72f352f64bc5138c58cbc3dbea8323 (patch) | |
| tree | 4afad73042891c78739b662db072ae484173361d /epan/stats_tree.c | |
| parent | 05b6a9ad0bc86e2fddb250a7280fcf4658d66b82 (diff) | |
Use g_hash_table_replace() when key depends on data
Using g_hash_table_insert() in cases where the key is contained within
value is error prone. Use g_hash_table_replace() to eliminate the risk
of ending up with incoherent hash table state.
Change-Id: I595457476a2682e927d2c56b2692404aef4dc43a
Reviewed-on: https://code.wireshark.org/review/34385
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/stats_tree.c')
| -rw-r--r-- | epan/stats_tree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/stats_tree.c b/epan/stats_tree.c index 10fdc10234..13c9738b32 100644 --- a/epan/stats_tree.c +++ b/epan/stats_tree.c @@ -521,7 +521,7 @@ new_stat_node(stats_tree *st, const gchar *name, int parent_id, stat_node_dataty } if(node->parent->hash) { - g_hash_table_insert(node->parent->hash,node->name,node); + g_hash_table_replace(node->parent->hash,node->name,node); } if (st->cfg->setup_node_pr) { |