diff options
| author | Dario Lombardo <lomato@gmail.com> | 2018-01-16 14:11:58 +0100 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2018-01-16 22:31:51 +0000 |
| commit | 34381ed20c7e1005dec1e13ab90edd736238f2d7 (patch) | |
| tree | dbf64bf282b25ed4665b439e8ffddfad5d35e6ec /epan/stat_tap_ui.c | |
| parent | f3b71f597c0da82217643ff8ae37354308070134 (diff) | |
stat_tap: don't use-after-free (found by clang).
Change-Id: Ie7304ad70c8cf3ac62abdf07aaa94d12c409f1b0
Reviewed-on: https://code.wireshark.org/review/25339
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'epan/stat_tap_ui.c')
| -rw-r--r-- | epan/stat_tap_ui.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/stat_tap_ui.c b/epan/stat_tap_ui.c index e6338d331f..258c77e8a5 100644 --- a/epan/stat_tap_ui.c +++ b/epan/stat_tap_ui.c @@ -139,9 +139,9 @@ start_requested_stats(void) while(stats_requested){ sr=(stat_requested *)stats_requested->data; (*sr->sca->func)(sr->arg,sr->sca->userdata); + stats_requested=g_slist_remove(stats_requested, sr); g_free(sr->arg); g_free(sr); - stats_requested=g_slist_remove(stats_requested, sr); } } |