diff options
author | Guy Harris <guy@alum.mit.edu> | 2017-09-25 00:16:26 -0700 |
---|---|---|
committer | Guy Harris <guy@alum.mit.edu> | 2017-09-25 07:18:22 +0000 |
commit | c1a5531b71208c8270f7d969f4aebdfbfb5ad12e (patch) | |
tree | 14233dd0873c63b2e6db22829138896a52f35891 /epan/etypes.h | |
parent | a98d1089166cc90ebf7c82b938ae0add478b921d (diff) |
pidl: Fix array range checks in python output
Pick up change from Samba:
commit 67040cf61232dd1cdcc820237919ac1e073c31c2
Author: Volker Lendecke <vl@samba.org>
Date: Tue Jun 20 15:31:18 2017 +0200
pidl: Fix array range checks in python output
Without this, we generated code like
if (ndr_table_dnsserver.num_calls < 0) {
PyErr_SetString(PyExc_TypeError, "Internal Error, ndr_interface_call missing for py_DnssrvOperation_ndr_pack");
return NULL;
}
call = &ndr_table_dnsserver.calls[0];
This does not really make sense, and Coverity found comparing the unsigned
num_calls against <0 a bit pointless.
Should fix 138 Coverity findings and make the code a bit more correct.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Change-Id: I401e3771e6f3c1125ff847749073693af23884fc
Reviewed-on: https://code.wireshark.org/review/23723
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'epan/etypes.h')
0 files changed, 0 insertions, 0 deletions