diff options
| author | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2018-05-16 08:35:28 +0200 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2018-05-17 07:43:51 +0000 |
| commit | c20255e25a7711612dac4675343a7761c0fa83b9 (patch) | |
| tree | b09a5a30e1ec851c5f0f5e6b7815e0a9f8f24f74 /epan/dissectors/packet-rsh.c | |
| parent | 57ddb2e651fa71ef4d1f678b3e7047e87bbbdbd9 (diff) | |
rsh: fix issue found by PVS Studio (V519)
The 'hash_info->state' variable is assigned values twice successively
Change-Id: I73fc8e1d6acaa7c68c517e345492f2193ca95ea1
Reviewed-on: https://code.wireshark.org/review/27597
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-rsh.c')
| -rw-r--r-- | epan/dissectors/packet-rsh.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/epan/dissectors/packet-rsh.c b/epan/dissectors/packet-rsh.c index 4cc4f5d420..0927493c4f 100644 --- a/epan/dissectors/packet-rsh.c +++ b/epan/dissectors/packet-rsh.c @@ -287,11 +287,6 @@ dissect_rsh(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U_) hash_info->server_username=wmem_strdup(wmem_file_scope(), (gchar*)field_stringz); } - /* Next field we need */ - hash_info->state = WAIT_FOR_COMMAND; - } else { - /* Since the data doesn't match this field, it must be data only */ - hash_info->state = WAIT_FOR_DATA; } /* Used if the next field is in the same packet */ |