diff options
| author | Guy Harris <gharris@sonic.net> | 2021-04-30 03:18:25 -0700 |
|---|---|---|
| committer | Guy Harris <gharris@sonic.net> | 2021-04-30 03:19:19 -0700 |
| commit | 57a1514ac74527651ad42dca3041f3f53509317e (patch) | |
| tree | a69a01eaeac3d625a5312930fa81f0a3c6b12e96 /epan/dissectors/packet-h225.c | |
| parent | 09147397007c5456fd5acd4794b5ba15330bdad3 (diff) | |
Cast away the return value of g_strlcpy() and g_strlcat().
Most of the time, the return value tells us nothing useful, as we've
already decided that we're perfectly willing to live with string
truncation. Hopefully this keeps Coverity from whining that those
routines could return an error code (NARRATOR: They don't) and thus that
we're ignoring the possibility of failure (as indicated, we've already
decided that we can live with string truncation, so truncation is *NOT*
a failure).
Diffstat (limited to 'epan/dissectors/packet-h225.c')
| -rw-r--r-- | epan/dissectors/packet-h225.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/epan/dissectors/packet-h225.c b/epan/dissectors/packet-h225.c index 93d6b1cb58..d47dbed12d 100644 --- a/epan/dissectors/packet-h225.c +++ b/epan/dissectors/packet-h225.c @@ -3252,7 +3252,7 @@ dissect_h225_FastStart_item(tvbuff_t *tvb _U_, int offset _U_, asn1_ctx_t *actx if (h225_pi != NULL) { char temp[50]; g_snprintf(temp, 50, "%s %s", h225_pi->frame_label, codec_str); - g_strlcpy(h225_pi->frame_label, temp, 50); + (void) g_strlcpy(h225_pi->frame_label, temp, 50); h225_pi->is_faststart = TRUE; } contains_faststart = TRUE; @@ -4290,7 +4290,7 @@ dissect_h225_Setup_UUIE(tvbuff_t *tvb _U_, int offset _U_, asn1_ctx_t *actx _U_, if (contains_faststart) { char temp[50]; g_snprintf(temp, 50, "%s OLC (%s)", val_to_str(h225_pi->cs_type, T_h323_message_body_vals, "<unknown>"), h225_pi->frame_label); - g_strlcpy(h225_pi->frame_label, temp, 50); + (void) g_strlcpy(h225_pi->frame_label, temp, 50); } else g_snprintf(h225_pi->frame_label, 50, "%s", val_to_str(h225_pi->cs_type, T_h323_message_body_vals, "<unknown>")); } @@ -4348,7 +4348,7 @@ dissect_h225_CallProceeding_UUIE(tvbuff_t *tvb _U_, int offset _U_, asn1_ctx_t * if (contains_faststart) { char temp[50]; g_snprintf(temp, 50, "%s OLC (%s)", val_to_str(h225_pi->cs_type, T_h323_message_body_vals, "<unknown>"), h225_pi->frame_label); - g_strlcpy(h225_pi->frame_label, temp, 50); + (void) g_strlcpy(h225_pi->frame_label, temp, 50); } else g_snprintf(h225_pi->frame_label, 50, "%s", val_to_str(h225_pi->cs_type, T_h323_message_body_vals, "<unknown>")); } @@ -4397,7 +4397,7 @@ dissect_h225_Connect_UUIE(tvbuff_t *tvb _U_, int offset _U_, asn1_ctx_t *actx _U if (contains_faststart) { char temp[50]; g_snprintf(temp, 50, "%s OLC (%s)", val_to_str(h225_pi->cs_type, T_h323_message_body_vals, "<unknown>"), h225_pi->frame_label); - g_strlcpy(h225_pi->frame_label, temp, 50); + (void) g_strlcpy(h225_pi->frame_label, temp, 50); } else g_snprintf(h225_pi->frame_label, 50, "%s", val_to_str(h225_pi->cs_type, T_h323_message_body_vals, "<unknown>")); } @@ -4444,7 +4444,7 @@ dissect_h225_Alerting_UUIE(tvbuff_t *tvb _U_, int offset _U_, asn1_ctx_t *actx _ if (contains_faststart) { char temp[50]; g_snprintf(temp, 50, "%s OLC (%s)", val_to_str(h225_pi->cs_type, T_h323_message_body_vals, "<unknown>"), h225_pi->frame_label); - g_strlcpy(h225_pi->frame_label, temp, 50); + (void) g_strlcpy(h225_pi->frame_label, temp, 50); } else g_snprintf(h225_pi->frame_label, 50, "%s", val_to_str(h225_pi->cs_type, T_h323_message_body_vals, "<unknown>")); } @@ -4804,7 +4804,7 @@ dissect_h225_Progress_UUIE(tvbuff_t *tvb _U_, int offset _U_, asn1_ctx_t *actx _ if (contains_faststart) { char temp[50]; g_snprintf(temp, 50, "%s OLC (%s)", val_to_str(h225_pi->cs_type, T_h323_message_body_vals, "<unknown>"), h225_pi->frame_label); - g_strlcpy(h225_pi->frame_label, temp, 50); + (void) g_strlcpy(h225_pi->frame_label, temp, 50); } else g_snprintf(h225_pi->frame_label, 50, "%s", val_to_str(h225_pi->cs_type, T_h323_message_body_vals, "<unknown>")); } |