diff options
| author | Guy Harris <guy@alum.mit.edu> | 2015-04-30 15:21:00 -0700 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2015-04-30 22:22:59 +0000 |
| commit | 9fba5f0764678cfed4b7ff2a41fdcb0babcdbf55 (patch) | |
| tree | 0515e84e39049ba809ab2c1e8c1be4e6964a464a /epan/dissectors/packet-fcels.c | |
| parent | d2b02eaf591145f40eaa65d6b50908e47d7c4484 (diff) | |
Fix some cases where we're shifting a signed 1 left.
Shift 1U instead, to make sure it's unsigned; the result of, for
example, the result of shifting a signed value left is undefined if the
value times 2^{shift count} doesn't fit in the *signed* type of the
shifted value. That means, in particular, that the result of shifting 1
left by {number of bits in an int - 1} is undefined. (In *practice*,
it'll probably be -2^32, with the bit you want set, but that's not
guaranteed, and GCC 5.1 seems not to like it.)
Change-Id: I0d27565c382a04ceda9eec65f45a430ceb74cf53
Reviewed-on: https://code.wireshark.org/review/8255
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'epan/dissectors/packet-fcels.c')
| -rw-r--r-- | epan/dissectors/packet-fcels.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/epan/dissectors/packet-fcels.c b/epan/dissectors/packet-fcels.c index 5d657df426..d38c3c2074 100644 --- a/epan/dissectors/packet-fcels.c +++ b/epan/dissectors/packet-fcels.c @@ -287,9 +287,9 @@ static const true_false_string tfs_fcels_estat_seq_init = { }; -#define FC_ESB_ST_RESP (1 << 31) /* responder to exchange */ -#define FC_ESB_ST_SEQ_INIT (1 << 30) /* holds sequence initiative */ -#define FC_ESB_ST_COMPLETE (1 << 29) /* exchange is complete */ +#define FC_ESB_ST_RESP (1U << 31) /* responder to exchange */ +#define FC_ESB_ST_SEQ_INIT (1U << 30) /* holds sequence initiative */ +#define FC_ESB_ST_COMPLETE (1U << 29) /* exchange is complete */ static const value_string fc_els_proto_val[] = { {FC_ELS_LSRJT , "LS_RJT"}, |