aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-capwap.c
diff options
context:
space:
mode:
authorTomasz Moń <desowin@gmail.com>2019-05-15 17:56:08 +0200
committerAnders Broman <a.broman58@gmail.com>2019-05-20 12:53:38 +0000
commitca1163ab60d85ae625d406b30c6eb31937bd1a1d (patch)
tree45eb2f449e688028389208576a800ee78de35047 /epan/dissectors/packet-capwap.c
parent40f6cb70e9cc4c4d9826e8618e948b39efe1e8e9 (diff)
Qt: Add asynchronous simple dialog
When extcap fails before connecting to pipes, ws_write() in InterfaceToolbar::controlSend() fails and error message is displayed to the user. Before this change, the message box would block until the user closes the message. As the controlSend() was called inside "capture prepared" context the remaining capture preparation code would wait for the user action. However, the pipeTimeout() would get called before user confirms the message as Qt would be processing all events in the main event queue. This led to "capture failed" executing before "capture prepared" finished. Such interruption caused multiple issues including freeing buffer that was not yet allocated. Bug: 15743 Change-Id: I6bc2734126292cdc5b560418069caf98747be68e Reviewed-on: https://code.wireshark.org/review/33208 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Tomasz Moń <desowin@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-capwap.c')
0 files changed, 0 insertions, 0 deletions