diff options
| author | Martin Mathieson <martin.mathieson@keysight.com> | 2020-08-16 21:41:18 +0100 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2020-08-17 02:58:01 +0000 |
| commit | 3b67c5b3084cd74986115e06eab954b4f8332a3f (patch) | |
| tree | 8af69228676d2f4e3af160960b693a3f8073d567 /epan/dissectors/packet-bssap.c | |
| parent | e48ab21267c90bf5f870003299e00ea1656e2d7e (diff) | |
TFS: Add some commonly-defined string pairs to tfs.c
'check_tfs.py --common' can look for tfs values that appear multiple times.
Current output prior to these dssector changes was:
('No Extension', 'Extension') appears 3 times in: ['epan/dissectors/packet-bssap.c', 'epan/dissectors/packet-camel.c', 'epan/dissectors/packet-gsm_map.c']
('Optimised for signalling traffic', 'Not optimised for signalling traffic') appears 3 times in: ['epan/dissectors/packet-gsm_a_gm.c', 'epan/dissectors/packet-gsm_map.c', 'epan/dissectors/packet-gtp.c']
('Data PDU', 'Control PDU') appears 3 times in: ['epan/dissectors/packet-pdcp-lte.c', 'epan/dissectors/packet-pdcp-nr.c', 'epan/dissectors/packet-rlc-nr.c']
('Message sent to originating side', 'Message sent from originating side') appears 3 times in: ['epan/dissectors/packet-q2931.c', 'epan/dissectors/packet-q931.c', 'epan/dissectors/packet-q933.c']
('User', 'Provider') appears 3 times in: ['epan/dissectors/packet-q2931.c', 'epan/dissectors/packet-q931.c', 'epan/dissectors/packet-q933.c']
The first and last ones were made common, the others seem a little too specialised.
Checking some of the existing items in tfs.c (using QtCreator's 'Find Usages'),
some of the common items are used a lot, but many of them are not referenced.
Change-Id: Ia4006d2c4fa7cafbc3b004dc7a367a986dbeb0c4
Reviewed-on: https://code.wireshark.org/review/38177
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-bssap.c')
| -rw-r--r-- | epan/dissectors/packet-bssap.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/epan/dissectors/packet-bssap.c b/epan/dissectors/packet-bssap.c index 4ada237f05..a68c9d815d 100644 --- a/epan/dissectors/packet-bssap.c +++ b/epan/dissectors/packet-bssap.c @@ -1303,11 +1303,6 @@ dissect_bssap_service_area_id(tvbuff_t *tvb, proto_tree *tree, int offset) /* 18.4.22 SGSN number */ -static const true_false_string bssap_extension_value = { - "No Extension", - "Extension" -}; - static int dissect_bssap_sgsn_number(tvbuff_t *tvb, proto_tree *tree, int offset) { @@ -2160,7 +2155,7 @@ proto_register_bssap(void) { &hf_bssap_extension, { "Extension", "bssap.extension", - FT_BOOLEAN, 8, TFS(&bssap_extension_value), 0x80, + FT_BOOLEAN, 8, TFS(&tfs_no_extension_extension), 0x80, NULL, HFILL }}, { &hf_bssap_type_of_number, |