diff options
| author | Guy Harris <guy@alum.mit.edu> | 2018-09-30 14:24:48 -0700 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2018-09-30 21:25:22 +0000 |
| commit | 452e78bb83410d31fd3cdb3576ddbc592fd46475 (patch) | |
| tree | c7d458b70b81fe625fa4a41452ba6b89a2e2ab31 /epan/capture_dissectors.c | |
| parent | e7dec27ea024fd8e2e5b5370b692254d9a777ed6 (diff) | |
Fix the type of the packet buffer argument to a capture dissector.
It's a blob of bytes, so the right type is guint8 *, not guchar *.
(Yes, in practice, they're both typedefs for "unsigned char" - sadly,
C's data types didn't make a distinction between "byte-sized integral
value" and "character" - but given that we have different names, let's
use them to make it clearer what's being done.)
Change-Id: Idb10a208877c84df0432043d69d4aff5a2b2f803
Reviewed-on: https://code.wireshark.org/review/29943
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'epan/capture_dissectors.c')
| -rw-r--r-- | epan/capture_dissectors.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/epan/capture_dissectors.c b/epan/capture_dissectors.c index ca2872b22f..d6306907c7 100644 --- a/epan/capture_dissectors.c +++ b/epan/capture_dissectors.c @@ -134,7 +134,7 @@ void capture_dissector_add_uint(const char *name, const guint32 pattern, capture g_hash_table_insert(sub_dissectors->hash_table, GUINT_TO_POINTER(pattern), (gpointer) handle); } -gboolean try_capture_dissector(const char* name, const guint32 pattern, const guchar *pd, int offset, int len, capture_packet_info_t *cpinfo, const union wtap_pseudo_header *pseudo_header) +gboolean try_capture_dissector(const char* name, const guint32 pattern, const guint8 *pd, int offset, int len, capture_packet_info_t *cpinfo, const union wtap_pseudo_header *pseudo_header) { struct capture_dissector_table* sub_dissectors; capture_dissector_handle_t handle; @@ -153,7 +153,7 @@ gboolean try_capture_dissector(const char* name, const guint32 pattern, const gu return handle->dissector(pd, offset, len, cpinfo, pseudo_header); } -gboolean call_capture_dissector(capture_dissector_handle_t handle, const guchar *pd, int offset, int len, capture_packet_info_t *cpinfo, const union wtap_pseudo_header *pseudo_header) +gboolean call_capture_dissector(capture_dissector_handle_t handle, const guint8 *pd, int offset, int len, capture_packet_info_t *cpinfo, const union wtap_pseudo_header *pseudo_header) { if (handle == NULL) return FALSE; |