Qt: Rework the "Manage Interfaces" dialog.

Convert QTableWidget to QTreeWidget.

It looks like the GTK+ version has a separate set of apply/save buttons
for each tab which *only* operates on that tab. This can result unexpected
behavior which throws away changes if the user updates more than one
tab. Use a single "OK" button that applies all of our changes instead.

Reorder the tabs. Put Local Interfaces first and select it by default.
Always show Remote Interfaces. Disable it on platforms that don't have
PCAP_REMOTE.

Automatically start editing when we add a new pipe. Don't immediately
update pipe interface settings. Wait until we hit "OK" instead.

Rename NewFileDelegate to PathChooserDelegate. Note that we might want
to move it use it elsewhere in the application.

Try switching the user-facing terminology from "Hide" to the more
positive "Show".

Tell the user that we don't save pipe or remote interface settings.

Add a help URL for the "Manage Interfaces" dialog box.

Use the GLib and Qt string functions and classes to split and join
comma-separated preferences. This makes sure capture_dev_user_descr_find
doesn't skip over the first interface. It also keeps the Qt code from
adding a leading comma to our capture preferences.

Add a note about strings to README.qt. Summary: Use QStrings.

For another day:

- If we *do* save remote settings we need to store credentials securely,
  e.g. with CryptProtectData.

- Get rid of the remote settings dialogs. Their controls should fit in the
  remote settings tab.

- Add an extcap tab.

- We need getter/setter functions for global_capture_opts.all_ifaces. We
  iterate over it *way* too much.

Change-Id: Ib7b61972f3ece4325e0230f725e7f2678acbb24b
Reviewed-on: https://code.wireshark.org/review/3873
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>

1 files changed, 10 insertions, 2 deletions

diff --git a/doc/README.qt b/doc/README.qt
index f914034e38..1d530f452d 100644
--- a/doc/README.qt
+++ b/doc/README.qt
@@ -179,7 +179,16 @@ code uses InterCapConvention for class names and methods and
 underscore_convention for variables, with a trailing underscore for member
 variables.
 
-2.1.2 Mixing C and C++
+2.1.2 Strings
+
+If you're using GLib string functions or plain old C character array idioms in
+Qt-only code you're probably doing something wrong. QStrings are generally
+*much* safer and easier to use. They also make translations eaiser.
+
+If you need to pass strings between Qt and GLib you can use qstring_strdup
+gchar_free_to_qstring, which are defined in ui/qt/qt_ui_utils.h.
+
+2.1.3 Mixing C and C++
 
 Sometimes we have to call C++ functions from one of Wireshark's C callbacks and
 pass C++ objects to or from C. The C++ FAQ describes how to do this safely:
@@ -216,4 +225,3 @@ Qt makes translating the Wireshark UI into different languages easy.
 
 More information about Qt Linguist
 http://qt-project.org/doc/qt-4.8/linguist-manual.html
-