diff options
| author | Hadriel Kaplan <hadrielk@yahoo.com> | 2014-02-20 21:12:25 -0500 |
|---|---|---|
| committer | Evan Huus <eapache@gmail.com> | 2014-02-21 20:57:43 +0000 |
| commit | 7f074364b62b0e7a6a8660e48c9803ebcaa1c8fc (patch) | |
| tree | 99f2f7375ef0583fa3cf77084df4284e2a32e230 /doc | |
| parent | 1b210e967c9c68072486352d55c23e092083bcc2 (diff) | |
Fix bug 9790: Lua: wslua allows duplicate field registration
As discussed in bug 3513 and 9709, one can register more than one new ProtoFields for
the same field name. Of course C-code can do that too, and does a LOT apparently, but
if they're not similar ftypes then things can get scrweed up in display filters.
So this change prevents duplicate field registration of dissimilar ftypes. The
similarity is based on the discussion on the mailing list, and the listing in
README.developer has been updated to refelect that as well.
Also, this change adds a testscript for Proto/ProtoFields.
Change-Id: I43bd323f785245941a21289647332a19adec2a9d
Reviewed-on: https://code.wireshark.org/review/285
Reviewed-by: Evan Huus <eapache@gmail.com>
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/README.dissector | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/doc/README.dissector b/doc/README.dissector index cdd65e64ea..4db96d4623 100644 --- a/doc/README.dissector +++ b/doc/README.dissector @@ -1014,14 +1014,18 @@ the same abbreviation. For instance, the following is valid: This way a filter expression can match a header field, irrespective of the representation of it in the specific protocol context. This is interesting for protocols with variable-width header fields. -Note that the formats used must all belong to the same list as defined below: + +Note that the formats used must all belong to the same group as defined below: - FT_INT8, FT_INT16, FT_INT24 and FT_INT32 -- FT_UINT8, FT_UINT16, FT_UINT24, FT_UINT32, FT_IPXNET and FT_FRAMENUM -- FT_UINT64 and FT_EUI64 +- FT_UINT8, FT_UINT16, FT_UINT24, and FT_UINT32 - FT_STRING, FT_STRINGZ and FT_UINT_STRING - FT_FLOAT and FT_DOUBLE -- FT_BYTES, FT_UINT_BYTES, FT_AX25, FT_ETHER, FT_VINES, FT_OID and FT_REL_OID -- FT_ABSOLUTE_TIME and FT_RELATIVE_TIME +- FT_BYTES and FT_UINT_BYTES +- FT_OID and FT_REL_OID + +Any field not in a grouping above should *NOT* be used in duplicate field +abbrevations. The current code does not prevent it, but someday in the future +it might. The HFILL macro at the end of the struct will set reasonable default values for internally used fields. |