diff options
| author | Guy Harris <guy@alum.mit.edu> | 2019-07-24 11:22:33 -0700 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2019-07-24 19:05:13 +0000 |
| commit | 2c7e0a93e5f205bb61fb675d7de1b0ca9b5c0746 (patch) | |
| tree | 8ae6e291975cd548f0908b9cfd46525b5ebe451f /debian | |
| parent | c55780951cfd44420d1a40d5e6d68ee20af98338 (diff) | |
Add a routine to fetch raw bytes into a fixed-length buffer as a string.
That's what the remaining calls to tvb_get_nstringz() and
tvb_get_nstringz0() are being used to do, even though those routines
were not intended for that purpose - the calls are extracting from a
text protcool, meaning that the strings are *not* null-terminate in the
packet.
Strings - even null-terminated ones - should, in almost all cases, be
extracted by tvb_get_string_enc() or routines that call it, so that an
encoding is specified. In the few cases where we're fetching strings
only to be compared to ASCII constants, or to parse as numbers, we can
get away with this.
Change-Id: I29f0532902c4ade2207de7f06db69c32eafd4132
Reviewed-on: https://code.wireshark.org/review/34072
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'debian')
| -rw-r--r-- | debian/libwireshark0.symbols | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/debian/libwireshark0.symbols b/debian/libwireshark0.symbols index 61eb0b0a8f..c7b88ffeab 100644 --- a/debian/libwireshark0.symbols +++ b/debian/libwireshark0.symbols @@ -1777,6 +1777,7 @@ libwireshark.so.0 libwireshark0 #MINVER# tvb_get_ntohl@Base 1.9.1 tvb_get_ntohs@Base 1.9.1 tvb_get_ptr@Base 1.9.1 + tvb_get_raw_bytes_as_string@Base 3.1.0 tvb_get_string_bytes@Base 1.12.0~rc1 tvb_get_string_enc@Base 1.12.0~rc1 tvb_get_string_time@Base 1.12.0~rc1 |