aboutsummaryrefslogtreecommitdiffstats
path: root/cmake/modules
diff options
context:
space:
mode:
authorTomasz Moń <desowin@gmail.com>2021-04-03 18:29:11 +0200
committerWireshark GitLab Utility <gerald+gitlab-utility@wireshark.org>2021-08-29 08:50:57 +0000
commitc2edb44a9ac2bcd6bff267bd4d7301caff248eca (patch)
tree0e02dd70d1b2d748b0cf927724fb0bf657ba7cb7 /cmake/modules
parentbce7cbf52967a78319251f4d66fd0a21424c4504 (diff)
Qt: fix memory leaks found by Visual Leak Detector
Set PacketDiagram as parent of QGraphicsScene so the scene is destroyed together with PacketDiagram. Dynamically allocate WiresharkApplication and explicitly call its destructor when no longer needed. This results in deletion of FunnelAction objects created in register_menu_cb() and QAction objects created in TapParameterDialog::registerDialog(). For some reason, when breakpoint was set inside WiresharkApplication destructor it would not get triggered on exit, and so the child objects would get reported as memory leaks. Delete main window and application only after epan_cleanup(). This makes lua plugins actually call ops during cleanup (e.g. destroy_text_window) and makes it possible to free the memory allocated in FunnelStatistics constructor.
Diffstat (limited to 'cmake/modules')
0 files changed, 0 insertions, 0 deletions