diff options
| author | Gerald Combs <gerald@wireshark.org> | 2005-07-25 22:16:43 +0000 |
|---|---|---|
| committer | Gerald Combs <gerald@wireshark.org> | 2005-07-25 22:16:43 +0000 |
| commit | 8851e7125400db2e1ed9efec5e3791099610feb4 (patch) | |
| tree | 544a7aeaa4084852bcf400f7349d678b52a1c3a6 /ChangeLog | |
| parent | 1ca8874eda99120490069d0d297398a80f473d4b (diff) | |
Prep for 0.10.12. If you've added or changed any major features since
0.10.11 you may want to check the NEWS file to make sure your work is
present and correct.
svn path=/trunk/; revision=15071
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 8781 |
1 files changed, 5369 insertions, 3412 deletions
@@ -1,5761 +1,7718 @@ ------------------------------------------------------------------------ -r13684 | ulfl | 2005-03-09 17:00:21 -0600 (Wed, 09 Mar 2005) | 1 line +r14280 | gerald | 2005-05-02 16:56:40 -0500 (Mon, 02 May 2005) | 27 lines Changed paths: - M /trunk/epan/dissectors/packet-bssgp.c - M /trunk/epan/dissectors/packet-dtp.c - M /trunk/epan/dissectors/packet-fcp.c - M /trunk/epan/dissectors/packet-iscsi.c - M /trunk/gtk/stats_tree_stat.c + M /trunk/epan/dissectors/packet-dcm.c + +From Rich Coe: + + - fix memory leak when Assoc packet is processed repeatedly in ethereal + + - removed unused partial packet flag + + - added better support for DICOM VR + - sequences + - report actual VR in packet display, if supplied by xfer syntax + - show that we are not displaying entire tag string with '[...]', + some tags can hold up to 2^32-1 chars + + - remove my goofy attempt at trying to get access to the fragmented packets + (anyone have an idea on how to fix this ???) + + - process all the data in the Assoc packet even if display is off + + - limit display of data in Assoc packet to defined size of the data even + if reported size is larger + + - show the last tag in a packet as [incomplete] if we don't have all the data + + - added framework for reporting DICOM async negotiation (not finished) + (I'm not aware of an implementation which currently supports this) + + - still need to fix display of continuation packets -removed some MSVC compiler warnings, mostly I've casted "downsized function parameters" ------------------------------------------------------------------------ -r13683 | obiot | 2005-03-09 13:52:58 -0600 (Wed, 09 Mar 2005) | 4 lines +r14282 | tuexen | 2005-05-02 17:15:00 -0500 (Mon, 02 May 2005) | 2 lines Changed paths: - M /trunk/plugins/xml/packet-xml.c + M /trunk/Makefile.am -Remove duplicate media types and add XML media types from packet-text-media.c. +Get profinet compiling on Unix. -NOTE: we need to make sure that all the media types registered in the XML dissector get registered with the line-based text dissector as a fall-back when the XML dissector is disabled. +------------------------------------------------------------------------ +r14283 | lroland | 2005-05-02 19:19:08 -0500 (Mon, 02 May 2005) | 2 lines +Changed paths: + M /trunk/plugins/megaco/packet-megaco.c +add another lenght check in the megaco dissector. +Fixes bug 150. ------------------------------------------------------------------------ -r13682 | gerald | 2005-03-09 13:43:29 -0600 (Wed, 09 Mar 2005) | 3 lines +r14284 | lroland | 2005-05-02 20:03:33 -0500 (Mon, 02 May 2005) | 11 lines Changed paths: - M /trunk/epan/dissectors/packet-spnego.c + M /trunk/Makefile.nmake + M /trunk/doc/Makefile.nmake + M /trunk/plugins/Makefile.nmake + +add the new target "install-plugins" to nmake makefile +in the plugins subdirectory. This target will copy all plugins to plugins/$(VERSION), thus (t)ethereal will +find and load the plugins when called from within the source tree. + +call this target from the main nmake makefile after +installing other dependencies. call it from the nmake makefile +in the doc subdirectory before calling "tethereal -G". +This way "tethereal -G" will recognize the filterable +fields from the plugins, too. -Add a couple of definitions not present in MIT Kerberos. Fix a compiler -warning. ------------------------------------------------------------------------ -r13681 | guy | 2005-03-09 06:30:41 -0600 (Wed, 09 Mar 2005) | 3 lines +r14285 | ulfl | 2005-05-02 20:39:00 -0500 (Mon, 02 May 2005) | 1 line Changed paths: - M /trunk/AUTHORS - M /trunk/ethereal_gen.py + M /trunk/epan/dissectors/Makefile.common + D /trunk/epan/dissectors/packet-pn-dcp.c + M /trunk/plugins/profinet/Makefile.am + M /trunk/plugins/profinet/Makefile.nmake + A /trunk/plugins/profinet/packet-pn-dcp.c (from /trunk/epan/dissectors/packet-pn-dcp.c:14278) + M /trunk/plugins/profinet/profinet.c + +move the pn-dcp dissector into the profinet plugin +------------------------------------------------------------------------ +r14286 | gram | 2005-05-02 21:07:26 -0500 (Mon, 02 May 2005) | 2 lines +Changed paths: + M /trunk/tap-httpstat.c + M /trunk/tap-sipstat.c -From Jaap Keuter: update ethereal_gen.py to generate new-style plugin -dissectors. +Fix typos in error messages. ------------------------------------------------------------------------ -r13680 | sahlberg | 2005-03-09 05:59:40 -0600 (Wed, 09 Mar 2005) | 4 lines +r14287 | etxrab | 2005-05-03 00:22:43 -0500 (Tue, 03 May 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/packet-9p.c -refactor the code to not use heimdal functions to decrypt and unwrap the blob. -use builtin functrions instead which will make it trivial to add this support to mit later +From Nils O. Sel?sdal: + +- Decodes all the remaining bitfields in 9P +- Tidies up display a bit (using more subtrees) +- Fixes a few fields that are better off displayed as decimal/octal. ------------------------------------------------------------------------ -r13679 | guy | 2005-03-09 04:57:58 -0600 (Wed, 09 Mar 2005) | 13 lines +r14288 | tuexen | 2005-05-03 03:34:11 -0500 (Tue, 03 May 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dtp.c + M /trunk/gtk/sctp_stat.c -Set the eol-style and keywords properties. +Base the assoc search on port/vtags only. -Use "tvb_reported_length_remaining()", not "tvb_length_remaining()", in -the loop parsing the packet contents, so we throw an exception on a -short frame (to mark that it *is* a short frame). +------------------------------------------------------------------------ +r14289 | gerald | 2005-05-03 09:36:08 -0500 (Tue, 03 May 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-tcap.c -Use "tvb_format_text()" for text strings, so we don't have a problem -with non-printable characters. +Fix two places where we might loop infinitely, including the one found in +bug 155. Fix a couple of compiler warnings. -Use "ether_to_str()" to turn MAC addresses into strings. +------------------------------------------------------------------------ +r14298 | gerald | 2005-05-03 13:43:06 -0500 (Tue, 03 May 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-pres.c -Clean up indentation. +Back out all of the tvb_ensure_bytes_exist() calls. They shouldn't be +neccessary any more, and were causing problems. ------------------------------------------------------------------------ -r13678 | guy | 2005-03-09 04:43:34 -0600 (Wed, 09 Mar 2005) | 7 lines +r14299 | gerald | 2005-05-03 14:33:02 -0500 (Tue, 03 May 2005) | 3 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/NEWS + M /trunk/epan/proto.c -From Vladimir Kondratiev: +In proto_tree_set_string(), don't set a null fvalue or Ethereal will throw +a hissy fit. Fixes bug 157. -- better parsing for TIM info element: it parses 'bitmap control' byte -and provides list of AID for stations having power saving traffic. -- separate names for TIM elements. It helps to higlight beacons with -some properties, for example DTIM ones (dtim_count==0). +------------------------------------------------------------------------ +r14301 | ulfl | 2005-05-03 14:58:05 -0500 (Tue, 03 May 2005) | 1 line +Changed paths: + M /trunk/plugins/profinet/packet-dcerpc-pn-io.c +add a *lot* more dissections of the various PN-IO blocks ------------------------------------------------------------------------ -r13677 | guy | 2005-03-09 04:29:59 -0600 (Wed, 09 Mar 2005) | 2 lines +r14302 | etxrab | 2005-05-03 15:53:21 -0500 (Tue, 03 May 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-uma.c -Comment out a routine that's not currently being used. +Dissect GPRS user data. +------------------------------------------------------------------------ +r14303 | girlich | 2005-05-04 08:09:46 -0500 (Wed, 04 May 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-rpc.h + +Added RPC/ONC SYSTEM_ERROR accept state. ------------------------------------------------------------------------ -r13676 | guy | 2005-03-09 04:24:34 -0600 (Wed, 09 Mar 2005) | 2 lines +r14304 | gerald | 2005-05-04 10:35:21 -0500 (Wed, 04 May 2005) | 6 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-cdp.c + M /trunk/epan/dissectors/packet-pres.c + +Don't roll our own buffer-overflow-able string_to_hex() routine +when there's a perfectly good tvb_bytes_to_str() lying around, just +_begging_ to be used. -From Ricardo Muggli: decode the voice VLAN field in CDP packets. +Fix up white space. ------------------------------------------------------------------------ -r13675 | guy | 2005-03-09 04:12:05 -0600 (Wed, 09 Mar 2005) | 3 lines +r14305 | gerald | 2005-05-04 11:40:30 -0500 (Wed, 04 May 2005) | 4 lines Changed paths: - M /trunk/gtk/voip_calls_dlg.c + M /trunk/epan/dissectors/packet-rtp.c + +From Lars Roland: -From Francisco Alcoba: don't generate long filter expressions, fall back -to the old filter mechanism if the filter expression is too long. +Make sure a hash table exists before trying to access it. Fixes bug 105. ------------------------------------------------------------------------ -r13674 | ulfl | 2005-03-09 01:51:07 -0600 (Wed, 09 Mar 2005) | 1 line +r14306 | gerald | 2005-05-04 12:02:56 -0500 (Wed, 04 May 2005) | 4 lines Changed paths: - M /trunk/file.c + M /trunk/epan/dissectors/packet-smb.c + +Don't try to feed a null pointer to strncmp(). Fixes bug 158. +Shouldn't the number of fuzz bugs decrease asymptotically at some +point? -bugfix in PSML export output: the epan API slightly changed, epan_dissect_fill_in_columns must be called now to fill in column data. This resulted in missing values in PSML output. ------------------------------------------------------------------------ -r13673 | sahlberg | 2005-03-09 01:29:52 -0600 (Wed, 09 Mar 2005) | 4 lines +r14311 | guy | 2005-05-05 04:40:24 -0500 (Thu, 05 May 2005) | 3 lines Changed paths: - M /trunk/epan/crypt-md5.c - M /trunk/epan/crypt-md5.h + M /trunk/epan/to_str.c + M /trunk/epan/to_str.h -add helper to compute the md5 hmac +"oid_to_str()" and "oid_to_str_buf()" don't modify what the "oid" +argument points to, so make it a "const" pointer. +------------------------------------------------------------------------ +r14312 | guy | 2005-05-05 05:00:29 -0500 (Thu, 05 May 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-sctp.c +Re-parenthesize an expression, to squelch a compiler warning. ------------------------------------------------------------------------ -r13672 | guy | 2005-03-08 21:15:59 -0600 (Tue, 08 Mar 2005) | 2 lines +r14313 | guy | 2005-05-05 06:02:31 -0500 (Thu, 05 May 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-pgsql.c + M /trunk/epan/dissectors/packet-eth.c -Updates from Abhijit Menon-Sen. +Squelch a compiler warning. ------------------------------------------------------------------------ -r13671 | guy | 2005-03-08 21:04:46 -0600 (Tue, 08 Mar 2005) | 2 lines +r14314 | guy | 2005-05-05 06:03:46 -0500 (Thu, 05 May 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-kink.c + M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-bacapp.h -Fix the properties. +Change data types to match those of "iconv()", at least on OS X. ------------------------------------------------------------------------ -r13670 | guy | 2005-03-08 21:03:10 -0600 (Tue, 08 Mar 2005) | 2 lines +r14315 | guy | 2005-05-05 06:05:15 -0500 (Thu, 05 May 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/packet-dcm.c -Squelch some compiler warnings if we don't have Kerberos. +Change some data types, and add initializations, to squelch compiler +warnings. + +Fix indentation. ------------------------------------------------------------------------ -r13669 | guy | 2005-03-08 20:39:31 -0600 (Tue, 08 Mar 2005) | 2 lines +r14316 | guy | 2005-05-05 06:06:08 -0500 (Thu, 05 May 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-kink.c + M /trunk/gtk/smb_stat.c -"time_t", not "timer_t". +Fix a test (bug found by a compiler warning). ------------------------------------------------------------------------ -r13668 | sahlberg | 2005-03-08 17:47:29 -0600 (Tue, 08 Mar 2005) | 6 lines +r14317 | guy | 2005-05-05 06:07:22 -0500 (Thu, 05 May 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-spnego.c + M /trunk/gtk/voip_calls.c + +Don't explicitly initialize "h245_labels", as it's hard to initialize +all of it correctly, and as if you don't initialize all of it you get a +compiler warning. -use the rc4 functions from epan/crypt-rc4 instead of those in heimdal -so that we dont have to include <rc4.h> from heimdal +Add an assignment to squelch a compiler warning. -hopefully the build on freebsd will succeed now +------------------------------------------------------------------------ +r14318 | guy | 2005-05-05 06:08:20 -0500 (Thu, 05 May 2005) | 2 lines +Changed paths: + M /trunk/plugins/profinet/packet-dcerpc-pn-io.c +Fix a call to dereference a pointer (found by a compiler warning). ------------------------------------------------------------------------ -r13667 | sahlberg | 2005-03-08 16:32:43 -0600 (Tue, 08 Mar 2005) | 5 lines +r14319 | sahlberg | 2005-05-05 08:48:34 -0500 (Thu, 05 May 2005) | 3 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-kink.c + M /trunk/tethereal.c -New protocol : KINK +make tethereal compile when plugins are disabled -From Taekshi Nakashima the KINK protocol +------------------------------------------------------------------------ +r14320 | ulfl | 2005-05-05 10:25:04 -0500 (Thu, 05 May 2005) | 1 line +Changed paths: + M /trunk/packaging/nsis/Makefile.am +add GetWindowsVersion.nsh to the additional packaging files ------------------------------------------------------------------------ -r13666 | sahlberg | 2005-03-08 15:36:04 -0600 (Tue, 08 Mar 2005) | 3 lines +r14321 | jmayer | 2005-05-05 12:07:58 -0500 (Thu, 05 May 2005) | 1 line Changed paths: - M /trunk/acinclude.m4 + M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/packet-diameter-defs.h + M /trunk/epan/dissectors/packet-eapol.c + M /trunk/epan/dissectors/packet-ppp.c + M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-retix-bpdu.c + M /trunk/epan/dissectors/packet-sflow.c + M /trunk/epan/dissectors/packet-vlan.c -we dont need to link with gssapi.a any more +Change 802.11f -> F, 802.1d -> D, 802.1x -> X, 802.1q -Q, 802.1P -> p +------------------------------------------------------------------------ +r14322 | gram | 2005-05-05 20:56:40 -0500 (Thu, 05 May 2005) | 5 lines +Changed paths: + M /trunk/epan/dissectors/packet-bootp.c +Check the offset delta while we loop through the options. +Make sure the delta is > 0. +This intends to fix bug 160, although with a capture file +to test it, I can't be totally sure. ------------------------------------------------------------------------ -r13665 | sahlberg | 2005-03-08 15:13:14 -0600 (Tue, 08 Mar 2005) | 3 lines +r14323 | gram | 2005-05-05 21:08:30 -0500 (Thu, 05 May 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/packet-bootp.c -remove some dependencies of libgssapi +A fix for the previous fix for the infinite loop in bootp, bug #160. + +------------------------------------------------------------------------ +r14324 | sahlberg | 2005-05-06 05:11:08 -0500 (Fri, 06 May 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-ypserv.c + +prettify YPSERV ------------------------------------------------------------------------ -r13664 | sahlberg | 2005-03-08 14:22:07 -0600 (Tue, 08 Mar 2005) | 3 lines +r14325 | lroland | 2005-05-06 19:14:11 -0500 (Fri, 06 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/packet-osi-options.c -remove the need to include <gssapi.h> from heimdal +Increase size of an integer to prevent an integer overflow +Fixes Bug 162 +------------------------------------------------------------------------ +r14326 | ulfl | 2005-05-07 15:47:39 -0500 (Sat, 07 May 2005) | 1 line +Changed paths: + M /trunk/Makefile.am + M /trunk/gtk/compat_macros.h + M /trunk/gtk/menu.c + M /trunk/gtk/toolbar.c + A /trunk/image/toolbar/file_set_list_16.xpm + A /trunk/image/toolbar/file_set_next_16.xpm + A /trunk/image/toolbar/file_set_previous_16.xpm +add icons for the "File Set" menu items ------------------------------------------------------------------------ -r13663 | guy | 2005-03-08 13:31:50 -0600 (Tue, 08 Mar 2005) | 2 lines +r14327 | etxrab | 2005-05-08 15:34:57 -0500 (Sun, 08 May 2005) | 3 lines Changed paths: - M /trunk/doc/README.plugins + M /trunk/asn1/camel/camel.asn + M /trunk/asn1/camel/camel.cnf + M /trunk/asn1/camel/packet-camel-template.c + M /trunk/asn1/camel/packet-camel-template.h -More editing. +From Javier Acuna: +Added some code to dissect DateAndTime. ------------------------------------------------------------------------ -r13662 | guy | 2005-03-08 13:31:01 -0600 (Tue, 08 Mar 2005) | 2 lines +r14328 | etxrab | 2005-05-08 15:35:44 -0500 (Sun, 08 May 2005) | 3 lines Changed paths: - M /trunk/doc/README.plugins + M /trunk/epan/dissectors/packet-camel.c + M /trunk/epan/dissectors/packet-camel.h -Editing. +From Javier Acuna: +Added some code to dissect DateAndTime. ------------------------------------------------------------------------ -r13661 | ulfl | 2005-03-08 13:03:09 -0600 (Tue, 08 Mar 2005) | 1 line +r14329 | lroland | 2005-05-08 16:17:37 -0500 (Sun, 08 May 2005) | 1 line Changed paths: - M /trunk/doc/README.plugins + M /trunk/epan/dissectors/packet-sip.c -from jaap keuter: add info how to update from old to new style plugin registering +Reindent dissect_sip_common() and remove trailing white spaces from packet-sip.c. ------------------------------------------------------------------------ -r13660 | sahlberg | 2005-03-08 03:46:24 -0600 (Tue, 08 Mar 2005) | 8 lines +r14330 | lroland | 2005-05-08 17:19:18 -0500 (Sun, 08 May 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-ldap.c + M /trunk/epan/dissectors/packet-sip.c + +Improve dissection of SIP contact header and counting of bindings in REGISTER messages. -If ethereal is linked with HEIMDAL -and Kerberos decryption is enabled in preferences -and if we have the keytab file available +Introduce a function for disseting a sip uri in general -then attempt to decrypt Secure LDAP +TODO: +- add dissection of contact and uri parameters +- simplify the ugly code for dissecting "to" and "from" headers + by using the new function for uri dissection +------------------------------------------------------------------------ +r14331 | lroland | 2005-05-08 17:39:38 -0500 (Sun, 08 May 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-sip.c + +When saying that I remove the trailing white spaces I should do it, too. + +So I do it now and do some more reindentation, too. +------------------------------------------------------------------------ +r14332 | lroland | 2005-05-08 18:29:55 -0500 (Sun, 08 May 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-sip.c +Mark a function parameter as unused +------------------------------------------------------------------------ +r14333 | lroland | 2005-05-08 19:11:03 -0500 (Sun, 08 May 2005) | 5 lines +Changed paths: + M /trunk/asn1/camel/packet-camel-template.c + M /trunk/epan/dissectors/packet-camel.c +only lower-case ASCII letters, numbers, +underscores, and dots are allowed in the +preference name. +Fix it the camel dissector. ------------------------------------------------------------------------ -r13659 | sahlberg | 2005-03-08 03:45:19 -0600 (Tue, 08 Mar 2005) | 8 lines +r14334 | lroland | 2005-05-08 20:15:45 -0500 (Sun, 08 May 2005) | 1 line Changed paths: - M /trunk/acinclude.m4 - M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/packet-sip.c -when HEIMDAL is linked with : -make spnego able to decrypt data wrapped inside - GSSAPI/SPNEGO/KRB5 arcfour-hmac +Some fixes for the new SIP contact header parser. +------------------------------------------------------------------------ +r14335 | lroland | 2005-05-08 20:21:41 -0500 (Sun, 08 May 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-sip.c -This code will be more etherealified and evolve into being able to link with MIT as well. +Add another sanity check to the new SIP URI parser. +Just to be sure. +------------------------------------------------------------------------ +r14336 | jmayer | 2005-05-09 06:21:16 -0500 (Mon, 09 May 2005) | 5 lines +Changed paths: + M /trunk/epan/dissectors/packet-hpsw.c +I just found a packet with an option e. As the value looked very much +like the mac-address of the switch, I added decoding of option e as +mac address. ------------------------------------------------------------------------ -r13658 | sahlberg | 2005-03-08 03:43:36 -0600 (Tue, 08 Mar 2005) | 3 lines +r14337 | gerald | 2005-05-09 22:08:36 -0500 (Mon, 09 May 2005) | 4 lines Changed paths: - M /trunk/epan/packet.c - M /trunk/epan/packet_info.h + M /trunk/epan/dissectors/packet-ldap.c -gssapi decryption nees a few new fields to pass the blobs from application layer dissector all the way down to spnego or friends and back. +Make sure we don't feed a null string to strncmp(). Fixes bug 161. +Make sure we don't free static memory. Fix a small memory leak. ------------------------------------------------------------------------ -r13657 | lroland | 2005-03-07 16:31:13 -0600 (Mon, 07 Mar 2005) | 1 line +r14338 | gerald | 2005-05-09 22:10:09 -0500 (Mon, 09 May 2005) | 2 lines Changed paths: - M /trunk/packaging/nsis/Makefile.nmake - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/epan/dissectors/packet-smb-pipe.c + +Make a field type check more strict. Remove some unnecessary code. -add xml and stats_tree plugin to the installer. ------------------------------------------------------------------------ -r13656 | lroland | 2005-03-07 15:40:29 -0600 (Mon, 07 Mar 2005) | 1 line +r14339 | sahlberg | 2005-05-10 03:49:27 -0500 (Tue, 10 May 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-pn-rt.c - M /trunk/plugins/mate/mate.h - M /trunk/plugins/mate/mate_plugin.c - M /trunk/plugins/stats_tree/stats_tree_plugin.c - M /trunk/plugins/xml/xml_plugin.c + M /trunk/epan/dissectors/packet-snmp.c + +make SNMP over UDP a new style dissector and add some heuristics to check if this is SNMP or not, -remove remnants of the old plugin api from dissectors and plugins ------------------------------------------------------------------------ -r13655 | lroland | 2005-03-07 15:11:34 -0600 (Mon, 07 Mar 2005) | 2 lines +r14340 | etxrab | 2005-05-10 15:02:14 -0500 (Tue, 10 May 2005) | 1 line Changed paths: - M /trunk/gtk/stats_tree_stat.c + M /trunk/asn1/gsmmap/gsmmap.cnf -add a default size to stats_tree windows. so we do not have to resize them everytime. +fix some field rename errors turned up by the latest asn2eth compiler. +------------------------------------------------------------------------ +r14341 | etxrab | 2005-05-10 15:06:04 -0500 (Tue, 10 May 2005) | 1 line +Changed paths: + M /trunk/asn1/gsmmap/GSMMAP.asn + M /trunk/asn1/gsmmap/packet-gsm_map-template.c +Fix dissection of mt-forwardSM. ------------------------------------------------------------------------ -r13654 | lroland | 2005-03-07 14:31:35 -0600 (Mon, 07 Mar 2005) | 1 line +r14342 | etxrab | 2005-05-10 15:09:09 -0500 (Tue, 10 May 2005) | 1 line Changed paths: - M /trunk/plugins/stats_tree/Makefile.nmake + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-gsm_map.h -set SVN keyword ID +Fix dissection of mo-forwardSM ------------------------------------------------------------------------ -r13653 | lroland | 2005-03-07 14:25:09 -0600 (Mon, 07 Mar 2005) | 1 line +r14343 | lego | 2005-05-10 16:54:37 -0500 (Tue, 10 May 2005) | 5 lines Changed paths: - M /trunk/plugins/stats_tree/Makefile.nmake + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/dissectors/packet-isup.h + +- export Audio Codec modes from isup/bicc +- detailed dissection of GSM/UMTS speech code list ETSI 126 103 (3gpp 26.103 v3.0.0) +- use it for H.248 + -fix clean target ------------------------------------------------------------------------ -r13652 | etxrab | 2005-03-07 14:11:03 -0600 (Mon, 07 Mar 2005) | 1 line +r14344 | gerald | 2005-05-10 18:45:39 -0500 (Tue, 10 May 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-g723.c + M /trunk/plugins/agentx/packet-agentx.c + +Don't write a '\0' way the heck past the end of an array. Fixes bug 164. + +Add a comment asking if we shouldn't use oid_to_str() instead of our own +routine. -Add a g723 dissector to dissect the first byte to find the rate and if speech is pressent or not. ------------------------------------------------------------------------ -r13651 | lego | 2005-03-07 13:10:21 -0600 (Mon, 07 Mar 2005) | 15 lines +r14345 | sahlberg | 2005-05-11 05:40:53 -0500 (Wed, 11 May 2005) | 17 lines Changed paths: - M /trunk/gtk/graph_analysis.c - M /trunk/gtk/voip_calls.c - M /trunk/gtk/voip_calls.h + M /trunk/doc/README.developer + M /trunk/epan/conversation.c + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-tftp.c + M /trunk/epan/dissectors/packet-udp.c + M /trunk/epan/packet.c + M /trunk/epan/packet.h + +Some applications do very naughty things like reusing a port for a different protocol during different stages of an application cycle. + +This is very naughty and will cause problems when we have assigned a dissector to a dynamic port using conversation_set_dissector(). -From Alejandro Vaqero: - - Fix a problem when pressing a key when the "Graph" is displayed -without any frame selected. +To make ethereal handle this case I have changed the try_conversation_dissector() to allow it to fail and return 0, meaning yes there is indeed a protocol registered for this conversation but that protocol rejected this packet. +(which only happens for "new" style dissectors, "old" style dissectors will never reject a packet that way) - - Add support for RTP Payload changes. Now the graph will show any -change in the RTP payload type. This is useful for example to show DTMF -2833 in a call. +When this happens the decode_udp_port() helper will still allow other dissectors to be tried, in the hope that the conversation is now used for some other protocol and thus someone else might be able to decode the packet. + + +Update SNMP and TFTP dissectors to check that even if there already is a conversation but that conversation does NOT have snmp/tftp registered as the dissector for it, then create a new conversation anyway and attach the proper dissector. + +Since ethereal keeps track of which frame number a conversation started in, this actually works really well. --This line, and those below, will be ignored-- -M gtk/graph_analysis.c -M gtk/voip_calls.c -M gtk/voip_calls.h ------------------------------------------------------------------------ -r13650 | lego | 2005-03-07 05:35:52 -0600 (Mon, 07 Mar 2005) | 5 lines +r14346 | sahlberg | 2005-05-11 06:24:17 -0500 (Wed, 11 May 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-radius.c - M /trunk/epan/sminmpec.c - M /trunk/epan/sminmpec.h + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-juniper.c + M /trunk/wiretap/libpcap.c + M /trunk/wiretap/wtap.c + M /trunk/wiretap/wtap.h -From Florian Lohoff: +From Hannes Gredler +support for Juniper PPPOE encapsulation -Add Netscreen vendor specific attributes +------------------------------------------------------------------------ +r14347 | sahlberg | 2005-05-11 07:37:20 -0500 (Wed, 11 May 2005) | 2 lines +Changed paths: + M /trunk/gtk/sctp_graph_dlg.c + +avoid a div-by-0 ------------------------------------------------------------------------ -r13649 | lego | 2005-03-07 05:01:16 -0600 (Mon, 07 Mar 2005) | 6 lines +r14348 | etxrab | 2005-05-11 16:46:16 -0500 (Wed, 11 May 2005) | 1 line Changed paths: - M /trunk/gtk/voip_calls_dlg.c + M /trunk/asn1/gsmmap/gsmmap.cnf -From Francisco Alcoba: +pinfo->p2p_dir not set in the new gsm_map dissector causing problems with dissection of SMS messages. +------------------------------------------------------------------------ +r14349 | etxrab | 2005-05-11 16:59:44 -0500 (Wed, 11 May 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-gsm_sms.c + +From Viorel Suman: +Enable a proper deconding of an alphanumeric 7-bit encoded SMS TP-Originating-Address. - - Correct the order of the calls in the VoIP Calls dialog when ordering by time fields - - Prevent an assertion when ordering on the last columns +------------------------------------------------------------------------ +r14350 | etxrab | 2005-05-11 17:00:50 -0500 (Wed, 11 May 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-gsm_map.c +pinfo->p2p_dir not set in the new gsm_map dissector causing problems with dissection of SMS messages. ------------------------------------------------------------------------ -r13648 | jmayer | 2005-03-07 04:19:33 -0600 (Mon, 07 Mar 2005) | 4 lines +r14351 | etxrab | 2005-05-11 17:19:36 -0500 (Wed, 11 May 2005) | 1 line Changed paths: - M /trunk/capture.h - M /trunk/gtk/capture_info_dlg.c - M /trunk/gtk/main.c - M /trunk/gtk/summary_dlg.c - M /trunk/summary.h - M /trunk/tethereal.c + M /trunk/asn1/gsmmap/packet-gsm_map-template.c -- pcap.h needs to be included before capture.h -- As capture.h is empty without libpcap defined, only include it in that - case and don't protect the file internally against libpcap any more. +Reinsert Gerards patch (r14342) which was lost. +------------------------------------------------------------------------ +r14352 | etxrab | 2005-05-11 17:20:11 -0500 (Wed, 11 May 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-gsm_map.c +Reinsert Gerards patch (r14342) which was lost. ------------------------------------------------------------------------ -r13647 | jmayer | 2005-03-07 04:15:03 -0600 (Mon, 07 Mar 2005) | 1 line +r14353 | guy | 2005-05-11 21:50:27 -0500 (Wed, 11 May 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/addr_resolv.c + +Always set "*success" in "ipxnet_addr_lookup()" before returning (thanks +and a tip of the hat to GCC 4.0's interprocedural data flow analysis for +catching this one!). -Fix a small typo that would prevent compilation with MIT Kerberos ------------------------------------------------------------------------ -r13646 | sahlberg | 2005-03-07 03:02:33 -0600 (Mon, 07 Mar 2005) | 3 lines +r14354 | guy | 2005-05-11 21:51:59 -0500 (Wed, 11 May 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-kerberos.h + M /trunk/epan/dissectors/packet-ndmp.c -export some symbols we will need later. +Fix a routine to return the value it's supposed to return. + +------------------------------------------------------------------------ +r14355 | guy | 2005-05-11 21:55:59 -0500 (Wed, 11 May 2005) | 6 lines +Changed paths: + M /trunk/epan/dissectors/packet-sip.c +Squelch a compiler warning (GCC 4.0's data flow analysis is +interprocedural, so it knows "sip_parse_line()" doesn't always set +"*token_1_len", but it doesn't know that if it doesn't return OTHER_LINE +it *does* always set it, so it's safe not to set it as long as it's +never used if the return value is OTHER_LINE). ------------------------------------------------------------------------ -r13645 | jmayer | 2005-03-07 02:47:48 -0600 (Mon, 07 Mar 2005) | 11 lines +r14356 | guy | 2005-05-11 22:29:26 -0500 (Wed, 11 May 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/gtk/drag_and_drop.c -Make packet-kerberos.c compile again: +If we have libpcap, include <pcap.h>, because "capture.h" requires it. -Replace the use of the undefined type krb5_keyusage (at least with heimdal) -in decrypt_krb5_data with the old int. The change wasn't complete anyway -as the .h file wasn't changed and the third implemenitation of -decrypt_krb5_data was left out also. +If we *don't* have libpcap, don't include "capture.h", and don't test +whether a capture is in progress. -Disclaimer: I only made sure it compiles again, I don't know whether the - change has any side effects. +Clean up a message. + +------------------------------------------------------------------------ +r14357 | guy | 2005-05-11 22:29:59 -0500 (Wed, 11 May 2005) | 2 lines +Changed paths: + M /trunk/tethereal.c +Don't include <pcap.h> twice. ------------------------------------------------------------------------ -r13644 | guy | 2005-03-06 20:44:41 -0600 (Sun, 06 Mar 2005) | 10 lines +r14358 | guy | 2005-05-11 22:31:33 -0500 (Wed, 11 May 2005) | 3 lines Changed paths: - M /trunk/doc/README.plugins - M /trunk/epan/plugins.c - M /trunk/epan/plugins.h - M /trunk/ethereal_gen.py - M /trunk/gtk/plugins_dlg.c - M /trunk/plugins/acn/packet-acn.c - M /trunk/plugins/agentx/packet-agentx.c - M /trunk/plugins/artnet/packet-artnet.c - M /trunk/plugins/asn1/packet-asn1.c - M /trunk/plugins/ciscosm/packet-sm.c - M /trunk/plugins/docsis/packet-docsis.c - M /trunk/plugins/enttec/packet-enttec.c - M /trunk/plugins/giop/packet-coseventcomm.c - M /trunk/plugins/giop/packet-cosnaming.c - M /trunk/plugins/gryphon/packet-gryphon.c - M /trunk/plugins/irda/packet-irda.c - M /trunk/plugins/lwres/packet-lwres.c - M /trunk/plugins/mate/mate_plugin.c - M /trunk/plugins/megaco/packet-megaco.c - M /trunk/plugins/mgcp/packet-mgcp.c - M /trunk/plugins/opsi/packet-opsi.c - M /trunk/plugins/pcli/packet-pcli.c - M /trunk/plugins/rdm/packet-rdm.c - M /trunk/plugins/rlm/packet-rlm.c - M /trunk/plugins/rtnet/packet-rtnet.c - M /trunk/plugins/rudp/packet-rudp.c - M /trunk/plugins/stats_tree/stats_tree_plugin.c - M /trunk/plugins/v5ua/packet-v5ua.c - M /trunk/plugins/xml/xml_plugin.c + M /trunk/acinclude.m4 + M /trunk/capture_loop.c -Call the "new-style init" routine for plugins a "register" routine, as -it serves the same purpose as the register routine in a built-in -dissector, and don't require all dissectors to have one, as they might -just be taps. +Use "pcap_get_selectable_fd()" if we have it, and if it returns -1, +don't do a "select()". -Get rid of the stats tree's init routine, as it's just a tap, and as it -doesn't do anything. +------------------------------------------------------------------------ +r14359 | etxrab | 2005-05-13 00:47:56 -0500 (Fri, 13 May 2005) | 1 line +Changed paths: + M /trunk/tools/Makefile.am -Update the idl2eth Python script to generate plugins with register routines. +Add the asn2eth related files to extra-dist (I hope this is the right thing to do to get them into the SVN tarballs). +------------------------------------------------------------------------ +r14360 | etxrab | 2005-05-13 00:50:26 -0500 (Fri, 13 May 2005) | 1 line +Changed paths: + M /trunk/tools/Makefile.am +Forgott the lex.py file ------------------------------------------------------------------------ -r13643 | guy | 2005-03-06 19:22:55 -0600 (Sun, 06 Mar 2005) | 4 lines +r14361 | lego | 2005-05-13 06:16:05 -0500 (Fri, 13 May 2005) | 4 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/asn1/h248/h248.cnf + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/epan/dissectors/packet-h248.c + +- make sure contextId and transactionId are added to the tree as filterable fields even if they are larger than 4 octets +- set COL_INFO to something useful -Back out the BACnet application layer dissectin code - its use of -recursion instead of iteration means that packets with sufficiently -large lists can cause it to overflow the stack and crash. ------------------------------------------------------------------------ -r13642 | sahlberg | 2005-03-06 16:52:58 -0600 (Sun, 06 Mar 2005) | 3 lines +r14362 | gram | 2005-05-13 14:44:25 -0500 (Fri, 13 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-spnego.c + M /trunk/wiretap/libpcap.c + M /trunk/wiretap/wtap.h + +Add WTAP_GCOM_TIE1 and WTAP_GCOM_SERIAL for +Oolan Zimmer <ethereal@gcom.com> + +------------------------------------------------------------------------ +r14363 | sahlberg | 2005-05-14 12:12:45 -0500 (Sat, 14 May 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-scsi.c -minor update, add an extra parameter to a call to prepare for decryption of GSSAPI wrapped data +add a missing field to the REPORT LUNS datain pdu ------------------------------------------------------------------------ -r13641 | sahlberg | 2005-03-06 16:34:13 -0600 (Sun, 06 Mar 2005) | 3 lines +r14364 | sahlberg | 2005-05-14 12:41:07 -0500 (Sat, 14 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-kerberos.h + M /trunk/epan/dissectors/packet-scsi.c -export decrypt_krb5_data +add decoding of teh REMOVABLE bit in inquiry data ------------------------------------------------------------------------ -r13640 | guy | 2005-03-06 16:14:24 -0600 (Sun, 06 Mar 2005) | 14 lines +r14365 | gerald | 2005-05-14 14:13:02 -0500 (Sat, 14 May 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-smb.c -The length field in the "BACnet encoding rules" is limited to 32 bits -("Data lengths larger than 2^32-1 are not encodable using primitive -tags"), so it doesn't need to be a "guint64" - but it *can* be that big, -so we should handle the 65536-2^32-1 case. +Throw an exception if AndXOffset is less than the current offset. Fixes bug +163. I'm not sure if this fix is entirely correct, but it doesn't appear to +have affected any SMB captures here adversely. -Don't gratuitously throw away the upper 24 bits of various lengths by -casting them to guint8. +------------------------------------------------------------------------ +r14366 | sahlberg | 2005-05-14 16:00:43 -0500 (Sat, 14 May 2005) | 4 lines +Changed paths: + M /trunk/AUTHORS + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-armagetronad.c -Show signed values as such. +From Guillaume Chazarain +New protocol : ARMAGETRONAD dissector for the protcol used by the game of the same name -Don't use "match_strval()" - it returns a null pointer if it doesn't -find the value in the value_string table; instead, use "val_to_str()" so -we don't blow up if the value isn't found. ------------------------------------------------------------------------ -r13639 | lego | 2005-03-06 15:57:25 -0600 (Sun, 06 Mar 2005) | 4 lines +r14367 | sahlberg | 2005-05-14 16:08:20 -0500 (Sat, 14 May 2005) | 4 lines Changed paths: - M /trunk/plugins/xml/packet-xml.c - M /trunk/plugins/xml/xml_lexer.c - M /trunk/plugins/xml/xml_lexer.l + M /trunk/epan/dissectors/packet-fcswils.c -- Add some media types to be dissected as xml -- be more tollerant on how an XML document should look like +from dinesh +fix to make Zone_Alias objects decode properly ------------------------------------------------------------------------ -r13638 | lego | 2005-03-06 15:32:13 -0600 (Sun, 06 Mar 2005) | 3 lines +r14368 | gerald | 2005-05-14 16:13:07 -0500 (Sat, 14 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-ieee8023.c + +When we catch an exception, make sure we don't throw the same exception again +(and catch it again in the process). Fixes bug 170. + +------------------------------------------------------------------------ +r14369 | sahlberg | 2005-05-14 17:05:56 -0500 (Sat, 14 May 2005) | 5 lines +Changed paths: + M /trunk/epan/dissectors/packet-dcerpc.c -Add a preference for another alternate tcp port +from martin m + +prettify dcerpc ------------------------------------------------------------------------ -r13637 | etxrab | 2005-03-06 14:54:01 -0600 (Sun, 06 Mar 2005) | 1 line +r14370 | etxrab | 2005-05-15 16:15:53 -0500 (Sun, 15 May 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-amr.c + M /trunk/asn1/gsmmap/GSMMAP.asn -Fix a minor bug with FT_BOOLEAN. +From Tim Endean: +Ss-code is Optional in some cases. ------------------------------------------------------------------------ -r13636 | lego | 2005-03-06 14:43:54 -0600 (Sun, 06 Mar 2005) | 2 lines +r14371 | etxrab | 2005-05-15 16:17:29 -0500 (Sun, 15 May 2005) | 3 lines Changed paths: - M /trunk/epan/libethereal.def + M /trunk/epan/dissectors/packet-gsm_map.c - add format_text() to the plugin API + From Tim Endean: + Ss-code is Optional in some cases. ------------------------------------------------------------------------ -r13635 | guy | 2005-03-06 14:13:58 -0600 (Sun, 06 Mar 2005) | 4 lines +r14372 | etxrab | 2005-05-16 01:16:45 -0500 (Mon, 16 May 2005) | 6 lines Changed paths: - M /trunk/epan/address.h - M /trunk/epan/column-utils.c - M /trunk/epan/dissectors/packet-idp.c - M /trunk/epan/dissectors/packet-smb.c - M /trunk/epan/dissectors/packet-spp.c - M /trunk/plugins/stats_tree/pinfo_stats_tree.c + M /trunk/epan/dissectors/packet-rdt.c + +From Martin Mathieson: +new version of the RDT dissector. It turns out that +specs are available for this protocol on www.helixcommunity.org - this +version was written by myself and Tom Marshall of RealNetworks, Inc. + +I Changed stream_id and asm_rule_number to be guint16 to fix compiler warnings. +------------------------------------------------------------------------ +r14373 | lego | 2005-05-16 08:28:35 -0500 (Mon, 16 May 2005) | 5 lines +Changed paths: + M /trunk/plugins/mate + M /trunk/plugins/mate/Makefile.am + M /trunk/plugins/mate/mate.h + A /trunk/plugins/mate/mate_grammar.lemon + A /trunk/plugins/mate/mate_parser.l + M /trunk/plugins/mate/mate_plugin.c + M /trunk/plugins/mate/mate_runtime.c + M /trunk/plugins/mate/mate_setup.c + M /trunk/plugins/mate/mate_util.c + M /trunk/plugins/mate/mate_util.h + M /trunk/plugins/mate/moduleinfo.h + M /trunk/plugins/mate/packet-mate.c -Handle XNS IDP socket numbers. +MATE has a grammar. + +Although not yet fully implemented I want this version as a reference. -Handle SMB-over-SPP. ------------------------------------------------------------------------ -r13634 | guy | 2005-03-06 13:37:09 -0600 (Sun, 06 Mar 2005) | 4 lines +r14374 | lego | 2005-05-16 09:59:14 -0500 (Mon, 16 May 2005) | 3 lines Changed paths: - M /trunk/epan/epan.h - M /trunk/epan/plugins.c + M /trunk/plugins/mate/Makefile.nmake + +Forgot this one in the last checkin! -"report_err.h" declares "report_failure()", so it doesn't need to be -declared in "epan.h", and, as "epan/plugins.c" now includes -"report_err.h", it doesn't need to include "epan.h". ------------------------------------------------------------------------ -r13633 | lego | 2005-03-06 12:30:59 -0600 (Sun, 06 Mar 2005) | 2 lines +r14375 | lego | 2005-05-16 10:10:50 -0500 (Mon, 16 May 2005) | 3 lines Changed paths: - M /trunk/plugins/xml/xml_lexer.c - M /trunk/plugins/xml/xml_lexer.l + M /trunk/plugins/mate/Makefile.nmake + +let's get things right, we are in plugins/mate not epan/dfilter (from which I stole the nmake rules) -- get rid of some warnings ------------------------------------------------------------------------ -r13632 | lego | 2005-03-06 12:02:27 -0600 (Sun, 06 Mar 2005) | 3 lines +r14376 | lego | 2005-05-16 12:16:52 -0500 (Mon, 16 May 2005) | 3 lines Changed paths: - M /trunk/plugins/stats_tree/http_stats_tree.c + M /trunk/plugins/mate/mate.h + M /trunk/plugins/mate/mate_plugin.c + M /trunk/plugins/mate/mate_runtime.c + M /trunk/plugins/mate/mate_setup.c + M /trunk/plugins/mate/mate_util.c + M /trunk/plugins/mate/mate_util.h -- use the string id of the node, not the integer id in tick_stat_node +Transforms and Pdus are working already, Gops start to work. ------------------------------------------------------------------------ -r13631 | lego | 2005-03-06 11:06:55 -0600 (Sun, 06 Mar 2005) | 3 lines +r14377 | etxrab | 2005-05-16 13:15:33 -0500 (Mon, 16 May 2005) | 1 line Changed paths: - M /trunk/epan/stats_tree.c + M /trunk/epan/dissectors/packet-text-media.c -- replace tabs with spaces while printing -- get rid of a warning in windows compile +Add some more media types. +------------------------------------------------------------------------ +r14378 | etxrab | 2005-05-16 13:24:27 -0500 (Mon, 16 May 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-http.c +Add TCP port for "radan-http 8088/tcp Radan HTTP" from IANA. ------------------------------------------------------------------------ -r13630 | lego | 2005-03-06 10:58:34 -0600 (Sun, 06 Mar 2005) | 3 lines +r14379 | gram | 2005-05-16 18:21:01 -0500 (Mon, 16 May 2005) | 3 lines Changed paths: - M /trunk/plugins/stats_tree/stats_tree_plugin.c + M /trunk/tools/EtherealXML.py + +Add get_hide() to return the value of the "hide" tag +in field attributes. -Forgot this in the last checkin +------------------------------------------------------------------------ +r14380 | gram | 2005-05-16 20:47:04 -0500 (Mon, 16 May 2005) | 3 lines +Changed paths: + M /trunk/tools/EtherealXML.py +Add get_items_before(), to help analyze in the presence of +tunneled protocols. ------------------------------------------------------------------------ -r13629 | lego | 2005-03-06 10:49:16 -0600 (Sun, 06 Mar 2005) | 3 lines +r14381 | lego | 2005-05-17 08:29:36 -0500 (Tue, 17 May 2005) | 3 lines Changed paths: - M /trunk/configure.in - M /trunk/plugins/Makefile.am - M /trunk/plugins/Makefile.nmake - M /trunk/plugins/stats_tree/Makefile.am - A /trunk/plugins/stats_tree/Makefile.nmake + M /trunk/plugins/mate/mate_parser.l -Add stats_tree and xml plugins to the build process +- change the state label OUT to OUTSIDE to avoid a name collision with a macro defined in the windows system headers. ------------------------------------------------------------------------ -r13628 | jmayer | 2005-03-06 04:26:00 -0600 (Sun, 06 Mar 2005) | 4 lines +r14382 | etxrab | 2005-05-17 14:13:05 -0500 (Tue, 17 May 2005) | 1 line Changed paths: - M /trunk/gtk/packet_win.c + M /trunk/plugins/xml/packet-xml.c +Add some more media types to be dissected as xml. +------------------------------------------------------------------------ +r14383 | etxrab | 2005-05-17 14:15:31 -0500 (Tue, 17 May 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-diameter-defs.h -Undo the last "fix" (13626): Unconditionally including <pcap.h> is -going to cause trouble for compilations without libpcap. +Add some more AVP:s. ------------------------------------------------------------------------ -r13627 | jmayer | 2005-03-06 04:03:53 -0600 (Sun, 06 Mar 2005) | 5 lines +r14384 | etxrab | 2005-05-17 14:21:45 -0500 (Tue, 17 May 2005) | 3 lines Changed paths: - M /trunk/gtk/menu.c + M /trunk/epan/dissectors/packet-acse.c -Warning fix: -menu.c:1841:1: warning: C++ style comments are not allowed in ISO C90 -menu.c:1841:1: warning: (this will be reported only once per input file) -(just removed it) +From Yuriy Sidelnikov: +A perfectly good tvb_bytes_to_str() has been used instead of string_to_hex. ------------------------------------------------------------------------ -r13626 | jmayer | 2005-03-06 04:02:39 -0600 (Sun, 06 Mar 2005) | 7 lines +r14385 | etxrab | 2005-05-17 14:50:38 -0500 (Tue, 17 May 2005) | 2 lines Changed paths: - M /trunk/gtk/packet_win.c + M /trunk/wiretap/nettl.c + M /trunk/wiretap/wtap.c + M /trunk/wiretap/wtap.h -Warning fix: -../capture.h:115: warning: struct pcap_stat declared inside parameter list -../capture.h:115: warning: its scope is only this definition or declaration, - which is probably not what you want -../capture.h:125: warning: struct pcap_stat declared inside parameter list +From Mark C Brown,: +Fixes for LAP-B (SX25L2) and X.25 (SX25L3) nettl trace records. +------------------------------------------------------------------------ +r14386 | etxrab | 2005-05-17 14:51:09 -0500 (Tue, 17 May 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-nettl.c +From Mark C Brown,: +Fixes for LAP-B (SX25L2) and X.25 (SX25L3) nettl trace records. +------------------------------------------------------------------------ +r14387 | etxrab | 2005-05-17 15:30:49 -0500 (Tue, 17 May 2005) | 1 line +Changed paths: + M /trunk/asn1/h245/h245.cnf + M /trunk/asn1/h245/packet-h245-template.c +Make it possible to dissect h221nonstandarddata and fix some errors from the new asn2eth generator. ------------------------------------------------------------------------ -r13625 | jmayer | 2005-03-06 03:40:58 -0600 (Sun, 06 Mar 2005) | 5 lines +r14388 | etxrab | 2005-05-17 15:32:30 -0500 (Tue, 17 May 2005) | 1 line Changed paths: - M /trunk/epan/epan.h - M /trunk/epan/plugins.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-h245.h -Warning fix: -plugins.c:236: warning: implicit declaration of function - 'report_failure' +Make it possible to dissect h221nonstandard data and fix some compile warnings from asn2eth. +------------------------------------------------------------------------ +r14389 | ulfl | 2005-05-17 19:55:44 -0500 (Tue, 17 May 2005) | 1 line +Changed paths: + M /trunk/gtk/main.c +fix #187: don't crash if using "Expand Subtrees" in an empty area, just do nothing in that case +------------------------------------------------------------------------ +r14390 | ulfl | 2005-05-17 20:21:49 -0500 (Tue, 17 May 2005) | 1 line +Changed paths: + M /trunk/fileset.c +don't crash, if the given filename doesn't contain a dot e.g. 'test123' ------------------------------------------------------------------------ -r13624 | jmayer | 2005-03-06 03:33:44 -0600 (Sun, 06 Mar 2005) | 5 lines +r14391 | etxrab | 2005-05-18 00:19:22 -0500 (Wed, 18 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-sdp.c + M /trunk/gtk/sctp_stat.c -Warning fix: -packet-sdp.c:74: warning: 'reset_sdp_packet_info' declared 'static' - but never defined +From Albert Chin: +C++ comments in C source files (gtk/sctp_stat.c) +------------------------------------------------------------------------ +r14392 | etxrab | 2005-05-18 00:44:12 -0500 (Wed, 18 May 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-h221_nonstd.c +Add a dissector for h221 nonstandard data which can easily be expanded with publically avalable data or +replaced by a propriatary one. ------------------------------------------------------------------------ -r13623 | guy | 2005-03-05 22:42:51 -0600 (Sat, 05 Mar 2005) | 2 lines +r14393 | lego | 2005-05-18 08:51:49 -0500 (Wed, 18 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ssl.c + M /trunk/epan/dissectors/packet-isup.c + +- add an isup stats_tree with statistics regarding message types and the directions in which they flow. -From Yaniv Kaul: show the protocol name in every record. ------------------------------------------------------------------------ -r13622 | guy | 2005-03-05 22:41:42 -0600 (Sat, 05 Mar 2005) | 2 lines +r14394 | ulfl | 2005-05-18 14:02:11 -0500 (Wed, 18 May 2005) | 1 line Changed paths: - M /trunk/epan/plugins.c + M /trunk/fileset.c -Squelch some compiler warnings. +do some code cleanup (from the previous commit) and close the directories opened with opendir/g_dir_open +------------------------------------------------------------------------ +r14395 | ulfl | 2005-05-18 14:30:18 -0500 (Wed, 18 May 2005) | 1 line +Changed paths: + M /trunk/gtk/menu.c + M /trunk/gtk/proto_draw.c +insensitive context menu "Expand Subtrees" if no protocol field is currently selected, sort and name the tree related menu items like the context menu ones ------------------------------------------------------------------------ -r13621 | guy | 2005-03-05 22:41:00 -0600 (Sat, 05 Mar 2005) | 2 lines +r14396 | guy | 2005-05-19 04:26:15 -0500 (Thu, 19 May 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-h221_nonstd.c -Get rid of an unused variable. +Clean up indentation. + +Add some comments with questions. + +Mark an unused argument as such, and get rid of an unused variable. ------------------------------------------------------------------------ -r13620 | lego | 2005-03-05 21:45:41 -0600 (Sat, 05 Mar 2005) | 3 lines +r14397 | etxrab | 2005-05-19 15:32:58 -0500 (Thu, 19 May 2005) | 1 line Changed paths: - M /trunk/plugins/stats_tree/stats_tree_plugin.c + M /trunk/asn1/h245/h245.cnf -oops, no new_plugin_init() now there is +Display version number and product number as strings. +------------------------------------------------------------------------ +r14398 | etxrab | 2005-05-19 15:33:59 -0500 (Thu, 19 May 2005) | 1 line +Changed paths: + M /trunk/epan/t35.c +Add Sony and Nokia VendorID:s +------------------------------------------------------------------------ +r14399 | etxrab | 2005-05-19 15:34:35 -0500 (Thu, 19 May 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-h245.c +Display version number and product number as strings. ------------------------------------------------------------------------ -r13619 | lego | 2005-03-05 21:38:25 -0600 (Sat, 05 Mar 2005) | 4 lines +r14400 | etxrab | 2005-05-19 15:35:30 -0500 (Thu, 19 May 2005) | 1 line Changed paths: - A /trunk/plugins/xml - A /trunk/plugins/xml/AUTHORS - A /trunk/plugins/xml/COPYING - A /trunk/plugins/xml/Makefile.am - A /trunk/plugins/xml/Makefile.nmake - A /trunk/plugins/xml/moduleinfo.h - A /trunk/plugins/xml/packet-xml.c - A /trunk/plugins/xml/packet-xml.h - A /trunk/plugins/xml/xml_lexer.c - A /trunk/plugins/xml/xml_lexer.l - A /trunk/plugins/xml/xml_plugin.c + M /trunk/epan/dissectors/packet-h221_nonstd.c -The first part of the XML dissector -currently just a preety-printer with some generic fields +Use value_string for codec values/strings. +------------------------------------------------------------------------ +r14401 | lego | 2005-05-20 14:38:24 -0500 (Fri, 20 May 2005) | 3 lines +Changed paths: + M /trunk/asn1/h248/h248.cnf + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/epan/dissectors/packet-h248.c + +some cosmetic fixes ------------------------------------------------------------------------ -r13618 | guy | 2005-03-05 21:38:17 -0600 (Sat, 05 Mar 2005) | 2 lines +r14402 | lego | 2005-05-20 14:40:10 -0500 (Fri, 20 May 2005) | 4 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/stats_tree.c + +dup the filter string so that it can be freed without problems. +fixes bug 195 -No, the code is the numerical value, not the vendor ID. ------------------------------------------------------------------------ -r13617 | guy | 2005-03-05 21:28:41 -0600 (Sat, 05 Mar 2005) | 2 lines +r14403 | lego | 2005-05-20 14:43:40 -0500 (Fri, 20 May 2005) | 3 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-diameter.c + M /trunk/plugins/mate/mate_parser.l + +Fix the Id tag -From Ben Turner: fix an addVendor() call. ------------------------------------------------------------------------ -r13616 | guy | 2005-03-05 21:25:19 -0600 (Sat, 05 Mar 2005) | 2 lines +r14404 | ulfl | 2005-05-20 16:40:03 -0500 (Fri, 20 May 2005) | 1 line Changed paths: - M /trunk/asn1/inap/packet-inap-template.h - M /trunk/epan/dissectors/packet-inap.h + M /trunk/packaging/nsis/ethereal.nsi -Add a newline to the end of the file. +bugfix: add the profinet plugin to NSIS +------------------------------------------------------------------------ +r14405 | ulfl | 2005-05-20 16:44:17 -0500 (Fri, 20 May 2005) | 1 line +Changed paths: + M /trunk/epan/addr_resolv.c + M /trunk/epan/addr_resolv.h + M /trunk/epan/libethereal.def +add get_manuf_name_if_known (returns NULL if unknown) in addition to get_manuf_name ------------------------------------------------------------------------ -r13615 | guy | 2005-03-05 21:19:34 -0600 (Sat, 05 Mar 2005) | 3 lines +r14406 | ulfl | 2005-05-20 17:16:47 -0500 (Fri, 20 May 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rtsp.c + M /trunk/Makefile.am + M /trunk/Makefile.nmake + A /trunk/capture_wpcap_packet.c + A /trunk/capture_wpcap_packet.h -Get rid of "unknown transport" warnings - don't spam the user just -because we haven't yet written a dissector for a particular protocol. +win32 only: get interface details from WinPcap's packet.dll (direct access to NDIS specific driver information, lower first part) +------------------------------------------------------------------------ +r14407 | ulfl | 2005-05-20 17:23:00 -0500 (Fri, 20 May 2005) | 1 line +Changed paths: + M /trunk/gtk/Makefile.am + M /trunk/gtk/Makefile.common + A /trunk/gtk/capture_if_details_dlg.c + A /trunk/gtk/capture_if_details_dlg.h + M /trunk/gtk/capture_if_dlg.c + M /trunk/gtk/main.c +win32 only: get interface details from WinPcap's packet.dll (direct access to NDIS specific driver information, upper second GTK part) ------------------------------------------------------------------------ -r13614 | guy | 2005-03-05 21:11:24 -0600 (Sat, 05 Mar 2005) | 7 lines +r14408 | ulfl | 2005-05-20 19:10:17 -0500 (Fri, 20 May 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-pgsql.c + M /trunk/capture_wpcap_packet.c + M /trunk/capture_wpcap_packet.h -Handle the "32-bit length is > 2^31-1, so the protocol tree routines -will treat it as negative" problem by first calling -"tvb_ensure_bytes_exist()" - if the length is *that* large, it will run -past the end of the tvbuff, so the exception that -"tvb_ensure_bytes_exist()" will throw with a negative argument will be -the correct exception. +don't use LPADAPTER but simply void * as we don't need to look inside the members of this struct +------------------------------------------------------------------------ +r14409 | etxrab | 2005-05-21 04:13:28 -0500 (Sat, 21 May 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-ansi_map.c +From Javier Acuna: +filter packets by their Billing ID ------------------------------------------------------------------------ -r13613 | lego | 2005-03-05 20:55:06 -0600 (Sat, 05 Mar 2005) | 2 lines +r14410 | etxrab | 2005-05-21 04:26:16 -0500 (Sat, 21 May 2005) | 5 lines Changed paths: - M /trunk/plugins/stats_tree/stats_tree_plugin.c + M /trunk/gtk/voip_calls_dlg.c + +From Javier Acuna: +It adds "CIC" info display on the comments column for ISUP +It adds a small Help button that open up a window that offers you to vist the Wiki page containing the explanation of the Dialog window. -remove plugin_init() ------------------------------------------------------------------------ -r13612 | lego | 2005-03-05 20:53:23 -0600 (Sat, 05 Mar 2005) | 2 lines +r14411 | ulfl | 2005-05-21 04:41:57 -0500 (Sat, 21 May 2005) | 1 line Changed paths: - M /trunk/plugins/mate/mate_plugin.c - -Change to new_plugin_init() + M /trunk/capture_wpcap_packet.c + M /trunk/capture_wpcap_packet.h + M /trunk/gtk/capture_if_details_dlg.c +as suggested by Loris: add wpcap_packet_get_version() and check the packet.dll version before using it (very restrictive for now, will check for exact DLL version strings). If version is unknown, ask user to continue or not. ------------------------------------------------------------------------ -r13611 | guy | 2005-03-05 20:24:49 -0600 (Sat, 05 Mar 2005) | 16 lines +r14412 | ulfl | 2005-05-21 04:59:49 -0500 (Sat, 21 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/capture-wpcap.c + M /trunk/config.h.win32 -No, they don't use BER for the variable portion of a PDU; update the -comment appropriately. +bugfix: mark pcap_freecode() as optional, as it's not available by WinPcap 2.3 -Make a bunch of routines static. +add optional pcap_next_ex() which is currently unused +------------------------------------------------------------------------ +r14413 | ulfl | 2005-05-21 06:08:48 -0500 (Sat, 21 May 2005) | 1 line +Changed paths: + M /trunk/capture-wpcap.c -Don't just dissect stuff past the end of the variable portion as data - -the protocol spec doesn't appear to say there's anything after that. +bugfix: prevent a (null pointer access) crash with very early WinPcap version < 2.3 +------------------------------------------------------------------------ +r14414 | ulfl | 2005-05-21 06:10:16 -0500 (Sat, 21 May 2005) | 1 line +Changed paths: + M /trunk/capture_wpcap_packet.c + M /trunk/gtk/capture_if_details_dlg.c -Don't pass the offset to the routines to dissect the different types of -PDUs, just have them start at 0. +don't crash if packet.dll is not available, add some more packet.dll version numbers +------------------------------------------------------------------------ +r14415 | lego | 2005-05-21 10:47:18 -0500 (Sat, 21 May 2005) | 3 lines +Changed paths: + M /trunk/plugins/mate/packet-mate.c -Use guint8 for 8-bit unsigned quantities. +PDU, GOP and GOG should be at the same level not nested -Rename the routine to dissect Abort PDUs to match the other PDU -dissectors. ------------------------------------------------------------------------ -r13610 | jmayer | 2005-03-05 20:07:53 -0600 (Sat, 05 Mar 2005) | 1 line +r14416 | lego | 2005-05-21 19:44:34 -0500 (Sat, 21 May 2005) | 7 lines Changed paths: - M /trunk/FAQ - M /trunk/help/faq.txt + M /trunk/plugins/mate + M /trunk/plugins/mate/mate_grammar.lemon + M /trunk/plugins/mate/mate_runtime.c + M /trunk/plugins/mate/mate_setup.c + +at this point mate should be working as it did before the grammar + + - pdu transports were upside down (ip/tcp vs tcp/ip) + - the gop to gog index was not being populated + - tell svn to ignore generated c files + -Update to Sun, February 27 2005. ------------------------------------------------------------------------ -r13609 | guy | 2005-03-05 19:53:56 -0600 (Sat, 05 Mar 2005) | 9 lines +r14417 | etxrab | 2005-05-23 00:52:28 -0500 (Mon, 23 May 2005) | 36 lines +Changed paths: + M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-bacapp.h + M /trunk/epan/dissectors/packet-bvlc.c + +From Steve Karg: + +* added additional value string enumerations from BACnet-2004 +* removed vendor specific value string enumerations +* corrected some value strings enumerations that were incorrect +* refactored some common strings as strings + format +* refactored some value strings to use a reserved range and a +proprietary range by using val_to_split_str function which now correctly +shows the split range when a value is not matched. +* corrected some spelling errors +* converted some item text values to dissector registration +* added protocol tree for the BACnet tag headers +* added value strings tree display for some bit string BACnet properties +* added value strings tree display for some enumerated BACnet properties +* changed the conversion of signed, unsigned, and enumerated BACnet +values to use ntohx functions. +* added proper handling for large values of signed, unsigned, and +enumerated BACnet values. +* refactored BACnet Null and Boolean Tag tree +* refactored BACnet Real and Double Tag tree +* changed comments into functions for special tags +* changed some white space to match existing file style +* refactored tvb_reported_length to tvb_length_remaining to simplify +* corrected octet-string tree when length is zero +* refactored octet-string tree to use tvb_bytes_to_str +* corrected application tagged productions that were context tagged +* corrected context tagged productions that were application tagged +* corrected offset for BACnet character strings +* refactored some identical service request tree handling +* changed confirmed APDU to highlight the correct portion of the APDU +* changed some dissector registration values to display as decimal +* changed cast in call to iconv() to fix compiler warning +* corrected bit-wise AND in AtomicFile tree handling + +packet-bvlc.c +* added error text in tree when encoded length doesn't match actual length +------------------------------------------------------------------------ +r14418 | jmayer | 2005-05-23 07:18:10 -0500 (Mon, 23 May 2005) | 5 lines Changed paths: M /trunk/epan/dissectors/packet-bacapp.c -Don't use "long" and "%l[doux]" for 64-bit quantities, use guint64 and % -followed by PRIu64. +Warning fix: +packet-bacapp.c:1266:1: warning: C++ style comments are not allowed in ISO C90 +packet-bacapp.c:1266:1: warning: (this will be reported only once per input file) + + +------------------------------------------------------------------------ +r14419 | jmayer | 2005-05-23 07:19:00 -0500 (Mon, 23 May 2005) | 4 lines +Changed paths: + M /trunk/epan/dissectors/packet-camel.h -Don't use C++/C99-style comments. +Warning fix: +packet-camel.h:49: warning: 'dissect_camel_DestinationAddress' declared 'static' but never defined -Use "tvb_reported_length()" to get packet lengths - don't use -"tvb_length()", and especially don't directly refer to the "length" -field of the tvbuff. ------------------------------------------------------------------------ -r13608 | jmayer | 2005-03-05 19:52:34 -0600 (Sat, 05 Mar 2005) | 7 lines +r14420 | jmayer | 2005-05-23 07:32:37 -0500 (Mon, 23 May 2005) | 5 lines Changed paths: - M /trunk/make-manuf - M /trunk/manuf - M /trunk/manuf.tmpl + M /trunk/epan/dissectors/packet-bacapp.c +Warning fix: +packet-bacapp.c:1264: warning: ISO C does not allow extra ';' outside of +a function -- Modify make-manuf to add a message to manuf how to modify it - (aka: don't modify manuf, change manuf.tmpl and wka.tmpl instead) -- Remove OUI 08:00:0F from manuf.tmpl, the IEEE provides the correct - value by now. -- Regenerate manuf ------------------------------------------------------------------------ -r13607 | jmayer | 2005-03-05 19:15:29 -0600 (Sat, 05 Mar 2005) | 1 line +r14421 | etxrab | 2005-05-23 13:37:45 -0500 (Mon, 23 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-rdt.c + M /trunk/asn1/camel/packet-camel-template.h -Martin Mathieson: Add information sources + Warning fix: + packet-camel.h:49: warning: 'dissect_camel_DestinationAddress' declared 'static' but never defined +do this change also for the template file. ------------------------------------------------------------------------ -r13606 | lego | 2005-03-05 18:39:40 -0600 (Sat, 05 Mar 2005) | 2 lines +r14422 | gerald | 2005-05-23 16:18:14 -0500 (Mon, 23 May 2005) | 3 lines Changed paths: - M /trunk/manuf + M /trunk/plugins/docsis/packet-docsis.c -Juan Gonzales of Mitel Networks pointed out this change to the IEEE's OUI list +Make sure we don't loop when we dissect concatenated PDUs. Make some int +values larger in order to keep them from overflowing. ------------------------------------------------------------------------ -r13605 | guy | 2005-03-05 18:17:37 -0600 (Sat, 05 Mar 2005) | 3 lines +r14423 | guy | 2005-05-23 20:28:25 -0500 (Mon, 23 May 2005) | 2 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/gtk/voip_calls_dlg.c -From Herbert Lischka: implement some (not all) tags according to BACNET -application handbook. +Include "webbrowser.h" to declare "browser_open_url()". ------------------------------------------------------------------------ -r13604 | guy | 2005-03-05 17:44:23 -0600 (Sat, 05 Mar 2005) | 2 lines +r14424 | gerald | 2005-05-24 08:50:20 -0500 (Tue, 24 May 2005) | 2 lines Changed paths: - M /trunk/gtk/sctp_stat_dlg.c + M /trunk/epan/dissectors/packet-per.c -Get rid of a redundant test. +Throw an exception instead of calling g_assert_not_reached(). Fixes bug 175. ------------------------------------------------------------------------ -r13603 | guy | 2005-03-05 17:36:07 -0600 (Sat, 05 Mar 2005) | 3 lines +r14425 | gerald | 2005-05-24 11:46:18 -0500 (Tue, 24 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ospf.c + M /trunk/epan/dissectors/packet-bootp.c -For OSPF versions other than 2 or 3, stop dissecting the packet after -the checksum (which is the last header field common to V2 and V3). +Add extra TLV length checks and signedness fixes. Fixes the infinite loop in +bug 196. ------------------------------------------------------------------------ -r13602 | sahlberg | 2005-03-05 15:00:41 -0600 (Sat, 05 Mar 2005) | 4 lines +r14426 | ulfl | 2005-05-24 14:57:37 -0500 (Tue, 24 May 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-dcom-oxid.c -From Mike Duigou updates to JXTA +dissect ServerAlive response +------------------------------------------------------------------------ +r14427 | ulfl | 2005-05-24 14:59:20 -0500 (Tue, 24 May 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-dcom-sysact.c +dissect ORPC this/that of RemoteCreateInstance +------------------------------------------------------------------------ +r14428 | ulfl | 2005-05-24 15:00:14 -0500 (Tue, 24 May 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-dcom.c +add values for STDOBJREF flags +------------------------------------------------------------------------ +r14429 | ulfl | 2005-05-24 15:01:08 -0500 (Tue, 24 May 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-dcom-remunkn.c +fix IRemUnknown2 UUID ------------------------------------------------------------------------ -r13601 | guy | 2005-03-05 14:52:03 -0600 (Sat, 05 Mar 2005) | 3 lines +r14430 | guy | 2005-05-25 03:25:14 -0500 (Wed, 25 May 2005) | 2 lines Changed paths: - M /trunk/gtk/gsm_map_summary.c + M /trunk/epan/libethereal.def -From Laurent Rabret: handle the case where there's no file name (i.e., -an unsaved live capture), and avoid dividing by zero. +Add some more reassembly routines. ------------------------------------------------------------------------ -r13600 | guy | 2005-03-05 14:36:03 -0600 (Sat, 05 Mar 2005) | 5 lines +r14431 | guy | 2005-05-25 11:59:59 -0500 (Wed, 25 May 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-fw1.c + M /trunk/doc/ethereal-filter.pod.template -Clean up indentation. +Update URLs for WinPcap. -Strings don't have a base, so use BASE_NONE with them, not BASE_DEC or -BASE_HEX. +------------------------------------------------------------------------ +r14432 | ulfl | 2005-05-25 12:46:04 -0500 (Wed, 25 May 2005) | 1 line +Changed paths: + M /trunk/capture_sync.c +fix #199: encapsulate capture filename, to avoid problems with spaces in the filename (win32 only) ------------------------------------------------------------------------ -r13599 | gerald | 2005-03-05 11:57:27 -0600 (Sat, 05 Mar 2005) | 4 lines +r14433 | etxrab | 2005-05-25 13:27:33 -0500 (Wed, 25 May 2005) | 2 lines Changed paths: - M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/voip_calls_dlg.c -When analyzing RTP streams, use the source address as well as the SSRC -to determine forward and reverse directions. This fixes a capture I -have which has the same SSRC in the forward and reverse streams. +Back out the two last changes by popular demand :) +as we don't want multiple language versions. +------------------------------------------------------------------------ +r14434 | ulfl | 2005-05-25 16:37:46 -0500 (Wed, 25 May 2005) | 1 line +Changed paths: + M /trunk/capture-wpcap.c +add const to pcap_next_ex() parameter, as WinPcap 3.1 beta 4 (and libpcap 0.8) requires it ------------------------------------------------------------------------ -r13598 | sahlberg | 2005-03-05 05:12:01 -0600 (Sat, 05 Mar 2005) | 6 lines +r14435 | ulfl | 2005-05-25 17:20:46 -0500 (Wed, 25 May 2005) | 1 line Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-dtp.c + M /trunk/capture_sync.c -New Protocol : DTP +forgot to init savefilestring = NULL; +------------------------------------------------------------------------ +r14436 | ulfl | 2005-05-25 18:28:59 -0500 (Wed, 25 May 2005) | 3 lines +Changed paths: + M /trunk/capture.c + M /trunk/file.h + M /trunk/gtk/main.c + +the capture child might not respond shortly after bringing it up (especially it will block, if no input coming from an input capture pipe (e.g. mkfifo) is coming in) +to prevent problems, bring the main GUI into "capture mode" right after successfully spawn/exec the capture child, without waiting for any response from it +------------------------------------------------------------------------ +r14437 | gerald | 2005-05-26 09:53:39 -0500 (Thu, 26 May 2005) | 9 lines +Changed paths: + M /trunk/epan/proto.c -From Charlie Lenahan initial DTP support +In some places we call proto_tree_add_item() with hfindex and length +values that may not be valid (e.g. dissect_ber_octet_string() +in packet-ber.c). If the length is invalid, get_uint_value() or +get_int_value() will abort. Change them to throw an exception instead. +This keeps us from having to do a lot of extra work in the dissector. + +Fixes bug 182. ------------------------------------------------------------------------ -r13597 | sahlberg | 2005-03-05 04:51:30 -0600 (Sat, 05 Mar 2005) | 6 lines +r14438 | ulfl | 2005-05-26 12:50:27 -0500 (Thu, 26 May 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/capture.c + M /trunk/capture.h + M /trunk/capture_loop.c + M /trunk/capture_opts.c + M /trunk/capture_sync.c + M /trunk/gtk/main.c + A /trunk/log.h -from susanne edlund : make tlli appear in the tree +use the log features of the GLib to have verbose output of the capturing engine, e.g. GLib provides different domains for different submodules. Output more verbose than warning level will be disabled by default (just like before). -also change value_length and total_length signed to eliminate a compiler warning +use the console_log_handler in main.c for win32 AND unix now +Currently use the log for the capturing engine (only), as I desperately needed a log output for debugging. ------------------------------------------------------------------------ -r13596 | lroland | 2005-03-05 00:28:10 -0600 (Sat, 05 Mar 2005) | 12 lines +r14439 | ulfl | 2005-05-26 13:03:34 -0500 (Thu, 26 May 2005) | 1 line +Changed paths: + M /trunk/gtk/main.c + +avoid two gcc warnings +------------------------------------------------------------------------ +r14440 | ulfl | 2005-05-26 13:29:09 -0500 (Thu, 26 May 2005) | 1 line +Changed paths: + M /trunk/gtk/main.c + +don't use stdout but stderr for logging, as this will confuse the capture childs sync_pipe (has to be solved later) +------------------------------------------------------------------------ +r14441 | ulfl | 2005-05-26 14:06:01 -0500 (Thu, 26 May 2005) | 1 line +Changed paths: + M /trunk/capture_loop.c + M /trunk/capture_sync.c + +some cleanup of capture error notification handling +------------------------------------------------------------------------ +r14442 | ulfl | 2005-05-26 14:38:26 -0500 (Thu, 26 May 2005) | 1 line +Changed paths: + M /trunk/capture_loop.c + +fix #125: as suggested, the data in rechdr has to be kept over several calls to capture_loop_dispatch, so put it in the loop_data +------------------------------------------------------------------------ +r14443 | etxrab | 2005-05-26 15:11:35 -0500 (Thu, 26 May 2005) | 13 lines +Changed paths: + M /trunk/epan/dissectors/packet-rtsp.c + +These 2 patches make RDT support pretty complete now: +From Martin Mathieson: + +packet-rdt.c: +- register a configurable UDP port (off by default, but needed where setup traffic isn't captured) +- dissect extra 'buffer info' fields +- move bit fields into 'flags' subtrees +- misc. minor fixes and improvements (mainly formatting) + +packet-rtsp.c: +- improve detection of RDT as the transport +- allow interleaved frame data to be dissected as RDT packets + +------------------------------------------------------------------------ +r14444 | etxrab | 2005-05-26 15:13:42 -0500 (Thu, 26 May 2005) | 6 lines Changed paths: - M /trunk/doc/README.plugins - M /trunk/epan/plugins.c - M /trunk/plugins/acn/Makefile.nmake - M /trunk/plugins/acn/packet-acn.c - M /trunk/plugins/agentx/Makefile.nmake - M /trunk/plugins/agentx/packet-agentx.c - M /trunk/plugins/artnet/Makefile.nmake - M /trunk/plugins/artnet/packet-artnet.c - M /trunk/plugins/asn1/Makefile.nmake - M /trunk/plugins/asn1/packet-asn1.c - M /trunk/plugins/ciscosm/Makefile.nmake - M /trunk/plugins/ciscosm/packet-sm.c - M /trunk/plugins/docsis/Makefile.nmake - M /trunk/plugins/docsis/packet-bpkmattr.c - M /trunk/plugins/docsis/packet-bpkmreq.c - M /trunk/plugins/docsis/packet-bpkmrsp.c - M /trunk/plugins/docsis/packet-docsis.c - M /trunk/plugins/docsis/packet-dsaack.c - M /trunk/plugins/docsis/packet-dsareq.c - M /trunk/plugins/docsis/packet-dsarsp.c - M /trunk/plugins/docsis/packet-dscack.c - M /trunk/plugins/docsis/packet-dscreq.c - M /trunk/plugins/docsis/packet-dscrsp.c - M /trunk/plugins/docsis/packet-dsdreq.c - M /trunk/plugins/docsis/packet-dsdrsp.c - M /trunk/plugins/docsis/packet-intrngreq.c - M /trunk/plugins/docsis/packet-macmgmt.c - M /trunk/plugins/docsis/packet-map.c - M /trunk/plugins/docsis/packet-regack.c - M /trunk/plugins/docsis/packet-regreq.c - M /trunk/plugins/docsis/packet-regrsp.c - M /trunk/plugins/docsis/packet-rngreq.c - M /trunk/plugins/docsis/packet-rngrsp.c - M /trunk/plugins/docsis/packet-tlv.c - M /trunk/plugins/docsis/packet-type29ucd.c - M /trunk/plugins/docsis/packet-uccreq.c - M /trunk/plugins/docsis/packet-uccrsp.c - M /trunk/plugins/docsis/packet-ucd.c - M /trunk/plugins/docsis/packet-vendor.c - M /trunk/plugins/enttec/Makefile.nmake - M /trunk/plugins/enttec/packet-enttec.c - M /trunk/plugins/giop/Makefile.nmake - M /trunk/plugins/giop/packet-coseventcomm.c - M /trunk/plugins/giop/packet-cosnaming.c - M /trunk/plugins/gryphon/Makefile.nmake - M /trunk/plugins/gryphon/packet-gryphon.c - M /trunk/plugins/irda/Makefile.nmake - M /trunk/plugins/irda/packet-ircomm.c - M /trunk/plugins/irda/packet-irda.c - M /trunk/plugins/irda/packet-sir.c - M /trunk/plugins/lwres/Makefile.nmake - M /trunk/plugins/lwres/packet-lwres.c - M /trunk/plugins/mate/Makefile.nmake - M /trunk/plugins/megaco/Makefile.nmake - M /trunk/plugins/megaco/packet-megaco.c - M /trunk/plugins/mgcp/Makefile.nmake M /trunk/plugins/mgcp/packet-mgcp.c - M /trunk/plugins/opsi/Makefile.nmake - M /trunk/plugins/opsi/packet-opsi.c - M /trunk/plugins/pcli/Makefile.nmake - M /trunk/plugins/pcli/packet-pcli.c - M /trunk/plugins/rdm/Makefile.nmake - M /trunk/plugins/rdm/packet-rdm.c - M /trunk/plugins/rlm/Makefile.nmake - M /trunk/plugins/rlm/packet-rlm.c - M /trunk/plugins/rtnet/Makefile.nmake - M /trunk/plugins/rtnet/packet-rtnet.c - M /trunk/plugins/rudp/Makefile.nmake - M /trunk/plugins/rudp/packet-rudp.c - M /trunk/plugins/v5ua/Makefile.nmake - M /trunk/plugins/v5ua/packet-v5ua.c -Preparations for dropping the old plugin api. -Introduce a new init routine for plugins, -which does not take the plugin api table as an -argument and allows etheral to distinguish -between plugins using the old and the new api. +From Martin Mathieson: -Update README.plugins accordingly +This 2-liner: +- adds the correct item for localconnectionoptions param +- recognises the message verb "MESG" -Change all g_warnings() in epan/plugins.c to report_failue(). -On windows we do not have a log console open while -loading the plugins, because a log console cannot be opened before the prefs have been read. Thus g_warnings() -does not work for reporting problems with plugins. ------------------------------------------------------------------------ -r13595 | guy | 2005-03-04 22:58:13 -0600 (Fri, 04 Mar 2005) | 2 lines +r14445 | ulfl | 2005-05-26 15:23:13 -0500 (Thu, 26 May 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/Makefile.common -From Susanne Edlund: filter on NRI values in BSSGP. +add log.h +------------------------------------------------------------------------ +r14446 | ulfl | 2005-05-26 16:45:58 -0500 (Thu, 26 May 2005) | 1 line +Changed paths: + M /trunk/capture.c +changed the loglevel of "capture kill" from message to info (it's no action that the user directly triggered) ------------------------------------------------------------------------ -r13594 | guy | 2005-03-04 19:03:22 -0600 (Fri, 04 Mar 2005) | 3 lines +r14447 | ulfl | 2005-05-26 16:49:48 -0500 (Thu, 26 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-tzsp.c + M /trunk/gtk/main.c -From Chris Waters: correct an error with the decoding of signal -strength information in 802.11 captures. +show the complete filename in the statusbar, as there's no good reason to hide it (bugzilla #198) +fix various log related problems ------------------------------------------------------------------------ -r13593 | guy | 2005-03-04 19:00:15 -0600 (Fri, 04 Mar 2005) | 3 lines +r14448 | ulfl | 2005-05-26 18:18:10 -0500 (Thu, 26 May 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/gtk/graph_analysis.c + +fix #203: the scroll event handler used an inappropriate implementation to get event values, fixed this. On win32 this was working before and after the changes, so the bug *might* remain ... +------------------------------------------------------------------------ +r14449 | guy | 2005-05-26 20:34:42 -0500 (Thu, 26 May 2005) | 2 lines +Changed paths: + M /trunk/plugins/profinet -Omit some stuff when building without a Kerberos library, as it's unused -if you don't have a Kerberos library to do decryption. +Set svn:ignore to ignore generated files. ------------------------------------------------------------------------ -r13592 | tuexen | 2005-03-04 18:51:33 -0600 (Fri, 04 Mar 2005) | 2 lines +r14450 | guy | 2005-05-26 21:30:10 -0500 (Thu, 26 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-sctp.c + M /trunk/epan/dissectors/packet-smb-browse.c -Enable details in protocol tree by default like TCP and UDP. +The DESIRE_ and OS_ values are bit indices, not numerical values that +appear by themselves; get rid of the value_string tables for them. ------------------------------------------------------------------------ -r13591 | lroland | 2005-03-04 18:21:46 -0600 (Fri, 04 Mar 2005) | 1 line +r14451 | sahlberg | 2005-05-27 00:04:03 -0500 (Fri, 27 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/gtk/graph_analysis.c + +GdKEventScroll is not available in GTK-1.2 + -fix kerberos dissector for those having no kerberos decryption ------------------------------------------------------------------------ -r13590 | sahlberg | 2005-03-04 16:32:06 -0600 (Fri, 04 Mar 2005) | 6 lines +r14452 | sahlberg | 2005-05-27 01:00:08 -0500 (Fri, 27 May 2005) | 9 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-mpls-echo.c - M /trunk/epan/dissectors/packet-mpls.c - A /trunk/epan/dissectors/packet-mpls.h + M /trunk/epan/dissectors/packet-wsp.c + M /trunk/epan/proto.c + +cket wsp is creating string items and later appending to them and their value at runtime which breaks when the TRY_TO_FAKE_THIS_ITEM() is used. -from Carlos Pignataro +Add a comment to proto_item_append_string() explaining the "danger" and what needs to be done if one decides to use proto_item_append_string() + +Add a small change to WSP so that it will disable this speed optimization so not to trigger a DISSECTOR_BUG in proto_item_append_string() -update MPLS to support MPLS Echo ------------------------------------------------------------------------ -r13589 | sahlberg | 2005-03-04 16:25:02 -0600 (Fri, 04 Mar 2005) | 5 lines +r14453 | sahlberg | 2005-05-27 03:53:07 -0500 (Fri, 27 May 2005) | 4 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-kerberos.h + M /trunk/epan/dissectors/packet-kink.c -from didier: bug fix for the menu, -if ethereal could not open the file make us still be able to use the Open menu item to open a different file +From T.Nakashima +updates to KINK +------------------------------------------------------------------------ +r14454 | gram | 2005-05-27 10:13:09 -0500 (Fri, 27 May 2005) | 5 lines +Changed paths: + M /trunk/clopts_common.c + M /trunk/epan/proto.c + A /trunk/tools/ftsanity.py + +Add a "-G fields3" report which prints the bitmask of the field, and avoids +printing the blurb twice, like fields2 does. +Add a script, fsanity.py, to check sanity of FT definitions. Right now the +only check is for bitmasks for integer-like fields. ------------------------------------------------------------------------ -r13588 | jmayer | 2005-03-04 12:54:22 -0600 (Fri, 04 Mar 2005) | 1 line +r14455 | lego | 2005-05-27 13:33:09 -0500 (Fri, 27 May 2005) | 4 lines Changed paths: - M /trunk/docbook/Makefile + M /trunk/epan/prefs.c + +don't use a static buffer for preference values, allocate it, and, if necessary reallocate so that +the string always fits. + -Small fixes to previous patch ------------------------------------------------------------------------ -r13587 | gerald | 2005-03-04 11:42:42 -0600 (Fri, 04 Mar 2005) | 4 lines +r14456 | etxrab | 2005-05-27 13:35:19 -0500 (Fri, 27 May 2005) | 7 lines Changed paths: - M /trunk/Makefile.am + M /trunk/epan/dissectors/packet-rdt.c + +From Martin Mathieson +packet-rdt.c: +- register a configurable UDP port (off by default, but needed where setup traffic isn't captured) +- dissect extra 'buffer info' fields +- move bit fields into 'flags' subtrees +- misc. minor fixes and improvements (mainly formatting) +Missed eralier... +------------------------------------------------------------------------ +r14457 | sahlberg | 2005-05-27 16:33:27 -0500 (Fri, 27 May 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-wsp.c -Remove AUTHORS-SHORT and AUTHORS-SHORT-FORMAT from the distribution. -(They're automatically generated.) +from didier fix for the regression for bug 62 ------------------------------------------------------------------------ -r13586 | sahlberg | 2005-03-04 07:39:15 -0600 (Fri, 04 Mar 2005) | 7 lines +r14458 | sahlberg | 2005-05-27 16:39:38 -0500 (Fri, 27 May 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-kerberos.h - M /trunk/epan/dissectors/packet-kpasswd.c + M /trunk/epan/dissectors/packet-kink.c -make kpasswd privide subdissectors to handle the user-data field for the KRB_PRIV structure for kpasswd requests and replies. +from Gilbert, +make kink compile again on non-kerberos builds. -decrypt and behold the new password in plaintext in all its glory -(given you have the keytab with the old one of course) +encapsulate a call to decrypt kerberos to only be compiled in when compiling with kerberos. ------------------------------------------------------------------------ -r13585 | jmayer | 2005-03-04 07:24:47 -0600 (Fri, 04 Mar 2005) | 3 lines +r14459 | obiot | 2005-05-27 19:51:56 -0500 (Fri, 27 May 2005) | 2 lines Changed paths: - M /trunk/docbook/Makefile - M /trunk/docbook/README.txt + M /trunk/epan/dissectors/packet-image-gif.c -- Add -Xmx256m automatically on unixish systems. -- Make build process for A4 and letter pdfs more similar. +From Gilbert Ramirez - Fix a FT_NONE with a bitmask (shouldn't have one). ------------------------------------------------------------------------ -r13584 | sahlberg | 2005-03-04 06:28:00 -0600 (Fri, 04 Mar 2005) | 4 lines +r14460 | sahlberg | 2005-05-27 22:37:16 -0500 (Fri, 27 May 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-gssapi.c - M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-scsi.c -some authentication stuff from metze +refactor scsi dissector toi be table driven so it will be easier to add new +commandsets. ------------------------------------------------------------------------ -r13583 | sahlberg | 2005-03-04 06:21:40 -0600 (Fri, 04 Mar 2005) | 3 lines +r14461 | sahlberg | 2005-05-28 00:42:39 -0500 (Sat, 28 May 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-kerberos.h + M /trunk/epan/dissectors/packet-scsi.c + +more scsi refactoring + +starting to implement MMC codeset : CDROM/DVD -make ethereal able to decrypt KRB_PRIV which kpasswd uses ------------------------------------------------------------------------ -r13582 | sahlberg | 2005-03-04 05:08:03 -0600 (Fri, 04 Mar 2005) | 3 lines +r14462 | sahlberg | 2005-05-28 03:27:44 -0500 (Sat, 28 May 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-mapi.c + M /trunk/epan/dissectors/packet-scsi.c -the unknown stuff in the decrypted blobs in mapi are just uninitialized buffer padding so dont show them in the decode tree +some more MMC4 updates +------------------------------------------------------------------------ +r14463 | ulfl | 2005-05-28 06:04:11 -0500 (Sat, 28 May 2005) | 1 line +Changed paths: + M /trunk/gtk/graph_analysis.c +prevent unused function warning ------------------------------------------------------------------------ -r13581 | lego | 2005-03-03 07:59:52 -0600 (Thu, 03 Mar 2005) | 4 lines +r14464 | sahlberg | 2005-05-28 07:45:38 -0500 (Sat, 28 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-rmcp.c + M /trunk/epan/dissectors/packet-scsi.c -From Francisco Alcoba, -do not look for data blocks in ACK packets +updates to mmc, add more dissection of GET_CONFIGURATION and READ_TOC ------------------------------------------------------------------------ -r13580 | guy | 2005-03-03 04:23:29 -0600 (Thu, 03 Mar 2005) | 3 lines +r14465 | ulfl | 2005-05-28 07:49:19 -0500 (Sat, 28 May 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-isup.c - -From Anders Broman: fix a fault in the CODEC LIST routine where offset -was wrongly calculated, and clean up some other miscellaneous stuff. + M /trunk/epan/dissectors/packet-ndps.c +add some tvb_ensure_bytes_exist() calls, fixes #197, #202 and #208 ------------------------------------------------------------------------ -r13579 | guy | 2005-03-03 03:36:19 -0600 (Thu, 03 Mar 2005) | 2 lines +r14466 | sahlberg | 2005-05-28 08:01:14 -0500 (Sat, 28 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-idp.h + M /trunk/epan/dissectors/packet-scsi.c + +add the SynchronizeCache command for MMC -Oops, forgot packet-idp.h. ------------------------------------------------------------------------ -r13578 | guy | 2005-03-03 02:54:00 -0600 (Thu, 03 Mar 2005) | 4 lines +r14467 | sahlberg | 2005-05-28 08:29:45 -0500 (Sat, 28 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-acse.c - M /trunk/epan/dissectors/packet-acse.h + M /trunk/epan/dissectors/packet-scsi.c + +add MMC READ BUFFER CAPACITY command -From Yuriy Sidelnikov: correctly display User Information -field in release request/response PDu if the Reason field -is absent. ------------------------------------------------------------------------ -r13577 | guy | 2005-03-03 02:34:48 -0600 (Thu, 03 Mar 2005) | 4 lines +r14468 | sahlberg | 2005-05-28 18:05:41 -0500 (Sat, 28 May 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-3com-xns.c - M /trunk/epan/dissectors/packet-ethertype.c - A /trunk/epan/dissectors/packet-idp.c - M /trunk/epan/dissectors/packet-retix-bpdu.c - A /trunk/epan/dissectors/packet-spp.c - M /trunk/etypes.h + M /trunk/plugins/mgcp/packet-mgcp.c + +from Alejandro Vaquero +fox to packet-mgcp.c to make the viop analysis working again. -Add support for what appears to be 3Com's scheme for encapsulating XNS -over Token Ring (and presumably other link layers using 802.2 LLC), and -for the XNS IDP and SPP protocols. ------------------------------------------------------------------------ -r13576 | lego | 2005-03-02 17:25:41 -0600 (Wed, 02 Mar 2005) | 3 lines +r14469 | sahlberg | 2005-05-28 20:49:09 -0500 (Sat, 28 May 2005) | 5 lines Changed paths: - M /trunk/gtk/voip_calls.c + M /trunk/epan/dissectors/packet-iscsi.c + +update iscsi so that when we have ImmediateData we also call SCSI to decode the +payload (DATAOUT) and not just the scsi CDB. + -From Alejandro Vaquero: -Avoid adding to a call non ISUP mtp3 packets towards the same destination as a copy of the last ISUP packet towards that dpc. ------------------------------------------------------------------------ -r13575 | lego | 2005-03-02 17:22:11 -0600 (Wed, 02 Mar 2005) | 4 lines +r14470 | sahlberg | 2005-05-28 20:54:22 -0500 (Sat, 28 May 2005) | 6 lines Changed paths: - M /trunk/gtk/rtp_analysis.c - M /trunk/gtk/rtp_stream.c - M /trunk/gtk/rtp_stream.h + M /trunk/epan/dissectors/packet-scsi.c -This is the rest of the patch from Francisco Alcoba. -I forgot to check in changes to these files yesterday +minor prettification + +in the decode pane for the SCSI protocol, +put the name of the CDB on the protocol line ------------------------------------------------------------------------ -r13574 | guy | 2005-03-02 15:08:47 -0600 (Wed, 02 Mar 2005) | 7 lines +r14471 | sahlberg | 2005-05-28 21:30:49 -0500 (Sat, 28 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-3g-a11.c + M /trunk/epan/dissectors/packet-iscsi.c + +create a subset tvb before calling off to the SCSI dissector +so that the right part of the hexpane is highlighted when one clicks on an nondissected data line + +------------------------------------------------------------------------ +r14472 | sahlberg | 2005-05-28 21:55:12 -0500 (Sat, 28 May 2005) | 6 lines +Changed paths: + M /trunk/epan/dissectors/packet-fcp.c + M /trunk/epan/dissectors/packet-iscsi.c + M /trunk/epan/dissectors/packet-ndmp.c + M /trunk/epan/dissectors/packet-scsi.c + M /trunk/epan/dissectors/packet-scsi.h -Use "tvb_get_string()" to fetch strings from the packet, rather than -filling up a fixed-length buffer. +make all callers of dissect_scsi_cdb() first create a new subset tvb + +change the signature for dissect_scsi_cdb since we no longer need to pass offset over. -Add a bunch of length checks. -Clean up indentation. ------------------------------------------------------------------------ -r13573 | etxrab | 2005-03-02 14:16:18 -0600 (Wed, 02 Mar 2005) | 2 lines +r14473 | sahlberg | 2005-05-28 22:18:53 -0500 (Sat, 28 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-fcp.c + M /trunk/epan/dissectors/packet-iscsi.c + M /trunk/epan/dissectors/packet-ndmp.c + M /trunk/epan/dissectors/packet-scsi.c + M /trunk/epan/dissectors/packet-scsi.h + +remove offset and len from the signature of dissect_scsi_payload() + -Present diameter time as UTC time rather than the local time zone of the machine running Ethereal is at. - Insert a comment that time before 1970 will not be presented properly. ------------------------------------------------------------------------ -r13572 | lego | 2005-03-01 19:24:18 -0600 (Tue, 01 Mar 2005) | 5 lines +r14474 | jmayer | 2005-05-29 03:19:11 -0500 (Sun, 29 May 2005) | 5 lines Changed paths: - M /trunk/gtk/rtp_stream_dlg.c + M /trunk/epan/dissectors/packet-ieee80211.c -Frrom Francisco Alcoba -- Name resolution support for the RTP Stream Analysis functionality -- fix a crash when trying to analyze with no stream selected. + +Add minimal 802.11j decoding. There's not fun in doing more unless +someone provides a capture file. ------------------------------------------------------------------------ -r13571 | guy | 2005-03-01 18:21:33 -0600 (Tue, 01 Mar 2005) | 11 lines +r14475 | sahlberg | 2005-05-29 03:29:55 -0500 (Sun, 29 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-gprs-llc.c + M /trunk/epan/dissectors/packet-scsi.c -Handle the CRC correctly: +MMC SET STREAMING command + + +------------------------------------------------------------------------ +r14476 | sahlberg | 2005-05-29 03:45:09 -0500 (Sun, 29 May 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-scsi.c - don't do it if we don't have the entire packet, including the - CRC value; +add MMC RESERVE TRACK cdb - fetch the CRC value from the packet with tvb_get_letoh24(), - and compare that against the computed CRC, rather than comparing - the computed CRC (presumably in host byte order) with the - little-endian CRC in the packet (that doesn't work if host byte - order is big-endian). ------------------------------------------------------------------------ -r13570 | lego | 2005-03-01 17:46:05 -0600 (Tue, 01 Mar 2005) | 4 lines +r14477 | ulfl | 2005-05-29 06:23:42 -0500 (Sun, 29 May 2005) | 1 line Changed paths: - M /trunk/tethereal.c + M /trunk/epan/proto.c -If -z was not given as the very last argument the tap listener initialization might have crashed. +fix #11: add a [truncated] to the label, if the message to display is too long +------------------------------------------------------------------------ +r14478 | ulfl | 2005-05-29 07:27:31 -0500 (Sun, 29 May 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-rsync.c -Copy the optarg so that when the tap initialization is called it gets the right argument. +fix #86: use format_text before adding version string to the info column +------------------------------------------------------------------------ +r14479 | ulfl | 2005-05-29 08:02:57 -0500 (Sun, 29 May 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-dns.c +fix #201: add format_text before output of the DNS name, in case it contains invalid chars ------------------------------------------------------------------------ -r13569 | guy | 2005-03-01 15:49:19 -0600 (Tue, 01 Mar 2005) | 2 lines +r14480 | ulfl | 2005-05-29 09:09:58 -0500 (Sun, 29 May 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-retix-bpdu.c + M /trunk/gtk/recent.c -OK, *really* set the properties this time. +clarify some recent file entry descriptions +------------------------------------------------------------------------ +r14481 | ulfl | 2005-05-29 21:58:13 -0500 (Sun, 29 May 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-ndps.c + +add two more tvb_ensure_bytes_exist() calls to fix #216 +When I look at the remaining code, I fear this will become a never ending story :-( ------------------------------------------------------------------------ -r13568 | guy | 2005-03-01 15:47:54 -0600 (Tue, 01 Mar 2005) | 3 lines +r14482 | ulfl | 2005-05-29 22:10:37 -0500 (Sun, 29 May 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-retix-bpdu.c + M /trunk/epan/dissectors/packet-smb.c + +fix #215: the field hf_smb_print_spool_file_name used the wrong type, use FT_STRINGZ to add a string +------------------------------------------------------------------------ +r14483 | ulfl | 2005-05-29 23:06:22 -0500 (Sun, 29 May 2005) | 3 lines +Changed paths: + M /trunk/doc/ethereal.pod + M /trunk/gtk/main.c + M /trunk/gtk/recent.c + M /trunk/gtk/recent.h -Set the svn:keywords and svn:eol-style properties appropriately, and -give it an RCS ID. +First part to fix #148: use command line parameter -o not only for preferences but also for recent settings. +This way we can simply remove the GUI related command line parameters -B, -P and -T, which are useless now. ------------------------------------------------------------------------ -r13567 | guy | 2005-03-01 13:59:54 -0600 (Tue, 01 Mar 2005) | 3 lines +r14484 | ulfl | 2005-05-29 23:46:25 -0500 (Sun, 29 May 2005) | 1 line Changed paths: - M /trunk/wiretap/file_access.c + M /trunk/capture_opts.c + M /trunk/capture_sync.c + M /trunk/doc/ethereal.pod + M /trunk/gtk/main.c + +fix #148: (win32 only) use command line parameter -B to set capture buffer size +------------------------------------------------------------------------ +r14485 | sahlberg | 2005-05-30 06:16:08 -0500 (Mon, 30 May 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-scsi.c + +add MMC READ TRACK INFORMATION cdb -The DBS Etherwatch file handler does look for a magic number (the word -"ETHERWATCH"). ------------------------------------------------------------------------ -r13566 | lego | 2005-03-01 13:43:14 -0600 (Tue, 01 Mar 2005) | 3 lines +r14486 | sahlberg | 2005-05-30 07:09:39 -0500 (Mon, 30 May 2005) | 3 lines Changed paths: - M /trunk/plugins/stats_tree/http_stats_tree.c + M /trunk/epan/dissectors/packet-scsi.c -add the http_srv tap a tree to verify load distribution between several http servers and/or virtual hosts +add MMC READ DISC INFORMATION cdb ------------------------------------------------------------------------ -r13565 | lego | 2005-03-01 10:19:46 -0600 (Tue, 01 Mar 2005) | 10 lines +r14487 | gerald | 2005-05-30 10:51:03 -0500 (Mon, 30 May 2005) | 2 lines Changed paths: - M /trunk/gtk/graph_analysis.c - M /trunk/gtk/graph_analysis.h - M /trunk/gtk/voip_calls.c + M /trunk/plugins/megaco/packet-megaco.c -From Alejandro Vaquero: +Break out of an infinite loop. Fixes bugs 213 & 214. -patch to the voip calls facility to: +------------------------------------------------------------------------ +r14488 | gerald | 2005-05-30 11:03:24 -0500 (Mon, 30 May 2005) | 3 lines +Changed paths: + M /trunk/plugins/giop/packet-coseventcomm.c + M /trunk/plugins/giop/packet-cosnaming.c -- Add a horizontal scrollbar in the "Graph" to scroll the "comments" -- Fix a "state" bug in H323 and SIP calls -- Fix a bug that can make the "graph" to crash, and also clean up the "address" when the window is close +Throw an exception if we're handed a null pointer when we weren't +expecting one. Fixes bug 200. +------------------------------------------------------------------------ +r14489 | gerald | 2005-05-30 11:49:47 -0500 (Mon, 30 May 2005) | 2 lines +Changed paths: + M /trunk/editcap.c +Add random bit errors to the fuzz tests. ------------------------------------------------------------------------ -r13564 | lego | 2005-03-01 05:37:26 -0600 (Tue, 01 Mar 2005) | 4 lines +r14490 | ulfl | 2005-05-30 13:37:19 -0500 (Mon, 30 May 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-dcerpc.c +fix highlighting length, if more than one RPC call is in a TCP PDU -In packets with more than one req/resp the items of all the req/resp subtrees always pointed to the offset of the first req/resp. +set "n*DCERPC" in the proto column if more than one RPC call in a TCP PDU, overwriting the interface name, as there's probably more than one interface involved +add some more RPC info to the toplevel RPC proto_item +add a comment, if some bytes are not dissected but might be in the next TCP PDU ------------------------------------------------------------------------ -r13563 | sahlberg | 2005-03-01 04:09:53 -0600 (Tue, 01 Mar 2005) | 7 lines +r14491 | etxrab | 2005-05-30 13:39:39 -0500 (Mon, 30 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-iscsi.c + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-msrp.c + +Add dissection of MSRP +http://www.ietf.org/internet-drafts/draft-ietf-simple-message-sessions-10.txt -If errorrecoverylevel==0 is used and the A bit is clear in a DataIn PDU -the iscsi layer will not hold the LUN value (it is reserved) -so we need to remember if from the initial Command PDU. +------------------------------------------------------------------------ +r14492 | gerald | 2005-05-30 15:48:12 -0500 (Mon, 30 May 2005) | 6 lines +Changed paths: + M /trunk/epan/column.c -make the LUN reporting work for errorrecoverylevel==0 targets +Fix an off-by-one error found by Steve Grubb. Steve gets the award +for longest standing bug found so far. This has been present since +version 0.5.0. +Fixes part of bug 217. ------------------------------------------------------------------------ -r13562 | guy | 2005-03-01 00:32:56 -0600 (Tue, 01 Mar 2005) | 2 lines +r14493 | gerald | 2005-05-30 15:51:36 -0500 (Mon, 30 May 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-3g-a11.c + M /trunk/epan/dissectors/packet-ber.c -Show NTP times correctly. +From Steve Grubb: Initialize a variable. Fixes part of bug 217. ------------------------------------------------------------------------ -r13561 | guy | 2005-03-01 00:04:31 -0600 (Tue, 01 Mar 2005) | 2 lines +r14494 | gerald | 2005-05-30 15:53:08 -0500 (Mon, 30 May 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ntp.c + M /trunk/epan/dissectors/packet-bootp.c -Show NTP times in a fashion more similar to that used for other times. +From Steve Grubb: Fix off by one errors. Fixes part of bug 217. ------------------------------------------------------------------------ -r13560 | guy | 2005-03-01 00:03:08 -0600 (Tue, 01 Mar 2005) | 2 lines +r14495 | gerald | 2005-05-30 15:55:16 -0500 (Mon, 30 May 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-mip.c + M /trunk/asn1/camel/packet-camel-template.c + M /trunk/epan/dissectors/packet-camel.c -Show NTP times correctly. +From Steve Grubb: Fix a memory leak. + +Don't pass a null to atoi(). + +Fixes part of bug 217. ------------------------------------------------------------------------ -r13559 | guy | 2005-02-28 18:05:57 -0600 (Mon, 28 Feb 2005) | 9 lines +r14496 | gerald | 2005-05-30 15:58:20 -0500 (Mon, 30 May 2005) | 2 lines Changed paths: - M /trunk/doc/ethereal.pod - M /trunk/doc/tethereal.pod - M /trunk/epan/prefs.c + M /trunk/epan/dissectors/packet-cpfi.c + M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/dissectors/packet-dcom-cba-acco.c + M /trunk/epan/dissectors/packet-ethertype.c + M /trunk/epan/dissectors/packet-frame.c -From Graeme Hewson: rename the global preferences file to "preferences" -(it's now in an "ethereal" directory, so there's no need for it to have -a name that distinguishes it from files for other programs) - if it's -not found as "preferences", try "ethereal.conf" for compatibility - and -update the man pages appropriately. +More bug fixes from Steve Grubb. See bug 217 for details. + +------------------------------------------------------------------------ +r14497 | gerald | 2005-05-30 16:00:05 -0500 (Mon, 30 May 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-ieee8023.c + M /trunk/epan/dissectors/packet-isl.c -Fix a typo in the section color filters (the file name is "colorfilters", -not "color filters"). +From Steve Grubb: Initialize some variables. Fixes part of bug 217. ------------------------------------------------------------------------ -r13558 | ulfl | 2005-02-28 16:46:49 -0600 (Mon, 28 Feb 2005) | 3 lines +r14498 | gerald | 2005-05-30 16:01:52 -0500 (Mon, 30 May 2005) | 2 lines Changed paths: - M /trunk/capture.c - M /trunk/capture.h - M /trunk/capture_sync.c - M /trunk/file.c - M /trunk/file.h + M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/packet-radius.c -Another step towards using the parent/child mode for ALL captures. +From Steve Grubb: Fix buffer and array length checks. Fixes part of bug 217. -This is currently still disabled, as we cannot pass all required capture flags to the child process (lack of command line parameters). ------------------------------------------------------------------------ -r13557 | lego | 2005-02-28 16:39:03 -0600 (Mon, 28 Feb 2005) | 15 lines +r14499 | gerald | 2005-05-30 16:04:58 -0500 (Mon, 30 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-telnet.c -even if unharmful, this was simply ugly. -change +Don't try to check the suboption length type if we don't have a suboption. +Found by Steve Grubb. Fixes part of bug 217. -do { - if (i == 0) break; - ... -} while (i); +------------------------------------------------------------------------ +r14500 | gerald | 2005-05-30 16:08:16 -0500 (Mon, 30 May 2005) | 2 lines +Changed paths: + M /trunk/wiretap/netmon.c -for a propper +From Steve Grubb: Fix a memory leak. Fixes part of bug 217. -while(i) { - ... -} +------------------------------------------------------------------------ +r14501 | ulfl | 2005-05-30 16:10:21 -0500 (Mon, 30 May 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-smb.c +don't go into an (almost) endless loop, if si->info_count is -1, which is the default value. Seems to be a general bug worth to thought about, but I don't know the SMB internals and this bugfix should work anyway. +Found this by a privately fuzzed capture file (sorry, can't give it away) ------------------------------------------------------------------------ -r13556 | lego | 2005-02-28 16:32:16 -0600 (Mon, 28 Feb 2005) | 4 lines +r14502 | ulfl | 2005-05-30 17:40:55 -0500 (Mon, 30 May 2005) | 1 line Changed paths: - M /trunk/plugins/stats_tree/Makefile.am - A /trunk/plugins/stats_tree/http_stats_tree.c - M /trunk/plugins/stats_tree/stats_tree_plugin.c + M /trunk/epan/dissectors/packet-dcom.c -add the http_stats_tree, -a replacement for the current http tap listeners and a tree for requested hosts/uris +add a tvb_ensure_bytes_exist() to prevent a dissector bug +------------------------------------------------------------------------ +r14503 | ulfl | 2005-05-31 03:02:24 -0500 (Tue, 31 May 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-dcom.c + +fix handling, if ArraySize of a BSTR is 0, +replace a g_assert by DISSECTOR_ASSERT +------------------------------------------------------------------------ +r14504 | gram | 2005-05-31 09:03:34 -0500 (Tue, 31 May 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-cops.c +Remove bitmasks from field definitions for FT_IPv4 +and FT_IPv6 fields. ------------------------------------------------------------------------ -r13555 | lego | 2005-02-28 16:27:24 -0600 (Mon, 28 Feb 2005) | 5 lines +r14505 | gram | 2005-05-31 09:07:16 -0500 (Tue, 31 May 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-http.c - M /trunk/epan/dissectors/packet-http.h + M /trunk/AUTHORS + M /trunk/print.c + +Put 'unmaskedvalue' field in XML for bit-masked values. +Fix interpretation of 'value' field. +Patch from Vasanth Manickam. -few changes to http -- stat_infos are mantained in a GPtrArray to avoid leaking and overwriting them -- added http_host and request_uri to http_info_value_t +------------------------------------------------------------------------ +r14506 | ulfl | 2005-05-31 13:27:20 -0500 (Tue, 31 May 2005) | 3 lines +Changed paths: + M /trunk/plugins/profinet/packet-dcerpc-pn-io.c +add another tvb_ensure_bytes_exist() call +replace dissect_ndr_uuid_t by dissect_dcerpc_uuid_t, as this is the correct function to use and will prevent a problem with access to non existing private_data in dissect_ndr_uuid_t ------------------------------------------------------------------------ -r13554 | etxrab | 2005-02-28 14:51:23 -0600 (Mon, 28 Feb 2005) | 2 lines +r14507 | ulfl | 2005-05-31 13:30:37 -0500 (Tue, 31 May 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-dcom-cba.c -Change the RADIUS ATTRIBUTES for some 3GPP AVP:s to display them as (UTF8)Strings, also -added some more AVP:s from a later spec. +bugfix: remove some not required dissect_dcom_that() calls, as "ORPC that" was errorneously dissected twice ------------------------------------------------------------------------ -r13553 | etxrab | 2005-02-28 14:49:34 -0600 (Mon, 28 Feb 2005) | 1 line +r14508 | ulfl | 2005-05-31 13:31:27 -0500 (Tue, 31 May 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-dcom-remact.c -Undo change of return (addVendor(atoi(id), code, name)); as it wasn't correct. +better dissect ProtSeqs values ------------------------------------------------------------------------ -r13552 | etxrab | 2005-02-28 14:48:23 -0600 (Mon, 28 Feb 2005) | 1 line +r14509 | lroland | 2005-05-31 15:42:15 -0500 (Tue, 31 May 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/Makefile.nmake + M /trunk/plugins/Makefile.nmake -Correct presentation of IMSI digits and highlight correct bytes. +As suggested by Jaap Keuter: +Add generated files copied by "install-deps" to the +"clean" target ------------------------------------------------------------------------ -r13551 | guy | 2005-02-28 13:47:46 -0600 (Mon, 28 Feb 2005) | 3 lines +r14510 | ulfl | 2005-05-31 16:17:54 -0500 (Tue, 31 May 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rx.c + M /trunk/file.c -Add a link to an RX spec, and ask whether the Epoch really should be -dissected as a UN*X time. +convenience: if a "Go To Packet" didn't succeeded, add the requested packet number to the error message, +------------------------------------------------------------------------ +r14511 | ulfl | 2005-05-31 16:30:40 -0500 (Tue, 31 May 2005) | 1 line +Changed paths: + M /trunk/doc/ethereal.pod + M /trunk/gtk/main.c +add new command line flag "-g", will go to a given packet, after loading a capture file with -r ------------------------------------------------------------------------ -r13550 | lego | 2005-02-28 05:10:49 -0600 (Mon, 28 Feb 2005) | 3 lines +r14512 | lroland | 2005-05-31 16:34:14 -0500 (Tue, 31 May 2005) | 3 lines Changed paths: - M /trunk/plugins/stats_tree/stats_tree_plugin.c + M /trunk/config.nmake + M /trunk/plugins/stats_tree/Makefile.nmake -Adapt the stats_tree example plugin to the last changes +Add a note to config.nmake that it is required to set ENABLE_LIBETHEREAL to get plugin support in Ethereal. +Change Makefile.nmake of the stats_tree plugin to the current scheme. +------------------------------------------------------------------------ +r14513 | etxrab | 2005-06-01 01:46:41 -0500 (Wed, 01 Jun 2005) | 5 lines +Changed paths: + M /trunk/plugins/giop/Makefile.am + M /trunk/plugins/giop/Makefile.nmake + M /trunk/plugins/giop/README + A /trunk/plugins/giop/packet-tango.c +From Paolo Frigo : +A new plugin based on GIOP to recognize Tango packets. TANGO is +an object oriented distributed control system based on CORBA. Tango is +being actively developed as a collaborative effort among the ESRF, Soleil, Elettra and ALBA synchrotron facilities. TANGO is an open source +project hosted by SourceForge. ------------------------------------------------------------------------ -r13549 | guy | 2005-02-28 03:21:59 -0600 (Mon, 28 Feb 2005) | 2 lines +r14514 | etxrab | 2005-06-01 01:47:15 -0500 (Wed, 01 Jun 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-gprs-llc.c + M /trunk/ethereal_gen.py -Fix capitalization. +From Paolo Frigo : +A new plugin based on GIOP to recognize Tango packets. TANGO is +an object oriented distributed control system based on CORBA. Tango is +being actively developed as a collaborative effort among the ESRF, Soleil, Elettra and ALBA synchrotron facilities. TANGO is an open source +project hosted by SourceForge. +------------------------------------------------------------------------ +r14515 | ulfl | 2005-06-01 14:17:59 -0500 (Wed, 01 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-windows-common.c +bugfix: use g_snprintf instead of sprintf to prevent a buffer overflow ------------------------------------------------------------------------ -r13548 | guy | 2005-02-28 03:21:19 -0600 (Mon, 28 Feb 2005) | 2 lines +r14516 | ulfl | 2005-06-01 14:19:40 -0500 (Wed, 01 Jun 2005) | 1 line Changed paths: - M /trunk/epan/prefs.c + M /trunk/epan/dissectors/packet-dcom.c -Map "llcgprs.ignore_cipher_bit" to "llcgprs.autodetect_cipher_bit". +prevent "Dissector Bug": prevent a string processing of length 0 +------------------------------------------------------------------------ +r14517 | ulfl | 2005-06-01 16:28:40 -0500 (Wed, 01 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-frame.c +mark some fields as generated and clarify some field descriptions ------------------------------------------------------------------------ -r13547 | guy | 2005-02-28 02:22:02 -0600 (Mon, 28 Feb 2005) | 2 lines +r14518 | ulfl | 2005-06-01 18:44:24 -0500 (Wed, 01 Jun 2005) | 5 lines Changed paths: - M /trunk/tools/asn2eth.py + M /trunk/epan/dissectors/packet-ip.c + +add some hidden fields to be able to filter on the resolved hostname "ip.host" / "ip.src_host" / "ip.dst_host", this was formerly not possible. -Handle the new signature for "dissect_per_restricted_character_string()". +replace some deprecated proto_tree_add_..._hidden() calls by seperate calls by proto_tree_add_...() and PROTO_ITEM_SET_HIDDEN() +some other cosmetic changes ------------------------------------------------------------------------ -r13546 | lego | 2005-02-27 19:20:52 -0600 (Sun, 27 Feb 2005) | 7 lines +r14519 | ulfl | 2005-06-01 18:47:55 -0500 (Wed, 01 Jun 2005) | 1 line Changed paths: - M /trunk/gtk/stats_tree_stat.c + M /trunk/epan/dissectors/packet-ip.c +add a reference to the corresponding RFC's of the Differentiated Services field pref setting +------------------------------------------------------------------------ +r14520 | ulfl | 2005-06-01 19:28:38 -0500 (Wed, 01 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-eth.c -- do not free the string passed to register_ethereal_tap() -it caused the taps to have "funny" names. +add the resolved Ethernet addresses to the "Ethernet II" summary line +------------------------------------------------------------------------ +r14521 | guy | 2005-06-02 02:17:08 -0500 (Thu, 02 Jun 2005) | 2 lines +Changed paths: + M /trunk/INSTALL -- rename the window as "$name Stats Tree" +Note that this is *not* what you use if you're building from Subversion. +------------------------------------------------------------------------ +r14522 | ulfl | 2005-06-02 02:29:24 -0500 (Thu, 02 Jun 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-wbxml.c + +bugfix: don't use match_strval() in combination with format strings (as it may return NULL) but val_to_str() +I don't know if the output as hex is appropriate, someone with more WBXML knowledge might have a look (however, it's done for unknown values only) ------------------------------------------------------------------------ -r13545 | lego | 2005-02-27 18:55:49 -0600 (Sun, 27 Feb 2005) | 5 lines +r14523 | ulfl | 2005-06-02 13:29:29 -0500 (Thu, 02 Jun 2005) | 1 line Changed paths: - M /trunk/gtk/main.c - M /trunk/tethereal.c + M /trunk/epan/proto.c -Make sure that plugin tap listeners get registered before the non-plugin tap listeners -that's because stat trees are registered as tap listeners by either -gtk/stats_tree_stat.c or tap-stats_tree.c +show Ethernet and IPX addresses the same way as we do with other fields as well (e.g. IP addresses), first the converted value (e.g. IP address or manufaturer name) and then in brackets the "raw data" +------------------------------------------------------------------------ +r14524 | ulfl | 2005-06-02 13:35:20 -0500 (Thu, 02 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/proto.c + M /trunk/epan/proto.h +add new function proto_tree_move_item(), which will move an already existing proto_item inside the tree (but it can't be moved to a different "tree level") +------------------------------------------------------------------------ +r14525 | ulfl | 2005-06-02 13:39:45 -0500 (Thu, 02 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-dcerpc.c +bugfix (fuzz_tested): add tvb_ensure_bytes_exist() before adding a fragment at two places, otherwise we get an access violation ------------------------------------------------------------------------ -r13544 | lego | 2005-02-27 17:43:12 -0600 (Sun, 27 Feb 2005) | 3 lines +r14526 | ulfl | 2005-06-02 13:44:17 -0500 (Thu, 02 Jun 2005) | 1 line Changed paths: - M /trunk/epan/libethereal.def + M /trunk/epan/dissectors/packet-smb.c -Add register_all_plugin_tap_listeners() to libethereal.def +bugfix (fuzz_tested): t2i can be zero, test at all places before using it +------------------------------------------------------------------------ +r14527 | ulfl | 2005-06-02 13:52:55 -0500 (Thu, 02 Jun 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-smb-pipe.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/reassemble.c + M /trunk/epan/reassemble.h +add a generated toplevel line between the TCP protocol and the desegmented content, to better understand what's going on while desegmenting. +We'll have to add similar mechanisms for other protocols as well... ------------------------------------------------------------------------ -r13543 | guy | 2005-02-27 16:04:48 -0600 (Sun, 27 Feb 2005) | 4 lines +r14528 | ulfl | 2005-06-02 14:31:16 -0500 (Thu, 02 Jun 2005) | 1 line Changed paths: - M /trunk/epan/plugins.c - M /trunk/epan/plugins.h - M /trunk/gtk/main.c - M /trunk/gtk/plugins_dlg.c - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-ndps.c -The stats tree stuff should ultimately allow us to have plugin taps, so -add infrastructure for them, and display the plugin type (which could be -both dissector *and* tap) in the list of plugins. +fix #223: add another tvb_ensure_bytes_exist() call +------------------------------------------------------------------------ +r14529 | ulfl | 2005-06-02 15:03:15 -0500 (Thu, 02 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-http.c +add length information to "Content-encoded entity body" ------------------------------------------------------------------------ -r13542 | etxrab | 2005-02-27 15:33:32 -0600 (Sun, 27 Feb 2005) | 1 line +r14530 | ulfl | 2005-06-02 15:52:13 -0500 (Thu, 02 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-udp.c -Avoid trying to display a time before 00:00:00 UTC, January 1, 1970 as it currently will be displayed wrongly. +use [] not () brackets to indicate [correct] UDP checksum, as this is a generated field ------------------------------------------------------------------------ -r13541 | guy | 2005-02-27 15:15:30 -0600 (Sun, 27 Feb 2005) | 3 lines +r14531 | ulfl | 2005-06-02 15:55:58 -0500 (Thu, 02 Jun 2005) | 2 lines Changed paths: - M /trunk/capture_opts.c - M /trunk/clopts_common.c - M /trunk/clopts_common.h - M /trunk/gtk/main.c + M /trunk/epan/dissectors/packet-clnp.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-dnp.c + M /trunk/epan/dissectors/packet-eap.c + M /trunk/epan/dissectors/packet-ndps.c + M /trunk/epan/dissectors/packet-netbios.c + M /trunk/epan/dissectors/packet-q931.c + M /trunk/epan/dissectors/packet-x25.c + M /trunk/epan/reassemble.c + M /trunk/epan/reassemble.h -Move "get_natural_int()" and "get_positive_int()" from "capture_opts.c" -to "clopts_common.c", make them not static, and use them in "gtk/main.c". +add a generated toplevel line between the connectionless DCE/RPC protocol and the defragmented DCE/RPC content, to better understand what's going on if defragmentation is done. ------------------------------------------------------------------------ -r13540 | lego | 2005-02-27 14:26:55 -0600 (Sun, 27 Feb 2005) | 13 lines +r14532 | ulfl | 2005-06-02 17:11:22 -0500 (Thu, 02 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ip.c - M /trunk/epan/dissectors/packet-rmt-fec.c + M /trunk/epan/dissectors/packet-ncp2222.inc -From Stefano Pettini +fix call to show_fragment_seq_tree() reported by buildbot +------------------------------------------------------------------------ +r14533 | ashokn | 2005-06-02 17:49:59 -0500 (Thu, 02 Jun 2005) | 7 lines +Changed paths: + M /trunk/epan/dissectors/packet-lmp.c -1) added _U_ tags in RMT dissectors to suppress "unused parameter" warnings. -2) added a dissector_add_handle("ip.udp", ip_handle) to IP dissector, to -allow the following chain of protocols: IP over UDP over IP. It seems -uncommon, but it's used by implementations of experimental protocols -(e.g. TCP-XM) that run a userspace IP stack (e.g. lwIP) over UDP. The -dissector of IP over UDP must be enabled explicitly using the "decode -as..." window. +Updated LMP to handle the latest protocol. Removed old protocol values +since they are no longer useful. +Manu Pathak <mapathak@cisco.com> contributed these changes ------------------------------------------------------------------------ -r13539 | lego | 2005-02-27 14:17:06 -0600 (Sun, 27 Feb 2005) | 5 lines +r14534 | etxrab | 2005-06-03 01:29:25 -0500 (Fri, 03 Jun 2005) | 6 lines Changed paths: - M /trunk/gtk/stats_tree_stat.c + M /trunk/epan/dissectors/packet-jxta.c -the last commit broke windows compilation. - minor changes in typing variables - exclude a GTK2 call from being called while using GTK1 +From Mike Duigou: +Extends the jxta dissector to add higher level conversation +tracking, improved display, tapping and fixes a bug which caused some +conversations to get lost. ------------------------------------------------------------------------ -r13538 | ulfl | 2005-02-27 13:59:03 -0600 (Sun, 27 Feb 2005) | 1 line +r14535 | etxrab | 2005-06-03 01:31:58 -0500 (Fri, 03 Jun 2005) | 4 lines Changed paths: - M /trunk/capture.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-tcp.h + +From Mike Duigou: + A minor change to the prototype of tcp_dissect_pdus() +which uses the function pointer type from packet.h -some more cleanup of the capturing code (e.g. split up of the code reading in the "normal mode" captured data) ------------------------------------------------------------------------ -r13537 | ulfl | 2005-02-27 12:52:05 -0600 (Sun, 27 Feb 2005) | 3 lines +r14536 | etxrab | 2005-06-03 01:34:35 -0500 (Fri, 03 Jun 2005) | 4 lines Changed paths: - M /trunk/capture.c + M /trunk/epan/dissectors/packet-ssl.c -bugfix to bring up correct error message if capture file couldn't be openened. +From Mike Duigou: +A few doxygen updates and an improved section on +writing dissectors that don't use tcp_dissect_pdus(). -some code cleanup ------------------------------------------------------------------------ -r13536 | ulfl | 2005-02-27 12:27:30 -0600 (Sun, 27 Feb 2005) | 1 line +r14537 | etxrab | 2005-06-03 01:35:44 -0500 (Fri, 03 Jun 2005) | 4 lines Changed paths: - M /trunk/epan/libethereal.def + M /trunk/epan/address.h + M /trunk/epan/packet.h + M /trunk/epan/packet_info.h + +From Mike Duigou: +A few doxygen updates and an improved section on +writing dissectors that don't use tcp_dissect_pdus(). -add missing reinit_stats_tree symbol, so MSVC can compile again ------------------------------------------------------------------------ -r13535 | ulfl | 2005-02-27 11:30:33 -0600 (Sun, 27 Feb 2005) | 1 line +r14538 | etxrab | 2005-06-03 01:36:07 -0500 (Fri, 03 Jun 2005) | 4 lines Changed paths: - M /trunk/capture.c - M /trunk/capture.h - M /trunk/gtk/main.c + M /trunk/doc/README.developer + +From Mike Duigou: +A few doxygen updates and an improved section on +writing dissectors that don't use tcp_dissect_pdus(). -some clarification of the capture child thing ------------------------------------------------------------------------ -r13534 | lego | 2005-02-27 10:55:24 -0600 (Sun, 27 Feb 2005) | 8 lines +r14539 | etxrab | 2005-06-03 01:37:05 -0500 (Fri, 03 Jun 2005) | 4 lines Changed paths: - M /trunk/epan/stats_tree.c - M /trunk/epan/stats_tree.h - M /trunk/epan/stats_tree_priv.h - M /trunk/gtk/stats_tree_stat.c - M /trunk/tap-stats_tree.c + M /trunk/packaging/rpm/SPECS/ethereal.spec.in -Several fixes to the stats_tree - - Avoid creating a copy of every branch at reinitialization - this used to cause some GTK warnings and a leakage of tree nodes +From Mike Duigou: +Fixes a problem with the RPM spec which prevents it from +working with current versions of rpmbuild. -- propperly check the optarg to avoid getting junk in the filter text - this caused a crash +------------------------------------------------------------------------ +r14540 | guy | 2005-06-03 04:55:28 -0500 (Fri, 03 Jun 2005) | 2 lines +Changed paths: + M /trunk/capture-wpcap.c + M /trunk/gtk/capture_dlg.c + M /trunk/gtk/capture_if_dlg.c +Update URLs and domain names that refer to the WinPcap site. ------------------------------------------------------------------------ -r13533 | ulfl | 2005-02-27 10:54:52 -0600 (Sun, 27 Feb 2005) | 1 line +r14541 | etxrab | 2005-06-03 04:56:03 -0500 (Fri, 03 Jun 2005) | 2 lines Changed paths: - M /trunk/capture.h + M /trunk/epan/dissectors/packet-isup.c -minor comment additions +Register the ISUP dissector to make it callable through +call_dissector() ------------------------------------------------------------------------ -r13532 | lego | 2005-02-27 08:01:12 -0600 (Sun, 27 Feb 2005) | 2 lines +r14542 | lego | 2005-06-03 08:50:30 -0500 (Fri, 03 Jun 2005) | 6 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-sscop.c + A /trunk/epan/dissectors/packet-sscop.h + + +- add a way to call the sscop dissector with an arbitrary handle\ +- make most fields "filterable" +- dissect stat and ustat pdu lists -abort early in main_filter_packets() if dftext is NULL ------------------------------------------------------------------------ -r13531 | lego | 2005-02-27 07:57:45 -0600 (Sun, 27 Feb 2005) | 5 lines +r14543 | lego | 2005-06-03 08:54:34 -0500 (Fri, 03 Jun 2005) | 3 lines Changed paths: - M /trunk/gtk/sctp_stat_dlg.c + M /trunk/epan/dissectors/packet-sscop.h -few fixes to The SCTP associations dialog -- do not call main_filter_packets() with a null dfilter string -- fix two leaks +keywords and eol-style ------------------------------------------------------------------------ -r13530 | lego | 2005-02-27 07:00:22 -0600 (Sun, 27 Feb 2005) | 6 lines +r14544 | lego | 2005-06-03 09:02:06 -0500 (Fri, 03 Jun 2005) | 3 lines Changed paths: - M /trunk/gtk/dlg_utils.c + M /trunk/epan/dissectors/packet-sscop.c -From Martin Mathielson +fix the PDU list, and put it at the bottom -- from the "Capture Options" dialog, if you select the Capture Filter(s) -file browser, Cancel doesn't work. +------------------------------------------------------------------------ +r14545 | ulfl | 2005-06-03 20:29:14 -0500 (Fri, 03 Jun 2005) | 5 lines +Changed paths: + M /trunk/doc/ethereal.pod + M /trunk/doc/tethereal.pod + M /trunk/gtk/main.c + M /trunk/tethereal.c + +update usage output and manual pages for both Ethereal and Tethereal to reflect the latest changes in the command line. + +clarifications of some command line parameter descriptions in the manual pages +this also fixes #221 ------------------------------------------------------------------------ -r13529 | lego | 2005-02-27 06:45:07 -0600 (Sun, 27 Feb 2005) | 7 lines +r14546 | ulfl | 2005-06-03 21:06:16 -0500 (Fri, 03 Jun 2005) | 3 lines Changed paths: - M /trunk/gtk/rtp_stream_dlg.c + M /trunk/gtk/packet_list.c -From Martin Mathielson -- from the "RTP streams" dialog, pressing 'Analyze' with no stream selected -would throw up an 'invalid filter' error. This patch avoids anything if no -steam(s) are selected. +fix #220: the automatic display of the vertical scrollbar at the packet list doesn't seem to work in all cases (not shown although scrolling would be necessary) +as I don't see a way to fix this (and it just don't really hurt, as this scrollbar is usually shown anyway if some more packets have to be display) just show it always +------------------------------------------------------------------------ +r14547 | ulfl | 2005-06-03 23:14:02 -0500 (Fri, 03 Jun 2005) | 1 line +Changed paths: + M /trunk/doc/ethereal.pod + M /trunk/doc/tethereal.pod +make a complete redesign of the files section +------------------------------------------------------------------------ +r14548 | ulfl | 2005-06-03 23:57:10 -0500 (Fri, 03 Jun 2005) | 1 line +Changed paths: + M /trunk/doc/ethereal.pod +update to changes done in the menu ------------------------------------------------------------------------ -r13528 | guy | 2005-02-25 18:14:22 -0600 (Fri, 25 Feb 2005) | 4 lines +r14549 | ulfl | 2005-06-04 05:23:10 -0500 (Sat, 04 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/proto_hier_stats.c -The Kerberos-over-UDP dissector can decide not to dissect packets, so it -needs to be a new-style dissector and explicitly reject them so that -other dissectors can pick them up. +fix #224: hierarchy stats had problems with the new generated toplevel desegmentation items "[Reassembled TCP Segments]" +------------------------------------------------------------------------ +r14550 | ulfl | 2005-06-04 06:47:38 -0500 (Sat, 04 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-dns.c +fix #201 second part: adapt the string length of the unformatted text, so it won't show \000 and beyond ------------------------------------------------------------------------ -r13527 | guy | 2005-02-25 17:47:21 -0600 (Fri, 25 Feb 2005) | 3 lines +r14551 | lego | 2005-06-04 14:22:39 -0500 (Sat, 04 Jun 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-kerberos4.c + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-user_encap.c + +Give the user the ability to decide how to decode USER DLTs -The Kerberos 4 dissector is now a dissector that can reject packets, so -register it with "new_register_dissector". ------------------------------------------------------------------------ -r13526 | guy | 2005-02-25 17:44:44 -0600 (Fri, 25 Feb 2005) | 3 lines +r14552 | ulfl | 2005-06-04 16:39:36 -0500 (Sat, 04 Jun 2005) | 1 line Changed paths: - M /trunk/epan/packet_info.h + M /trunk/epan/dissectors/packet-lmp.c + +fix #225-#231: the enum lmp_filter_keys contained holes, so the logic to detect the field type failed, resulting in the bug +------------------------------------------------------------------------ +r14553 | guy | 2005-06-04 16:58:55 -0500 (Sat, 04 Jun 2005) | 7 lines +Changed paths: + M /trunk/wiretap/libpcap.c + M /trunk/wiretap/netmon.c + M /trunk/wiretap/nettl.c -Make the DCE transport type an "int" so that -1 is a valid value and the -compiler doesn't say "that's unsigned, it can't possibly be equal to -1". +Fix some more leaks in error returns from open routines (if the open can +fail after the private data is allocated, you have to free the private +data). + +The file header in nettl files is 128 bytes - use a #define for it, and +also a #define for the magic number size. ------------------------------------------------------------------------ -r13525 | lroland | 2005-02-25 17:37:14 -0600 (Fri, 25 Feb 2005) | 3 lines +r14554 | ulfl | 2005-06-04 17:05:50 -0500 (Sat, 04 Jun 2005) | 3 lines Changed paths: - M /trunk/epan/libethereal.def + M /trunk/epan/dissectors/packet-per.h -Add another function from epan/stats_tree.c to the list of exported functions in libethereal.def +if some PER errors has to be put to the stderr, give at least info where it's coming from (__FILE__ and __LINE__) -Finally ethereal can be built again on windows. +BTW: time for something like a "NotImplementedException"?!?, this seems to be a common mechanism, if a dissector hasn't implemented all protocol elemements (yet) ------------------------------------------------------------------------ -r13524 | lroland | 2005-02-25 17:08:53 -0600 (Fri, 25 Feb 2005) | 1 line +r14555 | etxrab | 2005-06-06 08:55:47 -0500 (Mon, 06 Jun 2005) | 2 lines Changed paths: - M /trunk/plugins/Makefile.nmake - M /trunk/plugins/Xass-list - M /trunk/plugins/Xplugin_api.c - M /trunk/plugins/Xplugin_api.h - M /trunk/plugins/Xplugin_api_decls.h - M /trunk/plugins/Xplugin_table.h - M /trunk/plugins/plugin_api_list.c + M /trunk/epan/dissectors/packet-rsvp.c -add agentx plugin to the clean target and update the old plugin api +From Richard Rabbat: +a patch for a couple of fixes to rsvp sub-objects. ------------------------------------------------------------------------ -r13523 | sahlberg | 2005-02-25 17:03:24 -0600 (Fri, 25 Feb 2005) | 3 lines +r14556 | etxrab | 2005-06-06 09:01:04 -0500 (Mon, 06 Jun 2005) | 10 lines Changed paths: - M /trunk/epan/dissectors/packet-scsi.c + M /trunk/gtk/graph_analysis.c + M /trunk/gtk/graph_analysis.h -start dissecting serviceactionin16 +From Alejandro Vaquero: +- Add a pane to contain the main graph and the comments to be able to +split them +- Change the main graph area to be a scrolled_window +- Change the look of the selected item to be blue with white text color +- Gray color the title area +- Change the conversations color to more "soft" colors (it was difficult +to read in some cases before) ------------------------------------------------------------------------ -r13522 | lego | 2005-02-25 16:57:43 -0600 (Fri, 25 Feb 2005) | 4 lines +r14557 | etxrab | 2005-06-06 10:17:41 -0500 (Mon, 06 Jun 2005) | 5 lines Changed paths: - M /trunk/gtk/stats_tree_stat.c + M /trunk/epan/to_str.c -- undo disabling the GTK2 version -- do not declare a variable after the first statement or else windows compilation fails +From Mike Duigou: + a patch to to_str.c which adds support for printing +AT_STRINGZ address type. Amazing that this wasn't there! ------------------------------------------------------------------------ -r13521 | lego | 2005-02-25 16:30:58 -0600 (Fri, 25 Feb 2005) | 3 lines +r14558 | etxrab | 2005-06-06 10:20:10 -0500 (Mon, 06 Jun 2005) | 26 lines Changed paths: - M /trunk/gtk/stats_tree_stat.c + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-jxta.c + A /trunk/epan/dissectors/packet-jxta.h + +From Mike Duigou: + a patch which adds support for displaying jxta +conversations and endpoints from the 'Statistics' menu. Also adds : + + - a generated field to Welcome messages to indicate whether this +welcome is from the initiator or the receiver. You can filter on this +field with 'jxta.welcome.initiator==[0|1]' + + - Marks the source and destination fields of message added in the last +patch as generated fields. (Saw it being done for some other protocol). + + - Cleans up dissection of Message which used to assume it would +dissected more than one set of hdr/message per tvbuff. Now it only +attempts to dissect one. -Temporarily disable the gtk2 version that causes a compilation error on windows. +- Uses GMemChunk for tap info and for conversation data rather than +g_malloc() There's still a major leakage of g_malloc()ed the c-strings +which are used in jxta addresses. Any suggestions for how these can be +allocated such that they can be freed re-init is called would be +appreciated. For address objects whose data ptr doesn't point into a +tvbuff it's not clear what the lifecyle of an address object is. + + - Fixes a bug with filling in the of the transport layer conversation +data. >= vs. > ------------------------------------------------------------------------ -r13520 | lroland | 2005-02-25 16:06:00 -0600 (Fri, 25 Feb 2005) | 1 line +r14559 | etxrab | 2005-06-06 10:22:17 -0500 (Mon, 06 Jun 2005) | 26 lines Changed paths: - M /trunk/epan/libethereal.def + M /trunk/gtk/Makefile.common + A /trunk/gtk/conversations_jxta.c + A /trunk/gtk/hostlist_jxta.c + +From Mike Duigou: + a patch which adds support for displaying jxta +conversations and endpoints from the 'Statistics' menu. Also adds : + + - a generated field to Welcome messages to indicate whether this +welcome is from the initiator or the receiver. You can filter on this +field with 'jxta.welcome.initiator==[0|1]' + + - Marks the source and destination fields of message added in the last +patch as generated fields. (Saw it being done for some other protocol). + + - Cleans up dissection of Message which used to assume it would +dissected more than one set of hdr/message per tvbuff. Now it only +attempts to dissect one. + +- Uses GMemChunk for tap info and for conversation data rather than +g_malloc() There's still a major leakage of g_malloc()ed the c-strings +which are used in jxta addresses. Any suggestions for how these can be +allocated such that they can be freed re-init is called would be +appreciated. For address objects whose data ptr doesn't point into a +tvbuff it's not clear what the lifecyle of an address object is. + + - Fixes a bug with filling in the of the transport layer conversation +data. >= vs. > + -Add another function from epan/stats_tree.c to the list of exported functions in libethereal.def ------------------------------------------------------------------------ -r13519 | lroland | 2005-02-25 15:51:29 -0600 (Fri, 25 Feb 2005) | 1 line +r14560 | etxrab | 2005-06-06 10:37:12 -0500 (Mon, 06 Jun 2005) | 1 line Changed paths: - M /trunk/epan/libethereal.def + A /trunk/asn1/tcap -Add some functions from epan/stats_tree.c to the list of exported functions in libethereal.def +Add the asn2eth genereated TCAP dissector to SVN ------------------------------------------------------------------------ -r13518 | tuexen | 2005-02-25 15:03:48 -0600 (Fri, 25 Feb 2005) | 2 lines +r14561 | etxrab | 2005-06-06 10:39:20 -0500 (Mon, 06 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-sctp.c + A /trunk/asn1/tcap/Makefile + A /trunk/asn1/tcap/packet-tcap-template.c + A /trunk/asn1/tcap/packet-tcap-template.h + A /trunk/asn1/tcap/tcap.asn + A /trunk/asn1/tcap/tcap.cnf -Show prot numbers in protocol tree, if wanted. Suggested by Jeff Morris. +Add the asn2eth generated TCAP dissector made by Tim Endean to the SVN tree. +------------------------------------------------------------------------ +r14562 | etxrab | 2005-06-06 12:07:04 -0500 (Mon, 06 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-jxta.h +Fix a typo and add an ifdef ------------------------------------------------------------------------ -r13517 | tuexen | 2005-02-25 14:33:28 -0600 (Fri, 25 Feb 2005) | 2 lines +r14563 | etxrab | 2005-06-06 12:08:37 -0500 (Mon, 06 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-mtp3.c + M /trunk/gtk/conversations_jxta.c + M /trunk/gtk/conversations_table.h + M /trunk/gtk/hostlist_jxta.c + +Add an ifdef and "dont apply patch twice". +------------------------------------------------------------------------ +r14564 | etxrab | 2005-06-06 12:40:07 -0500 (Mon, 06 Jun 2005) | 1 line +Changed paths: + A /trunk/asn1/tcap/Makefile.nmake -Add higher SI values. +Add makefile.nmake +------------------------------------------------------------------------ +r14565 | etxrab | 2005-06-06 13:01:58 -0500 (Mon, 06 Jun 2005) | 1 line +Changed paths: + A /trunk/epan/dissectors/packet-isup_thin.c +Dissector for ISUP over TCP. ------------------------------------------------------------------------ -r13516 | sahlberg | 2005-02-25 05:38:56 -0600 (Fri, 25 Feb 2005) | 5 lines +r14566 | lego | 2005-06-06 13:45:47 -0500 (Mon, 06 Jun 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-kerberos4.c + M /trunk/epan/dissectors/packet-user_encap.c -add support to call krb4 for suspected krb4 stuff soming in on udp port 88 +the trailer's offset and len were not ok. -weirdo krb4 implementations apparently do this. +------------------------------------------------------------------------ +r14567 | lego | 2005-06-06 13:51:05 -0500 (Mon, 06 Jun 2005) | 3 lines +Changed paths: + M /trunk/asn1/h248/h248.cnf + M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-h248.h +- make sure there's something to add to colinfo. +- auditValueRequest is a request too ------------------------------------------------------------------------ -r13515 | sahlberg | 2005-02-25 04:30:21 -0600 (Fri, 25 Feb 2005) | 7 lines +r14568 | lego | 2005-06-06 13:52:54 -0500 (Mon, 06 Jun 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-dcerpc.h - M /trunk/epan/dissectors/packet-smb-pipe.c - M /trunk/epan/packet_info.h - M /trunk/gtk/decode_as_dcerpc.c + M /trunk/epan/dissectors/packet-sscop.c -pinfo->private_data was a quite subptimal idea +- add an hf entry I forgot +- get the STAT/USTAT PDU list straight -change the decodeas for dcerpc so that it actually works again for dcerpc over smb +------------------------------------------------------------------------ +r14569 | lego | 2005-06-06 13:53:43 -0500 (Mon, 06 Jun 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-alcap.c +register the dissector so that it can be found ------------------------------------------------------------------------ -r13514 | guy | 2005-02-25 03:58:50 -0600 (Fri, 25 Feb 2005) | 8 lines +r14570 | ulfl | 2005-06-06 15:32:08 -0500 (Mon, 06 Jun 2005) | 3 lines Changed paths: - M /trunk/Makefile.am + M /trunk/docbook/edg_src/EDG_chapter_dissection.xml -"docboook/Makefile.auto.in" is presumably generated from -"docbook/Makefile.auto.am", so it shouldn't need to be included in -EXTRA_DIST - and including it causes "make distcheck" to fail very early -with +from Julian Onions: add a devel section about start writing a dissector - make: *** No rule to make target `docbook/Makefile.auto.in', - needed by `distdir'. Stop. +some editing by me ... +------------------------------------------------------------------------ +r14571 | etxrab | 2005-06-06 15:42:18 -0500 (Mon, 06 Jun 2005) | 1 line +Changed paths: + M /trunk/asn1/tcap/packet-tcap-template.c + M /trunk/asn1/tcap/tcap.cnf +Let the sub dissector use the top tree. ------------------------------------------------------------------------ -r13513 | guy | 2005-02-25 03:56:04 -0600 (Fri, 25 Feb 2005) | 2 lines +r14572 | etxrab | 2005-06-07 00:49:06 -0500 (Tue, 07 Jun 2005) | 7 lines Changed paths: - M /trunk/epan/libethereal.def - M /trunk/epan/stats_tree.h + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-ber.h + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/dissectors/packet-tcap.h + +From Tim Endean: + +- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags. +- Both ANSI and ITU variants supported without configuration. +- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first. -There's no "tick_range_with_parent_name()" routine. ------------------------------------------------------------------------ -r13512 | guy | 2005-02-25 02:32:33 -0600 (Fri, 25 Feb 2005) | 3 lines +r14573 | etxrab | 2005-06-07 00:49:57 -0500 (Tue, 07 Jun 2005) | 6 lines Changed paths: - M /trunk/plugins/Xplugin_table.h + M /trunk/asn1/gsmmap/packet-gsm_map-template.c -Fix the declaration of "dissect_ber_boolean()" to match the current -version. +From Tim Endean: + +- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags. +- Both ANSI and ITU variants supported without configuration. +- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first. ------------------------------------------------------------------------ -r13511 | guy | 2005-02-25 02:31:51 -0600 (Fri, 25 Feb 2005) | 3 lines +r14574 | etxrab | 2005-06-07 00:50:28 -0500 (Tue, 07 Jun 2005) | 6 lines Changed paths: - M /trunk/plugins/plugin_api_list.c + M /trunk/asn1/tcap/packet-tcap-template.c + M /trunk/asn1/tcap/tcap.cnf + +From Tim Endean: -Fix the declaration of "dissect_ber_boolean()" to match the current -version. +- I have had to make some changes to packet-ber to allow for PRIVATE and APPLICATION tags. +- Both ANSI and ITU variants supported without configuration. +- Asn.1 dissectors can now register using an OID value as well as an SSN, the oid it tried first. ------------------------------------------------------------------------ -r13510 | guy | 2005-02-25 01:48:51 -0600 (Fri, 25 Feb 2005) | 4 lines +r14575 | kukosa | 2005-06-07 06:58:22 -0500 (Tue, 07 Jun 2005) | 3 lines Changed paths: - M /trunk/epan/libethereal.def - -Add the stats tree routines. + M /trunk/tools/asn2eth.py -Alphabetize, in dictionary order (case-insensitive). +- usage of dissect_per_null() and dissect_ber_null() +- new #.FN_PARS directive (implemented only for OCTET STRING and INTEGER now) +- set true value strings for named bits +------------------------------------------------------------------------ +r14576 | kukosa | 2005-06-07 07:05:03 -0500 (Tue, 07 Jun 2005) | 1 line +Changed paths: + M /trunk/asn1/h225/h225.cnf +Usage of new #.FN_PARS directive instead of #.FN_BODY ------------------------------------------------------------------------ -r13509 | lego | 2005-02-24 23:15:18 -0600 (Thu, 24 Feb 2005) | 3 lines +r14577 | etxrab | 2005-06-07 10:21:22 -0500 (Tue, 07 Jun 2005) | 5 lines Changed paths: - M /trunk/plugins/stats_tree/pinfo_stats_tree.c + M /trunk/gtk/graph_analysis.c -added a tree example +From Alejandro Vaquero: +glib-object.h is is glib2 only. + graph_analysis.c:47:25: glib-object.h: No such file or directory + a patch for ths issue and also to correct the "first_item" +issue reported in "RE: [Ethereal-dev] Voip graph analysis "Save as" button" +------------------------------------------------------------------------ +r14578 | etxrab | 2005-06-07 15:29:23 -0500 (Tue, 07 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-tcap.c +Some fixes from Tim Endean +------------------------------------------------------------------------ +r14579 | etxrab | 2005-06-07 15:30:04 -0500 (Tue, 07 Jun 2005) | 1 line +Changed paths: + M /trunk/asn1/tcap/tcap.asn + M /trunk/asn1/tcap/tcap.cnf +Some fixes from Tim Endean ------------------------------------------------------------------------ -r13508 | lego | 2005-02-24 23:14:38 -0600 (Thu, 24 Feb 2005) | 2 lines +r14580 | etxrab | 2005-06-07 15:56:54 -0500 (Tue, 07 Jun 2005) | 1 line Changed paths: - M /trunk/epan/stats_tree.c - M /trunk/epan/stats_tree.h + M /trunk/etypes.h -change to int the return type of manip_stat_node() so that it can be used as a parent +Add some ethertypes +------------------------------------------------------------------------ +r14581 | etxrab | 2005-06-07 15:57:27 -0500 (Tue, 07 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-ethertype.c +Add some ethertypes ------------------------------------------------------------------------ -r13507 | lego | 2005-02-24 22:02:00 -0600 (Thu, 24 Feb 2005) | 3 lines +r14582 | lego | 2005-06-07 18:22:37 -0500 (Tue, 07 Jun 2005) | 3 lines Changed paths: - M /trunk/Makefile.common - M /trunk/epan/Makefile.common - M /trunk/gtk/Makefile.common + M /trunk/epan/dissectors/packet-alcap.c -Get stats_tree compiled +make sure that colifo gets set and put some other useful info there ------------------------------------------------------------------------ -r13506 | lego | 2005-02-24 21:56:12 -0600 (Thu, 24 Feb 2005) | 6 lines +r14583 | lego | 2005-06-07 18:25:46 -0500 (Tue, 07 Jun 2005) | 5 lines Changed paths: - M /trunk/epan/stats_tree.c - M /trunk/epan/stats_tree_priv.h - M /trunk/gtk/stats_tree_stat.c + M /trunk/epan/dissectors/packet-rtcp.c + M /trunk/epan/dissectors/packet-rtp.c + M /trunk/epan/dissectors/packet-t38.c -some more work for +From: Martin Mathieson -- beautify the text output -- make gtk1 textbox implementation usable (I hope) +fix cases where %d has been used instead of %u... ------------------------------------------------------------------------ -r13505 | etxrab | 2005-02-24 16:36:26 -0600 (Thu, 24 Feb 2005) | 1 line +r14584 | etxrab | 2005-06-08 00:03:36 -0500 (Wed, 08 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-radius.c -Dissect MTP3 with service indicator 14 as H248. +Fix a typo. ------------------------------------------------------------------------ -r13504 | etxrab | 2005-02-24 16:35:10 -0600 (Thu, 24 Feb 2005) | 2 lines +r14585 | etxrab | 2005-06-08 00:04:26 -0500 (Wed, 08 Jun 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-tcap.c -From Ben Turner: -Vendors were not being parsed properly from the XML diameter dictionary. +From Tim Endean: +Fix ssn range ------------------------------------------------------------------------ -r13503 | lego | 2005-02-24 16:04:34 -0600 (Thu, 24 Feb 2005) | 7 lines +r14586 | etxrab | 2005-06-08 00:06:30 -0500 (Wed, 08 Jun 2005) | 1 line Changed paths: - M /trunk/plugins/stats_tree/pinfo_stats_tree.c - M /trunk/plugins/stats_tree/stats_tree_plugin.c + M /trunk/asn1/tcap/packet-tcap-template.c -Change the plugin to be something useful. - -Adds more taps, -tests range nodes -tests pivot nodes +Cahnge ssn range +------------------------------------------------------------------------ +r14587 | ulfl | 2005-06-08 01:33:49 -0500 (Wed, 08 Jun 2005) | 1 line +Changed paths: + M /trunk/tools/fuzz-test.sh +add some general and some cygwin related comments +------------------------------------------------------------------------ +r14588 | ulfl | 2005-06-08 01:40:17 -0500 (Wed, 08 Jun 2005) | 1 line +Changed paths: + M /trunk/tools/fuzz-test.sh +fix a problem if the tools have a space char in their path ------------------------------------------------------------------------ -r13502 | lego | 2005-02-24 16:02:31 -0600 (Thu, 24 Feb 2005) | 7 lines +r14589 | gerald | 2005-06-08 10:32:00 -0500 (Wed, 08 Jun 2005) | 2 lines Changed paths: - M /trunk/epan/stats_tree.c - M /trunk/epan/stats_tree.h - M /trunk/epan/stats_tree_priv.h - M /trunk/gtk/stats_tree_stat.c - M /trunk/tap-stats_tree.c + M /trunk/epan/dissectors/packet-h1.c -Update to the stats_tree tapping API +Break out of an infinite loop. Fixes bug 232. -- change the tap init_string to %s,tree instead of %s,stat -- change the registration key (it used to be tapname, that disallowed to register more than one tap per protocol) -- add a "pivot" node for convenience +------------------------------------------------------------------------ +r14590 | etxrab | 2005-06-08 13:52:34 -0500 (Wed, 08 Jun 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-tcap.c +From Olivier Jacques, +- beautify TCAP decoding without upper dissector associated. +With a couple of if (parameter_tvb) trown in to hopfully fix a Buildbot crash output +------------------------------------------------------------------------ +r14591 | etxrab | 2005-06-08 13:53:11 -0500 (Wed, 08 Jun 2005) | 3 lines +Changed paths: + M /trunk/asn1/tcap/packet-tcap-template.c + M /trunk/asn1/tcap/tcap.cnf +From Olivier Jacques, +- beautify TCAP decoding without upper dissector associated. +With a couple of if (parameter_tvb) trown in to hopfully fix a Buildbot crash output ------------------------------------------------------------------------ -r13501 | lroland | 2005-02-24 15:31:20 -0600 (Thu, 24 Feb 2005) | 3 lines +r14592 | etxrab | 2005-06-08 23:28:13 -0500 (Wed, 08 Jun 2005) | 2 lines Changed paths: - M /trunk/gtk/graph_analysis.c - M /trunk/gtk/graph_analysis.h - M /trunk/gtk/voip_calls.c - M /trunk/gtk/voip_calls.h - M /trunk/gtk/voip_calls_dlg.c + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-tcap.c -By Francisco Alcoba: +From Tim Endean: +Check for tvb. +------------------------------------------------------------------------ +r14593 | etxrab | 2005-06-09 00:40:26 -0500 (Thu, 09 Jun 2005) | 2 lines +Changed paths: + M /trunk/doc/README.developer + M /trunk/doc/README.tapping -Support for name resolution and IPv6 in VoIP Call Analysis +From Mike Duigou +Minor corrections to README.developer and README.tapping ------------------------------------------------------------------------ -r13500 | lego | 2005-02-24 15:22:51 -0600 (Thu, 24 Feb 2005) | 6 lines +r14594 | ulfl | 2005-06-09 01:58:03 -0500 (Thu, 09 Jun 2005) | 3 lines Changed paths: - M /trunk/capture_opts.c + M /trunk/filters.c + +Try to read the "cfilters"/"dfilters" config files from the global path (program dir), if no personal versions of these files are available. +This is the same behaviour, as we do it for the colorfilters/preferences/... files already. +------------------------------------------------------------------------ +r14595 | ulfl | 2005-06-09 02:43:32 -0500 (Thu, 09 Jun 2005) | 7 lines +Changed paths: + M /trunk/Makefile.am + A /trunk/cfilters + A /trunk/colorfilters + A /trunk/dfilters + M /trunk/packaging/nsis/ethereal.nsi -avoid capture stopping after just 1 packet in tethereal, +provide global default files for cfilters/colorfilters/dfilters -- in capture_opts_init() set capture_opts->autostop_packets to 0 instead of one. +at least the colorfilters file needs some more "finetuning" +NSIS (Win32): install these files into the Ethereal Program dir, but don't overwrite existing ones +makefile.am: I've added the three files to EXTRA_DIST and pkgdata_DATA, which *seems* to be the right places ------------------------------------------------------------------------ -r13499 | jmayer | 2005-02-24 13:46:15 -0600 (Thu, 24 Feb 2005) | 1 line +r14596 | ulfl | 2005-06-09 03:03:34 -0500 (Thu, 09 Jun 2005) | 1 line Changed paths: - M /trunk/configure.in + M /trunk/doc/ethereal.pod -Search for fop, not fop.sh +we possibly have global cfilters/dfilters files now ------------------------------------------------------------------------ -r13498 | jmayer | 2005-02-24 13:45:08 -0600 (Thu, 24 Feb 2005) | 1 line +r14597 | etxrab | 2005-06-09 12:25:40 -0500 (Thu, 09 Jun 2005) | 2 lines Changed paths: - M /trunk/wiretap/README.airmagnet + M /trunk/plugins/giop/Makefile.am + M /trunk/plugins/giop/Makefile.nmake + A /trunk/plugins/giop/packet-parlay.c -Minor fixes +Add dissection of parlay +www.parlay.org ------------------------------------------------------------------------ -r13497 | jmayer | 2005-02-24 03:08:20 -0600 (Thu, 24 Feb 2005) | 1 line +r14598 | gerald | 2005-06-09 13:24:55 -0500 (Thu, 09 Jun 2005) | 2 lines Changed paths: M /trunk/Makefile.am - M /trunk/doc/Makefile.am -Didier Gautheron: Fix out of tree compilation +Change "colorfilter" to "colorfilters". Fix up whitespace. + ------------------------------------------------------------------------ -r13496 | jmayer | 2005-02-24 01:23:18 -0600 (Thu, 24 Feb 2005) | 1 line +r14599 | ulfl | 2005-06-09 14:49:56 -0500 (Thu, 09 Jun 2005) | 1 line Changed paths: - M /trunk/Makefile.am + M /trunk/doc/ethereal.pod -Preliminary cleanup of static plugin linking +add some more details to the files section ------------------------------------------------------------------------ -r13495 | jmayer | 2005-02-24 01:19:42 -0600 (Thu, 24 Feb 2005) | 1 line +r14600 | ulfl | 2005-06-09 14:52:10 -0500 (Thu, 09 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-pn-rt.c -Add some minor Cisco proprietary stuff (hostname, network-eap) +add some more details of the RT protocols frame ID's ------------------------------------------------------------------------ -r13494 | guy | 2005-02-23 23:45:15 -0600 (Wed, 23 Feb 2005) | 6 lines +r14601 | ulfl | 2005-06-09 14:55:55 -0500 (Thu, 09 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rtcp.c + M /trunk/gtk/main.c -Clean up white space. +bugfix: don't crash, if cf->filename is NULL (which happens if an invalid capture filter is entered) +------------------------------------------------------------------------ +r14602 | ulfl | 2005-06-09 14:58:02 -0500 (Thu, 09 Jun 2005) | 1 line +Changed paths: + M /trunk/gtk/main.c -"decode_boolean_bitfield()" returns a "const char *" - don't cast it to -a "gchar *" and modify what it points to. Instead, just use -"other_decode_bitfield_value()". +fix positions of create_console()/destroy_console() calls for help and version output +------------------------------------------------------------------------ +r14603 | ulfl | 2005-06-09 15:08:39 -0500 (Thu, 09 Jun 2005) | 1 line +Changed paths: + M /trunk/plugins/profinet/ChangeLog + M /trunk/plugins/profinet/moduleinfo.h +raise plugin version from 0.1.0 to 0.1.1 as some bugs were found using fuzz-test.sh since the last Ethereal release ------------------------------------------------------------------------ -r13493 | guy | 2005-02-23 23:42:51 -0600 (Wed, 23 Feb 2005) | 3 lines +r14604 | ulfl | 2005-06-09 17:46:41 -0500 (Thu, 09 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-eth.h + M /trunk/docbook/edg_src/EDG_chapter_dissection.xml -Not everything that uses "capture_eth()" includes "capture.h" (the ATM -dissector, for one). +from Julian Onions: add more about protocol dissection to the developer's guide +------------------------------------------------------------------------ +r14605 | ulfl | 2005-06-09 17:49:08 -0500 (Thu, 09 Jun 2005) | 1 line +Changed paths: + M /trunk/AUTHORS +add Julian Onions ------------------------------------------------------------------------ -r13492 | guy | 2005-02-23 23:42:03 -0600 (Wed, 23 Feb 2005) | 3 lines +r14606 | lego | 2005-06-10 11:01:16 -0500 (Fri, 10 Jun 2005) | 5 lines Changed paths: - M /trunk/gtk/rtp_stream_dlg.c + M /trunk/wiretap/Makefile.common + M /trunk/wiretap/file_access.c + A /trunk/wiretap/k12.c + A /trunk/wiretap/k12.h + M /trunk/wiretap/wtap-int.h + M /trunk/wiretap/wtap.h + +Initial checkin of the 32 bit tektronix k12 binary format (rf5) + +There is still much to do, but at the very least it can import files allowing the user to choose which protocols handle the diferent sources. -Mallocate the strings to be put into the columns, rather than filling in -fixed-length buffers. ------------------------------------------------------------------------ -r13491 | guy | 2005-02-23 23:40:55 -0600 (Wed, 23 Feb 2005) | 2 lines +r14607 | lego | 2005-06-10 11:23:22 -0500 (Fri, 10 Jun 2005) | 3 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/wiretap/k12.c + +Fixed indentation and removed control characters, in an attempt to understand why windows fail to compile. -Don't include "../image/eicon3d64.xpm", as we're not using it for now. ------------------------------------------------------------------------ -r13490 | guy | 2005-02-23 23:39:59 -0600 (Wed, 23 Feb 2005) | 5 lines +r14608 | ulfl | 2005-06-10 13:28:22 -0500 (Fri, 10 Jun 2005) | 9 lines Changed paths: - M /trunk/capture_opts.c + M /trunk/epan/dissectors/packet-bittorrent.c + M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-cops.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-esis.c + M /trunk/epan/dissectors/packet-gsm_sms_ud.c + M /trunk/epan/dissectors/packet-iax2.c + M /trunk/epan/dissectors/packet-iscsi.c + M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-ldap.c + M /trunk/epan/dissectors/packet-msdp.c + M /trunk/epan/dissectors/packet-msproxy.c + M /trunk/epan/dissectors/packet-mtp3.c + M /trunk/epan/dissectors/packet-ncp2222.inc + M /trunk/epan/dissectors/packet-ospf.c + M /trunk/epan/dissectors/packet-pim.c + M /trunk/epan/dissectors/packet-ppp.c + M /trunk/epan/dissectors/packet-pppoe.c + M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-rtsp.c + M /trunk/epan/dissectors/packet-smb-pipe.c + M /trunk/epan/dissectors/packet-smpp.c + M /trunk/epan/dissectors/packet-sna.c + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-socks.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-udp.c + M /trunk/epan/dissectors/packet-vj.c + M /trunk/epan/dissectors/packet-wbxml.c + M /trunk/epan/dissectors/packet-wcp.c + M /trunk/epan/dissectors/packet-x11.c + +just to get things straight: a dissector should *never* do any g_assert() calls! -Include <string.h> and <ctype.h> to get the appropriate functions -declared and macros defined. +in a simple approach, I've replaced all g_assert() and g_assert_not_reached() calls by their exception throwing counterparts DISSECTOR_ASSERT() and DISSECTOR_ASSERT_NOT_REACHED() -Pass all the necessary arguments to "get_natural_int()". +this will replace application crash by showing a dissector bug, which is the desired behaviour +there were some g_assert calls in the protocol registering functions, which might not be acting as expected now, but to be able to simply search for g_assert in the future I've replaced that calls too + +one g_assert remained, the one when someone throws an unknown exception "into" packet_frame.c, but IMHO this one should remain. ------------------------------------------------------------------------ -r13489 | lego | 2005-02-23 22:15:40 -0600 (Wed, 23 Feb 2005) | 10 lines +r14609 | ulfl | 2005-06-10 13:30:33 -0500 (Fri, 10 Jun 2005) | 1 line Changed paths: - M /trunk/gtk/graph_analysis.c - M /trunk/gtk/voip_calls_dlg.c + M /trunk/plugins/stats_tree/pinfo_stats_tree.c -From Alejandro Vaquero -voip_calls_dlg.c - Change the "prepare filter" function to be protocol independent. Now it uses the - "frame_num"s from the Graph structure to create the filter. This also add support - to MGCP and H323 LRQ/LCF filters that were not supported before. +don't call g_assert_not_reached() for an unknown port type +------------------------------------------------------------------------ +r14610 | ulfl | 2005-06-10 14:09:49 -0500 (Fri, 10 Jun 2005) | 5 lines +Changed paths: + M /trunk/gtk/main.c -graph_analysis.c: - Change the mouse scroll wheel implementation to make a 3 line step change instead of 1 line. +this is an attempt, please report problems: +after asking the devlist if this would break things and got no negative response, try to scan command line parameters twice, trying to "rewind" the getopt settings +this way, fixing #135 ------------------------------------------------------------------------ -r13488 | lego | 2005-02-23 22:11:31 -0600 (Wed, 23 Feb 2005) | 4 lines +r14611 | ulfl | 2005-06-11 07:12:12 -0500 (Sat, 11 Jun 2005) | 1 line Changed paths: - M /trunk/plugins/mate/mate_util.c - M /trunk/plugins/mate/packet-mate.c + M /trunk/gtk/voip_calls_dlg.c -- fix a crash in new_avpl_strict_match when the operator avpl was empty -- change the name of the preference mate.config_filename: into mate.config: +add help button pointing to the wiki page +------------------------------------------------------------------------ +r14612 | etxrab | 2005-06-11 10:58:01 -0500 (Sat, 11 Jun 2005) | 4 lines +Changed paths: + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-csm-encaps.c +From Angelo Bannack, + A CSM_ENCAPS dissector to use with ethereal. +The CSM_ENCAPS is a protocol used by MindSpeed to communicate with your products, and configure VoIP channels. ------------------------------------------------------------------------ -r13487 | ulfl | 2005-02-23 18:30:32 -0600 (Wed, 23 Feb 2005) | 1 line +r14613 | etxrab | 2005-06-11 11:03:24 -0500 (Sat, 11 Jun 2005) | 1 line Changed paths: - M /trunk/capture_sync.c + M /trunk/AUTHORS -if capture filename passed to parent, save it. Will currently take no effect. +Add Angelo Bannack as an author. ------------------------------------------------------------------------ -r13486 | etxrab | 2005-02-23 17:14:42 -0600 (Wed, 23 Feb 2005) | 1 line +r14614 | ulfl | 2005-06-11 11:50:18 -0500 (Sat, 11 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h + M /trunk/gtk/voip_calls_dlg.c -fix some asn2eth warnings +add missing #include "webbrowser.h" from previous commit ------------------------------------------------------------------------ -r13485 | etxrab | 2005-02-23 17:13:57 -0600 (Wed, 23 Feb 2005) | 1 line +r14615 | guy | 2005-06-11 14:02:31 -0500 (Sat, 11 Jun 2005) | 2 lines Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/docbook/edg_src/EDG_chapter_libraries.xml + +Update references to the WinPcap Web site. -Fix some asn2eth warnings. ------------------------------------------------------------------------ -r13484 | etxrab | 2005-02-23 17:12:48 -0600 (Wed, 23 Feb 2005) | 1 line +r14616 | guy | 2005-06-11 14:03:49 -0500 (Sat, 11 Jun 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-h248.c - M /trunk/epan/dissectors/packet-h248.h + M /trunk/docbook/user-guide.xml + +Update references to the WinPcap Web site. -Add dissection of packet tdmc ------------------------------------------------------------------------ -r13483 | etxrab | 2005-02-23 17:12:07 -0600 (Wed, 23 Feb 2005) | 1 line +r14617 | etxrab | 2005-06-11 16:31:13 -0500 (Sat, 11 Jun 2005) | 1 line Changed paths: - M /trunk/asn1/h248/packet-h248-template.c + M /trunk/epan/dissectors/packet-yhoo.c -Add dissection of packet tdmc +Add some yhoo_service_vals ------------------------------------------------------------------------ -r13482 | ulfl | 2005-02-23 16:04:31 -0600 (Wed, 23 Feb 2005) | 1 line +r14618 | ulfl | 2005-06-13 01:55:06 -0500 (Mon, 13 Jun 2005) | 1 line Changed paths: - M /trunk/capture_loop.c - M /trunk/capture_opts.c - M /trunk/capture_sync.c - M /trunk/capture_sync.h + M /trunk/docbook/catalog.xml -pass child capture filename to parent process (name currently unused) and some fork_child cleanup +from Jaap Keuter: add some comments, how paths should look like for a debian distro ------------------------------------------------------------------------ -r13481 | ulfl | 2005-02-23 15:04:19 -0600 (Wed, 23 Feb 2005) | 1 line +r14619 | lego | 2005-06-13 03:47:24 -0500 (Mon, 13 Jun 2005) | 2 lines Changed paths: - M /trunk/capture.h + M /trunk/plugins/giop/Makefile.am + +Add the missing parlay.la to the makefile -CHILD_NAME is only used #ifdef HAVE_LIBPCAP ------------------------------------------------------------------------ -r13480 | lego | 2005-02-23 11:05:32 -0600 (Wed, 23 Feb 2005) | 4 lines +r14620 | gerald | 2005-06-13 11:31:01 -0500 (Mon, 13 Jun 2005) | 4 lines Changed paths: - M /trunk/tethereal.c + M /trunk/Makefile.am + M /trunk/make-version.pl + +Read .svn/entries directly instead of calling "svn info", as suggested by +Thomas Anders. This should make things more locale-independent and remove +a dependency on "svn" being present. + +------------------------------------------------------------------------ +r14621 | lego | 2005-06-13 14:45:21 -0500 (Mon, 13 Jun 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-k12.c + M /trunk/wiretap/k12.c + M /trunk/wiretap/wtap.h -in tethereal -list_link_layer_types was not being initialized causing the "-r" option to fail +use a helper dissector to show k12 files. ------------------------------------------------------------------------ -r13479 | sahlberg | 2005-02-23 02:57:47 -0600 (Wed, 23 Feb 2005) | 3 lines +r14622 | ulfl | 2005-06-13 15:01:05 -0500 (Mon, 13 Jun 2005) | 1 line Changed paths: - M /trunk/asn1/cms/cms-exp.cnf - M /trunk/asn1/pkixcrmf/crmf-exp.cnf - M /trunk/asn1/x509af/x509af-exp.cnf - M /trunk/asn1/x509ce/x509ce-exp.cnf - M /trunk/asn1/x509if/x509if-exp.cnf - M /trunk/asn1/x509sat/x509sat-exp.cnf - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-ber.h - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-cms.h - M /trunk/epan/dissectors/packet-crmf.c - M /trunk/epan/dissectors/packet-crmf.h - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h - M /trunk/epan/dissectors/packet-h248.c - M /trunk/epan/dissectors/packet-h248.h - M /trunk/epan/dissectors/packet-inap.c - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-ocsp.c - M /trunk/epan/dissectors/packet-pkcs1.c - M /trunk/epan/dissectors/packet-pkix1explicit.c - M /trunk/epan/dissectors/packet-pkix1explicit.h - M /trunk/epan/dissectors/packet-pkixqualified.c - M /trunk/epan/dissectors/packet-pkixtsp.c - M /trunk/epan/dissectors/packet-smrse.c - M /trunk/epan/dissectors/packet-x509af.c - M /trunk/epan/dissectors/packet-x509af.h - M /trunk/epan/dissectors/packet-x509ce.c - M /trunk/epan/dissectors/packet-x509ce.h - M /trunk/epan/dissectors/packet-x509if.c - M /trunk/epan/dissectors/packet-x509if.h - M /trunk/epan/dissectors/packet-x509sat.c - M /trunk/epan/dissectors/packet-x509sat.h - M /trunk/tools/asn2eth.py + M /trunk/docbook/eug_src/EUG_chapter_build_install.xml -update asn2eth and all generated dissectors to new dissect_ber_boolean that takes a implicit_tag parameter +minor editing +------------------------------------------------------------------------ +r14623 | ulfl | 2005-06-13 15:04:09 -0500 (Mon, 13 Jun 2005) | 1 line +Changed paths: + M /trunk/docbook/eug_src/EUG_chapter_introduction.xml + +the note about not sending sensitive information to the lists should really be a warning, not only a note +------------------------------------------------------------------------ +r14624 | gerald | 2005-06-13 17:40:11 -0500 (Mon, 13 Jun 2005) | 8 lines +Changed paths: + M /trunk/clopts_common.c + M /trunk/epan/prefs.c + +Change read_prefs() to use GStrings instead of (re)allocating memory +ourselves. This fixes a potential off-by-one error found by Steve Grubb. + +Add two new -G options: defaultprefs and currentprefs. The first dumps +the default preferences to stdout and the second dumps the user's prefs +to stdout. ------------------------------------------------------------------------ -r13478 | sahlberg | 2005-02-23 02:38:18 -0600 (Wed, 23 Feb 2005) | 3 lines +r14625 | jmayer | 2005-06-14 08:35:24 -0500 (Tue, 14 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ndmp.c + M /trunk/asn1/gsmmap/packet-gsm_map-template.c -fix printout of length of ndmp pdu +No // comments +------------------------------------------------------------------------ +r14626 | jmayer | 2005-06-14 09:33:55 -0500 (Tue, 14 Jun 2005) | 4 lines +Changed paths: + M /trunk/epan/dissectors/packet-wlancap.c +Always skip the whole header: The current code would only decode +sizeof strcut wlan_header_v1 bytes, but if our struct was missing +some newer elements, things would go wrong. ------------------------------------------------------------------------ -r13477 | sahlberg | 2005-02-23 02:37:30 -0600 (Wed, 23 Feb 2005) | 4 lines +r14627 | gerald | 2005-06-14 13:18:05 -0500 (Tue, 14 Jun 2005) | 15 lines Changed paths: - M /trunk/gtk/voip_calls.c + M /trunk/epan/dissectors/packet-dcerpc-samr.c + M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/dissectors/packet-isis-lsp.c + M /trunk/epan/dissectors/packet-ncp2222.inc + M /trunk/tools/lemon/lemon.c + +From Steve Grubb: -g_strrstr does not exist in gtk 1 -replace it with strstr +Fix bounds checking in lemon.c. Fix up an if/else block in +packet-dcerpc-samr.c. Fix hex printing in packet-gtp.c. +Fix other problems discovered by Steve: + +Fix a bounds check in packet-isis-lsp.c. Also, fix netmask printing +on non-little-endian machines. Add a comment about adding a netmask +routine to to_str.c. Add bounds checks to packet-ncp2222.inc. + + +All of these apply to bug 217. + ------------------------------------------------------------------------ -r13476 | ulfl | 2005-02-23 02:34:12 -0600 (Wed, 23 Feb 2005) | 1 line +r14628 | etxrab | 2005-06-14 16:45:29 -0500 (Tue, 14 Jun 2005) | 1 line Changed paths: - M /trunk/capture.h - M /trunk/capture_opts.c - M /trunk/gtk/main.c - M /trunk/tethereal.c + M /trunk/epan/sminmpec.c + M /trunk/epan/sminmpec.h -use the applications name (currently "ethereal" or "tethereal") in capture_opts, instead of hardcoded "ethereal" for both. +Add Vendor ID of T-Mobile and T-Systems Nova International GmbH. ------------------------------------------------------------------------ -r13475 | gerald | 2005-02-22 23:47:17 -0600 (Tue, 22 Feb 2005) | 2 lines +r14629 | etxrab | 2005-06-14 16:46:51 -0500 (Tue, 14 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-radius.c -Add request URI and Version fields. Add a question about fixing a memory leak. +Add vendor AVP:s for T-Mobile and T-Systems Nova International GmbH. +------------------------------------------------------------------------ +r14630 | etxrab | 2005-06-14 16:48:42 -0500 (Tue, 14 Jun 2005) | 3 lines +Changed paths: + M /trunk/gtk/voip_calls_dlg.c + +From Javier Acuna +patch to include Cic info in Voip Calls ------------------------------------------------------------------------ -r13474 | ulfl | 2005-02-22 19:01:19 -0600 (Tue, 22 Feb 2005) | 1 line +r14631 | etxrab | 2005-06-14 16:57:17 -0500 (Tue, 14 Jun 2005) | 1 line Changed paths: - M /trunk/Makefile.common - M /trunk/capture.c - A /trunk/capture_opts.c - M /trunk/gtk/main.c - M /trunk/tethereal.c + M /trunk/plugins/giop/Makefile.am -move capture_opts related things (init, command line, ...) from capture.c to a new file capture_opts.c and let both ethereal and tethereal use it. +Correct a typo ------------------------------------------------------------------------ -r13473 | ulfl | 2005-02-22 17:46:54 -0600 (Tue, 22 Feb 2005) | 5 lines +r14632 | etxrab | 2005-06-14 16:58:54 -0500 (Tue, 14 Jun 2005) | 2 lines Changed paths: - M /trunk/capture.c - M /trunk/doc/ethereal.pod + M /trunk/epan/dissectors/packet-ymsg.c + +From Samuel Thibault, +Some updates to the yahoo msg dissector. +------------------------------------------------------------------------ +r14633 | etxrab | 2005-06-14 17:01:55 -0500 (Tue, 14 Jun 2005) | 1 line +Changed paths: + M /trunk/AUTHORS + +Add Samuel Thibault +------------------------------------------------------------------------ +r14634 | gerald | 2005-06-15 10:10:02 -0500 (Wed, 15 Jun 2005) | 5 lines +Changed paths: + M /trunk/epan/proto.c -add the number of autostop files to the command line parameters, e.g.: +When we add an FT_STRINGZ item, throw an exception if the length is +less than -1. If the length is 0, set the item string to "[Empty]". +This fixes bug 219. --a files:20 -also added this to the manpage, the user's guide will follow later ------------------------------------------------------------------------ -r13472 | ulfl | 2005-02-22 15:22:56 -0600 (Tue, 22 Feb 2005) | 2 lines +r14635 | gerald | 2005-06-15 12:56:47 -0500 (Wed, 15 Jun 2005) | 3 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/epan/dissectors/packet-csm-encaps.c + +Fix an infinite loop found by randpkt testing. Change the line endings from +DOS to UNIX. -There seems to be some disagreement about if and how the welcome screen feature should be implemented. -As I currently don't have the time to continue this, I've temporarily disabled it. ------------------------------------------------------------------------ -r13471 | ulfl | 2005-02-22 14:25:23 -0600 (Tue, 22 Feb 2005) | 1 line +r14636 | gerald | 2005-06-15 13:35:13 -0500 (Wed, 15 Jun 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-pn-io.c - M /trunk/epan/dissectors/packet-pn-rt.c + M /trunk/epan/dissectors/packet-lmp.c + +Fix a couple of infinite loops found by Buildbot. Were the recent +changes to this dissector fuzz tested at all? -fix usage of "if(tree) {" to display the right things, even if no coloring rule is set ------------------------------------------------------------------------ -r13470 | lego | 2005-02-22 13:37:46 -0600 (Tue, 22 Feb 2005) | 5 lines +r14637 | gerald | 2005-06-15 15:55:11 -0500 (Wed, 15 Jun 2005) | 4 lines Changed paths: - M /trunk/gtk/voip_calls.c + M /trunk/epan/dissectors/packet-dcerpc-samr.c -From Alejandro Vaquero: - replace the code that used g_strsplit_set and was broken by me - changing it to g_strsplit with something that works +In sam_dissect_SAM_SECURITY_DESCRIPTOR_data(), throw an exception if we +fetch a too-long length. Fixes bug 236. ------------------------------------------------------------------------ -r13469 | lego | 2005-02-22 13:17:28 -0600 (Tue, 22 Feb 2005) | 7 lines +r14638 | gerald | 2005-06-15 16:33:48 -0500 (Wed, 15 Jun 2005) | 2 lines Changed paths: - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-pagp.c -Do not call the tap's initialization as soon as the -z option is read, -postpone it after the preferences callback has being called. +Add missing hf entries. Fixes bug 240. -That way mate's fields, which are registered by the preferences callback -can be used as part of the tap's filter. +------------------------------------------------------------------------ +r14639 | gerald | 2005-06-15 16:42:30 -0500 (Wed, 15 Jun 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-smpp.c +Catch an infinite loop in smpp_handle_dlist(). Fixes bug 246. ------------------------------------------------------------------------ -r13468 | ulfl | 2005-02-22 01:53:54 -0600 (Tue, 22 Feb 2005) | 1 line +r14640 | gerald | 2005-06-15 17:08:43 -0500 (Wed, 15 Jun 2005) | 3 lines Changed paths: - M /trunk/gtk/graph_analysis.c + M /trunk/epan/dissectors/packet-dcerpc-browser.c + +Make sure dissect_browser_TYPE_12_data() returns the right value. Catch +integer overflows in that and other functions. Fixes bug 236. -prevent messages like "Couldn't load font x, falling back to y", see comment for details ------------------------------------------------------------------------ -r13467 | ulfl | 2005-02-22 01:31:19 -0600 (Tue, 22 Feb 2005) | 1 line +r14641 | ulfl | 2005-06-15 17:45:51 -0500 (Wed, 15 Jun 2005) | 1 line Changed paths: - M /trunk/gtk/voip_calls_dlg.c + M /trunk/docbook/eug_src/EUG_chapter_build_install.xml -some changes to the dialog's button behaviour +minor editing ------------------------------------------------------------------------ -r13466 | ulfl | 2005-02-22 01:25:16 -0600 (Tue, 22 Feb 2005) | 1 line +r14642 | ulfl | 2005-06-15 17:47:20 -0500 (Wed, 15 Jun 2005) | 1 line Changed paths: - M /trunk/gtk/voip_calls.c + M /trunk/docbook/eug_src/EUG_chapter_use.xml -bugfix: using the "rtp_example.raw.gz" from the wiki, the dialog runs into an endless loop, as a g_list_next() was missing in a while loop +update various menu items (screenshots must be updated as well) ------------------------------------------------------------------------ -r13465 | ulfl | 2005-02-22 01:22:51 -0600 (Tue, 22 Feb 2005) | 1 line +r14643 | gerald | 2005-06-15 17:56:23 -0500 (Wed, 15 Jun 2005) | 2 lines Changed paths: - M /trunk/gtk/rtp_stream_dlg.c + M /trunk/epan/dissectors/packet-per.c + +Handle FT_UINTs in dissect_per_integer(). Fixes bug 234. -buttons should use "Header capitalization" see GNOME HIG http://developer.gnome.org/projects/gup/hig/1.0/layout.html#layout-capitalization ------------------------------------------------------------------------ -r13464 | lego | 2005-02-21 20:16:35 -0600 (Mon, 21 Feb 2005) | 2 lines +r14644 | ulfl | 2005-06-15 18:05:37 -0500 (Wed, 15 Jun 2005) | 1 line Changed paths: - M /trunk/plugins/mate/mate_setup.c + M /trunk/gtk/compat_macros.h -avoid crashing when Debug_Cfg is set and no Payload is given for a Pdu +don't call "Capture/Start" Capture but Start in the toolbar +------------------------------------------------------------------------ +r14645 | ulfl | 2005-06-15 18:55:46 -0500 (Wed, 15 Jun 2005) | 1 line +Changed paths: + M /trunk/docbook/Makefile + M /trunk/docbook/eug_src/EUG_chapter_use.xml + A /trunk/docbook/graphics/toolbar/autoscroll_24.png + D /trunk/docbook/graphics/toolbar/capture_24.png + A /trunk/docbook/graphics/toolbar/capture_filter_24.png + A /trunk/docbook/graphics/toolbar/capture_interfaces_24.png + A /trunk/docbook/graphics/toolbar/capture_options_24.png + A /trunk/docbook/graphics/toolbar/capture_restart_24.png + A /trunk/docbook/graphics/toolbar/capture_start_24.png + A /trunk/docbook/graphics/toolbar/capture_stop_24.png + D /trunk/docbook/graphics/toolbar/cfilter_24.png + A /trunk/docbook/graphics/toolbar/colorize_24.png + D /trunk/docbook/graphics/toolbar/dfilter_24.png + A /trunk/docbook/graphics/toolbar/display_filter_24.png + A /trunk/docbook/graphics/toolbar/resize_columns_24.png + M /trunk/docbook/user-guide.xml +update toolbar items and icons ------------------------------------------------------------------------ -r13463 | lego | 2005-02-21 19:55:04 -0600 (Mon, 21 Feb 2005) | 7 lines +r14646 | lego | 2005-06-15 21:27:30 -0500 (Wed, 15 Jun 2005) | 5 lines Changed paths: - M /trunk/epan/addr_resolv.c - M /trunk/epan/addr_resolv.h - M /trunk/epan/address.h - M /trunk/epan/column-utils.c - M /trunk/gtk/conversations_table.c - M /trunk/gtk/hostlist_table.c + M /trunk/epan/dissectors/packet-k12.c + M /trunk/wiretap/k12.c + M /trunk/wiretap/wtap.h -From Francisco Alcoba: -changed the behaviour of get_addr_name: - - resolve to a name if the address supports it - - call address_to_str if it does not, but the address is valid - - return "NONE" if it is AT_NONE +third and last(?) iteration on the import routines for tektronix 32bit rf5 files. +Now the import is correct even for large files. +I found out when and where the "junk" was inserted. ------------------------------------------------------------------------ -r13462 | lego | 2005-02-21 17:29:49 -0600 (Mon, 21 Feb 2005) | 4 lines +r14647 | guy | 2005-06-16 01:06:18 -0500 (Thu, 16 Jun 2005) | 2 lines Changed paths: - M /trunk/plugins/mgcp/packet-mgcp.h + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-gsm_map.h +Regenerate - this squelches some compiler warnings. -ooops,I forgot this one with the last checkin +------------------------------------------------------------------------ +r14648 | guy | 2005-06-16 01:19:03 -0500 (Thu, 16 Jun 2005) | 11 lines +Changed paths: + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-isakmp.c + A /trunk/epan/dissectors/packet-isakmp.h + M /trunk/epan/dissectors/packet-kink.c + +Static variables considered harmful. Make the ISAKMP version a +parameter to many functions inside the ISAKMP dissector, as well as to +the "isakmp_dissect_payloads()" routine it exports. Get rid of +"isakmp_set_version()", as the version can be passed to +"isakmp_dissect_payloads()" from the KINK dissector. +Put the declaration of "isakmp_dissect_payloads()" into a +"packet-isakmp.h" header, and have "packet-isakmp.c" and "packet-kink.h" +include it rather than declariing "isakmp_dissect_payloads()" itself - +or not doing so at all. ------------------------------------------------------------------------ -r13461 | lego | 2005-02-21 16:53:01 -0600 (Mon, 21 Feb 2005) | 7 lines +r14649 | guy | 2005-06-16 01:27:18 -0500 (Thu, 16 Jun 2005) | 2 lines Changed paths: - M /trunk/gtk/voip_calls.c + M /trunk/epan/dissectors/packet-kink.c -from Alejandro Vaquero - - fix the thinks I broken removing warnings in the last commit +Squelch some compiler warnings. + +------------------------------------------------------------------------ +r14650 | guy | 2005-06-16 01:28:50 -0500 (Thu, 16 Jun 2005) | 6 lines +Changed paths: + M /trunk/epan/dissectors/packet-msrp.c -other than that I removed calls to glib2 that broke -compilation on solaris' buiddbot +Include <ctype.h> to get "isdigit()" defined/declared. +"dissect_msrp()" is a "new-style" dissector; register it as such. + +Squelch an uninitialized variable warning. ------------------------------------------------------------------------ -r13460 | ulfl | 2005-02-21 14:19:15 -0600 (Mon, 21 Feb 2005) | 1 line +r14651 | guy | 2005-06-16 01:30:33 -0500 (Thu, 16 Jun 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-ethertype.c - M /trunk/etypes.h + M /trunk/epan/dissectors/packet-per.c + +"proto_tree_add_text()" doesn't add a named field, so it takes no "hf_" +argument. + +Report a non-integral type used with "dissect_per_integer()" with an +explicit "REPORT_DISSECTOR_BUG()" call, as that's a dissector bug. -added IEEE 802.1 Link Layer Discovery Protocol (LLDP) to the ethertypes, but sorry, no dissector (yet?) ------------------------------------------------------------------------ -r13459 | ulfl | 2005-02-21 13:51:13 -0600 (Mon, 21 Feb 2005) | 1 line +r14652 | guy | 2005-06-16 01:31:25 -0500 (Thu, 16 Jun 2005) | 2 lines Changed paths: - M /trunk/gtk/about_dlg.c + M /trunk/epan/dissectors/packet-jxta.c + +Squelch some unitialized variable warnings. -We've "just reached" 2005, extend the copyright notice by the "new" year ... ------------------------------------------------------------------------ -r13458 | ulfl | 2005-02-21 13:49:38 -0600 (Mon, 21 Feb 2005) | 1 line +r14653 | guy | 2005-06-16 01:32:20 -0500 (Thu, 16 Jun 2005) | 2 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/epan/dissectors/packet-isup_thin.c + +"dissect_isup_thin()" is a new-style dissector; register it as such. -As we have a (two) WishList(s) in the Wiki now, this to do list doesn't make any sense ------------------------------------------------------------------------ -r13457 | lego | 2005-02-20 21:06:41 -0600 (Sun, 20 Feb 2005) | 5 lines +r14654 | guy | 2005-06-16 01:33:49 -0500 (Thu, 16 Jun 2005) | 2 lines Changed paths: - M /trunk/gtk/graph_analysis.c - -From Alejandro Vaquero -Add support of mouse scroll wheel and directional keys -(Up, down, left, and right) in the Graph Analysis. + M /trunk/gtk/recent.c +Include <ctype.h> to define/declare "isspace()". ------------------------------------------------------------------------ -r13456 | lego | 2005-02-20 20:36:55 -0600 (Sun, 20 Feb 2005) | 6 lines +r14655 | guy | 2005-06-16 01:34:27 -0500 (Thu, 16 Jun 2005) | 2 lines Changed paths: - M /trunk/gtk/voip_calls.c + M /trunk/gtk/main.c -fix few things: -- boolean does not exists in *nix change them to g_boolean -- removed some warnings about uninitialized variables -- mgcp_info->hasDigitMap is a pointer to a boolean, dereference it +Fix a typo, and squelch a compiler warning. + +------------------------------------------------------------------------ +r14656 | guy | 2005-06-16 01:41:28 -0500 (Thu, 16 Jun 2005) | 2 lines +Changed paths: + M /trunk/gtk/main.c +Don't hand a null pointer to a "%s" format. ------------------------------------------------------------------------ -r13455 | ulfl | 2005-02-20 20:35:42 -0600 (Sun, 20 Feb 2005) | 3 lines +r14657 | guy | 2005-06-16 01:50:20 -0500 (Thu, 16 Jun 2005) | 3 lines Changed paths: - M /trunk/docbook/Makefile + M /trunk/epan/dissectors/packet-lmp.c -I have to check this in with HHC enabled, otherwise I cannot get a chm file without the SVN-version.xml includes a modified tag. +Register "version" as an obsolete preference, so it's silently ignored, +rather than provoking a warning. -Joerg seem's to have fix this HHC thing, so it should be compilable on unix systems without errors (hopefully). ------------------------------------------------------------------------ -r13454 | ulfl | 2005-02-20 20:12:21 -0600 (Sun, 20 Feb 2005) | 1 line +r14658 | guy | 2005-06-16 02:46:03 -0500 (Thu, 16 Jun 2005) | 20 lines Changed paths: - M /trunk/docbook/Makefile + M /trunk/asn1/tcap/packet-tcap-template.c + M /trunk/asn1/tcap/tcap.cnf + M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/dissectors/packet-tcap.h + +Clean up white space. + +Register "standard" and "lock_info_col" as obsolete preferences, so +they're silently ignored rather than triggering warnings. + +Propagate changes to check for "dissect_ber_octet_string()" supplying a +null tvbuff pointer from the checkins to the generated dissector ("Do +not modify this file" means "Do not modify this file"!) to the tcap.cnf +file, so that they're not lost if the dissector is regenerated. (Don't +propagate the checks for "tvb_new_subset()" returning null - it never +returns null.) + +Pass -1 to "tvb_new_subset()" when appropriate. + +When looping over packet data, check against the reported length, not +the captured length, so we indicate a short frame if we get stopped by +the snapshot length. + +Get rid of unused variables. -add svn_version.xml to both validate targets ------------------------------------------------------------------------ -r13453 | jmayer | 2005-02-20 19:02:43 -0600 (Sun, 20 Feb 2005) | 1 line +r14659 | guy | 2005-06-16 03:10:13 -0500 (Thu, 16 Jun 2005) | 5 lines Changed paths: - M /trunk/docbook + M /trunk/wiretap/netxray.c + +Note that the WAN_CAPTYPE value of 4 can correspond to Cisco HDLC +traffic as well as Frame Relay traffic, and give some information about +the cruft found in the xxc field of the header for one CHDLC and one FR +capture. -svn:ignore the new pdf file names and svn_version.xml ------------------------------------------------------------------------ -r13452 | ulfl | 2005-02-20 16:36:34 -0600 (Sun, 20 Feb 2005) | 3 lines +r14660 | guy | 2005-06-16 04:58:01 -0500 (Thu, 16 Jun 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dcm.c - M /trunk/epan/dissectors/packet-pres.c - M /trunk/epan/dissectors/packet-rtcp.c - M /trunk/epan/dissectors/packet-sigcomp.c - M /trunk/epan/sigcomp_state_hdlr.c - M /trunk/epan/xmlstub.h - M /trunk/plugins/acn/packet-acn.c - M /trunk/plugins/lwres/packet-lwres.c - M /trunk/plugins/mate/mate_util.c + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-jxta.c -fix a typo: lenght -> length +From Peter Kovar: fix an incorrect assignment that caused a compilation +error with GCC 4. -This seems to be a "more common" typo, fixed it 13 times throughout the code ... ------------------------------------------------------------------------ -r13451 | ulfl | 2005-02-20 15:45:52 -0600 (Sun, 20 Feb 2005) | 3 lines +r14661 | guy | 2005-06-16 05:05:23 -0500 (Thu, 16 Jun 2005) | 4 lines Changed paths: - M /trunk/docbook/Makefile + M /trunk/gtk/hostlist_jxta.c -from Joerg Mayer: changes towards the automake generation +Get rid of unnecessary assignment and unnecessary "volatile" qualifier. + +Mark unused parameter as such. -I've added some minor cleanup things ------------------------------------------------------------------------ -r13450 | ulfl | 2005-02-20 14:49:15 -0600 (Sun, 20 Feb 2005) | 6 lines +r14662 | guy | 2005-06-16 05:06:22 -0500 (Thu, 16 Jun 2005) | 4 lines Changed paths: - A /trunk/docbook/edg_graphics/note.png - A /trunk/docbook/edg_graphics/tip.png - A /trunk/docbook/edg_graphics/warning.png - M /trunk/docbook/graphics/note.png - M /trunk/docbook/graphics/tip.png - M /trunk/docbook/graphics/warning.png + M /trunk/epan/dissectors/packet-k12.c -The former icons used for both guide's were copied from the DOCBOOKXSLT package, which is used to convert the files from XML to HTML or whatever. +Remove unused variable. -As it's unsure if the license of these icons match the way we use it (I would think so, but I'm unsure), -I've replaced them by stock icons (see http://developer.gnome.org/doc/API/2.0/gtk/gtk-Stock-Items.html) from the GTK library (licensed under LPGL), so it should be ok to use them in an GPL project. +Clean up indentation. -I had to scale them from 48x48 to 24x24, but the Gimp is my friend :-) ------------------------------------------------------------------------ -r13449 | lego | 2005-02-20 12:18:10 -0600 (Sun, 20 Feb 2005) | 2 lines +r14663 | jmayer | 2005-06-16 12:23:34 -0500 (Thu, 16 Jun 2005) | 3 lines Changed paths: - M /trunk/gtk/stats_tree_stat.c + M /trunk/epan/proto.h + M /trunk/epan/value_string.h -comment out two g_message() calls +Get rid of several megabytes worth of warnings about +"discards qualifier from assignment". ------------------------------------------------------------------------ -r13448 | lego | 2005-02-20 11:43:38 -0600 (Sun, 20 Feb 2005) | 5 lines +r14664 | gerald | 2005-06-16 14:51:14 -0500 (Thu, 16 Jun 2005) | 2 lines Changed paths: - M /trunk/epan/stats_tree.c - M /trunk/epan/stats_tree.h - M /trunk/epan/stats_tree_priv.h - M /trunk/gtk/stats_tree_stat.c - M /trunk/plugins/stats_tree/stats_tree_plugin.c + M /trunk/epan/dissectors/packet-smpp.c -Fixes few things during reinitialization with gtk2 (it doesn't crash anymore), - there are still problems at reinit (gtk2 node->pr warns about an iterator not been OK) +Fix Win32 compilation, broken by yesterday's checkin. -set up propperties of the given files +------------------------------------------------------------------------ +r14665 | ulfl | 2005-06-16 15:27:55 -0500 (Thu, 16 Jun 2005) | 1 line +Changed paths: + M /trunk/docbook/eug_src/EUG_chapter_capture.xml + M /trunk/docbook/eug_src/EUG_chapter_io.xml +updated to latest Ethereal GUI ------------------------------------------------------------------------ -r13447 | lroland | 2005-02-20 09:53:11 -0600 (Sun, 20 Feb 2005) | 7 lines +r14666 | etxrab | 2005-06-16 16:15:12 -0500 (Thu, 16 Jun 2005) | 115 lines Changed paths: - M /trunk/gtk/mgcp_stat.c - M /trunk/gtk/voip_calls.c - M /trunk/gtk/voip_calls.h - M /trunk/gtk/voip_calls_dlg.c - M /trunk/plugins/mgcp/packet-mgcp.c - M /trunk/plugins/mgcp/packet-mgcp.h - M /trunk/tap-mgcpstat.c + M /trunk/epan/sigcomp-udvm.c + M /trunk/epan/sigcomp-udvm.h + M /trunk/epan/sigcomp_state_hdlr.c + M /trunk/epan/sigcomp_state_hdlr.h -Don't register mgcp taps, -when we haven't loaded the mgcp plugin. +From Paul Ollis: + epan/sigcomp_state_hdlr.c epan/sigcomp_state_hdlr.h + --------------------------------------------------- -and + Function udvm_state_access: + + 1. Removed the state_vars_valid parameter. It is no longer used. + + 2. The function now correctly updates each of state_length, + state_address and state_instruction with saved state value. + + [Previously this was only done for state referenced in the SigComp + message header.] + + 3. Removed code that (incorrectly) read byte_copy_left from UDVM memory + within the loop that writes the state to UDVM memory. + + 4. Removed the code that set the useful values in UDVM memory. This + should only be done for state referenced in the SigComp message + header. (The decompress_sigcomp_message function, sets the useful + values.) + + + epan/sigcomp-udvm.c epan/sigcomp-udvm.h + --------------------------------------- + + Function decompress_sigcomp_message: + + 1. Added three new parameters; header_len, byte_code_state_len, + byte_code_id_len. The byte_code_state_len and byte_code_id_len + are used to set the useful values in UDVM memory. The + header_len is required to calculate the cycles available + for decompression. + + 2. Various minor corrections to spellings, etc in generated + messages. + + 3. Reduced the number of lines of output for print_level_1. Now + the execution trace shows the instruction name and parameter + values on one line. + + [This was done because, we found that even at the lowest + level of detail ethereal became unusably slow; running on + a 500 MHz SPARC. This seems to be related to the number of + lines produced by the SigComp trace, which can easily be over + 1000 with the modified code.] + + 4. Removed the used of some floating point functions. In all + cases they were unnecessary and could potentially cause the + code to produce the wrong results on some platforms (although + this is unlikely). + + 5. The useful values are now set correctly, using the new + byte_code_state_len and byte_code_id_len parameters. + + 6. The message header length is now included in the calculation of + maximum_UDVM_cycles. Previously, the calculation could underestimate + the value, resulting in the (small) chance that some legitimate + messages might fail to decompress. + + Note: The calculation might now slightly over-estimate the cycles + but this is a reasonable thing to do. + + 7. Implemented the PUSH, POP, CALL and RETURN instructions. + + Note: The two SORT instructions and the CRC and SHA-1 instructions + are still not implemented. + + 8. The COPY and COPY-LITERAL instructions now apply the + byte-copying-rules to the source address as well as the destination + address. + + 9. The COPY-LITERAL and COPY-OFFSET now correctly handle the + destination operand. Previously, it was possible for the destination + to be left at byte_copy_right when it should be left at + byte_copy_left. + + 10. All three COPY instructions will now behave correctly if the source + or destination start at byte_copy_right; i.e. they read/write to + byte_copy_right, byte_copy_right+1, etc. Previously the parameters + would wrap to byte_copy_left. + + 11. The COPY-OFFSET instruction now correctly calculates the source + address for all values of offset. Previously a very large offset + (greater than the circular buffer size) could cause the starting + position to be mis-calculated. + + 12. Modulo 65536 arithmetic has been added in some places where it was + missing. + + [Only when noticed, we have not been able to check all the code.] + + 13. Some redundant code was removed for the INPUT-BITS instruction. + Also, INPUT-BITS (0, x, x) now correctly discards spare bits when + the P-bit, has changed. + + 14. Corrected the cycles used calculation for the INPUT-BITS + instruction. + + 15. Corrected some minor cases where the used_udvm_cycles was not + incremented. + + [Not really a problem, but it allowed us to verify correctness with + some of the SigComp torture tests.] + + 16. Removed some redundant code in INPUT-HUFFMAN (and reorganised some + comments to keep them making sense). + + + Function decomp_dispatch_get_bits: + + 1. This has been rewritten. The original version could not correctly + handle requests for more than 8 bits. The new version is cleaner and + correctly handles all cases. -From Alejandro Vaquero: -mgcp support for the voip call analysis tap ------------------------------------------------------------------------ -r13446 | jmayer | 2005-02-20 01:25:58 -0600 (Sun, 20 Feb 2005) | 1 line +r14667 | etxrab | 2005-06-16 16:16:23 -0500 (Thu, 16 Jun 2005) | 16 lines Changed paths: - M /trunk/docbook/Makefile + M /trunk/epan/dissectors/packet-sigcomp.c + +From Paul Ollis: + epan/dissectors/packet-sigcomp.c + -------------------------------- + + Function dissect_sigcomp: + + 1. Make sure the temporary buffer that is used to load byte-code from + state is zeroed, since the function udvm_state_access implicitly + relies on this. + + 2. Pass the SigComp message header length, state length and partial + state length to decompress_sigcomp_message. + + 3. Removed the state_vars_valid parameter from calls to + udvm_state_access. -Fix generation of svn_version.xml with Unix make ------------------------------------------------------------------------ -r13445 | jmayer | 2005-02-20 00:42:08 -0600 (Sun, 20 Feb 2005) | 1 line +r14668 | etxrab | 2005-06-16 16:19:37 -0500 (Thu, 16 Jun 2005) | 1 line Changed paths: - M /trunk/configure.in - M /trunk/docbook/Makefile + M /trunk/AUTHORS -Correct fix for distcheck this time - definitely +Add Paul Ollis ------------------------------------------------------------------------ -r13444 | jmayer | 2005-02-20 00:08:15 -0600 (Sun, 20 Feb 2005) | 1 line +r14669 | ulfl | 2005-06-16 16:19:50 -0500 (Thu, 16 Jun 2005) | 1 line Changed paths: - M /trunk/docbook/Makefile + M /trunk/docbook/eug_src/EUG_chapter_io.xml + M /trunk/docbook/eug_src/EUG_chapter_use.xml -The last checkin changed the settings to my system - reevrt them back so Ulf can use it out of the box +add a "file sets" section and fix a link to it ------------------------------------------------------------------------ -r13443 | jmayer | 2005-02-19 23:53:06 -0600 (Sat, 19 Feb 2005) | 1 line +r14670 | ulfl | 2005-06-16 16:34:06 -0500 (Thu, 16 Jun 2005) | 1 line Changed paths: - M /trunk/docbook/Makefile + M /trunk/docbook/eug_src/EUG_chapter_io.xml -Remove Makefile.auto during make clean (distcheck again) +add ChIOExportCSVDialog section, docbook validation should work again ------------------------------------------------------------------------ -r13442 | jmayer | 2005-02-19 23:39:24 -0600 (Sat, 19 Feb 2005) | 1 line +r14671 | ulfl | 2005-06-16 16:51:17 -0500 (Thu, 16 Jun 2005) | 1 line Changed paths: - M /trunk/plugins/stats_tree - M /trunk/plugins/stats_tree/AUTHORS - M /trunk/plugins/stats_tree/Makefile.am - M /trunk/plugins/stats_tree/NEWS - M /trunk/plugins/stats_tree/pinfo_stats_tree.c - M /trunk/plugins/stats_tree/stats_tree_plugin.c + M /trunk/docbook/eug_src/EUG_chapter_advanced.xml -Add some svn props +updated to latest Ethereal GUI ------------------------------------------------------------------------ -r13441 | jmayer | 2005-02-19 23:20:42 -0600 (Sat, 19 Feb 2005) | 1 line +r14672 | etxrab | 2005-06-16 17:06:12 -0500 (Thu, 16 Jun 2005) | 1 line Changed paths: - M /trunk/configure.in + M /trunk/epan/sminmpec.c + M /trunk/epan/sminmpec.h -Remove stats_tree again: It breaks distcheck +Add some more vendors ------------------------------------------------------------------------ -r13440 | jmayer | 2005-02-19 23:06:28 -0600 (Sat, 19 Feb 2005) | 1 line +r14673 | etxrab | 2005-06-16 17:07:38 -0500 (Thu, 16 Jun 2005) | 1 line Changed paths: - M /trunk/Makefile.am + M /trunk/epan/dissectors/packet-radius.c -Makefile.autoi.* isn't automagically added to tarball - add to EXTRA_DIST for now +Change "radius type" on some vendor AVP:s and add some more ones. ------------------------------------------------------------------------ -r13439 | jmayer | 2005-02-19 23:01:46 -0600 (Sat, 19 Feb 2005) | 1 line +r14674 | ulfl | 2005-06-16 18:27:57 -0500 (Thu, 16 Jun 2005) | 1 line Changed paths: - M /trunk/configure.in - M /trunk/docbook - A /trunk/docbook/Makefile.auto.am + M /trunk/docbook/eug_src/EUG_chapter_statistics.xml + M /trunk/docbook/eug_src/EUG_chapter_work.xml -Beginnings of autogenerating docbook/Makefile (long way to go) so call it Makefile.auto for now +updated to latest Ethereal GUI ------------------------------------------------------------------------ -r13438 | jmayer | 2005-02-19 22:34:03 -0600 (Sat, 19 Feb 2005) | 1 line +r14675 | ulfl | 2005-06-16 20:27:52 -0500 (Thu, 16 Jun 2005) | 1 line Changed paths: - M /trunk/configure.in + M /trunk/docbook/eug_src/EUG_chapter_customize.xml -Create stats_tree Makefile to allow manual builds +updated to latest Ethereal GUI ------------------------------------------------------------------------ -r13437 | jmayer | 2005-02-19 22:31:30 -0600 (Sat, 19 Feb 2005) | 1 line +r14676 | ulfl | 2005-06-16 20:28:41 -0500 (Thu, 16 Jun 2005) | 1 line Changed paths: - M /trunk/gtk/Makefile.nmake + M /trunk/docbook/eug_src/EUG_app_tools.xml -Replace some spaces by TAB to make vim with syntax highlighting happy +updated to latest Ethereal GUI ------------------------------------------------------------------------ -r13436 | jmayer | 2005-02-19 22:17:17 -0600 (Sat, 19 Feb 2005) | 1 line +r14677 | ulfl | 2005-06-17 02:56:27 -0500 (Fri, 17 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/Makefile.common + M /trunk/editcap.c -Add packet-rdt.h to DISSECTOR_INCLUDES +the -E probability parameter was missing in the usage summary ------------------------------------------------------------------------ -r13435 | lego | 2005-02-19 20:21:04 -0600 (Sat, 19 Feb 2005) | 9 lines +r14678 | ulfl | 2005-06-17 02:57:41 -0500 (Fri, 17 Jun 2005) | 1 line Changed paths: - M /trunk/plugins/mate/examples/call.mate - M /trunk/plugins/mate/examples/mms.mate - M /trunk/plugins/mate/examples/pasv_ftp.mate - M /trunk/plugins/mate/examples/tcp.mate - M /trunk/plugins/mate/examples/web.mate - M /trunk/plugins/mate/mate.h - M /trunk/plugins/mate/mate_setup.c - M /trunk/plugins/mate/packet-mate.c - -Changed the GopTree in GogDef and GogExtra from a boolean to a string - GopTree={BasicTree|NoTree|FullTree} - NoTree: just an item for each gop - BasicTree: (default) some essential information regarding the gop - FullTree: the Gop's full tree + M /trunk/gtk/main.c -added Id and eol-style to examples +fix a typo in the usage output +------------------------------------------------------------------------ +r14679 | gerald | 2005-06-17 10:03:26 -0500 (Fri, 17 Jun 2005) | 2 lines +Changed paths: + M /trunk/doc/README.developer +Add a note about fuzz testing. ------------------------------------------------------------------------ -r13434 | lego | 2005-02-19 19:58:29 -0600 (Sat, 19 Feb 2005) | 2 lines +r14680 | jmayer | 2005-06-17 12:10:21 -0500 (Fri, 17 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rdt.c - M /trunk/epan/dissectors/packet-rdt.h + M /trunk/manuf -modify eol-style property +Update manuf +------------------------------------------------------------------------ +r14681 | jmayer | 2005-06-17 12:12:12 -0500 (Fri, 17 Jun 2005) | 1 line +Changed paths: + M /trunk/FAQ + M /trunk/help/faq.txt +Update FAQ ------------------------------------------------------------------------ -r13433 | lego | 2005-02-19 19:41:57 -0600 (Sat, 19 Feb 2005) | 2 lines +r14682 | lego | 2005-06-17 12:26:43 -0500 (Fri, 17 Jun 2005) | 4 lines Changed paths: - M /trunk/plugins/mate/examples/mms.mate + M /trunk/epan/dissectors/packet-k12.c + M /trunk/wiretap/file_access.c + M /trunk/wiretap/k12.c + M /trunk/wiretap/k12.h + M /trunk/wiretap/wtap-int.h + +- Write rf5 files (I don't think tektronix software will be able to read these, ethereal does) +- change k12.atm.vci and k12.atm.vpi into atm.vci and atm.vpi -set the property keyword Id ------------------------------------------------------------------------ -r13432 | lego | 2005-02-19 19:40:31 -0600 (Sat, 19 Feb 2005) | 2 lines +r14683 | lego | 2005-06-17 12:33:48 -0500 (Fri, 17 Jun 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-rdt.c - M /trunk/epan/dissectors/packet-rdt.h + M /trunk/epan/dissectors/packet-gsm_a.c + +Register the dtap dissector by name. -set the Id keyword for these two new files ------------------------------------------------------------------------ -r13431 | lego | 2005-02-19 16:43:38 -0600 (Sat, 19 Feb 2005) | 3 lines +r14684 | lego | 2005-06-17 12:37:10 -0500 (Fri, 17 Jun 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-rdt.c - A /trunk/epan/dissectors/packet-rdt.h - M /trunk/epan/dissectors/packet-rtsp.c + M /trunk/epan/dissectors/packet-sscop.c + M /trunk/epan/dissectors/packet-sscop.h + +- fix a bug I introduced by copy pasting an incorrect offset of some items +- prepare the tap -From Martin Mathielson - RDT (Realplayer Data Protocol) dissector and patch RTSP to create RDT conversations ------------------------------------------------------------------------ -r13430 | lego | 2005-02-18 21:22:24 -0600 (Fri, 18 Feb 2005) | 2 lines +r14685 | gerald | 2005-06-17 13:41:02 -0500 (Fri, 17 Jun 2005) | 5 lines Changed paths: - A /trunk/plugins/mate/examples/mms.mate + M /trunk/colorfilters -add mms.mate to the examples collection +Tweak the global coloring rules a bit. Give "normal" traffic pastel +backgrounds and "bad" traffic bold backgrounds, which is the strategy +used in some of the sample coloring rules. Include a few rules from +the samples as well. ------------------------------------------------------------------------ -r13429 | lego | 2005-02-18 21:10:50 -0600 (Fri, 18 Feb 2005) | 2 lines +r14686 | tuexen | 2005-06-17 16:02:40 -0500 (Fri, 17 Jun 2005) | 2 lines Changed paths: - M /trunk/plugins/mate/mate_setup.c + M /trunk/epan/dissectors/packet-sctp.c -In order to avoid a crash at reanalize_gop(), do not accept a GogKey where the Gop has not yet being declared. +Add support for draft-ietf-tsvwg-sctp-auth-00.txt. ------------------------------------------------------------------------ -r13428 | lego | 2005-02-18 16:43:12 -0600 (Fri, 18 Feb 2005) | 2 lines +r14687 | jmayer | 2005-06-17 19:10:59 -0500 (Fri, 17 Jun 2005) | 1 line Changed paths: - M /trunk/plugins/mate/moduleinfo.h + M /trunk/Makefile.am + +Remove a leftover dummy list +------------------------------------------------------------------------ +r14688 | lego | 2005-06-17 20:09:04 -0500 (Fri, 17 Jun 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-k12.c + +- Use report_error and Co. to report errors -Step the version number of the plugin ------------------------------------------------------------------------ -r13427 | lego | 2005-02-18 16:33:16 -0600 (Fri, 18 Feb 2005) | 3 lines +r14689 | lego | 2005-06-17 20:15:17 -0500 (Fri, 17 Jun 2005) | 5 lines Changed paths: - M /trunk/plugins/mate/mate.h - M /trunk/plugins/mate/mate_runtime.c - M /trunk/plugins/mate/mate_setup.c + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-synergy.c + +from Vasanth Manickam + +Synergy is a cross platform software which enables to easily share a single mouse and keyboard between multiple computers with different operating systems, each with its own display, without special hardware. Its listed on sourceforge (http://synergy2.sourceforge.net/). -Adds Payload AVP to PduDef AVPLs simmetric to the Transport AVP -allows to fetch fields also from ranges that are the payload of the Proto ------------------------------------------------------------------------ -r13426 | sahlberg | 2005-02-18 15:19:01 -0600 (Fri, 18 Feb 2005) | 7 lines +r14690 | jmayer | 2005-06-18 03:49:24 -0500 (Sat, 18 Jun 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-rmt-lct.c + +Dominik Kuhlen: Fix a copy/paste bug reported in + http://bugs.ethereal.com/bugzilla/show_bug.cgi?id=211 -usage of tcp_dissect_pdu is broken +------------------------------------------------------------------------ +r14691 | jmayer | 2005-06-18 03:52:41 -0500 (Sat, 18 Jun 2005) | 1 line +Changed paths: + M /trunk/AUTHORS -comment it out to stop it from dumping core. -jxta people will have to fix this properly later. +Add Dominik Kuhlen to AUTHORS +------------------------------------------------------------------------ +r14692 | jmayer | 2005-06-18 10:41:26 -0500 (Sat, 18 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-telnet.c +Partial fix for bug 191: Sanity check is ok now +------------------------------------------------------------------------ +r14693 | gerald | 2005-06-18 15:57:01 -0500 (Sat, 18 Jun 2005) | 2 lines +Changed paths: + M /trunk/epan/prefs.c +Clear out any leftover preference information. Fix up whitespace. ------------------------------------------------------------------------ -r13425 | lego | 2005-02-18 14:19:52 -0600 (Fri, 18 Feb 2005) | 2 lines +r14694 | lego | 2005-06-18 19:08:30 -0500 (Sat, 18 Jun 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-eth.h + M /trunk/epan/dissectors/packet-afp.c + M /trunk/epan/dissectors/packet-afp.h + M /trunk/epan/dissectors/packet-dsi.c + +from Didier Gautheron + +The new AFP 3.2 specification used by Apple OS X 10.4 -do not prototype capture_eth() unless capture.h has being included ------------------------------------------------------------------------ -r13424 | lego | 2005-02-18 14:11:30 -0600 (Fri, 18 Feb 2005) | 2 lines +r14695 | sahlberg | 2005-06-19 06:40:39 -0500 (Sun, 19 Jun 2005) | 3 lines Changed paths: - M /trunk/plugins/mate/packet-mate.c + M /trunk/epan/dissectors/packet-pres.c + M /trunk/epan/dissectors/packet-ses.h + +push one more object into the session structure so acse can pick it up later. -Get rid of some useless lines from the last patch ------------------------------------------------------------------------ -r13423 | lego | 2005-02-18 14:02:40 -0600 (Fri, 18 Feb 2005) | 2 lines +r14696 | sahlberg | 2005-06-19 06:47:59 -0500 (Sun, 19 Jun 2005) | 3 lines Changed paths: - M /trunk/plugins/mate/mate.h - M /trunk/plugins/mate/mate_setup.c - M /trunk/plugins/mate/packet-mate.c + M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-ftam.c + +make cmip and ftam also register by ber oid so that they will work when the new ACSE goes in -Add a pointer to the start frame of each gop in the gog's tree ------------------------------------------------------------------------ -r13422 | lego | 2005-02-18 12:40:25 -0600 (Fri, 18 Feb 2005) | 5 lines +r14697 | sahlberg | 2005-06-19 06:49:16 -0500 (Sun, 19 Jun 2005) | 3 lines Changed paths: - M /trunk/plugins/mate/mate_setup.c + M /trunk/asn1/cmip/packet-cmip-template.c -two fixes in config loading: - - do not accept GopDefs for non existent pdus Pdu - - GogExtra "no For" instead of "no Name" +register cmip as ber oid dissector ------------------------------------------------------------------------ -r13421 | sahlberg | 2005-02-17 14:56:47 -0600 (Thu, 17 Feb 2005) | 3 lines +r14698 | sahlberg | 2005-06-19 06:51:23 -0500 (Sun, 19 Jun 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-scsi.c + A /trunk/asn1/acse + A /trunk/asn1/acse/Makefile + A /trunk/asn1/acse/Makefile.nmake + A /trunk/asn1/acse/acse.asn + A /trunk/asn1/acse/acse.cnf + A /trunk/asn1/acse/packet-acse-template.c + A /trunk/asn1/acse/packet-acse-template.h -minor prettification +New autogenerated ACSE dissector. + +There is a bug in ASN2ETH which means one can not do make copy_files +instead one needs to change two bugs in the generated code manually. +These two changes are in the comment at the top of the template/generated file ------------------------------------------------------------------------ -r13420 | sahlberg | 2005-02-17 06:07:45 -0600 (Thu, 17 Feb 2005) | 8 lines +r14699 | sahlberg | 2005-06-19 06:54:33 -0500 (Sun, 19 Jun 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-fcp.c - M /trunk/epan/dissectors/packet-iscsi.c - M /trunk/epan/dissectors/packet-ndmp.c - M /trunk/epan/dissectors/packet-scsi.c - M /trunk/epan/dissectors/packet-scsi.h + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-acse.h -pass lun (and status) to scsi subdissector so we can filter -on scsi.lun and prettify the summary line a bit. +New autogenerated ACSE dissector. -ndmp still needs some work to track luns between commands -and fcp needs verification it works for volumesetaddressing. +Note that the autogenerated dissector contains two bugs which i belive are asn2eth bugs. +This is why make copy_files does not work. +The comment at the top of the generated file explains which two changes one has to do manually after autogenerating the dissector, until asn2eth gets fixed. ------------------------------------------------------------------------ -r13419 | guy | 2005-02-16 21:05:54 -0600 (Wed, 16 Feb 2005) | 6 lines +r14700 | jmayer | 2005-06-19 10:16:30 -0500 (Sun, 19 Jun 2005) | 1 line Changed paths: - M /trunk/file.c - M /trunk/file.h - M /trunk/gtk/drag_and_drop.c - M /trunk/gtk/file_dlg.c + M /trunk/epan/packet.h + +Warning fix: Declare some more strings const +------------------------------------------------------------------------ +r14701 | jmayer | 2005-06-19 10:17:42 -0500 (Sun, 19 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-kerberos.h + +Fix trivial warning +------------------------------------------------------------------------ +r14702 | guy | 2005-06-19 14:08:37 -0500 (Sun, 19 Jun 2005) | 2 lines +Changed paths: + M /trunk/doc/idl2eth.pod -Have "cf_merge_files()" take a pointer-to-pointer-to-char as the output -file name argument; if the pointed-to pointer is null, it opens a -temporary file, and sets that pointer to a mallocated copy of the -pathname of the temporary file. It no longer needs a file descriptor as -an argument. +Update URL for omniORB. ------------------------------------------------------------------------ -r13418 | etxrab | 2005-02-16 16:44:15 -0600 (Wed, 16 Feb 2005) | 1 line +r14703 | guy | 2005-06-19 14:17:15 -0500 (Sun, 19 Jun 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h + M /trunk/README.macos + +Add a note about the PNG, JPEG, and TIFF loaders not being usable (or +not easy to get to work) on Tiger. -Add some of the anytime operations. ------------------------------------------------------------------------ -r13417 | etxrab | 2005-02-16 16:42:52 -0600 (Wed, 16 Feb 2005) | 1 line +r14704 | etxrab | 2005-06-19 16:11:52 -0500 (Sun, 19 Jun 2005) | 2 lines Changed paths: M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/gsmmap.cnf + M /trunk/asn1/gsmmap/packet-gsm_map-template.c -Add some of the AnyTime... Operations. +Update some OID:s and add some ASN1 code from ETSI TS 129 002 V5.7.0. +Will regenerate later. ------------------------------------------------------------------------ -r13416 | etxrab | 2005-02-16 16:40:56 -0600 (Wed, 16 Feb 2005) | 3 lines +r14705 | etxrab | 2005-06-19 16:16:04 -0500 (Sun, 19 Jun 2005) | 1 line Changed paths: - M /trunk/tools/asn2eth.py + M /trunk/epan/dissectors/packet-radius.c + +Add some Cisco AVP:s +------------------------------------------------------------------------ +r14706 | guy | 2005-06-19 17:29:08 -0500 (Sun, 19 Jun 2005) | 4 lines +Changed paths: + M /trunk/ethereal_gen.py -From Tomas Kukosa: -Fix problems with bitfields with dashed ("-") names +Get rid of the include of "snprintf.h", as g_snprintf()" should be used. + +Add _U_s to reduce the number of warnings. ------------------------------------------------------------------------ -r13415 | lego | 2005-02-16 08:26:27 -0600 (Wed, 16 Feb 2005) | 3 lines +r14707 | sahlberg | 2005-06-19 21:37:42 -0500 (Sun, 19 Jun 2005) | 2 lines Changed paths: - A /trunk/plugins/stats_tree - A /trunk/plugins/stats_tree/AUTHORS - A /trunk/plugins/stats_tree/Makefile.am - A /trunk/plugins/stats_tree/NEWS - A /trunk/plugins/stats_tree/pinfo_stats_tree.c - A /trunk/plugins/stats_tree/stats_tree_plugin.c + M /trunk/asn1/acse/packet-acse-template.c -An example stats_tree plugin using pinfo as its only data source -I'm not checking changes to the Makefiles yet. +add Sids email as the original author of ACSE dissector ------------------------------------------------------------------------ -r13414 | lego | 2005-02-16 08:16:40 -0600 (Wed, 16 Feb 2005) | 3 lines +r14708 | sahlberg | 2005-06-19 23:44:39 -0500 (Sun, 19 Jun 2005) | 7 lines Changed paths: - A /trunk/epan/stats_tree.c - A /trunk/epan/stats_tree.h - A /trunk/epan/stats_tree_priv.h - A /trunk/gtk/stats_tree_stat.c - A /trunk/tap-stats_tree.c + M /trunk/epan/dissectors/packet-gssapi.c + M /trunk/epan/dissectors/packet-gssapi.h + +convert gssapi to use packet-ber helpers instead of the asn1 ones. + +once spnego is converted as well, the epan/asn1.h include can be removed from : +kerberos, spnego, gssapi and ntlmssp + -Initial checkin of the stats-tree tap API -Makefiles have not been modified yet, there's still work to do. ------------------------------------------------------------------------ -r13413 | sahlberg | 2005-02-16 05:31:56 -0600 (Wed, 16 Feb 2005) | 5 lines +r14709 | sahlberg | 2005-06-20 00:28:56 -0500 (Mon, 20 Jun 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-nt.c - M /trunk/epan/dissectors/packet-dcerpc-nt.h + M /trunk/epan/dissectors/packet-gssapi.c + M /trunk/epan/dissectors/packet-gssapi.h + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-ntlmssp.c + M /trunk/epan/dissectors/packet-spnego.c + +move one function only used by SPNEGO to packet-spnego.c -preparations for autogenerated ms dcerpc interfaces -make it possible to prettify SIDs and control how and where their string representation should be shown in the summary line and the tree -similar to how counted_strings prettification can be controlled +remove the include of <epan/asn1.h> from kerberos, ntlmssp and gssapi since they no longer need to include that file. ------------------------------------------------------------------------ -r13412 | sahlberg | 2005-02-16 04:25:00 -0600 (Wed, 16 Feb 2005) | 4 lines +r14710 | sahlberg | 2005-06-20 02:18:10 -0500 (Mon, 20 Jun 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-nt.c + M /trunk/asn1/tcap/packet-tcap-template.c + M /trunk/asn1/tcap/packet-tcap-template.h + M /trunk/epan/dissectors/packet-gsm_ss.c + M /trunk/epan/dissectors/packet-gsm_ss.h + M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/dissectors/packet-tcap.h + +move two functions that are not used by tcap and only used by gsm_a and gsm_ss into gsm_ss. -mark the frame opened/closed fields for policy handles as GENERATED fields +remove the include <epan.asn1.h> from tcap since it no longer needs that file. + +only 9 dissectors remain that use asn1.h ------------------------------------------------------------------------ -r13411 | sahlberg | 2005-02-16 04:11:26 -0600 (Wed, 16 Feb 2005) | 4 lines +r14711 | sahlberg | 2005-06-20 04:43:29 -0500 (Mon, 20 Jun 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/dcerpc/idl2eth.c + M /trunk/epan/dissectors/packet-spnego.c + +convert one function to use packet-ber instead of asn1 + -add simple check that if a hf_rename field has not been referenced by the idl/cnf files then it is likely the conformance file has become stale and needs updating. abort with an error message. +------------------------------------------------------------------------ +r14712 | sahlberg | 2005-06-20 05:22:03 -0500 (Mon, 20 Jun 2005) | 5 lines +Changed paths: + M /trunk/epan/dissectors/packet-spnego.c +convert the function +dissect_spnego_mechTypes() tu use the packet-ber api instead of the +asn1 api. ------------------------------------------------------------------------ -r13410 | sahlberg | 2005-02-16 03:24:52 -0600 (Wed, 16 Feb 2005) | 3 lines +r14713 | gerald | 2005-06-20 14:35:58 -0500 (Mon, 20 Jun 2005) | 4 lines Changed paths: - M /trunk/gtk/rtp_analysis.c - M /trunk/gtk/rtp_analysis.h - M /trunk/gtk/rtp_stream.c - M /trunk/gtk/rtp_stream.h - M /trunk/gtk/rtp_stream_dlg.c + M /trunk/epan/dissectors/packet-afp.c + M /trunk/epan/dissectors/packet-ansi_637.c + M /trunk/epan/dissectors/packet-ansi_a.c + M /trunk/epan/dissectors/packet-ansi_map.c + M /trunk/epan/dissectors/packet-dcerpc-spoolss.c + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-iapp.c + M /trunk/epan/dissectors/packet-ncp2222.inc + M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/packet-rsvp.c + M /trunk/epan/dissectors/packet-slowprotocols.c + M /trunk/epan/proto.h + M /trunk/plugins/irda/packet-irda.c + M /trunk/plugins/profinet/packet-pn-dcp.c + +Fix a format string vulneratility in the AFP dissector identified +by iDEFENSE. Add constant format strings to proto_item_append_text() +in a bunch of other dissectors. Copy a comment from proto.c to proto.h. -from lars ruoff a few extra columns for rtp analysis +------------------------------------------------------------------------ +r14714 | etxrab | 2005-06-20 15:14:22 -0500 (Mon, 20 Jun 2005) | 12 lines +Changed paths: + M /trunk/gtk/conversations_jxta.c + M /trunk/gtk/conversations_table.c + M /trunk/gtk/hostlist_jxta.c + M /trunk/gtk/hostlist_table.c + M /trunk/gtk/sat.h +From Mike Duigou: + In order to get filtering of conversations and +> endpoints to work from the endpoints and conversations windows I found +> it necessary to add a new AT_URI address type and a SAT_JXTA. This also +> necessitated a change to to_str.c to avoid a buffer overflow problem. +> Please review these changes carefully. +> +> Also includes some changes to the jxta dissector to fix filtering on +> generated fields and some changes to the types used for ints/unsigned ints. +> +> Fixes a bug with the processing of messages containing namespaces. ------------------------------------------------------------------------ -r13409 | sahlberg | 2005-02-15 18:19:52 -0600 (Tue, 15 Feb 2005) | 6 lines +r14715 | etxrab | 2005-06-20 15:14:57 -0500 (Mon, 20 Jun 2005) | 12 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/address.h + M /trunk/epan/to_str.c -add extra sanity check. -dont match a request with a reply that came earlier in the trace or SRT will -look funny :-) +From Mike Duigou: + In order to get filtering of conversations and +> endpoints to work from the endpoints and conversations windows I found +> it necessary to add a new AT_URI address type and a SAT_JXTA. This also +> necessitated a change to to_str.c to avoid a buffer overflow problem. +> Please review these changes carefully. +> +> Also includes some changes to the jxta dissector to fix filtering on +> generated fields and some changes to the types used for ints/unsigned ints. +> +> Fixes a bug with the processing of messages containing namespaces. +------------------------------------------------------------------------ +r14716 | etxrab | 2005-06-20 15:15:33 -0500 (Mon, 20 Jun 2005) | 12 lines +Changed paths: + M /trunk/epan/dissectors/packet-jxta.c +From Mike Duigou: + In order to get filtering of conversations and +> endpoints to work from the endpoints and conversations windows I found +> it necessary to add a new AT_URI address type and a SAT_JXTA. This also +> necessitated a change to to_str.c to avoid a buffer overflow problem. +> Please review these changes carefully. +> +> Also includes some changes to the jxta dissector to fix filtering on +> generated fields and some changes to the types used for ints/unsigned ints. +> +> Fixes a bug with the processing of messages containing namespaces. ------------------------------------------------------------------------ -r13408 | sahlberg | 2005-02-15 15:01:51 -0600 (Tue, 15 Feb 2005) | 3 lines +r14717 | lego | 2005-06-20 16:21:06 -0500 (Mon, 20 Jun 2005) | 3 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-retix-bpdu.c + M /trunk/asn1/h248/h248.cnf + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/epan/dissectors/packet-h248.c -new protocol from Giles Scott : Retix spanning tree protocol +if exists call the h248term subdissector. ------------------------------------------------------------------------ -r13407 | guy | 2005-02-15 14:01:24 -0600 (Tue, 15 Feb 2005) | 7 lines +r14718 | guy | 2005-06-21 04:15:26 -0500 (Tue, 21 Jun 2005) | 3 lines Changed paths: - M /trunk/file.c - M /trunk/gtk/drag_and_drop.c - M /trunk/gtk/file_dlg.c + M /trunk/plugins/giop/packet-tango.c + +Get rid of include of "snprintf.h", and _U_-ify arguments, as per +changes made to idl2eth. + +------------------------------------------------------------------------ +r14719 | guy | 2005-06-21 04:17:53 -0500 (Tue, 21 Jun 2005) | 5 lines +Changed paths: + M /trunk/plugins/giop/packet-parlay.c -Have "cf_merge_files()" always close "out_fd" before returning; it does -so if "wtap_dump_fdopen()" succeeds (as a side-effect of calling -"wtap_dump_close()"), even if "cf_merge_fails()" after that, so it -should do so if it fails. +Fix the line endings. -That means we don't need to close it in the callers of "cf_merge_files()". +Get rid of include of "snprintf.h", and _U_-ify arguments, as per +changes made to idl2eth. ------------------------------------------------------------------------ -r13406 | guy | 2005-02-14 21:49:12 -0600 (Mon, 14 Feb 2005) | 4 lines +r14720 | sahlberg | 2005-06-21 04:38:59 -0500 (Tue, 21 Jun 2005) | 5 lines Changed paths: - M /trunk/capture_loop.c + M /trunk/asn1/acse/packet-acse-template.c + M /trunk/asn1/tcap/tcap.cnf + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-ber.h + M /trunk/epan/dissectors/packet-gssapi.c + M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/packet-tcap.c + +the maximum ASN OID length is 256 bytes and there is a define to control this. -WinPcap 3.0 might support PPP/WAN capturing on Windows OT, so lump it -together with the pre-3.0 releases. Mention 3.1 beta's support, noting -that it's a beta. +fix bug251 and all other occurances where an oid string passed to packet_ber_object_identifier() +is not defined as foo[MAX_OID_STR_LEN] ------------------------------------------------------------------------ -r13405 | guy | 2005-02-14 19:42:39 -0600 (Mon, 14 Feb 2005) | 3 lines +r14721 | sahlberg | 2005-06-21 05:19:10 -0500 (Tue, 21 Jun 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-lmp.c + +terminate some value_strings properly with a {0,NULL} -Add the missing packet-dcerpc-budb.h to the list of header files, so it -goes into the source tarball. ------------------------------------------------------------------------ -r13404 | guy | 2005-02-14 16:07:26 -0600 (Mon, 14 Feb 2005) | 2 lines +r14722 | guy | 2005-06-21 12:40:11 -0500 (Tue, 21 Jun 2005) | 2 lines Changed paths: - M /trunk/asn1/gsmmap/packet-gsm_map-template.c - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h + M /trunk/plugins/giop/packet-parlay.c -Fix some compiler warnings (at least one of which is for a real problem). +It's svn:eol-style, not svn:eolstyle. ------------------------------------------------------------------------ -r13403 | guy | 2005-02-14 16:06:22 -0600 (Mon, 14 Feb 2005) | 2 lines +r14723 | gerald | 2005-06-21 17:02:18 -0500 (Tue, 21 Jun 2005) | 2 lines Changed paths: - M /trunk/gtk/voip_calls.c - M /trunk/gtk/voip_calls_dlg.c + M /trunk/epan/prefs.c -Add #includes to define various macros and declare various functions. +Make a couple of variables dynamic, as suggested by Ulf. ------------------------------------------------------------------------ -r13402 | guy | 2005-02-14 14:33:57 -0600 (Mon, 14 Feb 2005) | 22 lines +r14724 | lego | 2005-06-21 21:18:10 -0500 (Tue, 21 Jun 2005) | 2 lines Changed paths: - M /trunk/Makefile.am - M /trunk/Makefile.common - M /trunk/Makefile.nmake - M /trunk/doc/Makefile.nmake - M /trunk/epan/Makefile.am - M /trunk/epan/Makefile.nmake - M /trunk/epan/dfilter/Makefile.nmake - M /trunk/epan/dissectors/Makefile.am - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/Makefile.nmake - M /trunk/epan/ftypes/Makefile.nmake - M /trunk/gtk/Makefile.am - M /trunk/gtk/Makefile.common - M /trunk/gtk/Makefile.nmake - M /trunk/help/Makefile.nmake - M /trunk/image/Makefile.nmake - M /trunk/packaging/nsis/Makefile.nmake - M /trunk/plugins/Makefile.nmake - M /trunk/plugins/acn/Makefile.nmake - M /trunk/plugins/agentx/Makefile.nmake - M /trunk/plugins/artnet/Makefile.nmake - M /trunk/plugins/asn1/Makefile.nmake - M /trunk/plugins/ciscosm/Makefile.nmake - M /trunk/plugins/docsis/Makefile.nmake - M /trunk/plugins/enttec/Makefile.nmake - M /trunk/plugins/giop/Makefile.nmake - M /trunk/plugins/gryphon/Makefile.nmake - M /trunk/plugins/irda/Makefile.nmake - M /trunk/plugins/lwres/Makefile.nmake - M /trunk/plugins/mate/Makefile.nmake - M /trunk/plugins/megaco/Makefile.nmake - M /trunk/plugins/mgcp/Makefile.nmake - M /trunk/plugins/opsi/Makefile.nmake - M /trunk/plugins/pcli/Makefile.nmake - M /trunk/plugins/rdm/Makefile.nmake - M /trunk/plugins/rlm/Makefile.nmake - M /trunk/plugins/rtnet/Makefile.nmake - M /trunk/plugins/rudp/Makefile.nmake - M /trunk/plugins/v5ua/Makefile.nmake - M /trunk/tools/Makefile.nmake - M /trunk/tools/lemon/Makefile.nmake - M /trunk/wiretap/Makefile.nmake - -Make the "maintainer-clean" rules get rid of some additional generated -files. Do this with GENERATED_HEADER_FILES, GENERATED_C_FILES, and -GENERATED_FILES macros in Makefile.common files, along the lines of what -wiretap/Makefile.common has. - -Clean up "*~" files with "make clean" rather than only "make distclean" -in some additional places. - -Add "maintainer-clean" rules to the Makefile.nmake files, paralelling -the ones in the automake-generated Makefile.in files, using the -GENERATED_FILES macros from Makefile.common files. In some cases, move -the cleanup of files from "make distclean" to "make maintainer-clean", -and in other cases, put in a comment indicating why we're not doing that -(because some files that are distributed in the source tarballs, namely -Flex output, were built with a UN*X Flex and won't compile on Windows, -so we get rid of them with "make distclean" so you can clean up stuff -that *has* to be re-generated for Windows). - -Clean up some *CLEANFILES definitions - get rid of ones that no longer -apply as files were moved or that add to the definition a name that's -already there. - ------------------------------------------------------------------------- -r13401 | sahlberg | 2005-02-14 13:56:11 -0600 (Mon, 14 Feb 2005) | 3 lines -Changed paths: - A /trunk/epan/dissectors/dcerpc/budb - A /trunk/epan/dissectors/dcerpc/budb/Makefile - A /trunk/epan/dissectors/dcerpc/budb/budb.cnf - A /trunk/epan/dissectors/dcerpc/budb/budb.idl - A /trunk/epan/dissectors/dcerpc/budb/template.c - A /trunk/epan/dissectors/dcerpc/budb/template.h - M /trunk/epan/dissectors/packet-dcerpc-budb.c - A /trunk/epan/dissectors/packet-dcerpc-budb.h + M /trunk/epan/dissectors/packet-sdp.c + +add ipbcp attribute as in Q.1970 + +------------------------------------------------------------------------ +r14725 | sahlberg | 2005-06-22 03:15:18 -0500 (Wed, 22 Jun 2005) | 9 lines +Changed paths: + M /trunk/asn1/acse/Makefile + M /trunk/asn1/acse/acse.asn + M /trunk/asn1/acse/acse.cnf + M /trunk/asn1/acse/packet-acse-template.c + M /trunk/asn1/cmip/packet-cmip-template.c + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-ftam.c + +remove a dissector table we no longer use from ACSE +and also from the CMIP and FTAM dissectors that tried to register against it. + +Implement a workaround for the asn2eth bug (can not yet handle tagged assignments) to the conformance file and remove the warnings from the template file. + +Since workaround is implemented in conformance file, make make copy_files install the dissector instead of printing a warning message. -add machinegenerated full dissector for dcedfs BUDB protocol ------------------------------------------------------------------------ -r13400 | sahlberg | 2005-02-14 13:46:03 -0600 (Mon, 14 Feb 2005) | 3 lines +r14726 | sahlberg | 2005-06-22 03:28:59 -0500 (Wed, 22 Jun 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/dcerpc/idl2eth.c + M /trunk/asn1/acse/packet-acse-template.c + M /trunk/epan/dissectors/packet-acse.c + +only create the ACSE protocol tree if there is an ACSE layer present. - make idl-lite compiler handle varying arrays +do not create it if it is just a SES_DATA_TRANSFER PDU ------------------------------------------------------------------------ -r13399 | sahlberg | 2005-02-14 13:43:34 -0600 (Mon, 14 Feb 2005) | 3 lines +r14727 | sahlberg | 2005-06-22 03:41:58 -0500 (Wed, 22 Jun 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-dcerpc.h + M /trunk/epan/dissectors/packet-frame.c + +add a dummy variable frame_number to dissect_frame() and assign it the current frame number so that the crashdump that buildbot generates will show which frame the problem occured in. + +this is useful since some bugs only trigger ia crash on some platforms. +example bug 255 which does not trigger a crash on linux redhat 7.1 -add support for varying arrays ------------------------------------------------------------------------ -r13398 | sahlberg | 2005-02-14 13:34:59 -0600 (Mon, 14 Feb 2005) | 3 lines +r14728 | sahlberg | 2005-06-22 04:58:46 -0500 (Wed, 22 Jun 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-ber.c + +update to packet-ber + +1, start making indefinite length constructions actually work +2, when attempting to decode an unknown BER octet sequence, do not generate [malformed packet] just because the length does not make sense and might point outside the tvb. it might just be that there are implicit tags in the asn1 specification and that it is just impossible to decode the octet stream without knowledge of the asn. -in sack options only look for tcp session metadata if both tcp_analysis and tcp_relative preferences are set. relative depends on analysis ------------------------------------------------------------------------ -r13397 | etxrab | 2005-02-14 10:21:47 -0600 (Mon, 14 Feb 2005) | 1 line +r14729 | gerald | 2005-06-22 10:37:46 -0500 (Wed, 22 Jun 2005) | 3 lines Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/to_str.c + +Fix an off-by-four error, which should take care of bugs 254 - 258. Print +OID values as unsigned ints instead of signed. -Add some more V3 opcodes ------------------------------------------------------------------------ -r13396 | etxrab | 2005-02-14 10:20:58 -0600 (Mon, 14 Feb 2005) | 1 line +r14730 | etxrab | 2005-06-22 11:15:16 -0500 (Wed, 22 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c + A /trunk/idl -Add some more V3 opcodes +Add a folder for IDL dockuments ------------------------------------------------------------------------ -r13395 | etxrab | 2005-02-14 02:21:14 -0600 (Mon, 14 Feb 2005) | 1 line +r14731 | etxrab | 2005-06-22 11:16:24 -0500 (Wed, 22 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c + A /trunk/idl/parlay -From :Tim Endean correct conditions for a while loop. +Add a folder for Parlay IDL doc's ------------------------------------------------------------------------ -r13394 | etxrab | 2005-02-14 02:20:33 -0600 (Mon, 14 Feb 2005) | 1 line +r14732 | etxrab | 2005-06-22 11:17:18 -0500 (Wed, 22 Jun 2005) | 1 line Changed paths: - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + A /trunk/idl/parlay/Parlay.idl + A /trunk/idl/parlay/README.parlay + A /trunk/idl/parlay/am.idl + A /trunk/idl/parlay/cccs.idl + A /trunk/idl/parlay/cm.idl + A /trunk/idl/parlay/common_cc_data.idl + A /trunk/idl/parlay/cs.idl + A /trunk/idl/parlay/dsc.idl + A /trunk/idl/parlay/fw_data.idl + A /trunk/idl/parlay/fw_if.idl + A /trunk/idl/parlay/fw_if_access.idl + A /trunk/idl/parlay/fw_if_app.idl + A /trunk/idl/parlay/fw_if_entop.idl + A /trunk/idl/parlay/fw_if_service.idl + A /trunk/idl/parlay/gcc_data.idl + A /trunk/idl/parlay/gcc_interfaces.idl + A /trunk/idl/parlay/gms.idl + A /trunk/idl/parlay/mm.idl + A /trunk/idl/parlay/mmccs.idl + A /trunk/idl/parlay/mmm.idl + A /trunk/idl/parlay/mpcc_data.idl + A /trunk/idl/parlay/mpcc_interfaces.idl + A /trunk/idl/parlay/osa.idl + A /trunk/idl/parlay/pam_data.idl + A /trunk/idl/parlay/pam_interfaces.idl + A /trunk/idl/parlay/policy_data.idl + A /trunk/idl/parlay/policy_interfaces.idl + A /trunk/idl/parlay/termcap.idl + A /trunk/idl/parlay/ui_data.idl + A /trunk/idl/parlay/ui_interfaces.idl -From :Tim Endean correct conditions for a while loop. +Add the IDL doc's needed to build the Parlay dissector. ------------------------------------------------------------------------ -r13393 | guy | 2005-02-13 20:46:54 -0600 (Sun, 13 Feb 2005) | 2 lines +r14733 | sahlberg | 2005-06-23 04:28:46 -0500 (Thu, 23 Jun 2005) | 5 lines Changed paths: - M /trunk/plugins/agentx + M /trunk/asn1/cmip/cmip.cnf + M /trunk/epan/dissectors/packet-cmip.c + +fix for CMIP, we should set the opcode_type BEFORE we try to use it in the subdissector, +it doesnt work really that well if we have opcode_type set to INVOKE from the previous packet and this new packet contains a ReturnResult. + -Add the usual set of file names/patterns to ignore. ------------------------------------------------------------------------ -r13392 | lroland | 2005-02-13 17:30:56 -0600 (Sun, 13 Feb 2005) | 1 line +r14734 | ulfl | 2005-06-23 15:14:05 -0500 (Thu, 23 Jun 2005) | 1 line Changed paths: - M /trunk/gtk/graph_analysis.c - M /trunk/gtk/voip_calls.c - M /trunk/gtk/voip_calls_dlg.c + M /trunk/gtk/main.c -remove a bunch of unnecessary "includes" from VoIP tap and graph analysis sources +beautify version and usage output ------------------------------------------------------------------------ -r13391 | lego | 2005-02-12 21:53:48 -0600 (Sat, 12 Feb 2005) | 3 lines +r14735 | ulfl | 2005-06-23 15:18:17 -0500 (Thu, 23 Jun 2005) | 1 line Changed paths: - M /trunk/AUTHORS + M /trunk/gtk/main.c + +Win32: "fix" handling of create_console(), hopefully clarifying usage of the corresponding prefs flag +------------------------------------------------------------------------ +r14736 | ulfl | 2005-06-23 16:19:05 -0500 (Thu, 23 Jun 2005) | 3 lines +Changed paths: + M /trunk/gtk/main.c -Update Venna Nagarjuna -change my own e-mail address (I'll keep the old one for two more weeks only) +fix #135: handle the command line parameters -v, -h and -G completely in their own getopt() loop. +This is done "long before" calling gtk_init() as this function requires a running X server, causing an error if running from the console only. ------------------------------------------------------------------------ -r13390 | lego | 2005-02-12 21:41:44 -0600 (Sat, 12 Feb 2005) | 3 lines +r14737 | etxrab | 2005-06-23 17:15:47 -0500 (Thu, 23 Jun 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-rtcp.c + M /trunk/asn1/tcap/packet-tcap-template.c -From Venna, Nagarjuna: - add support for RTCP-XR as specified in RFC 3611 +From Valery Vybornov: +add register_dissector to packet-tcap.c +------------------------------------------------------------------------ +r14738 | etxrab | 2005-06-23 17:17:03 -0500 (Thu, 23 Jun 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/dissectors/packet-tcap.h +From Valery Vybornov: +add register_dissector to packet-tcap.c ------------------------------------------------------------------------ -r13389 | lroland | 2005-02-12 18:10:15 -0600 (Sat, 12 Feb 2005) | 8 lines +r14739 | guy | 2005-06-23 20:32:42 -0500 (Thu, 23 Jun 2005) | 5 lines Changed paths: - M /trunk/Makefile.nmake - M /trunk/alert_box.c - M /trunk/capture.c - M /trunk/capture_sync.c - M /trunk/capture_ui_utils.c - M /trunk/color_filters.c - M /trunk/dftest.c - M /trunk/epan/Makefile.nmake - M /trunk/file.c - M /trunk/gtk/capture_if_dlg.c - M /trunk/print.c - M /trunk/tap-ansi_astat.c - M /trunk/tap-gsm_astat.c - M /trunk/tap-h225counter.c - M /trunk/tap-rpcstat.c - M /trunk/tap-smbsids.c - M /trunk/tap-smbstat.c + M /trunk/epan/prefs.c + M /trunk/epan/prefs.h + M /trunk/gtk/dfilter_expr_dlg.c + M /trunk/gtk/http_stat.c + M /trunk/gtk/service_response_time_table.c + M /trunk/gtk/service_response_time_table.h + M /trunk/gtk/sip_stat.c + M /trunk/gtk/wsp_stat.c + M /trunk/tap-httpstat.c + M /trunk/tap-protohierstat.c + M /trunk/tap-sipstat.c M /trunk/tap-wspstat.c - M /trunk/tethereal.c -change nmake makefiles in /trunk and /trunk/epan so that -object code for libethereal.dll isn't generated by the -makefile in /trunk. +Constify a bunch of structure members and function arguments, to squelch +compiler warnings. + +Clean up indentation. -Having no code in /trunk linked into libethereal.dll -anymore, the definition of the macro _NEED_VAR_IMPORT_ -can be moved from various source files in /trunk to /trunk/Makefile.nmake . -So do that, too. ------------------------------------------------------------------------ -r13388 | etxrab | 2005-02-12 15:36:56 -0600 (Sat, 12 Feb 2005) | 1 line +r14740 | guy | 2005-06-23 21:51:01 -0500 (Thu, 23 Jun 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/proto.c + M /trunk/epan/proto.h + M /trunk/gtk/main.c + M /trunk/plugins/mate/mate_setup.c + +More constification. -Add a part of the previous patch that didn't apply. ------------------------------------------------------------------------ -r13387 | etxrab | 2005-02-12 15:35:01 -0600 (Sat, 12 Feb 2005) | 9 lines +r14741 | sahlberg | 2005-06-24 03:57:41 -0500 (Fri, 24 Jun 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-ber.c + +fix to ber NULL handling +1, make it actually show the hf field when present +2, make it handle imlicit_tag properly + -GMM/SM: - - Dissect detach_type now correctly ( fixed by Miklos Szurdi ) - - Dissect timer correctly ( fixed by Miklos Szurdi ) - - Update SM causes for Release 6 ( Miklos Szurdi ) - - Update service_type for Release 6 ( Miklos Szurdi ) - - Rearange pco code like Guy Harris has suggested ( Guy Harris ) - - reimplement dissection of IPv4 and IPv6 addresses - - Fix offset in pdp_addr - - Fix offset in Traffic Flow Template (tft ------------------------------------------------------------------------ -r13386 | etxrab | 2005-02-12 15:20:38 -0600 (Sat, 12 Feb 2005) | 20 lines +r14742 | sahlberg | 2005-06-24 05:03:20 -0500 (Fri, 24 Jun 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-gprs-llc.c + M /trunk/epan/dissectors/packet-ber.c -From Rene Pilz : + for unknown GraphicString +just decode them as an octet string and say in the decode pane this is an unknown GraphicString -BSSGP: - - Does not dissect the LLC-PDU twice -LLC: -- Add CRC calculation to differ between ciphered and non-ciphered packets without taking care about the encryption bit. -This solves crashes when the option "ignore ciphere bit" was activated +------------------------------------------------------------------------ +r14743 | guy | 2005-06-24 06:26:19 -0500 (Fri, 24 Jun 2005) | 6 lines +Changed paths: + M /trunk/ethereal_gen.py -GMM/SM: - - Dissect detach_type now correctly ( fixed by Miklos Szurdi ) - - Dissect timer correctly ( fixed by Miklos Szurdi ) - - Update SM causes for Release 6 ( Miklos Szurdi ) - - Update service_type for Release 6 ( Miklos Szurdi ) - - Rearange pco code like Guy Harris has suggested ( Guy Harris ) - - reimplement dissection of IPv4 and IPv6 addresses - - Fix offset in pdp_addr - - Fix offset in Traffic Flow Template (tft) +There's no guarantee that a reply with a reply status of USER_EXCEPTION +includes an exception ID - the sequence length could be zero. When +generating a dissector for a USER_EXCEPTION reply, return FALSE if +there's no exception ID. (And since we're now always using the header +pointer argument, un-_U_ize it.) ------------------------------------------------------------------------ -r13385 | etxrab | 2005-02-12 15:20:01 -0600 (Sat, 12 Feb 2005) | 20 lines +r14744 | guy | 2005-06-24 06:38:19 -0500 (Fri, 24 Jun 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-bssgp.c + A /trunk/idl/coseventcomm.idl + A /trunk/idl/cosnaming.idl + +Add IDL for cosnaming and coseventcomm. -From Rene Pilz : +------------------------------------------------------------------------ +r14745 | guy | 2005-06-24 07:43:32 -0500 (Fri, 24 Jun 2005) | 5 lines +Changed paths: + M /trunk/plugins/giop/packet-coseventcomm.c + M /trunk/plugins/giop/packet-cosnaming.c + M /trunk/plugins/giop/packet-parlay.c + M /trunk/plugins/giop/packet-tango.c -BSSGP: - - Does not dissect the LLC-PDU twice +Re-generate the CosNaming, CosEventComm, and Parlay dissectors from the +IDL (and re-insert an earlier bug fix into the CosNaming and +CosEventComm dissectors), and add a new check added to ethereal_gen.py +to the Tango dissector. -LLC: -- Add CRC calculation to differ between ciphered and non-ciphered packets without taking care about the encryption bit. -This solves crashes when the option "ignore ciphere bit" was activated +------------------------------------------------------------------------ +r14746 | sahlberg | 2005-06-25 02:46:14 -0500 (Sat, 25 Jun 2005) | 3 lines +Changed paths: + A /trunk/asn1/acse/acse-exp.cnf + M /trunk/asn1/acse/acse.cnf + M /trunk/asn1/acse/packet-acse-template.h + M /trunk/asn1/cmip/CMIP.asn + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-acse.h +Make ACSE export the EXTERNAL construct since both CMIP and FTAM rely on it. -GMM/SM: - - Dissect detach_type now correctly ( fixed by Miklos Szurdi ) - - Dissect timer correctly ( fixed by Miklos Szurdi ) - - Update SM causes for Release 6 ( Miklos Szurdi ) - - Update service_type for Release 6 ( Miklos Szurdi ) - - Rearange pco code like Guy Harris has suggested ( Guy Harris ) - - reimplement dissection of IPv4 and IPv6 addresses - - Fix offset in pdp_addr - - Fix offset in Traffic Flow Template (tft) ------------------------------------------------------------------------ -r13384 | etxrab | 2005-02-11 16:44:09 -0600 (Fri, 11 Feb 2005) | 1 line +r14747 | sahlberg | 2005-06-25 07:40:53 -0500 (Sat, 25 Jun 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c + A /trunk/asn1/ftam + A /trunk/asn1/ftam/ISO8571-FTAM.asn + A /trunk/asn1/ftam/Makefile + A /trunk/asn1/ftam/Makefile.nmake + A /trunk/asn1/ftam/ftam.cnf + A /trunk/asn1/ftam/packet-ftam-template.c + A /trunk/asn1/ftam/packet-ftam-template.h + M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/dissectors/packet-ftam.h + +new FTAM dissector generated by asn2eth + + -Dissect Return error and some more operationcodes. ------------------------------------------------------------------------ -r13383 | etxrab | 2005-02-11 16:43:24 -0600 (Fri, 11 Feb 2005) | 1 line +r14748 | etxrab | 2005-06-25 12:25:44 -0500 (Sat, 25 Jun 2005) | 1 line Changed paths: M /trunk/asn1/gsmmap/GSMMAP.asn + M /trunk/asn1/gsmmap/gsmmap.cnf M /trunk/asn1/gsmmap/packet-gsm_map-template.c -Dissect Return error and some more operationcodes. +Major rewrite to update to version TS 129 002 V6.9.0 ------------------------------------------------------------------------ -r13382 | lego | 2005-02-10 18:04:25 -0600 (Thu, 10 Feb 2005) | 1 line +r14749 | etxrab | 2005-06-25 12:26:30 -0500 (Sat, 25 Jun 2005) | 1 line Changed paths: - M /trunk/plugins/mate/mate_runtime.c - M /trunk/plugins/mate/packet-mate.c + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-gsm_map.h -avoid freeing the gop_key more than once and do not reregister the tap at every reload +Major rewrite to update to version TS 129 002 V6.9.0 ------------------------------------------------------------------------ -r13381 | lego | 2005-02-10 11:14:31 -0600 (Thu, 10 Feb 2005) | 1 line +r14750 | guy | 2005-06-25 13:20:13 -0500 (Sat, 25 Jun 2005) | 8 lines Changed paths: - M /trunk/plugins/mate/packet-mate.c + M /trunk/ethereal_gen.py + M /trunk/plugins/giop/packet-coseventcomm.c + M /trunk/plugins/giop/packet-cosnaming.c + M /trunk/plugins/giop/packet-parlay.c -mate runtime did not get initialized when configured after loading a capture file ------------------------------------------------------------------------- -r13380 | lego | 2005-02-10 10:55:08 -0600 (Thu, 10 Feb 2005) | 1 line -Changed paths: - M /trunk/plugins/mate/mate.h - M /trunk/plugins/mate/mate_setup.c - M /trunk/plugins/mate/packet-mate.c +In generated GIOP dissectors, don't set the Protocol or Info columns, or +create the top-level protocol tree item, until the dissector accepts the +packet as being for it. + +"strcmp()" isn't a Boolean; don't treat it as such. + +Get rid of trailing white space. -add "mate" as a protocol to its tree ------------------------------------------------------------------------ -r13379 | gerald | 2005-02-10 10:24:12 -0600 (Thu, 10 Feb 2005) | 4 lines +r14751 | guy | 2005-06-25 13:56:08 -0500 (Sat, 25 Jun 2005) | 2 lines Changed paths: M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-dns.c -From Nicolas Dichtel via Vincent Jardin: +Give Paolo Frigo credit for the TANGO dissector. + +------------------------------------------------------------------------ +r14752 | guy | 2005-06-25 14:14:17 -0500 (Sat, 25 Jun 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-ppp.c -Print a couple of missing fields. +The data in an Identification packet is a message intended to be +human-readable; displayh it with "tvb_format_text()". ------------------------------------------------------------------------ -r13378 | lego | 2005-02-10 10:23:52 -0600 (Thu, 10 Feb 2005) | 1 line +r14753 | ulfl | 2005-06-25 16:27:26 -0500 (Sat, 25 Jun 2005) | 1 line Changed paths: - A /trunk/plugins/mate/examples/call.mate - D /trunk/plugins/mate/examples/call.thing - D /trunk/plugins/mate/examples/cmplx_call.thing - D /trunk/plugins/mate/examples/ftp.thing - D /trunk/plugins/mate/examples/mgw.thing - D /trunk/plugins/mate/examples/mgw2.thing - D /trunk/plugins/mate/examples/mgw_mi.thing - D /trunk/plugins/mate/examples/newcall.mate - D /trunk/plugins/mate/examples/nrg_sms.thing - A /trunk/plugins/mate/examples/pasv_ftp.mate - D /trunk/plugins/mate/examples/rad.thing - A /trunk/plugins/mate/examples/tcp.mate - A /trunk/plugins/mate/examples/web.mate - M /trunk/plugins/mate/matelib/sip.mate - D /trunk/plugins/mate/presentation.txt + M /trunk/gtk/main.c -cleanup matelib and mate examples +we are not a GNU program, so we shouldn't report as such in the command line help output ------------------------------------------------------------------------ -r13377 | guy | 2005-02-10 02:52:35 -0600 (Thu, 10 Feb 2005) | 2 lines +r14754 | sahlberg | 2005-06-25 16:57:11 -0500 (Sat, 25 Jun 2005) | 4 lines Changed paths: - M /trunk/plugins/agentx/packet-agentx.c + M /trunk/AUTHORS + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-mms-control.c + A /trunk/epan/dissectors/packet-mms-data.c + +From Martin Mathieson +New protocol : MS MediaServer protocol -Use tcp_dissect_pdus(). ------------------------------------------------------------------------ -r13376 | guy | 2005-02-10 02:15:35 -0600 (Thu, 10 Feb 2005) | 3 lines +r14755 | sahlberg | 2005-06-25 17:15:51 -0500 (Sat, 25 Jun 2005) | 6 lines Changed paths: - M /trunk/plugins/agentx/packet-agentx.c + M /trunk/epan/conversation.c + +from Kashyap Desai + +fix bug in conversation_delete_proto_data +second argument to g_slist_remove() is a pointer to the data, not a GSlist containing a list of such pointers. -Use VB_ rather than V_ for the VarBind types, to avoid a collision with -V_INT in oleauto.h in Windows. ------------------------------------------------------------------------ -r13375 | guy | 2005-02-10 02:10:18 -0600 (Thu, 10 Feb 2005) | 3 lines +r14756 | sahlberg | 2005-06-25 18:12:24 -0500 (Sat, 25 Jun 2005) | 5 lines Changed paths: - M /trunk/epan/libethereal.def + M /trunk/asn1/cmip/CMIP.asn + M /trunk/asn1/cmip/cmip.cnf + M /trunk/asn1/cmip/packet-cmip-template.c + +some updates for CMIP. + +note taht cmip does not yet compile due to a possible asn2eth compiler bug -Export the routines to add 64-bit integer values, and export -tvb_ensure_length_remaining(). ------------------------------------------------------------------------ -r13374 | guy | 2005-02-10 02:07:44 -0600 (Thu, 10 Feb 2005) | 6 lines +r14757 | sahlberg | 2005-06-25 19:12:15 -0500 (Sat, 25 Jun 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-iax2.c + M /trunk/gtk/graph_analysis.c -Add a hack to set "reversed" and "circuit" in code paths where it wasn't -getting set. The hack needs to be replaced by code that does the right -thing. +From Alejandro, fix for GTK1 graph_analysis issue. -Fix indentation. ------------------------------------------------------------------------ -r13373 | guy | 2005-02-10 01:23:01 -0600 (Thu, 10 Feb 2005) | 3 lines +r14758 | sahlberg | 2005-06-26 00:48:50 -0500 (Sun, 26 Jun 2005) | 13 lines Changed paths: - M /trunk/gtk/capture_prefs.c + M /trunk/asn1/camel/packet-camel-template.c + M /trunk/asn1/ftam/ftam.cnf + M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/asn1/inap/packet-inap-template.c + M /trunk/asn1/pkixcmp/cmp-exp.cnf + M /trunk/asn1/tcap/tcap.cnf + M /trunk/epan/dissectors/packet-MAP_DialoguePDU.c + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-ber.h + M /trunk/epan/dissectors/packet-camel.c + M /trunk/epan/dissectors/packet-camel.h + M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-cmp.c + M /trunk/epan/dissectors/packet-cmp.h + M /trunk/epan/dissectors/packet-cms.c + M /trunk/epan/dissectors/packet-crmf.c + M /trunk/epan/dissectors/packet-ess.c + M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-gsm_map.h + M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-inap.c + M /trunk/epan/dissectors/packet-inap.h + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-logotypecertextn.c + M /trunk/epan/dissectors/packet-ocsp.c + M /trunk/epan/dissectors/packet-pkinit.c + M /trunk/epan/dissectors/packet-pkix1implicit.c + M /trunk/epan/dissectors/packet-pkix1implicit.h + M /trunk/epan/dissectors/packet-pkixqualified.c + M /trunk/epan/dissectors/packet-smrse.c + M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/dissectors/packet-tcap.h + M /trunk/epan/dissectors/packet-x509af.c + M /trunk/epan/dissectors/packet-x509ce.c + M /trunk/epan/dissectors/packet-x509if.c + M /trunk/epan/dissectors/packet-x509sat.c + M /trunk/tools/asn2eth.py + +make dissect_ber_choice take a guint* that will return the +index of the branch taken or -1 to make prettifications easier to implement. + + +change the signature of dissect_ber_choice and rename it to dissect_ber_CHOICE to catch all +occurences of the use of this function + +update asn2eth to use the new name/signature + +update all occurences of this function to the new name and new signature. + -Always make the elements of the "text" array point to g_mallocated -strings, so that they can safely be g_freed. ------------------------------------------------------------------------ -r13372 | guy | 2005-02-10 00:36:21 -0600 (Thu, 10 Feb 2005) | 2 lines +r14759 | sahlberg | 2005-06-26 01:16:03 -0500 (Sun, 26 Jun 2005) | 3 lines Changed paths: - M /trunk/AUTHORS - M /trunk/Makefile.am - M /trunk/configure.in - M /trunk/packaging/nsis/Makefile.nmake - M /trunk/packaging/nsis/ethereal.nsi - M /trunk/plugins/Makefile.am - M /trunk/plugins/Makefile.nmake - A /trunk/plugins/agentx - A /trunk/plugins/agentx/AUTHORS - A /trunk/plugins/agentx/Makefile.am - A /trunk/plugins/agentx/Makefile.nmake - A /trunk/plugins/agentx/moduleinfo.h - A /trunk/plugins/agentx/packet-agentx.c + M /trunk/asn1/ftam/ftam.cnf + M /trunk/asn1/ftam/packet-ftam-template.c + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-ftam.c + +prettify ftam by puttign the command name in the info column -From Oleg Terletsky: AgentX support. ------------------------------------------------------------------------ -r13371 | guy | 2005-02-09 21:19:59 -0600 (Wed, 09 Feb 2005) | 3 lines +r14760 | sahlberg | 2005-06-26 01:28:53 -0500 (Sun, 26 Jun 2005) | 3 lines Changed paths: - M /trunk/asn1/inap/packet-inap-template.c - M /trunk/epan/dissectors/packet-inap.c - M /trunk/epan/dissectors/packet-inap.h + M /trunk/epan/libethereal.def + +update libethereal.def to the new name dissect_ber_CHOICE -Remove an extra /*, some unused variables, and an unneeded include (INAP -currently has no taps). ------------------------------------------------------------------------ -r13370 | guy | 2005-02-09 21:10:08 -0600 (Wed, 09 Feb 2005) | 2 lines +r14761 | sahlberg | 2005-06-26 03:12:54 -0500 (Sun, 26 Jun 2005) | 4 lines Changed paths: - A /trunk/asn1/inap/Makefile + M /trunk/epan/dissectors/packet-mms-control.c + M /trunk/epan/dissectors/packet-mms-data.c + +rename the protocol and the protocol fields to msmms from mms to make way for the telco mms protocol. + -Add a Makefile. ------------------------------------------------------------------------ -r13369 | ulfl | 2005-02-09 19:55:36 -0600 (Wed, 09 Feb 2005) | 1 line +r14762 | ulfl | 2005-06-26 04:14:12 -0500 (Sun, 26 Jun 2005) | 1 line Changed paths: - M /trunk/file.c + M /trunk/doc/README.capture -bugfix for sync_mode captures, wasn't started correctly (cf_callback_invoke(cf_cb_live_capture_started); was never called) +update text to reflect the current implementation (e.g. we don't have normal/sync mode any longer) ------------------------------------------------------------------------ -r13368 | lroland | 2005-02-09 19:26:19 -0600 (Wed, 09 Feb 2005) | 4 lines +r14763 | ulfl | 2005-06-26 04:24:38 -0500 (Sun, 26 Jun 2005) | 1 line Changed paths: - M /trunk/Makefile.nmake - M /trunk/epan/Makefile.am - M /trunk/epan/Makefile.common - M /trunk/epan/Makefile.nmake - M /trunk/epan/dissectors/Makefile.nmake - -clean up makefiles. + D /trunk/docbook/edg_graphics/ethereal-capture-normal.dia + D /trunk/docbook/edg_graphics/ethereal-capture-normal.png -especially /trunk/Makefile.nmake doesn't have to include -/trunk/epan/Makefile.common anymore. +we don't have the capture normal mode any longer ------------------------------------------------------------------------ -r13367 | lroland | 2005-02-09 17:55:14 -0600 (Wed, 09 Feb 2005) | 1 line +r14764 | ulfl | 2005-06-26 05:23:39 -0500 (Sun, 26 Jun 2005) | 3 lines Changed paths: - M /trunk/asn1/inap/inap.cnf + M /trunk/gtk/main.c -fix svn properties +remove compiler warnings: +main.c(345) : warning C4090: 'function' : different 'const' qualifiers +main.c(345) : warning C4022: 'simple_dialog_set_cb' : pointer mismatch for actual parameter 3 ------------------------------------------------------------------------ -r13366 | lroland | 2005-02-09 17:38:00 -0600 (Wed, 09 Feb 2005) | 8 lines +r14765 | ulfl | 2005-06-26 05:26:47 -0500 (Sun, 26 Jun 2005) | 1 line Changed paths: - M /trunk/Makefile.common - D /trunk/asn1.c - D /trunk/asn1.h - M /trunk/epan/Makefile.common - A /trunk/epan/asn1.c (from /trunk/asn1.c:13362) - A /trunk/epan/asn1.h (from /trunk/asn1.h:13362) - M /trunk/epan/dissectors/ncp2222.py - M /trunk/epan/dissectors/packet-acse.c - M /trunk/epan/dissectors/packet-ansi_map.c - M /trunk/epan/dissectors/packet-atalk.c - M /trunk/epan/dissectors/packet-clnp.c - M /trunk/epan/dissectors/packet-cops.c - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-diameter.c - M /trunk/epan/dissectors/packet-dnp.c - M /trunk/epan/dissectors/packet-eap.c - M /trunk/epan/dissectors/packet-fc.c - M /trunk/epan/dissectors/packet-ftam.c - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-gsm_sms_ud.c - M /trunk/epan/dissectors/packet-gsm_ss.c - M /trunk/epan/dissectors/packet-gssapi.c - M /trunk/epan/dissectors/packet-ieee80211.c - M /trunk/epan/dissectors/packet-inap.c - M /trunk/epan/dissectors/packet-ip.c - M /trunk/epan/dissectors/packet-ipv6.c - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-ldap.c - M /trunk/epan/dissectors/packet-lwapp.c - M /trunk/epan/dissectors/packet-mq.c - M /trunk/epan/dissectors/packet-mysql.c - M /trunk/epan/dissectors/packet-ncp.c - M /trunk/epan/dissectors/packet-ndmp.c - M /trunk/epan/dissectors/packet-ndps.c - M /trunk/epan/dissectors/packet-netbios.c - M /trunk/epan/dissectors/packet-ntlmssp.c - M /trunk/epan/dissectors/packet-pgsql.c - M /trunk/epan/dissectors/packet-pres.c - M /trunk/epan/dissectors/packet-q931.c - M /trunk/epan/dissectors/packet-rpc.c - M /trunk/epan/dissectors/packet-smb-pipe.c - M /trunk/epan/dissectors/packet-smb.c - M /trunk/epan/dissectors/packet-sna.c - M /trunk/epan/dissectors/packet-sndcp.c - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/dissectors/packet-spnego.c - M /trunk/epan/dissectors/packet-srvloc.c - M /trunk/epan/dissectors/packet-ssh.c - M /trunk/epan/dissectors/packet-tcap.c - M /trunk/epan/dissectors/packet-tcp.c - M /trunk/epan/dissectors/packet-tds.c - M /trunk/epan/dissectors/packet-wtp.c - M /trunk/epan/dissectors/packet-x25.c - A /trunk/epan/follow.c (from /trunk/follow.c:13362) - A /trunk/epan/follow.h (from /trunk/follow.h:13362) - M /trunk/epan/packet.c - M /trunk/epan/plugins.c - A /trunk/epan/ptvcursor.c (from /trunk/ptvcursor.c:13362) - A /trunk/epan/ptvcursor.h (from /trunk/ptvcursor.h:13362) - A /trunk/epan/reassemble.c (from /trunk/reassemble.c:13362) - A /trunk/epan/reassemble.h (from /trunk/reassemble.h:13362) - A /trunk/epan/xmlstub.c (from /trunk/xmlstub.c:13359) - A /trunk/epan/xmlstub.h (from /trunk/xmlstub.h:13359) - D /trunk/follow.c - D /trunk/follow.h - M /trunk/gtk/follow_dlg.c - M /trunk/plugins/asn1/packet-asn1.c - M /trunk/plugins/plugin_api.h - M /trunk/plugins/plugin_api_list.c - D /trunk/ptvcursor.c - D /trunk/ptvcursor.h - D /trunk/reassemble.c - D /trunk/reassemble.h - D /trunk/xmlstub.c - D /trunk/xmlstub.h - -Move the following files from /trunk to /trunk/epan: -asn1.[ch] -follow.[ch] -ptvcursor.[ch] -reassemble.[ch] -xmlstub.[ch] - -fix #include statements accordingly. ------------------------------------------------------------------------- -r13365 | etxrab | 2005-02-09 16:43:57 -0600 (Wed, 09 Feb 2005) | 1 line + M /trunk/gtk/sctp_graph_dlg.c + +sctp_graph_dlg.c(383) : warning C4244: '=' : conversion from 'unsigned int ' to 'float ', possible loss of data +------------------------------------------------------------------------ +r14766 | ulfl | 2005-06-26 05:28:51 -0500 (Sun, 26 Jun 2005) | 1 line Changed paths: - M /trunk/AUTHORS + M /trunk/gtk/proto_hier_stats_dlg.c -Add Tim Endean +proto_hier_stats_dlg.c(99) : warning C4090: '=' : different 'const' qualifiers ------------------------------------------------------------------------ -r13364 | etxrab | 2005-02-09 16:35:49 -0600 (Wed, 09 Feb 2005) | 1 line +r14767 | ulfl | 2005-06-26 05:41:38 -0500 (Sun, 26 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-inap.c - A /trunk/epan/dissectors/packet-inap.h + M /trunk/epan/dissectors/packet-alcap.c -From Tim Endean: INAP dissector. +packet-alcap.c(195) : warning C4090: 'return' : different 'const' qualifiers ------------------------------------------------------------------------ -r13363 | etxrab | 2005-02-09 16:31:40 -0600 (Wed, 09 Feb 2005) | 1 line +r14768 | ulfl | 2005-06-26 05:45:25 -0500 (Sun, 26 Jun 2005) | 1 line Changed paths: - A /trunk/asn1/inap/inap.asn - A /trunk/asn1/inap/inap.cnf - A /trunk/asn1/inap/packet-inap-template.c - A /trunk/asn1/inap/packet-inap-template.h + M /trunk/epan/dissectors/packet-ansi_637.c -From Tim Endean: INAP dissector. +packet-ansi_637.c(288) : warning C4090: 'return' : different 'const' qualifiers ------------------------------------------------------------------------ -r13362 | etxrab | 2005-02-09 16:01:53 -0600 (Wed, 09 Feb 2005) | 1 line +r14769 | ulfl | 2005-06-26 05:48:27 -0500 (Sun, 26 Jun 2005) | 1 line Changed paths: - A /trunk/asn1/inap + M /trunk/epan/dissectors/packet-ansi_683.c -From Tim Endean: INAP dissector +packet-ansi_683.c(93) : warning C4090: 'return' : different 'const' qualifiers ------------------------------------------------------------------------ -r13361 | etxrab | 2005-02-09 15:55:55 -0600 (Wed, 09 Feb 2005) | 1 line +r14770 | ulfl | 2005-06-26 05:51:56 -0500 (Sun, 26 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-ansi_801.c -Fix dissection of some opcodes etc. +packet-ansi_801.c(93) : warning C4090: 'return' : different 'const' qualifiers ------------------------------------------------------------------------ -r13360 | etxrab | 2005-02-09 15:54:57 -0600 (Wed, 09 Feb 2005) | 1 line +r14771 | ulfl | 2005-06-26 05:55:34 -0500 (Sun, 26 Jun 2005) | 1 line Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/dissectors/packet-ansi_a.c -Fix decoding of some opcodes etc. +packet-ansi_a.c(460) : warning C4090: 'return' : different 'const' qualifiers ------------------------------------------------------------------------ -r13359 | guy | 2005-02-09 03:25:54 -0600 (Wed, 09 Feb 2005) | 4 lines +r14772 | ulfl | 2005-06-26 05:58:32 -0500 (Sun, 26 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-l2tp.c + M /trunk/epan/dissectors/packet-ansi_map.c -From Deepak Jain: add support for some Cisco L2TPv3 AVPs, always show -the numerical value of the pseudowire type, and show the Remote End ID -AVP as text rather than binary data. +packet-ansi_map.c(760) : warning C4090: 'return' : different 'const' qualifiers +------------------------------------------------------------------------ +r14773 | etxrab | 2005-06-26 05:59:15 -0500 (Sun, 26 Jun 2005) | 1 line +Changed paths: + M /trunk/asn1/ftam/ftam.cnf + M /trunk/asn1/ftam/packet-ftam-template.c + M /trunk/asn1/ftam/packet-ftam-template.h +Fix a compiler warning and set eol-style. ------------------------------------------------------------------------ -r13358 | lroland | 2005-02-08 16:10:04 -0600 (Tue, 08 Feb 2005) | 1 line +r14774 | etxrab | 2005-06-26 06:00:19 -0500 (Sun, 26 Jun 2005) | 1 line Changed paths: - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/dissectors/packet-ftam.h -Set Registry key for starting NPF service to "Auto Start" and not "System Start". +Fix a compiler warning. ------------------------------------------------------------------------ -r13357 | lroland | 2005-02-08 15:12:54 -0600 (Tue, 08 Feb 2005) | 2 lines +r14775 | etxrab | 2005-06-26 06:01:04 -0500 (Sun, 26 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rtp.c + M /trunk/asn1/gsmmap/GSMMAP.asn + M /trunk/asn1/gsmmap/packet-gsm_map-template.c -use "guint" instead of "uint". -"uint" is not available on Windows +Add a signal ------------------------------------------------------------------------ -r13356 | guy | 2005-02-08 14:54:08 -0600 (Tue, 08 Feb 2005) | 7 lines +r14776 | ulfl | 2005-06-26 06:02:13 -0500 (Sun, 26 Jun 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-rtp.c + M /trunk/epan/dissectors/packet-dcerpc-samr.c -From Jon Ringle: add a preference to allow packets with an RTP version -of 0 to be dissected as STUN packets, to support dissecting of -application that follow the ICE methodology described in -draft-ietf-mmusic-ice-03. +packet-dcerpc-samr.c(2795) : warning C4090: '=' : different 'const' qualifiers +packet-dcerpc-samr.c(2900) : warning C4090: '=' : different 'const' qualifiers +packet-dcerpc-samr.c(2933) : warning C4090: '=' : different 'const' qualifiers +------------------------------------------------------------------------ +r14777 | etxrab | 2005-06-26 06:03:39 -0500 (Sun, 26 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-gsm_map.c -Remove some extra spaces at the end of tags for preferences. +Add a signal +------------------------------------------------------------------------ +r14778 | ulfl | 2005-06-26 06:10:26 -0500 (Sun, 26 Jun 2005) | 6 lines +Changed paths: + M /trunk/epan/dissectors/packet-diameter.c +packet-diameter.c(856) : warning C4090: 'function' : different 'const' qualifiers +packet-diameter.c(856) : warning C4024: 'addVendor' : different types for formal and actual parameter 2 +packet-diameter.c(857) : warning C4090: 'function' : different 'const' qualifiers +packet-diameter.c(857) : warning C4024: 'addVendor' : different types for formal and actual parameter 3 +packet-diameter.c(863) : warning C4090: 'function' : different 'const' qualifiers +packet-diameter.c(863) : warning C4024: 'addCommand' : different types for formal and actual parameter 2 ------------------------------------------------------------------------ -r13355 | ulfl | 2005-02-08 13:57:16 -0600 (Tue, 08 Feb 2005) | 3 lines +r14779 | ulfl | 2005-06-26 06:18:47 -0500 (Sun, 26 Jun 2005) | 1 line Changed paths: - M /trunk/capture.c - M /trunk/file.h - M /trunk/gtk/main.c + M /trunk/epan/dissectors/packet-pgsql.c -fix a capture bug if the capture filter wasn't valid to get back to "empty" state. +packet-pgsql.c(891) : warning C4090: 'return' : different 'const' qualifiers +------------------------------------------------------------------------ +r14780 | ulfl | 2005-06-26 06:21:39 -0500 (Sun, 26 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-smb.c -instead of already invoking cf_cb_live_capture_started in capture.c, I've introduced the new event cf_cb_live_capture_prepare which only has to set the main windows title and nothing more. +packet-smb.c(14406) : warning C4090: 'return' : different 'const' qualifiers ------------------------------------------------------------------------ -r13354 | lroland | 2005-02-08 13:36:20 -0600 (Tue, 08 Feb 2005) | 2 lines +r14781 | ulfl | 2005-06-26 06:24:26 -0500 (Sun, 26 Jun 2005) | 3 lines Changed paths: - M /trunk/Makefile.common - M /trunk/asn1/h225/packet-h225-template.c - M /trunk/epan/Makefile.common - M /trunk/epan/dissectors/packet-h225.c - A /trunk/epan/h225-persistentdata.c (from /trunk/h225-persistentdata.c:13345) - A /trunk/epan/h225-persistentdata.h (from /trunk/h225-persistentdata.h:13345) - D /trunk/h225-persistentdata.c - D /trunk/h225-persistentdata.h + M /trunk/epan/dissectors/packet-x11.c -Move h225-persistentdata.[ch] to epan, -as its code is linked into libethereal.dll. +packet-x11.c(1780) : warning C4090: 'function' : different 'const' qualifiers +packet-x11.c(1780) : warning C4022: 'g_tree_insert' : pointer mismatch for actual parameter 3 +packet-x11.c(2209) : warning C4090: 'initializing' : different 'const' qualifiers ------------------------------------------------------------------------ -r13353 | lroland | 2005-02-08 13:15:56 -0600 (Tue, 08 Feb 2005) | 2 lines +r14782 | ulfl | 2005-06-26 06:29:04 -0500 (Sun, 26 Jun 2005) | 2 lines Changed paths: - M /trunk/gtk/Makefile.am - M /trunk/gtk/Makefile.common - D /trunk/gtk/h323_analysis.c - D /trunk/gtk/h323_analysis.h - D /trunk/gtk/h323_conversations.c - D /trunk/gtk/h323_conversations.h - D /trunk/gtk/h323_conversations_dlg.c - D /trunk/gtk/h323_conversations_dlg.h + M /trunk/epan/proto.c -Remove the buggy h323 conversations tap. -It is superseded by the superior Voip Call analysis. +proto.c(2941) : warning C4090: 'function' : different 'const' qualifiers +proto.c(2941) : warning C4022: 'g_tree_insert' : pointer mismatch for actual parameter 2 ------------------------------------------------------------------------ -r13352 | ulfl | 2005-02-08 13:12:17 -0600 (Tue, 08 Feb 2005) | 1 line +r14783 | ulfl | 2005-06-26 06:32:02 -0500 (Sun, 26 Jun 2005) | 4 lines Changed paths: - M /trunk/gtk/menu.c + M /trunk/epan/prefs.c -bringing the packet details context menu item "Expand Tree" back as "Expand Subtrees". Renaming this, as this makes it much more obvious that potentially more than subtree (recursively) will be expanded +prefs.c(1218) : warning C4761: integral size mismatch in argument; conversion supplied +prefs.c(1230) : warning C4761: integral size mismatch in argument; conversion supplied +prefs.c(1240) : warning C4761: integral size mismatch in argument; conversion supplied +prefs.c(1245) : warning C4761: integral size mismatch in argument; conversion supplied ------------------------------------------------------------------------ -r13351 | etxrab | 2005-02-08 12:51:27 -0600 (Tue, 08 Feb 2005) | 2 lines +r14784 | ulfl | 2005-06-26 06:40:26 -0500 (Sun, 26 Jun 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/value_string.c -From LEGO -patch adding few more fields to RADIUS (I and O Packets and Octets) +value_string.c(71) : warning C4090: 'return' : different 'const' qualifiers ------------------------------------------------------------------------ -r13350 | etxrab | 2005-02-08 12:50:05 -0600 (Tue, 08 Feb 2005) | 2 lines +r14785 | guy | 2005-06-26 14:55:06 -0500 (Sun, 26 Jun 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-nsip.c + M /trunk/epan/dissectors/packet-hyperscsi.c + +Set the Info column to the correctly-capitalized name. + +Use "val_to_str()" to set the Info column, and give the "hyperscsi.cmd" +field a value_string table. -From : Susanne Edlund -patch for NSIP to fix a bug in packet SNS_DELETE. ------------------------------------------------------------------------ -r13349 | lroland | 2005-02-07 20:34:15 -0600 (Mon, 07 Feb 2005) | 8 lines +r14786 | guy | 2005-06-26 14:56:52 -0500 (Sun, 26 Jun 2005) | 26 lines Changed paths: - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/asn1/h245/packet-h245-template.c + M /trunk/epan/dissectors/packet-aarp.c + M /trunk/epan/dissectors/packet-aim.c + M /trunk/epan/dissectors/packet-ajp13.c + M /trunk/epan/dissectors/packet-alcap.c + M /trunk/epan/dissectors/packet-ansi_637.c + M /trunk/epan/dissectors/packet-ansi_683.c + M /trunk/epan/dissectors/packet-ansi_801.c + M /trunk/epan/dissectors/packet-ansi_a.c + M /trunk/epan/dissectors/packet-ansi_map.c + M /trunk/epan/dissectors/packet-arp.c + M /trunk/epan/dissectors/packet-arp.h + M /trunk/epan/dissectors/packet-bgp.c + M /trunk/epan/dissectors/packet-bittorrent.c + M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-cast.c + M /trunk/epan/dissectors/packet-cdp.c + M /trunk/epan/dissectors/packet-clnp.c + M /trunk/epan/dissectors/packet-cops.c + M /trunk/epan/dissectors/packet-dcerpc-afs4int.c + M /trunk/epan/dissectors/packet-dcerpc-nt.c + M /trunk/epan/dissectors/packet-dcerpc-rs_pgo.c + M /trunk/epan/dissectors/packet-dcerpc-spoolss.c + M /trunk/epan/dissectors/packet-dhcp-failover.c + M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-dns.h + M /trunk/epan/dissectors/packet-edonkey.c + M /trunk/epan/dissectors/packet-esis.c + M /trunk/epan/dissectors/packet-ethertype.c + M /trunk/epan/dissectors/packet-fclctl.c + M /trunk/epan/dissectors/packet-fclctl.h + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-gsm_sms.c + M /trunk/epan/dissectors/packet-gsm_ss.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-h245.h + M /trunk/epan/dissectors/packet-iapp.c + M /trunk/epan/dissectors/packet-icmpv6.c + M /trunk/epan/dissectors/packet-icq.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-image-jfif.c + M /trunk/epan/dissectors/packet-ipdc.c + M /trunk/epan/dissectors/packet-ipp.c + M /trunk/epan/dissectors/packet-ipsec.c + M /trunk/epan/dissectors/packet-ipv6.c + M /trunk/epan/dissectors/packet-isis-hello.c + M /trunk/epan/dissectors/packet-laplink.c + M /trunk/epan/dissectors/packet-ldap.c + M /trunk/epan/dissectors/packet-lmp.c + M /trunk/epan/dissectors/packet-mbtcp.c + M /trunk/epan/dissectors/packet-mmse.c + M /trunk/epan/dissectors/packet-nbns.c + M /trunk/epan/dissectors/packet-ncp2222.inc + M /trunk/epan/dissectors/packet-ndps.c + M /trunk/epan/dissectors/packet-netbios.c + M /trunk/epan/dissectors/packet-netbios.h + M /trunk/epan/dissectors/packet-nfs.c + M /trunk/epan/dissectors/packet-ospf.c + M /trunk/epan/dissectors/packet-pgsql.c + M /trunk/epan/dissectors/packet-pim.c + M /trunk/epan/dissectors/packet-pppoe.c + M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-rmcp.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-rsvp.c + M /trunk/epan/dissectors/packet-scsi.c + M /trunk/epan/dissectors/packet-ses.c + M /trunk/epan/dissectors/packet-skinny.c + M /trunk/epan/dissectors/packet-slsk.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-smpp.c + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-ssl.c + M /trunk/epan/dissectors/packet-stun.c + M /trunk/epan/dissectors/packet-trmac.c + M /trunk/epan/dissectors/packet-tzsp.c + M /trunk/epan/dissectors/packet-wsp.c + M /trunk/epan/dissectors/packet-wtls.c + M /trunk/epan/dissectors/packet-x11.c + M /trunk/epan/dissectors/packet-ypserv.c + M /trunk/epan/libethereal.def + M /trunk/epan/value_string.c + M /trunk/epan/value_string.h + M /trunk/epan/xdlc.c + M /trunk/plugins/rtnet/packet-rtnet.c + M /trunk/tap-wspstat.c + +Get rid of the private "my_match_strval()" routine in many dissectors; +add a "match_strval_idx()" routine that does the same thing, and have +"match_strval()" call it. -Add a section to the installer, which sets following key to "1" on WIN NT, if the key is available. +Make those routines, and "val_to_str()", return a "const" pointer. +Update dissectors as necessary to squelch compiler warnings produced by +that. -HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\NPF\Start +Use "val_to_str()" rather than using "match_strval()" and then, if the +result is null, substituting a specific string. Clean up some other +"match_strval()"/"val_to_str()" usages. -With this key set to 1, the NPF service is started automatically at startup and then even users with restricted privilegies should be able to access Network Devices for capturing. -See also: -http://winpcap.polito.it/misc/faq.htm#Q-18 +Add a null pointer check in the NDPS dissector's "attribute_value()" +routine, as it's not clear that "global_attribute_name" won't be null at +that point. + +Make some global variables in the AFS4INT dissector local. + +Make some routines not used outside the module they're in static. + +Make some tables "static const". + +Clean up white space. + +Fix Gerald's address in some files. ------------------------------------------------------------------------ -r13348 | guy | 2005-02-07 15:40:53 -0600 (Mon, 07 Feb 2005) | 9 lines +r14787 | guy | 2005-06-26 15:39:21 -0500 (Sun, 26 Jun 2005) | 2 lines Changed paths: - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-slsk.c -Fix up the suppression of packet printing and packet count printing so -that: +More constification. - packets are printed iff we're not saving packets to a file and - "-q" wasn't specified; +------------------------------------------------------------------------ +r14788 | guy | 2005-06-26 16:11:22 -0500 (Sun, 26 Jun 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-windows-common.c + M /trunk/epan/dissectors/packet-windows-common.h - packet counts are printed iff we're capturing (i.e., not reading - from a file) and "-q" wasn't specified. +Yet more constification. ------------------------------------------------------------------------ -r13347 | lroland | 2005-02-07 15:09:23 -0600 (Mon, 07 Feb 2005) | 4 lines +r14789 | etxrab | 2005-06-27 01:20:23 -0500 (Mon, 27 Jun 2005) | 6 lines Changed paths: - M /trunk/asn1/h225/h225.cnf - M /trunk/asn1/h225/packet-h225-template.c - M /trunk/asn1/h225/packet-h225-template.h M /trunk/gtk/voip_calls.c + M /trunk/gtk/voip_calls.h + M /trunk/gtk/voip_calls_dlg.c -And finally (I hope) the last part from the patch -from Alejandro Vaquero: - - patch for "Voip analysis" to get the LRQ/LCF/LRJ messages included in the H323 calls for Gatekeeper to Gatekeeper configurations +From Alejandro Vaquero +new dissector for the AudioCodes trunk trace protocol. +This protocol is used to debug the trunk protocol in AudioCodes +gateways. It currently supports ISDN PRI and CAS (MFCR2, WinkStart, +etc...) trunk protocols. It also add these protocols in the "Voip Calls +Graph..." ------------------------------------------------------------------------ -r13346 | guy | 2005-02-07 14:52:59 -0600 (Mon, 07 Feb 2005) | 2 lines +r14790 | etxrab | 2005-06-27 01:21:51 -0500 (Mon, 27 Jun 2005) | 6 lines Changed paths: - M /trunk/file.h - M /trunk/gtk/font_utils.c - M /trunk/gtk/main.c - M /trunk/gtk/ui_util.c - M /trunk/tethereal.c + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-actrace.c + A /trunk/epan/dissectors/packet-actrace.h + M /trunk/epan/dissectors/packet-q931.c + M /trunk/epan/dissectors/packet-q931.h + +From Alejandro Vaquero +new dissector for the AudioCodes trunk trace protocol. +This protocol is used to debug the trunk protocol in AudioCodes +gateways. It currently supports ISDN PRI and CAS (MFCR2, WinkStart, +etc...) trunk protocols. It also add these protocols in the "Voip Calls +Graph..." +------------------------------------------------------------------------ +r14791 | ulfl | 2005-06-27 02:28:25 -0500 (Mon, 27 Jun 2005) | 1 line +Changed paths: + M /trunk/docbook/Makefile -Make Ethereal and Tethereal compile if we're building without libpcap. +from Jaap Keuter: fix the graphics path of the edg_html_chunked target +------------------------------------------------------------------------ +r14792 | ulfl | 2005-06-27 02:39:48 -0500 (Mon, 27 Jun 2005) | 1 line +Changed paths: + M /trunk/docbook/Makefile +I've removed ethereal-capture-normal.* yesterday, as they are obsolete now ------------------------------------------------------------------------ -r13345 | ulfl | 2005-02-07 14:38:10 -0600 (Mon, 07 Feb 2005) | 1 line +r14793 | guy | 2005-06-27 02:50:11 -0500 (Mon, 27 Jun 2005) | 17 lines Changed paths: - M /trunk/capture.c + M /trunk/epan/dissectors/packet-dns.c + +The name returned by "get_dns_name()" (and thus by +"get_dns_name_type_class()") is null-terminated - and the length +returned is *NOT* the length of the string, it's the length of the chunk +of DNS data extracted by "get_dns_name()", and that chunk could just +point to a later chunk as part of DNS compression. When running the +name through "format_text()", just use "strlen()" to get the length, so +you don't get a value that's too large *OR* too small (both are +possible - "too large" if it's uncompressed and includes length +informatioin, "too small" if it contains a pointer to a string longer +than the pointer). + +When adding a string value to the protocol tree, add the *raw* name, not +the formatted name - the Ethereal display code will format the string's +value as necessary. + +Add formatting code for DNS names in replies. -fix a bug if capturing into named files is used ------------------------------------------------------------------------ -r13344 | etxrab | 2005-02-07 14:30:27 -0600 (Mon, 07 Feb 2005) | 4 lines +r14794 | sahlberg | 2005-06-27 03:12:55 -0500 (Mon, 27 Jun 2005) | 4 lines Changed paths: - M /trunk/plugins/Xplugin_table.h - M /trunk/plugins/plugin_api_list.c + M /trunk/epan/dissectors/packet-dnp.c -From Alejandro Vaquero : +From Chris Bontje +DNP3 Application Layer Object dissection - Find attached a patch for "Voip analysis" to get the LRQ/LCF/LRJ messages included in the H323 calls for Gatekeeper to Gatekeeper configurations ------------------------------------------------------------------------ -r13343 | ulfl | 2005-02-07 14:14:22 -0600 (Mon, 07 Feb 2005) | 1 line +r14795 | etxrab | 2005-06-27 03:13:41 -0500 (Mon, 27 Jun 2005) | 1 line Changed paths: - M /trunk/capture_sync.c + M /trunk/gtk/capture_if_details_dlg.c + M /trunk/gtk/gtk_stat_util.c + M /trunk/gtk/service_response_time_table.c + M /trunk/gtk/service_response_time_table.h -when building the argv string, use save_file_fd_str instead of save_file_fd to avoid confusion with the capture_opts field +Add som more const qualifiers. ------------------------------------------------------------------------ -r13342 | guy | 2005-02-07 13:42:32 -0600 (Mon, 07 Feb 2005) | 2 lines +r14796 | sahlberg | 2005-06-27 03:27:49 -0500 (Mon, 27 Jun 2005) | 6 lines Changed paths: - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-fcip.c + +some implementations do provide a CRC in the FCIP frame so skip the +'test for zero' check. +the heuristics are probably strong enough even without this check. + -Suppress the packet counts when we're reading from a file. ------------------------------------------------------------------------ -r13341 | guy | 2005-02-07 13:33:49 -0600 (Mon, 07 Feb 2005) | 2 lines +r14797 | etxrab | 2005-06-27 03:55:39 -0500 (Mon, 27 Jun 2005) | 1 line Changed paths: - M /trunk/tethereal.c - -Tethereal can write to a file in binary even if not built with libpcap. + M /trunk/epan/libethereal.def +Missed from previous commit. ------------------------------------------------------------------------ -r13340 | guy | 2005-02-07 13:11:45 -0600 (Mon, 07 Feb 2005) | 6 lines +r14798 | sahlberg | 2005-06-27 06:06:40 -0500 (Mon, 27 Jun 2005) | 4 lines Changed paths: - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-actrace.c + +remove a \n in the preference string to prevent it from creating a garbage/invalid preference file entry. -Clean up indentation. -The default for "capture_options.save_file" is a null pointer, meaning -we're not writing to a save file, we're writing out the dissection as -text. ------------------------------------------------------------------------ -r13339 | jmayer | 2005-02-07 09:55:13 -0600 (Mon, 07 Feb 2005) | 3 lines +r14799 | sahlberg | 2005-06-27 06:43:18 -0500 (Mon, 27 Jun 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-ber.c + +fix two bugs when updating offset incorrectly that could lead to an infinite loop when trying to decode an unknown ber structure + -In case we have an unknown vendor tag, just decode the vendor from -manuf. ------------------------------------------------------------------------ -r13338 | etxrab | 2005-02-07 02:58:40 -0600 (Mon, 07 Feb 2005) | 2 lines +r14800 | kukosa | 2005-06-27 08:45:47 -0500 (Mon, 27 Jun 2005) | 1 line Changed paths: M /trunk/tools/asn2eth.py -From Alejandro Vaquero : - Find attached a patch for "Voip analysis" to get the LRQ/LCF/LRJ messages included in the H323 calls for Gatekeeper to Gatekeeper configurations +fix for BER string tags ------------------------------------------------------------------------ -r13337 | etxrab | 2005-02-07 02:57:47 -0600 (Mon, 07 Feb 2005) | 2 lines +r14801 | sahlberg | 2005-06-27 15:45:02 -0500 (Mon, 27 Jun 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h225.h - M /trunk/epan/dissectors/packet-per.c - M /trunk/epan/dissectors/packet-per.h + M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/dissectors/packet-ftam.h + +regenerate FTAM with the bugfix for GraphicString in asn2eth -From Alejandro Vaquero : - Find attached a patch for "Voip analysis" to get the LRQ/LCF/LRJ messages included in the H323 calls for Gatekeeper to Gatekeeper configurations ------------------------------------------------------------------------- -r13336 | etxrab | 2005-02-07 02:56:39 -0600 (Mon, 07 Feb 2005) | 2 lines -Changed paths: - M /trunk/gtk/voip_calls.h - M /trunk/gtk/voip_calls_dlg.c -From Alejandro Vaquero : - Find attached a patch for "Voip analysis" to get the LRQ/LCF/LRJ messages included in the H323 calls for Gatekeeper to Gatekeeper configurations ------------------------------------------------------------------------ -r13335 | etxrab | 2005-02-07 02:54:24 -0600 (Mon, 07 Feb 2005) | 6 lines +r14802 | sahlberg | 2005-06-28 06:23:56 -0500 (Tue, 28 Jun 2005) | 4 lines Changed paths: - M /trunk/plugins/mate/mate_runtime.c - M /trunk/plugins/mate/mate_util.c + M /trunk/asn1/ftam/ISO8571-FTAM.asn + M /trunk/asn1/ftam/ftam.cnf + M /trunk/epan/dissectors/packet-ftam.c + +addition of NBS9 +and bugfix for FTAM where we sometimes forgot to check if the tag was implicit. -From LEGO: - - fixes a leak in analize_pdu() - - fixes a typo in analize_pdu() - - fixes a crash in scs_unsubscribe() - - save a malloc and a free in get_pdu_fields() ------------------------------------------------------------------------ -r13334 | guy | 2005-02-06 21:35:51 -0600 (Sun, 06 Feb 2005) | 3 lines +r14803 | gerald | 2005-06-28 09:02:21 -0500 (Tue, 28 Jun 2005) | 2 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/epan/dissectors/packet-actrace.c -The welcome pane isn't scrollable, so add it to the scrolling window -with a viewport. +Terminate a bunch of value_strings. ------------------------------------------------------------------------ -r13333 | guy | 2005-02-06 21:13:51 -0600 (Sun, 06 Feb 2005) | 5 lines +r14804 | gerald | 2005-06-28 09:46:47 -0500 (Tue, 28 Jun 2005) | 2 lines Changed paths: - M /trunk/capture_sync.c + M /trunk/epan/dissectors/packet-actrace.c -In the child process, capture_opts->fork_child is 0, not -1, so, in that -case, don't attempt to send a signal to the child. - -Expand a comment. +Add missing commas. ------------------------------------------------------------------------ -r13332 | guy | 2005-02-06 20:09:30 -0600 (Sun, 06 Feb 2005) | 7 lines +r14805 | etxrab | 2005-06-28 14:13:11 -0500 (Tue, 28 Jun 2005) | 1 line Changed paths: - M /trunk/capture.c - M /trunk/file.c - M /trunk/file.h - M /trunk/gtk/main.c - -Move the code to set the title on a window when a capture is in progress -to the "start live capture" callback, and call that from "do_capture()". + A /trunk/idl/tango.idl -When opening a capture file, don't pop up the "What do you want to do?" -pane when closing any existing file you have open, as we're just going -to put the regular view up right after that. +Add the Tango IDL file from Paolo Frigo. +------------------------------------------------------------------------ +r14806 | etxrab | 2005-06-28 14:14:14 -0500 (Tue, 28 Jun 2005) | 1 line +Changed paths: + M /trunk/plugins/giop/packet-tango.c +Regenerated Tango with the latest idl2eth and the tango.idl ------------------------------------------------------------------------ -r13331 | guy | 2005-02-06 19:32:53 -0600 (Sun, 06 Feb 2005) | 7 lines +r14807 | etxrab | 2005-06-28 16:14:09 -0500 (Tue, 28 Jun 2005) | 1 line Changed paths: - M /trunk/capture_sync.c - M /trunk/file.c - M /trunk/file.h + M /trunk/asn1/gsmmap/packet-gsm_map-template.c -Declare "cf_callback_t" before using it in a further declaration. +Fix to SendAuthenticationInfoRes. +------------------------------------------------------------------------ +r14808 | etxrab | 2005-06-28 16:14:59 -0500 (Tue, 28 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-gsm_map.h -Mark the "func" argument to "cf_callback_remove()" as unused. +Fix to SendAuthenticationInfoRes +------------------------------------------------------------------------ +r14809 | guy | 2005-06-28 16:25:56 -0500 (Tue, 28 Jun 2005) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-kerberos.h -Get rid of the "iface" argument to "cf_start_tail()", as it's no longer -used. +Declare "decrypt_krb5_data()" for use by the KINK dissector. ------------------------------------------------------------------------ -r13330 | ulfl | 2005-02-06 18:54:46 -0600 (Sun, 06 Feb 2005) | 8 lines +r14810 | guy | 2005-06-28 16:43:24 -0500 (Tue, 28 Jun 2005) | 6 lines Changed paths: - M /trunk/file.c - M /trunk/file.h - M /trunk/gtk/main.c - -Instead of calling each single thing when doing/finish a file operation, file.c shouldn't call all the GUI related functions itself, instead throwing some kind of Events to it's caller(s). + M /trunk/gtk/mtp3_summary.c -I've implemented a very simple callback mechanism which provides exactly this. I've tried GHook from GLib before, but this doesn't seem to be the right thing, as it's too inflexible for the purpose here. +"mtp3_sum_draw()" is never called with a null "table" argument - the +code before the call would have blown up if "table" were null. Remove +the check for a null pointer; this squelches some unset-variable +warnings you get from GCC4 because its dataflow analysis runs across +function boundaries. -So I've implemented a callback function in main.c which receives all "events" and spreads them to menu, statusbar and itself. +------------------------------------------------------------------------ +r14811 | guy | 2005-06-28 17:01:18 -0500 (Tue, 28 Jun 2005) | 3 lines +Changed paths: + M /trunk/gtk/voip_calls_dlg.c -I would see this implementation as a prototype which may need improvements. Please comment the changes. +"Handle" a couple of cases in the switch statement by adding them to the +"not supported" case, to suppress compiler warnings. ------------------------------------------------------------------------ -r13329 | guy | 2005-02-06 18:31:45 -0600 (Sun, 06 Feb 2005) | 2 lines +r14812 | guy | 2005-06-28 17:15:12 -0500 (Tue, 28 Jun 2005) | 2 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/gtk/wsp_stat.c -Clean up indentation. +More constification. ------------------------------------------------------------------------ -r13328 | guy | 2005-02-06 17:16:05 -0600 (Sun, 06 Feb 2005) | 8 lines +r14813 | guy | 2005-06-28 17:39:56 -0500 (Tue, 28 Jun 2005) | 2 lines Changed paths: - M /trunk/Makefile.common - M /trunk/file.c - M /trunk/gtk/main.c - M /trunk/gtk/main.h - M /trunk/gtk/menu.c - A /trunk/main_window.h + M /trunk/epan/dissectors/packet-actrace.c -Don't have "set_menus_for_captured_packets()" call -"main_set_for_capture_file()"; it should only deal with menus, not -anything else - and it gets called while the menus are being set up, -which is before the main window has been completely created, so -"main_widgets_show_or_hide()", which is called by -"main_set_for_capture_file()", gets errors trying to show or hide -widgets the pointers to which are null. +Squelch a compiler warning. ------------------------------------------------------------------------ -r13327 | guy | 2005-02-06 17:06:23 -0600 (Sun, 06 Feb 2005) | 2 lines +r14814 | sahlberg | 2005-06-29 03:00:55 -0500 (Wed, 29 Jun 2005) | 6 lines Changed paths: - M /trunk/menu.h + M /trunk/epan/dissectors/packet-ber.c + +be more careful when attempting to dissect an unknown ber field not to read beyond the end and triggering a [malformed packet] + +also prettify the error when finding "unknown" entries inside a SEQUENCE to make it easier to track down what went wrong. + -Get rid of extra blank line at the end. ------------------------------------------------------------------------ -r13326 | guy | 2005-02-06 16:21:51 -0600 (Sun, 06 Feb 2005) | 2 lines +r14815 | ulfl | 2005-06-29 03:03:06 -0500 (Wed, 29 Jun 2005) | 1 line Changed paths: - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-dcerpc.c -"iface" is now a member of "capture_opts", not "cfile". +add references to the corresponding request of datagram ping and ack packets +------------------------------------------------------------------------ +r14816 | ulfl | 2005-06-29 03:06:07 -0500 (Wed, 29 Jun 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-dcom-cba-acco.c + M /trunk/epan/libethereal.def +make dissect_CBA_Connection_Data available for plugins ------------------------------------------------------------------------ -r13325 | guy | 2005-02-06 16:19:53 -0600 (Sun, 06 Feb 2005) | 2 lines +r14817 | sahlberg | 2005-06-29 03:11:23 -0500 (Wed, 29 Jun 2005) | 3 lines Changed paths: - M /trunk/capture_loop.c - M /trunk/capture_sync.c + M /trunk/asn1/ftam/ISO8571-FTAM.asn + M /trunk/epan/dissectors/packet-ftam.c + +fix a typo for the name of a bit -Get rid of a few cf_get_ references missed by the previous checkin. ------------------------------------------------------------------------ -r13324 | guy | 2005-02-06 16:18:15 -0600 (Sun, 06 Feb 2005) | 4 lines +r14818 | sahlberg | 2005-06-29 05:39:09 -0500 (Wed, 29 Jun 2005) | 7 lines Changed paths: - M /trunk/capture.c + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-ip.c -Include <ctype.h> for "isspace()". +from +Maria-Luiza Crivat and +Brice Augustin + +ICMP MPLS extensions -#ifdef a variable used only if _WIN32 is defined. ------------------------------------------------------------------------ -r13323 | guy | 2005-02-06 16:06:31 -0600 (Sun, 06 Feb 2005) | 2 lines +r14819 | sahlberg | 2005-06-29 06:59:42 -0500 (Wed, 29 Jun 2005) | 5 lines Changed paths: - M /trunk/capture.h + M /trunk/proto_hier_stats.c -Clean up indentation. +add fix for bug 224 + +we now put generated items as top-level items in the decode pane so +we should not check and abort if such are found. ------------------------------------------------------------------------ -r13322 | guy | 2005-02-06 15:36:11 -0600 (Sun, 06 Feb 2005) | 5 lines +r14820 | guy | 2005-06-29 17:39:36 -0500 (Wed, 29 Jun 2005) | 4 lines Changed paths: - M /trunk/configure.in - M /trunk/epan/Makefile.am + M /trunk/AUTHORS + +Add the usual (minimal) protection against email address harvesting. -Back out the previous change - we were setting "datafiledir", not -"datafile", and code in epan/filesystem.c expectes DATAFILE_DIR to be -set to the "ethereal" subdirectory of the data directory, not to the -data directory itself. +Fix one entry to have tabs between the name and the address. ------------------------------------------------------------------------ -r13321 | ulfl | 2005-02-06 15:34:59 -0600 (Sun, 06 Feb 2005) | 1 line +r14821 | guy | 2005-06-29 18:19:21 -0500 (Wed, 29 Jun 2005) | 6 lines Changed paths: - M /trunk/summary.h + M /trunk/epan/dissectors/packet-ip.c + +If only part of an entry in an object fits in the object, don't report +the stuff that didn't fit as a negative number of junk bytes. + +The difference between two pointers isn't guaranteed to have a +particular size; cast it to "long" and display it with "%ld". -minor code cleanup ------------------------------------------------------------------------ -r13320 | ulfl | 2005-02-06 15:20:35 -0600 (Sun, 06 Feb 2005) | 7 lines +r14822 | sahlberg | 2005-06-29 21:31:15 -0500 (Wed, 29 Jun 2005) | 5 lines Changed paths: - M /trunk/capture.c - M /trunk/capture.h - M /trunk/capture_loop.c - M /trunk/capture_sync.c - M /trunk/cfile.c - M /trunk/cfile.h - M /trunk/file.c - M /trunk/file.h - M /trunk/gtk/capture_dlg.c - M /trunk/gtk/capture_if_dlg.c - M /trunk/gtk/main.c - M /trunk/gtk/summary_dlg.c - M /trunk/summary.c - M /trunk/summary.h - M /trunk/tethereal.c + M /trunk/wiretap/network_instruments.c -another two steps towards privilege seperation: +make reading of observer files work again -move another two capture related fields (iface and cfilter) from cfile to capture_opts - -also move the handling of capture related command line options from main.c to capture.c, that way a future privilege seperated capture program can use the same code to parse it's command line than Ethereal. -It might be even possible to share this parser code even with Tethereal, didn't took a closer look at this. +for some reason we have forgotten to skip the initial (always 8?) bytes prior to the start of the frame. + ------------------------------------------------------------------------ -r13319 | guy | 2005-02-06 14:53:54 -0600 (Sun, 06 Feb 2005) | 10 lines +r14823 | sahlberg | 2005-06-30 02:48:25 -0500 (Thu, 30 Jun 2005) | 7 lines Changed paths: - M /trunk/gtk/sctp_error_dlg.c - M /trunk/gtk/sctp_stat.c - M /trunk/gtk/sctp_stat.h + M /trunk/asn1/cmip/cmip.cnf + M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-cmip.h -Clean up indentation. +fix a bug in the conformance file for CMIP to make it compile again +(semi-recent changes to asn2eth and PARAM handling makes us have to use double %% in some BODY statements) + +at the same time, regenerate it so it also benefit from bugfixes to handling of indefinite length -Make "reset()" static (it's not used outside "sctp_stat.c"), and fix its -prototype to match what's expected for a reset routine passed to -"register_tap_listener()". Similarly, fix the prototypes of other -routines passed to "register_tap_listener()", and get rid of the casts -of pointers to those functions to "void *". -Fix some declarations in "sctp_stat.h" to have function prototypes. ------------------------------------------------------------------------ -r13318 | etxrab | 2005-02-06 14:37:02 -0600 (Sun, 06 Feb 2005) | 6 lines +r14824 | etxrab | 2005-06-30 14:17:46 -0500 (Thu, 30 Jun 2005) | 3 lines Changed paths: - M /trunk/plugins/mate/mate.h - M /trunk/plugins/mate/mate_runtime.c - M /trunk/plugins/mate/mate_setup.c - M /trunk/plugins/mate/mate_util.c - -From: LEGO -- fix a bug at gog reinit that disabled gogs after reload of a file. -- fix some crashes when Debug_GoG>0 -- cleanup the debug output (no CR at the end is needed) -- Gops start when no GopStart is given and match an existing GogKey + M /trunk/plugins/megaco/packet-megaco.c +From Karl Knoebl +Accept SP as separator and * provide info to COL_INFO and some "prettification" + Cleaned up some comments as well. ------------------------------------------------------------------------ -r13317 | ulfl | 2005-02-06 08:43:27 -0600 (Sun, 06 Feb 2005) | 1 line +r14825 | etxrab | 2005-06-30 14:19:50 -0500 (Thu, 30 Jun 2005) | 1 line Changed paths: - M /trunk/capture.c - M /trunk/gtk/main.c + M /trunk/AUTHORS -some cleanup of the initial start sequence of Ethereal, filling in capture_opts and alike +Add Karl Knoebl as an author. ------------------------------------------------------------------------ -r13316 | ulfl | 2005-02-06 06:21:27 -0600 (Sun, 06 Feb 2005) | 1 line +r14826 | ulfl | 2005-06-30 17:46:19 -0500 (Thu, 30 Jun 2005) | 3 lines Changed paths: - M /trunk/capture.c - M /trunk/gtk/main.c + M /trunk/epan/column-utils.c + M /trunk/epan/column.c + M /trunk/epan/column_info.h + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/gtk/packet_list.c + +add a new DCE/RPC related column, which contains the call_id for connection oriented packets or the sequence number for connectionless (datagram) packets. -fix bugs regarding the capture child +This is extremely useful, to keep track of the corresponding request/response packets of a DCE/RPC call (which can be quite a lot packets if fragmentation is used). ------------------------------------------------------------------------ -r13315 | ulfl | 2005-02-05 18:13:00 -0600 (Sat, 05 Feb 2005) | 1 line +r14827 | ulfl | 2005-06-30 17:51:17 -0500 (Thu, 30 Jun 2005) | 1 line Changed paths: - M /trunk/capture.c - M /trunk/capture.h - M /trunk/gtk/main.c + M /trunk/epan/dissectors/packet-dcerpc.c -instead of initializing the capture_options in main.c, use the new function capture_opts_init +add some more information to the DCE/RPC packet details summary line ------------------------------------------------------------------------ -r13314 | lroland | 2005-02-05 17:34:56 -0600 (Sat, 05 Feb 2005) | 1 line +r14828 | kukosa | 2005-07-01 08:48:52 -0500 (Fri, 01 Jul 2005) | 1 line Changed paths: - M /trunk/gtk/voip_calls.c - M /trunk/gtk/voip_calls.h + M /trunk/epan/dissectors/packet-ber.c -remove obsolete function add_rtp_streams_graph() from voip_calls.[ch] and fix a register_tap_listener() call. +beter displaying of true/false strings in dissect_ber_bitstring() ------------------------------------------------------------------------ -r13313 | ulfl | 2005-02-05 17:12:44 -0600 (Sat, 05 Feb 2005) | 3 lines +r14829 | ulfl | 2005-07-01 15:47:22 -0500 (Fri, 01 Jul 2005) | 5 lines Changed paths: - M /trunk/gtk/compat_macros.h - M /trunk/gtk/main.c + M /trunk/gtk/find_dlg.c -begin a welcome page which is shown, if you don't have any capture data loaded. +fix #271: don't do: -This might be improved to have additional content and/or better layout of the elements. +g_free(bytes); + +twice, probably a copy/paste error ------------------------------------------------------------------------ -r13312 | ulfl | 2005-02-05 11:53:39 -0600 (Sat, 05 Feb 2005) | 1 line +r14830 | ulfl | 2005-07-01 16:04:13 -0500 (Fri, 01 Jul 2005) | 1 line Changed paths: - M /trunk/gtk/main.c - M /trunk/gtk/main.h - M /trunk/gtk/menu.c + M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-isns.c + M /trunk/epan/dissectors/packet-smpp.c -completely hide the main window panes, if we currently don't have a capture file. +fixed various issues (two serious ones) found by "private" fuzz-testing ------------------------------------------------------------------------ -r13311 | gerald | 2005-02-05 11:39:12 -0600 (Sat, 05 Feb 2005) | 6 lines +r14831 | guy | 2005-07-02 03:18:17 -0500 (Sat, 02 Jul 2005) | 17 lines Changed paths: - M /trunk/AUTHORS - M /trunk/wiretap/ascend-grammar.y - M /trunk/wiretap/ascend-int.h - M /trunk/wiretap/ascend-scanner.l - M /trunk/wiretap/ascend.c - M /trunk/wiretap/wtap.h + M /trunk/epan/dissectors/packet-nfs.c -From Josh Bailey: +Have separate fields for NFSv2, NFSv3, and NFSv4 return statuses, using +the names in the v2, v3, and v4 specs for values, so that they display +correctly and can be filtered on correctly. -Attached is an update to Lucent/Ascend trace parsing: fix a few bugs, -add support for ISDN and Ethernet captures - diffs to 0.10.9. +Have "nfs.status" as a hidden field, with a name table giving just "OK" +and "ERR_" values, and having items for v2, v3, and v4 status values +(the only collision is that the v3 JUKEBOX error is the v4 DELAY error), +so that filters on "nfs.status" will still work, but will now be able to +filter symbolically on values from v2, v3, and v4. +Show 33 status values in the Info column and the summary entry using the +table of v3 status values and names, not the table of v2 status values +and names. + +Fix some v3 dissectors to use the v3 return status field rather than the +v2 return status field. ------------------------------------------------------------------------ -r13310 | etxrab | 2005-02-05 09:51:45 -0600 (Sat, 05 Feb 2005) | 1 line +r14832 | jmayer | 2005-07-02 10:40:49 -0500 (Sat, 02 Jul 2005) | 5 lines Changed paths: - M /trunk/asn1/gsmmap/gsmmap.cnf + M /trunk/wiretap/AUTHORS + M /trunk/wiretap/netxray.c + +Chris Lydick: Support for Sniffer 2.003 files. + +Modified to match the current codebase. + -Remove g_free. ------------------------------------------------------------------------ -r13309 | ulfl | 2005-02-05 09:40:44 -0600 (Sat, 05 Feb 2005) | 3 lines +r14833 | tuexen | 2005-07-02 16:16:17 -0500 (Sat, 02 Jul 2005) | 2 lines Changed paths: - M /trunk/gtk/main.h + M /trunk/epan/dissectors/packet-sctp.c -fixed the dnd_init declaration +Use brackets instead of parentheses for the checksum info, which is generated. -(we have to do something about the non existing win32 compile dependencies, this is just a pain) ------------------------------------------------------------------------ -r13308 | ulfl | 2005-02-05 09:35:25 -0600 (Sat, 05 Feb 2005) | 5 lines +r14834 | guy | 2005-07-02 19:52:08 -0500 (Sat, 02 Jul 2005) | 5 lines Changed paths: - M /trunk/capture.c - M /trunk/capture.h - M /trunk/capture_sync.c - M /trunk/gtk/Makefile.common - A /trunk/gtk/drag_and_drop.c - M /trunk/gtk/main.c - M /trunk/gtk/main.h + M /trunk/epan/dissectors/packet-ip.c + +Note that the MPLS extension dissector will misdissect ICMP packets that +contain more than 128 bytes of the original datagram. (Yes, RFC 1812 +and the ICMP Extensions for MPLS draft collide here, as the draft in +question notes.) -rename kill_capture_child to capture_kill_child to have a common prefix +------------------------------------------------------------------------ +r14835 | sahlberg | 2005-07-03 00:28:12 -0500 (Sun, 03 Jul 2005) | 3 lines +Changed paths: + M /trunk/asn1/acse/acse-exp.cnf + M /trunk/asn1/acse/acse.cnf + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-acse.h + +export a few more symbols from acse -split drag and drop support out of main.c into new file drag_and_drop.c, to reduce the size of main.c a bit. -Hopefully this won't break unix builds because of missing #include's, I will keep an eye on the buildbot ------------------------------------------------------------------------ -r13307 | ulfl | 2005-02-05 08:37:56 -0600 (Sat, 05 Feb 2005) | 1 line +r14836 | sahlberg | 2005-07-03 01:08:53 -0500 (Sun, 03 Jul 2005) | 4 lines Changed paths: - M /trunk/file.c + A /trunk/asn1/mms + A /trunk/asn1/mms/Makefile + A /trunk/asn1/mms/Makefile.nmake + A /trunk/asn1/mms/mms-exp.cnf + A /trunk/asn1/mms/mms.asn + A /trunk/asn1/mms/mms.cnf + A /trunk/asn1/mms/packet-mms-template.c + A /trunk/asn1/mms/packet-mms-template.h + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-mms.c + A /trunk/epan/dissectors/packet-mms.h + +New protocol : +MMS Manufacturing Message Specification + -use the interfaces descriptive name to be shown in the statusbar as it's, well, more descriptive ------------------------------------------------------------------------ -r13306 | ulfl | 2005-02-05 08:33:03 -0600 (Sat, 05 Feb 2005) | 1 line +r14837 | etxrab | 2005-07-03 07:01:11 -0500 (Sun, 03 Jul 2005) | 1 line Changed paths: - M /trunk/file.h + M /trunk/epan/dissectors/Makefile.common -fix a comment +Add packet-mms.h ------------------------------------------------------------------------ -r13305 | etxrab | 2005-02-05 08:24:26 -0600 (Sat, 05 Feb 2005) | 1 line +r14838 | etxrab | 2005-07-03 15:33:06 -0500 (Sun, 03 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-uma.c -Re-commit the asn2eth based gsm-map dissector, hopfully it'll work better now. +Change gsm_a.c to use value strings in some places in preparation to use it from packet-uma.c and gsm_map. +Some bug fixes to packet-uma.c ------------------------------------------------------------------------ -r13304 | ulfl | 2005-02-05 07:44:27 -0600 (Sat, 05 Feb 2005) | 1 line +r14839 | etxrab | 2005-07-03 16:19:49 -0500 (Sun, 03 Jul 2005) | 1 line Changed paths: - M /trunk/capture_sync.c - M /trunk/file.c - M /trunk/file.h - M /trunk/gtk/file_dlg.c + M /trunk/epan/libethereal.def -minor enhancements to Guy's last update +Add an exported value string ------------------------------------------------------------------------ -r13303 | guy | 2005-02-05 06:50:47 -0600 (Sat, 05 Feb 2005) | 2 lines +r14840 | etxrab | 2005-07-03 16:20:27 -0500 (Sun, 03 Jul 2005) | 1 line Changed paths: - M /trunk/capture.c - M /trunk/capture_sync.c - M /trunk/file.c - M /trunk/file.h - M /trunk/gtk/file_dlg.c - M /trunk/gtk/main.c - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-gsm_a.h + M /trunk/epan/dissectors/packet-uma.c -Put "cf_status_t" back. +Add an exported value string +------------------------------------------------------------------------ +r14841 | ulfl | 2005-07-03 17:53:11 -0500 (Sun, 03 Jul 2005) | 1 line +Changed paths: + M /trunk/docbook/custom_layer_pdf.xsl +from Jaap Keuter: some improvements to the custom PDF creation stylesheet ------------------------------------------------------------------------ -r13302 | guy | 2005-02-05 06:08:01 -0600 (Sat, 05 Feb 2005) | 2 lines +r14842 | guy | 2005-07-03 22:45:29 -0500 (Sun, 03 Jul 2005) | 2 lines Changed paths: - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-giop.c -Make "cf_open()" match the prototype in "file.h". +Mark stub data as such if no dissector claims it. ------------------------------------------------------------------------ -r13301 | ulfl | 2005-02-05 05:37:56 -0600 (Sat, 05 Feb 2005) | 1 line +r14843 | ulfl | 2005-07-04 02:03:04 -0500 (Mon, 04 Jul 2005) | 1 line Changed paths: - M /trunk/capture.h + M /trunk/docbook/custom_layer_pdf.xsl -updated some comments +add a link to special documentation ------------------------------------------------------------------------ -r13300 | etxrab | 2005-02-05 05:08:24 -0600 (Sat, 05 Feb 2005) | 3 lines +r14844 | kukosa | 2005-07-04 04:35:25 -0500 (Mon, 04 Jul 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-rtp.c - M /trunk/epan/dissectors/packet-rtp.h + M /trunk/asn1/h225/h225.cnf + M /trunk/asn1/h225/packet-h225-template.c + M /trunk/asn1/h235/Makefile.nmake + M /trunk/asn1/h235/h235-exp.cnf + M /trunk/asn1/h245/h245.cnf + M /trunk/asn1/h245/packet-h245-template.c + M /trunk/asn1/h450/packet-h450-template.c + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h225.h + M /trunk/epan/dissectors/packet-h235.c + M /trunk/epan/dissectors/packet-h235.h + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-h245.h + M /trunk/epan/dissectors/packet-h450.c + M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/packet-per.h + M /trunk/epan/dissectors/packet-t38.c + M /trunk/tools/asn2eth.py -From Alejandro Vaquero: -a patch that to shows the RTP streams in the Graph. Now -using an RTP tap (not using the rtp_stream). +- use tvb instead of offset and length in dissect_per_octet_string() for value returning +- asn2eth: #.FN_PARS support for OCTET STRING +- usage of #.FN_PARS in h225 and h245 +- h225: ParallelH245Control support +- h245: better support of NonStandardParameter +- usage of MAX_OID_STR_LEN constant +- all PER dissectors regenerated ------------------------------------------------------------------------ -r13299 | etxrab | 2005-02-05 05:07:21 -0600 (Sat, 05 Feb 2005) | 4 lines +r14845 | kukosa | 2005-07-04 08:04:53 -0500 (Mon, 04 Jul 2005) | 1 line Changed paths: - M /trunk/gtk/voip_calls.c - M /trunk/gtk/voip_calls.h - M /trunk/gtk/voip_calls_dlg.c + M /trunk/epan/dfilter/semcheck.c + M /trunk/epan/ftypes/ftype-bytes.c + M /trunk/epan/ftypes/ftypes.h + M /trunk/epan/proto.c + M /trunk/epan/proto.h + M /trunk/epan/to_str.c + M /trunk/epan/to_str.h -From Alejandro Vaquero: -a patch that to shows the RTP streams in the Graph. Now -using an RTP tap (not using the rtp_stream). +new field type FT_GUID +------------------------------------------------------------------------ +r14846 | kukosa | 2005-07-04 08:13:07 -0500 (Mon, 04 Jul 2005) | 1 line +Changed paths: + M /trunk/epan/libethereal.def +export of proto_tree_add_guid...() functions ------------------------------------------------------------------------ -r13298 | ulfl | 2005-02-05 05:00:04 -0600 (Sat, 05 Feb 2005) | 1 line +r14847 | kukosa | 2005-07-04 08:19:58 -0500 (Mon, 04 Jul 2005) | 1 line Changed paths: - M /trunk/file.c - M /trunk/file.h + M /trunk/asn1/h225/h225.cnf + M /trunk/epan/dissectors/packet-h225.c -make some string parameters const, as they are not changed inside +usage of FT_GUID field type in H.225 dissector ------------------------------------------------------------------------ -r13297 | guy | 2005-02-04 22:37:36 -0600 (Fri, 04 Feb 2005) | 2 lines +r14848 | etxrab | 2005-07-04 14:07:02 -0500 (Mon, 04 Jul 2005) | 1 line Changed paths: - M /trunk/gtk/sctp_assoc_analyse.c + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-gsm_a.h + M /trunk/epan/dissectors/packet-gsm_map.c -retap_packets() was renamed cf_retap_packets(). +Add dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again. +------------------------------------------------------------------------ +r14849 | etxrab | 2005-07-04 14:09:38 -0500 (Mon, 04 Jul 2005) | 1 line +Changed paths: + M /trunk/asn1/gsmmap/gsmmap.cnf + M /trunk/asn1/gsmmap/packet-gsm_map-template.c +Add dissection of BSS-MAP elements and a fix to dissect Tele and Bearer service again. ------------------------------------------------------------------------ -r13296 | tuexen | 2005-02-04 16:48:17 -0600 (Fri, 04 Feb 2005) | 2 lines +r14850 | etxrab | 2005-07-04 23:30:59 -0500 (Mon, 04 Jul 2005) | 4 lines Changed paths: - M /trunk/gtk/Makefile.common + M /trunk/gtk/rtp_analysis.c + +From Ainsley Pereira: -Activate SCTP association analysis +If you have an RTP stream in which the first packet is duplicated, and has the marker bit set, then the RTP stream analysis will try to pad silence into a temporary file from 0 upto whatever the RTP timestamp is (which is enough to fill up my disk...). The patch fixes this misbehaviour. ------------------------------------------------------------------------ -r13295 | tuexen | 2005-02-04 16:45:15 -0600 (Fri, 04 Feb 2005) | 2 lines +r14851 | etxrab | 2005-07-04 23:32:32 -0500 (Mon, 04 Jul 2005) | 4 lines Changed paths: - M /trunk/gtk/sctp_assoc_analyse.c - M /trunk/gtk/sctp_byte_graph_dlg.c - M /trunk/gtk/sctp_error_dlg.c - M /trunk/gtk/sctp_graph_dlg.c - M /trunk/gtk/sctp_stat.c - M /trunk/gtk/sctp_stat.h + M /trunk/epan/dissectors/packet-lwapp.c -Update to versions compiling on and working on Windows and Unix. +From : David Frascone + +These minor changes fix some errors, and add some messages to the LWAPP dissector. ------------------------------------------------------------------------ -r13294 | tuexen | 2005-02-04 16:39:48 -0600 (Fri, 04 Feb 2005) | 2 lines +r14852 | etxrab | 2005-07-05 00:16:28 -0500 (Tue, 05 Jul 2005) | 10 lines Changed paths: - M /trunk/epan/dissectors/packet-sctp.c - M /trunk/epan/dissectors/packet-sctp.h + M /trunk/gtk/graph_analysis.c + M /trunk/gtk/graph_analysis.h + M /trunk/gtk/voip_calls.c + M /trunk/gtk/voip_calls.h + M /trunk/gtk/voip_calls_dlg.c -Add detection of zero checksum. +From Alejandro Vaquero +- avoid the clist of the calls dlg to be refreshed multiple times when +first appear. +- destroy the Graph window when the data is not valid anymore. +- fixes an H245 packet count error +- resizing the Graph windows when is displayed (up to 5 columns). +With a change to leave static voip_calls_tapinfo_t the_tapinfo_struct = + {0, NULL, 0, NULL, 0, 0, 0, 0, NULL, 0, 0, 0, 0, 0, 0, 0, 0, 0}; +alone. ------------------------------------------------------------------------ -r13293 | guy | 2005-02-04 14:54:12 -0600 (Fri, 04 Feb 2005) | 6 lines +r14853 | etxrab | 2005-07-05 12:09:28 -0500 (Tue, 05 Jul 2005) | 1 line Changed paths: - M /trunk/file.c - M /trunk/file.h - M /trunk/gtk/main.c - M /trunk/gtk/print_dlg.c - M /trunk/tethereal.c + M /trunk/plugins/xml/packet-xml.c -Instead of having a single enumerated type for status return values from -cf_ functions, have separate ones for different classes of routines, and -use gboolean when the return value is just "success" or "failure" - that -way you don't get compiler warnings if a case statement isn't handling a -particular status value if the routine in question won't return it. +Add application/vnd.wv.csp.xml +------------------------------------------------------------------------ +r14854 | etxrab | 2005-07-05 12:10:09 -0500 (Tue, 05 Jul 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-text-media.c +Add application/vnd.wv.csp.xml ------------------------------------------------------------------------ -r13292 | guy | 2005-02-04 14:32:32 -0600 (Fri, 04 Feb 2005) | 2 lines +r14855 | kukosa | 2005-07-05 13:55:17 -0500 (Tue, 05 Jul 2005) | 1 line Changed paths: - M /trunk/file.c + M /trunk/epan/to_str.c -Properly define "cf_start_tail()". +GUID lowercase form seems to be preferred +------------------------------------------------------------------------ +r14856 | kukosa | 2005-07-05 14:47:04 -0500 (Tue, 05 Jul 2005) | 2 lines +Changed paths: + M /trunk/tools/asn2eth.py +- #.FN_PARS support for ENUMERATED type +- cleanup unused parameters for some methods ------------------------------------------------------------------------ -r13291 | ulfl | 2005-02-04 13:29:27 -0600 (Fri, 04 Feb 2005) | 2 lines +r14857 | kukosa | 2005-07-05 14:53:38 -0500 (Tue, 05 Jul 2005) | 1 line Changed paths: - M /trunk/gtk/gsm_map_summary.c - M /trunk/gtk/mtp3_summary.c - M /trunk/gtk/summary_dlg.c - M /trunk/summary.c - M /trunk/summary.h + M /trunk/asn1/h225/h225.cnf -remove #include "globals.h" from summary.c, as it's a bad idea for multiple capture files. -If a summary user would like to get a summary, it should know the file of *which* it needs the summary. +more usage of #.FN_PARS ------------------------------------------------------------------------ -r13290 | ulfl | 2005-02-04 13:24:40 -0600 (Fri, 04 Feb 2005) | 5 lines +r14858 | gerald | 2005-07-05 15:04:03 -0500 (Tue, 05 Jul 2005) | 3 lines Changed paths: - M /trunk/pcap-util-unix.c + M /trunk/epan/reassemble.c + +Don't crash if we're handed a zero-length fragment. Fixes bug 272. Although +we don't crash now, we still don't handle zero-length fragments correctly. -this file doesn't use any item of the globals.h so remove #include. -However, if it needs one of: -#include "file.h" -#include <epan/timestamp.h> -it should include it directly, please let me know if it's required, as I can't test it :-( ------------------------------------------------------------------------ -r13289 | ulfl | 2005-02-04 12:44:44 -0600 (Fri, 04 Feb 2005) | 5 lines +r14859 | gerald | 2005-07-05 15:20:15 -0500 (Tue, 05 Jul 2005) | 3 lines Changed paths: - M /trunk/capture.c - M /trunk/capture_sync.c - M /trunk/file.c - M /trunk/file.h - M /trunk/gtk/bootp_stat.c - M /trunk/gtk/color_dlg.c - M /trunk/gtk/conversations_table.c - M /trunk/gtk/dcerpc_stat.c - M /trunk/gtk/decode_as_dlg.c - M /trunk/gtk/fc_stat.c - M /trunk/gtk/file_dlg.c - M /trunk/gtk/find_dlg.c - M /trunk/gtk/goto_dlg.c - M /trunk/gtk/graph_analysis.c - M /trunk/gtk/h225_counter.c - M /trunk/gtk/h225_ras_srt.c - M /trunk/gtk/h323_analysis.c - M /trunk/gtk/h323_conversations_dlg.c - M /trunk/gtk/hostlist_table.c - M /trunk/gtk/http_stat.c - M /trunk/gtk/io_stat.c - M /trunk/gtk/ldap_stat.c - M /trunk/gtk/main.c - M /trunk/gtk/main.h - M /trunk/gtk/menu.c - M /trunk/gtk/mgcp_stat.c - M /trunk/gtk/packet_history.c - M /trunk/gtk/packet_list.c - M /trunk/gtk/prefs_dlg.c - M /trunk/gtk/print_dlg.c - M /trunk/gtk/proto_dlg.c - M /trunk/gtk/proto_draw.c - M /trunk/gtk/rpc_progs.c - M /trunk/gtk/rpc_stat.c - M /trunk/gtk/rtp_analysis.c - M /trunk/gtk/rtp_stream.c - M /trunk/gtk/rtp_stream_dlg.c - M /trunk/gtk/sctp_error_dlg.c - M /trunk/gtk/sctp_stat_dlg.c - M /trunk/gtk/sip_stat.c - M /trunk/gtk/smb_stat.c - M /trunk/gtk/tcp_graph.c - M /trunk/gtk/voip_calls_dlg.c - M /trunk/gtk/wsp_stat.c - M /trunk/tethereal.c + M /trunk/asn1/h225/packet-h225-template.c + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h225.h -huge cleanup of capture file API (functions in file.c/file.h). +Call proto_tree_add_guid_hidden() for an FT_GUID value. Fixes bugs 274, +276, and 277. -This includes: all functions in file.h now have a cf_ prefix, will have doxygen tags, will have the capture_file *cf as the first parameter and I tried to generalize the return values for non trivial functions. +------------------------------------------------------------------------ +r14860 | kukosa | 2005-07-05 16:42:13 -0500 (Tue, 05 Jul 2005) | 1 line +Changed paths: + M /trunk/tools/asn2eth.py -Hopefully, I didn't introduced any new bugs, as I had to change a lot of files... +new directives #.PDU_NEW and #.REGISTER_NEW creating and registering PDU dissectors with new_dissector_t prototype ------------------------------------------------------------------------ -r13288 | gerald | 2005-02-04 09:22:25 -0600 (Fri, 04 Feb 2005) | 7 lines +r14861 | ulfl | 2005-07-05 17:33:22 -0500 (Tue, 05 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/Makefile.common - M /trunk/plugins/Xass-list - M /trunk/plugins/Xplugin_api.c - M /trunk/plugins/Xplugin_api.h - M /trunk/plugins/Xplugin_api_decls.h - M /trunk/plugins/Xplugin_table.h - M /trunk/plugins/plugin_api_list.c + M /trunk/epan/dissectors/packet-isns.c -Fix a couple of distcheck problems: +fix *several* dissector bugs, found by private fuzz-tests +------------------------------------------------------------------------ +r14862 | jmayer | 2005-07-05 17:58:00 -0500 (Tue, 05 Jul 2005) | 1 line +Changed paths: + M /trunk/wiretap/AUTHORS -Update conversation_new and find_conversation in plugin_api_list.c and -associated files. +Replace Chris Lydick by Robert Long as Author of the Sniffer 2.003 support patch +------------------------------------------------------------------------ +r14863 | kukosa | 2005-07-06 11:15:12 -0500 (Wed, 06 Jul 2005) | 2 lines +Changed paths: + M /trunk/tools/asn2eth.py -Add packet-dcerpc-butc.h to the distribution. +- #.FN_PARS implemented for BOOLEAN +- user defined body #.FN_BODY can be combined with default body using DEFAULT_BODY parameter (see e.g. H.225) +------------------------------------------------------------------------ +r14864 | kukosa | 2005-07-06 11:19:34 -0500 (Wed, 06 Jul 2005) | 1 line +Changed paths: + M /trunk/asn1/h225/h225.cnf + M /trunk/asn1/h245/h245.cnf +more usage of #.FN_PARS directive and usage of DEFAULT_BODY parameter ------------------------------------------------------------------------ -r13287 | guy | 2005-02-04 04:48:03 -0600 (Fri, 04 Feb 2005) | 4 lines +r14865 | guy | 2005-07-06 18:55:19 -0500 (Wed, 06 Jul 2005) | 2 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-slowprotocols.c + M /trunk/tools/asn2eth.py -From Dominique Bastien: marker and OAM slow protocol support. +Fix a spelling error. + +------------------------------------------------------------------------ +r14866 | guy | 2005-07-06 22:20:43 -0500 (Wed, 06 Jul 2005) | 3 lines +Changed paths: + M /trunk/gtk/voip_calls.c -Fix his e-mail address. +Explicitly initialize all the elements of a voip_calls_tapinfo_t, to +squelch a compiler warning. ------------------------------------------------------------------------ -r13286 | guy | 2005-02-04 04:32:28 -0600 (Fri, 04 Feb 2005) | 2 lines +r14867 | guy | 2005-07-06 23:03:35 -0500 (Wed, 06 Jul 2005) | 4 lines Changed paths: - M /trunk/plugins/mate/mate_setup.c + M /trunk/epan/address.h + M /trunk/gtk/voip_calls.c -HFILL can't be used to initialize at run time. +Add a cast to SET_ADDRESS() to squelch GCC4 "differ in signedness" +warnings. Use SET_ADDRESS in the VOIP calls code, rather than +explicitly filling in "pstn_add". ------------------------------------------------------------------------ -r13285 | ulfl | 2005-02-04 02:52:38 -0600 (Fri, 04 Feb 2005) | 1 line +r14868 | guy | 2005-07-06 23:05:01 -0500 (Wed, 06 Jul 2005) | 3 lines Changed paths: - M /trunk/capture_sync.c + M /trunk/gtk/voip_calls_dlg.c + +Squelch a compiler pointer vs. integer warning - NULL is for pointers, +'\0' is for characters. -remove access to global cfile, use access functions and capture_opts instead ------------------------------------------------------------------------ -r13284 | ulfl | 2005-02-04 02:42:39 -0600 (Fri, 04 Feb 2005) | 1 line +r14869 | kukosa | 2005-07-07 00:45:51 -0500 (Thu, 07 Jul 2005) | 1 line Changed paths: - M /trunk/capture_loop.c - M /trunk/file.c - M /trunk/file.h + M /trunk/asn1/h225/h225.cnf + M /trunk/asn1/h450/h450.cnf -remove #include "globals.h" and access to global cfile, use access functions and capture_opts instead +avoid few warnings from asn2eth compiler ------------------------------------------------------------------------ -r13283 | ulfl | 2005-02-04 02:27:41 -0600 (Fri, 04 Feb 2005) | 1 line +r14870 | etxrab | 2005-07-07 14:48:06 -0500 (Thu, 07 Jul 2005) | 1 line Changed paths: - M /trunk/capture.c - M /trunk/file.c - M /trunk/file.h + M /trunk/packaging/nsis/Makefile.nmake + M /trunk/packaging/nsis/ethereal.nsi -remove #include "globals.h" and access to global cfile, use access functions and capture_opts instead +Add parlay.dll and tango.dll to the installer. ------------------------------------------------------------------------ -r13282 | sahlberg | 2005-02-03 23:26:51 -0600 (Thu, 03 Feb 2005) | 3 lines +r14871 | gerald | 2005-07-07 16:26:09 -0500 (Thu, 07 Jul 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/dcerpc/butc/butc.idl - M /trunk/epan/dissectors/packet-dcerpc-butc.c - M /trunk/epan/dissectors/packet-dcerpc-butc.h + M /trunk/Makefile.nmake + M /trunk/epan/dissectors/make-reg-dotc.py + M /trunk/tools/cvsdiff-fix.py + M /trunk/tools/win32-setup.sh -use a bitmap for the restore flags so the dissection is prettier +Make sure "which" is present before we verify our tools. Add "env" to +the list of programs to check. Make sure our python scripts start with +"#!/usr/bin/env python" as recommended at + http://www.python.org/doc/faq/library.html#how-do-i-make-a-python-script-executable-on-unix ------------------------------------------------------------------------ -r13281 | sahlberg | 2005-02-03 22:58:03 -0600 (Thu, 03 Feb 2005) | 3 lines +r14872 | sahlberg | 2005-07-07 17:24:28 -0500 (Thu, 07 Jul 2005) | 7 lines Changed paths: - A /trunk/epan/dissectors/dcerpc/butc - A /trunk/epan/dissectors/dcerpc/butc/Makefile - A /trunk/epan/dissectors/dcerpc/butc/butc.cnf - A /trunk/epan/dissectors/dcerpc/butc/butc.idl - A /trunk/epan/dissectors/dcerpc/butc/template.c - A /trunk/epan/dissectors/dcerpc/butc/template.h + M /trunk/gtk/conversations_table.c + M /trunk/gtk/conversations_table.h + M /trunk/gtk/hostlist_table.c + M /trunk/gtk/hostlist_table.h + +make the packets/bytes counters 64bit integers to not wrap when using really large captures. + + +setting packet counter to 64bit is overkill but makes it consistent with the very similar bytes counter. -initial checkin of modified idl file for autogenerating the BUTC interface ------------------------------------------------------------------------ -r13280 | sahlberg | 2005-02-03 22:37:47 -0600 (Thu, 03 Feb 2005) | 7 lines +r14873 | guy | 2005-07-07 21:21:16 -0500 (Thu, 07 Jul 2005) | 3 lines Changed paths: - A /trunk/epan/dissectors/dcerpc - A /trunk/epan/dissectors/dcerpc/idl2eth.c + M /trunk/wiretap/nettl.c + +Make nettl file header items containing strings "gchar", to squelch +signed vs. unsigned compiler warnings. + +------------------------------------------------------------------------ +r14874 | guy | 2005-07-07 21:31:45 -0500 (Thu, 07 Jul 2005) | 23 lines +Changed paths: + M /trunk/epan/dissectors/packet-actrace.c + +Get rid of most unused arguments and variables (including some that are +set but not used). (Leave "pi" around so the warning acts as a reminder +that the tap structure stuff needs a cleanup - currently, the tap +structures aren't freed; perhaps the new memory allocation scheme +proposed by Ronnie could be used for tap structures.) -check in new directory for the files for autogenerating dcerpc interfaces -and the prototype idl compiler. +Have "ac_istrace()" return NOT_ACTRACE for apparently non-actrace +packets and return the packet type for actrace packets, so that we don't +need a global variable for the packet type. -this is not ready for wide use yet but is useful with a svn area where we can sync our changes to the compiler. +Make "actrace_udp_port" unsigned to squelch a signed vs. unsigned +warning. + +Use "col_set_str()" rather than "col_add_str()" when setting the +Protocol column. +We don't recognized packets as CAS packets unless they're 48 bytes long, +so we don't need to test whether they're 48 bytes long in the CAS packet +dissection code. +Use the reported length, not the captured length, when doing length +checks. ------------------------------------------------------------------------ -r13279 | sahlberg | 2005-02-03 22:31:59 -0600 (Thu, 03 Feb 2005) | 2 lines +r14875 | guy | 2005-07-08 04:12:11 -0500 (Fri, 08 Jul 2005) | 3 lines Changed paths: - M /trunk/capture_sync.c + M /trunk/gtk/summary_dlg.c + M /trunk/summary.h -add missing conversion to new use of save_file and fork_child +Make the counters in the summary 64-bit, so they don't overflow on +Really Big Captures. ------------------------------------------------------------------------ -r13278 | sahlberg | 2005-02-03 22:02:36 -0600 (Thu, 03 Feb 2005) | 4 lines +r14876 | tuexen | 2005-07-08 06:47:59 -0500 (Fri, 08 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-dcerpc.h - -add support for varying strings in addition to conformant and varying strings that we already support + M /trunk/gtk/sctp_graph_dlg.c +Fix a crash reported by Jeff Morris. +------------------------------------------------------------------------ +r14877 | etxrab | 2005-07-08 14:59:56 -0500 (Fri, 08 Jul 2005) | 1 line +Changed paths: + M /trunk/asn1/gsmmap/GSMMAP.asn + M /trunk/asn1/gsmmap/gsmmap.cnf + M /trunk/asn1/gsmmap/packet-gsm_map-template.c +Add some missing IMPLICIT tags, and use FN_PARS directive. ------------------------------------------------------------------------ -r13277 | sahlberg | 2005-02-03 20:17:29 -0600 (Thu, 03 Feb 2005) | 3 lines +r14878 | etxrab | 2005-07-08 15:01:11 -0500 (Fri, 08 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-butc.c - A /trunk/epan/dissectors/packet-dcerpc-butc.h + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-gsm_map.c -update BUTC and fill in all (bar one) dissectors +Add some missing IMPLICIT tags, and use FN_PARS directive. + +Add disection of some RR elements and command Handover. +------------------------------------------------------------------------ +r14879 | ulfl | 2005-07-08 17:04:35 -0500 (Fri, 08 Jul 2005) | 1 line +Changed paths: + M /trunk/docbook/graphics/ethereal-analyze-menu.png + M /trunk/docbook/graphics/ethereal-bytes-pane-popup-menu.png + M /trunk/docbook/graphics/ethereal-capture-menu.png + M /trunk/docbook/graphics/ethereal-capture-options.png + M /trunk/docbook/graphics/ethereal-decode-as.png + M /trunk/docbook/graphics/ethereal-details-pane-popup-menu.png + M /trunk/docbook/graphics/ethereal-details-pane.png + M /trunk/docbook/graphics/ethereal-display-filter-tcp.png + M /trunk/docbook/graphics/ethereal-edit-menu.png + M /trunk/docbook/graphics/ethereal-file-menu.png + M /trunk/docbook/graphics/ethereal-filter-toolbar.png + M /trunk/docbook/graphics/ethereal-find-packet.png + M /trunk/docbook/graphics/ethereal-follow-stream.png + M /trunk/docbook/graphics/ethereal-go-menu.png + M /trunk/docbook/graphics/ethereal-gui-preferences.png + M /trunk/docbook/graphics/ethereal-help-menu.png + M /trunk/docbook/graphics/ethereal-list-pane.png + M /trunk/docbook/graphics/ethereal-main-toolbar.png + M /trunk/docbook/graphics/ethereal-main.png + M /trunk/docbook/graphics/ethereal-packet-pane-popup-menu.png + M /trunk/docbook/graphics/ethereal-packet-selected.png + M /trunk/docbook/graphics/ethereal-statistics-menu.png + M /trunk/docbook/graphics/ethereal-stats-conversations.png + M /trunk/docbook/graphics/ethereal-stats-endpoints.png + M /trunk/docbook/graphics/ethereal-time-reference.png + M /trunk/docbook/graphics/ethereal-view-menu.png + M /trunk/docbook/user-guide.xml +Update the EDG screenshots to reflect the latest Ethereal GUI changes +------------------------------------------------------------------------ +r14880 | ulfl | 2005-07-08 17:11:13 -0500 (Fri, 08 Jul 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-dnp.c + M /trunk/epan/dissectors/packet-eth.c + M /trunk/epan/dissectors/packet-gprs-llc.c + M /trunk/epan/dissectors/packet-gre.c + M /trunk/epan/dissectors/packet-icmpv6.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-igmp.c + M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/dissectors/packet-isis-hello.c + M /trunk/epan/dissectors/packet-isis-lsp.c + M /trunk/epan/dissectors/packet-isis-snp.c + M /trunk/epan/dissectors/packet-lmp.c + M /trunk/epan/dissectors/packet-ospf.c + M /trunk/epan/dissectors/packet-pgm.c + M /trunk/epan/dissectors/packet-pim.c + M /trunk/epan/dissectors/packet-ppp.c + M /trunk/epan/dissectors/packet-rsvp.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-vrrp.c +checksum messages: use "[correct]" instead of "(correct)" and other "alike" messages ------------------------------------------------------------------------ -r13276 | ulfl | 2005-02-03 19:29:29 -0600 (Thu, 03 Feb 2005) | 4 lines +r14881 | guy | 2005-07-08 19:35:13 -0500 (Fri, 08 Jul 2005) | 8 lines Changed paths: - M /trunk/capture.c - M /trunk/capture.h - M /trunk/capture_loop.c - M /trunk/capture_sync.c - M /trunk/capture_sync.h - M /trunk/cfile.c - M /trunk/cfile.h - M /trunk/file.c - M /trunk/file.h - M /trunk/gtk/capture_dlg.c - M /trunk/gtk/capture_info_dlg.c - M /trunk/gtk/main.c - M /trunk/tethereal.c + M /trunk/epan/dissectors/packet-icep.c + +Use "tvb_get_string()" rather than duplicating its functionality by +hand. -(some) redesign of capture data structures. +Use "g_strdup()" rather than duplicating its functionality by hand. + +Make the magic number an array of "guint8", as "tvb_memeql()" expects a +pointer to "guint8". -don't use global cfile at all but only an untpyed handle to call the cf_... functions in file.c -move the save_file member from capture_file to capture_opts, as it's only used while capturing and while preparing it ------------------------------------------------------------------------ -r13275 | jmayer | 2005-02-03 18:29:37 -0600 (Thu, 03 Feb 2005) | 13 lines +r14882 | guy | 2005-07-08 19:44:44 -0500 (Fri, 08 Jul 2005) | 11 lines Changed paths: - M /trunk/configure.in - M /trunk/epan/Makefile.am + M /trunk/epan/dissectors/packet-bittorrent.c -Albert Chin: ->From autoconf.info: - In order to support these features, it is essential that `datadir' - remains being defined as `${prefix}/share' to depend upon the current - value of `prefix'. +Find the BitTorrent dissector immediately after registering it, and save +the handle, rather than finding it every time we need it. - A corollary is that you should not use these variables except in - Makefiles. For instance, instead of trying to evaluate `datadir' in - `configure' and hard-coding it in Makefiles using e.g., - `AC_DEFINE_UNQUOTED(DATADIR, "$datadir")', you should add - `-DDATADIR="$(datadir)"' to your `CPPFLAGS'. +Just make a guint8 array with the BitTorrent magic string length +followed by the string, and use "tvb_memeql()" to test against that - it +handles checking to make sure there's enough data in the tvbuff (if +not, it returns -1 as a "no match" indication) and then checks all of +the first 20 bytes in one operation. +Clean up white space. ------------------------------------------------------------------------ -r13274 | jmayer | 2005-02-03 18:22:00 -0600 (Thu, 03 Feb 2005) | 6 lines +r14883 | guy | 2005-07-08 19:47:57 -0500 (Fri, 08 Jul 2005) | 6 lines Changed paths: - M /trunk/plugins/mate/mate_setup.c + M /trunk/epan/dissectors/packet-lwapp.c -albert chin: - The HP-UX compilers don't like non-constant initializers (C99'ism). - Patch attached for plugins/mate/mate_setup.c. +MAC addresses are arrays of bytes, not strings; make the destination MAC +address an array of guint8 - that squelches some compiler warnings. -Fix a few warnings (change some () to (void)) +Use -1 rather than tvb_length(tvb) to make the item for LWAPP go to the +end of the tvbuff. ------------------------------------------------------------------------ -r13273 | jmayer | 2005-02-03 17:42:06 -0600 (Thu, 03 Feb 2005) | 5 lines +r14884 | guy | 2005-07-08 19:53:17 -0500 (Fri, 08 Jul 2005) | 20 lines Changed paths: - M /trunk/epan/dissectors/packet-fw1.c + M /trunk/epan/dissectors/packet-ans.c + M /trunk/epan/dissectors/packet-ap1394.c + M /trunk/epan/dissectors/packet-aruba-adp.c + M /trunk/epan/dissectors/packet-beep.c + M /trunk/epan/dissectors/packet-bssap.c + M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-cip.c + M /trunk/epan/dissectors/packet-clnp.c + M /trunk/epan/dissectors/packet-echo.c + M /trunk/epan/dissectors/packet-enc.c + M /trunk/epan/dissectors/packet-eth.c + M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-igmp.c + M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/dissectors/packet-ipdc.c + M /trunk/epan/dissectors/packet-ipv6.c + M /trunk/epan/dissectors/packet-iscsi.c + M /trunk/epan/dissectors/packet-lmp.c + M /trunk/epan/dissectors/packet-m2pa.c + M /trunk/epan/dissectors/packet-manolito.c + M /trunk/epan/dissectors/packet-nlm.c + M /trunk/epan/dissectors/packet-nsip.c + M /trunk/epan/dissectors/packet-pgm.c + M /trunk/epan/dissectors/packet-rdt.c + M /trunk/epan/dissectors/packet-retix-bpdu.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-skinny.c + M /trunk/epan/dissectors/packet-uma.c + +Squelch various signed vs. unsigned warnings by: + + making pointers to byte data be "guint8 *" rather than "char *", + and making buffers holding byte data arrays of "guint8" rather + than arrays of "char"; + + making pointers to text strings "char *" rather than "guchar *"; + + appropriately casting pointers (cast to "guint8 *" when passing + to routines expecting "guint8 *" or when assigning to "guint8 + *"); + + making port-number preferences "guint"; + + making enum preferences "gint"; -Yaniv Kaul - Attached patch simplifies a very complex 'if' statement in packet-fw1.c - and generally streamlines the code. + making hf_ variables "int". +Clean up white space. ------------------------------------------------------------------------ -r13272 | jmayer | 2005-02-03 17:35:57 -0600 (Thu, 03 Feb 2005) | 6 lines +r14885 | guy | 2005-07-08 21:58:07 -0500 (Fri, 08 Jul 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-ip.c + M /trunk/asn1/acse/acse.cnf + M /trunk/asn1/cms/cms.cnf + M /trunk/asn1/ocsp/ocsp.cnf + M /trunk/asn1/pkix1explicit/pkix1explicit.cnf + M /trunk/asn1/smrse/smrse.cnf + M /trunk/asn1/x509af/x509af.cnf + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-cms.c + M /trunk/epan/dissectors/packet-cms.h + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-ocsp.c + M /trunk/epan/dissectors/packet-ocsp.h + M /trunk/epan/dissectors/packet-pkix1explicit.c + M /trunk/epan/dissectors/packet-pkix1explicit.h + M /trunk/epan/dissectors/packet-smrse.c + M /trunk/epan/dissectors/packet-smrse.h + M /trunk/epan/dissectors/packet-x509af.c + M /trunk/epan/dissectors/packet-x509af.h -Yaniv Kaul: - Attached please find a small performance optimization to packet-ip.c, - which removes multiple redundant calls to tvb_get_ptr(). +Fix up a bunch of arguments to "dissect_ber_identifier()" to match its +current signature ("class" is a "gint8 *", not a "guint8 *", and "tag" +is a "gint32 *", not a "guint32 *"). Re-generate the dissectors from +the ASN.1 and the .cnf files in the cases where the arguments were fixed +in a .cnf file. -Changed srt_addr and dst_addr from char to guchar +Give some dissectors the right svn:keywords and svn:eol-style settings. ------------------------------------------------------------------------ -r13271 | jmayer | 2005-02-03 17:24:08 -0600 (Thu, 03 Feb 2005) | 5 lines +r14886 | guy | 2005-07-08 22:25:25 -0500 (Fri, 08 Jul 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-cosine.c + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-kerberos.h + M /trunk/epan/dissectors/packet-kink.c + M /trunk/epan/dissectors/packet-spnego.c -Motonori Shindo: -Please find attached a small patch for CoSine L2 debug dissector. The -code used to incorrectly select the first 4 octets in the tvbuff. This -patch fixes this problem. +Make a bunch of items in encryption code arrays of guint8, and make some +pointers either "void *" or "guint8 *", to reduce the level of compiler +warnings (the data in question is largely binary in those cases). ------------------------------------------------------------------------ -r13270 | jmayer | 2005-02-03 17:18:23 -0600 (Thu, 03 Feb 2005) | 4 lines +r14887 | ulfl | 2005-07-09 06:26:46 -0500 (Sat, 09 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/to_str.c + M /trunk/gtk/conversations_table.c + M /trunk/gtk/hostlist_table.c -Yniv Kaul: Small performance optimization - It change a while()->do, to do->while() and removes a variable (and an - assignment to it). +MSVC: fix some guint64 related compiler warnings, could someone please review my comment(s), I don't think it's currently implemented correct ------------------------------------------------------------------------ -r13269 | jmayer | 2005-02-03 16:52:20 -0600 (Thu, 03 Feb 2005) | 5 lines +r14888 | ulfl | 2005-07-09 06:28:13 -0500 (Sat, 09 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-arp.c + M /trunk/gtk/summary_dlg.c -ncisco Alcoba: - Do not add target address if the packet is a Request. According to the RFC, - target addresses in requests have no meaning +MSVC: fix some guint64 related compiler errors +strange enough, MSVC cannot convert from guint64 to float, so cast guint64 -> gint64 -> float +However, even gint64 might be big enough to prevent us from an overflow :-) ------------------------------------------------------------------------ -r13268 | ulfl | 2005-02-03 16:48:20 -0600 (Thu, 03 Feb 2005) | 1 line +r14889 | sahlberg | 2005-07-09 21:59:50 -0500 (Sat, 09 Jul 2005) | 14 lines Changed paths: - M /trunk/capture.c - M /trunk/capture.h - M /trunk/capture_loop.c - M /trunk/capture_sync.c - M /trunk/cfile.c - M /trunk/cfile.h - M /trunk/gtk/main.c - M /trunk/tethereal.c + M /trunk/gtk/tcp_graph.c + +It works reasonably well with extensive testing so here goes : + +tcp-graph has been modified to extract tcp data from a TAP instead of reading and parsing directly from the capture file. + +This makes tcp graph work for any type of capture and for any transport. + + + + +In the future someone with access to captures with TCP over something over TCP +to add a dialog where the user can specify WHICH of the multiple TCP sessions to graph. + + -move capture_file_fd field from capture_file to capture_opts type, as this is the place where it should be ------------------------------------------------------------------------ -r13267 | jmayer | 2005-02-03 16:44:13 -0600 (Thu, 03 Feb 2005) | 1 line +r14890 | sahlberg | 2005-07-10 00:27:38 -0500 (Sun, 10 Jul 2005) | 19 lines Changed paths: - M /trunk/wiretap/nettl.c - M /trunk/wiretap/nettl.h + M /trunk/epan/dissectors/packet-tcp.c + +For packets flagged as Retransmission + +calculate RTO as the delta between the retransmitted frame and the last previous frame seen for this session (in the same direction). + +while this is technically not the RTO this delta is in most cases more important/useful than the tru RTO anyway since this measure represents the amount of thiime that the link went idle while waiting for an RTO. + + + + +It would be nice with a statistics tap for TCP where one couls see, seeion by session : +Length in time of the session. +Total bytes transferred +Number of retransmissions +Time spent waiting for an RTO +Time spent waiting for an RTO in % of the total time. + + + -Mark C. Brown: Added support for new ixgbe card ------------------------------------------------------------------------ -r13266 | ulfl | 2005-02-03 15:58:33 -0600 (Thu, 03 Feb 2005) | 1 line +r14891 | jmayer | 2005-07-10 03:04:27 -0500 (Sun, 10 Jul 2005) | 7 lines Changed paths: - M /trunk/capture_loop.c - M /trunk/ringbuffer.c - M /trunk/ringbuffer.h - M /trunk/tethereal.c + M /trunk/Makefile.am + M /trunk/doc/Makefile.am + M /trunk/epan/Makefile.am + M /trunk/epan/dfilter/Makefile.am + M /trunk/epan/dissectors/Makefile.am + M /trunk/epan/ftypes/Makefile.am + M /trunk/gtk/Makefile.am + M /trunk/help/Makefile.am + M /trunk/packaging/Makefile.am + M /trunk/packaging/nsis/Makefile.am + M /trunk/packaging/rpm/Makefile.am + M /trunk/packaging/rpm/SPECS/Makefile.am + M /trunk/packaging/svr4/Makefile.am + M /trunk/plugins/Makefile.am + M /trunk/plugins/acn/Makefile.am + M /trunk/plugins/agentx/Makefile.am + M /trunk/plugins/artnet/Makefile.am + M /trunk/plugins/asn1/Makefile.am + M /trunk/plugins/ciscosm/Makefile.am + M /trunk/plugins/docsis/Makefile.am + M /trunk/plugins/enttec/Makefile.am + M /trunk/plugins/giop/Makefile.am + M /trunk/plugins/gryphon/Makefile.am + M /trunk/plugins/irda/Makefile.am + M /trunk/plugins/lwres/Makefile.am + M /trunk/plugins/mate/Makefile.am + M /trunk/plugins/megaco/Makefile.am + M /trunk/plugins/mgcp/Makefile.am + M /trunk/plugins/opsi/Makefile.am + M /trunk/plugins/pcli/Makefile.am + M /trunk/plugins/profinet/Makefile.am + M /trunk/plugins/rdm/Makefile.am + M /trunk/plugins/rlm/Makefile.am + M /trunk/plugins/rtnet/Makefile.am + M /trunk/plugins/rudp/Makefile.am + M /trunk/plugins/stats_tree/Makefile.am + M /trunk/plugins/v5ua/Makefile.am + M /trunk/plugins/xml/Makefile.am + M /trunk/tools/Makefile.am + M /trunk/tools/lemon/Makefile.am + M /trunk/wiretap/Makefile.am + +After doing "make maintainer-clean", "svn status --no-ignore | grep ^I" +returned quite a list of files. Add them to MAINTAINERCLEANFILES. + +Whitespace changes (replace multiple spaces by TABs, in a few cases this +needed to be done at the beginning of Makefile lines. + -prevent ringbuffer from having to know about capture_file type at all (decoupling dependencies) ------------------------------------------------------------------------ -r13265 | etxrab | 2005-02-03 15:57:42 -0600 (Thu, 03 Feb 2005) | 1 line +r14892 | guy | 2005-07-10 04:21:57 -0500 (Sun, 10 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-h248.c - M /trunk/epan/dissectors/packet-h248.h + M /trunk/gtk/tcp_graph.c + +Get rid of an unused argument. -Add dissection of some more packages. ------------------------------------------------------------------------ -r13264 | etxrab | 2005-02-03 15:56:59 -0600 (Thu, 03 Feb 2005) | 1 line +r14893 | guy | 2005-07-10 04:26:20 -0500 (Sun, 10 Jul 2005) | 3 lines Changed paths: - M /trunk/asn1/h248/h248.cnf - M /trunk/asn1/h248/packet-h248-template.c + M /trunk/epan/dissectors/packet-lpd.c + +Put the data (print job contents) in LPD requests under the LPD protocol +item, rather than making it a top-level item. -Add dissection of some more packages. ------------------------------------------------------------------------ -r13263 | etxrab | 2005-02-03 15:51:35 -0600 (Thu, 03 Feb 2005) | 4 lines +r14894 | guy | 2005-07-10 05:10:40 -0500 (Sun, 10 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-isup.c - M /trunk/epan/dissectors/packet-isup.h - M /trunk/epan/dissectors/packet-q931.c - M /trunk/epan/dissectors/packet-q931.h + M /trunk/gtk/tcp_graph.c + +Fix some comment typos. + +Don't regenerate the packet list when generating the TCP stream graph - +it won't be changing; just redissect and run the tap. -From Francisco Alcoba: -Patch for graphing ISUP calls. It shows the type of message, -in the first one the calling and called numbers, and in the second the SPs -and CIC; in releases it shows the cause value. ------------------------------------------------------------------------ -r13262 | etxrab | 2005-02-03 15:50:19 -0600 (Thu, 03 Feb 2005) | 4 lines +r14895 | guy | 2005-07-10 13:29:43 -0500 (Sun, 10 Jul 2005) | 9 lines Changed paths: - M /trunk/gtk/voip_calls.c + M /trunk/gtk/tcp_graph.c + +Just pass &cfile to select_tcpip_session(); we don't need to pass +cfile.current_frame to it separately. + +Note that we shouldn't ever get a "Selected packet isn't a TCP segment" +error any more; we can now handle all link layers. + +Give a little more detail in the message shown if there's *more than +one* TCP header in the packet. -From Francisco Alcoba: -Patch for graphing ISUP calls. It shows the type of message, -in the first one the calling and called numbers, and in the second the SPs -and CIC; in releases it shows the cause value. ------------------------------------------------------------------------ -r13261 | etxrab | 2005-02-03 15:22:09 -0600 (Thu, 03 Feb 2005) | 1 line +r14896 | etxrab | 2005-07-11 14:24:30 -0500 (Mon, 11 Jul 2005) | 1 line Changed paths: M /trunk/asn1/gsmmap/GSMMAP.asn M /trunk/asn1/gsmmap/gsmmap.cnf M /trunk/asn1/gsmmap/packet-gsm_map-template.c -Various updates to GSM MAP +Dissect some more fields ------------------------------------------------------------------------ -r13260 | jmayer | 2005-02-03 15:11:46 -0600 (Thu, 03 Feb 2005) | 2 lines +r14897 | etxrab | 2005-07-11 14:25:25 -0500 (Mon, 11 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-stun.c - -Jon Ringle: bug fix to the stun ERROR-CODE dissecting + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-gsm_a.h + M /trunk/epan/dissectors/packet-gsm_map.c +Dissect some more fields ------------------------------------------------------------------------ -r13259 | ulfl | 2005-02-03 14:44:19 -0600 (Thu, 03 Feb 2005) | 1 line +r14898 | ulfl | 2005-07-11 15:14:43 -0500 (Mon, 11 Jul 2005) | 1 line Changed paths: - M /trunk/gtk/follow_dlg.c + M /trunk/colorfilters -add tooltips to the dialogs radio buttons +fix a syntax error in the "Routing" rule, reported by Jeff Morriss ------------------------------------------------------------------------ -r13258 | guy | 2005-02-03 14:14:11 -0600 (Thu, 03 Feb 2005) | 3 lines +r14899 | etxrab | 2005-07-11 17:23:15 -0500 (Mon, 11 Jul 2005) | 2 lines Changed paths: - M /trunk/AUTHORS - M /trunk/wka.tmpl - -From Dominique Bastien: add the slow protocol MAC address to the list of -well-known MAC addresses. + A /trunk/epan/dissectors/packet-dis-enums.c + A /trunk/epan/dissectors/packet-dis-enums.h + A /trunk/epan/dissectors/packet-dis-fields.c + A /trunk/epan/dissectors/packet-dis-fields.h + A /trunk/epan/dissectors/packet-dis-pdus.c + A /trunk/epan/dissectors/packet-dis-pdus.h + A /trunk/epan/dissectors/packet-dis.c +From Jeremy j Ouellette: +DIS dissection. ------------------------------------------------------------------------ -r13257 | lroland | 2005-02-03 10:22:08 -0600 (Thu, 03 Feb 2005) | 1 line +r14900 | etxrab | 2005-07-11 17:23:57 -0500 (Mon, 11 Jul 2005) | 1 line Changed paths: - M /trunk/asn1/h225/h225.cnf - M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/Makefile.common -Small fix for h225 dissector as suggested by Tomas Kukosa +DIS dissection ------------------------------------------------------------------------ -r13256 | gram | 2005-02-03 09:03:29 -0600 (Thu, 03 Feb 2005) | 3 lines +r14901 | etxrab | 2005-07-11 17:27:20 -0500 (Mon, 11 Jul 2005) | 1 line Changed paths: - M /trunk/epan/ftypes/ftype-string.c - -From Pekka Pietikainen <pp@ee.oulu.fi>, add a byte to the hex[] -array so that there is room for the terminating NUL from sprintf(). + M /trunk/AUTHORS +Add Jeremy j Ouellette ------------------------------------------------------------------------ -r13255 | etxrab | 2005-02-03 00:54:55 -0600 (Thu, 03 Feb 2005) | 1 line +r14902 | guy | 2005-07-11 17:48:51 -0500 (Mon, 11 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-ntlmssp.c + +In NTLMSP_AUTH messages, include the domain name and user name in the +Info column. -Add an OID ------------------------------------------------------------------------ -r13254 | ulfl | 2005-02-02 20:35:20 -0600 (Wed, 02 Feb 2005) | 2 lines +r14903 | guy | 2005-07-11 20:01:19 -0500 (Mon, 11 Jul 2005) | 2 lines Changed paths: - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/asn1/ftam/ftam.cnf + M /trunk/asn1/tcap/packet-tcap-template.c + M /trunk/asn1/tcap/tcap.cnf + M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/packet-tcap.c + +Fix some more signed vs. unsigned warnings. -Enable GTK-Wimp only for Windows 2000/XP/2003 -...as Win9x/ME/NT known to have problems with it! ------------------------------------------------------------------------ -r13253 | ulfl | 2005-02-02 20:32:48 -0600 (Wed, 02 Feb 2005) | 6 lines +r14904 | jmayer | 2005-07-12 07:44:42 -0500 (Tue, 12 Jul 2005) | 8 lines Changed paths: - A /trunk/packaging/nsis/GetWindowsVersion.nsh + M /trunk/Makefile.am + M /trunk/Makefile.common + M /trunk/epan/dissectors/Makefile.am + M /trunk/epan/dissectors/Makefile.common -Copied this file from: -http://nsis.sourceforge.net/archive/nsisweb.php?page=15&instances=0,11 +Remove/replace SPACES at the beginning of Makefile.am/Makefile.common +files as not all make implementation work with this. + +Found by running +grep '^ ' `find . -name "Makefile.am" -o -name "Makefile.common"` + +Gerald: Maybe adding this to the buildbot would be a good idea after all. -Licensing question, as the NSIS homepage states: -http://nsis.sourceforge.net/features/license/ -so it should be ok to rerelease this file under the GPL ------------------------------------------------------------------------ -r13252 | guy | 2005-02-02 20:26:20 -0600 (Wed, 02 Feb 2005) | 2 lines +r14905 | jmayer | 2005-07-12 12:06:09 -0500 (Tue, 12 Jul 2005) | 3 lines Changed paths: - M /trunk/wiretap/erf.c + M /trunk/epan/dissectors/packet-radiotap.c -Give a URL for the ERF specification. +Add value for FCS (no decoding). +Fix a signedness warning. ------------------------------------------------------------------------ -r13251 | guy | 2005-02-02 19:24:07 -0600 (Wed, 02 Feb 2005) | 2 lines +r14906 | jmayer | 2005-07-12 12:08:17 -0500 (Tue, 12 Jul 2005) | 4 lines Changed paths: - M /trunk/epan/circuit.c + M /trunk/epan/dissectors -Fix a comment. +Update svn:ignore + Add register.c-tmp + Remove duplicate tags and TAGS ------------------------------------------------------------------------ -r13250 | guy | 2005-02-02 19:08:39 -0600 (Wed, 02 Feb 2005) | 3 lines +r14907 | etxrab | 2005-07-12 15:30:33 -0500 (Tue, 12 Jul 2005) | 1 line Changed paths: - M /trunk/epan/conversation.c - M /trunk/epan/conversation.h - -Check in the missing part of Jon Ringle's patch (the part that actually -changed the conversation code). + M /trunk/epan/dissectors/packet-gtp.c +Fix decoding of quintuplets. ------------------------------------------------------------------------ -r13249 | guy | 2005-02-02 19:07:21 -0600 (Wed, 02 Feb 2005) | 2 lines +r14908 | tuexen | 2005-07-12 16:04:05 -0500 (Tue, 12 Jul 2005) | 2 lines Changed paths: - M /trunk/AUTHORS + M /trunk/gtk/sctp_assoc_analyse.c + M /trunk/gtk/sctp_graph_dlg.c -Undo de-UTF-8ification and other damage. +From Irene Ruengeler: Handle multiple gap reports correctly and use correct name of a button. ------------------------------------------------------------------------ -r13248 | ulfl | 2005-02-02 16:18:37 -0600 (Wed, 02 Feb 2005) | 1 line +r14909 | ulfl | 2005-07-12 16:09:34 -0500 (Tue, 12 Jul 2005) | 1 line Changed paths: - M /trunk/docbook/eug_src/EUG_app_files.xml + M /trunk/epan/dissectors/packet-tpkt.c -added %ETHEREAL%\disabled_protos +add some more textual explanations of the protocol and it's fields ------------------------------------------------------------------------ -r13247 | ulfl | 2005-02-02 15:13:52 -0600 (Wed, 02 Feb 2005) | 3 lines +r14910 | ulfl | 2005-07-12 16:21:14 -0500 (Tue, 12 Jul 2005) | 1 line Changed paths: M /trunk/epan/dissectors/packet-clnp.c -bugfix: the EOT flag detection in a COTP data TPDU was using little endian, although it's big endian in the packet. - -some other minor output enhancements +code cleanup: use "correct" proto_tree_add_... functions for li and tpdu code fields ------------------------------------------------------------------------ -r13246 | etxrab | 2005-02-02 14:15:29 -0600 (Wed, 02 Feb 2005) | 1 line +r14911 | etxrab | 2005-07-13 00:06:38 -0500 (Wed, 13 Jul 2005) | 3 lines Changed paths: - M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-aim-messaging.c + M /trunk/epan/dissectors/packet-aim.c + +From Ilya Konstantinov : + A patch to the AIM dissector to support Client Auto Response messages. I still don't know the meaning of all the fields as they weren't all mapped but this patch decodes all the important ones. -Add Jon Ringle, at the moment I don't have the e-mail address. ------------------------------------------------------------------------ -r13245 | etxrab | 2005-02-02 14:09:00 -0600 (Wed, 02 Feb 2005) | 11 lines +r14912 | sahlberg | 2005-07-13 03:00:15 -0500 (Wed, 13 Jul 2005) | 9 lines Changed paths: - M /trunk/plugins/irda/packet-irda.c + M /trunk/epan/dissectors/dcerpc/idl2eth.c + M /trunk/epan/dissectors/packet-dcerpc-drsuapi.c + M /trunk/epan/dissectors/packet-dcerpc.c + +make idl2eth generate FT_GUID hf fields for uuid_t and GUID types. + +make dissect_dcerpc_uuid_t() accept eitehr FT_STRING (old style) and FT_GUID (new style) hf fields. once all dissectors are modified to use FT_GUID we can remove the FT_STRING support here. + +regenerate the DRSUAPI interface with the new FT_GUID support. + + -From Jon Ringle: - 1) Added a setup_frame parameter to conversation_t -2) Used the conversation_t next to maintain a list of conversations with the -same src/dest tuple but different setup_frame number. -3) Changed the signature of find_conversation() and conversation_new() to pass -in the frame number. -4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image -are present, and T.38 conversation if only m=image is present. I expect that -RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 -packets. ------------------------------------------------------------------------ -r13244 | etxrab | 2005-02-02 14:08:36 -0600 (Wed, 02 Feb 2005) | 11 lines +r14913 | sahlberg | 2005-07-13 03:24:05 -0500 (Wed, 13 Jul 2005) | 3 lines Changed paths: - M /trunk/plugins/mgcp/packet-mgcp.c + M /trunk/epan/dissectors/dcerpc/dssetup/packet-dcerpc-dssetup.c + M /trunk/epan/dissectors/packet-dcerpc-budb.c + M /trunk/epan/dissectors/packet-dcerpc-dssetup.c + +convert two other autogenerated dissectors to use FT_GUID -From Jon Ringle: - 1) Added a setup_frame parameter to conversation_t -2) Used the conversation_t next to maintain a list of conversations with the -same src/dest tuple but different setup_frame number. -3) Changed the signature of find_conversation() and conversation_new() to pass -in the frame number. -4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image -are present, and T.38 conversation if only m=image is present. I expect that -RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 -packets. ------------------------------------------------------------------------ -r13243 | etxrab | 2005-02-02 14:07:03 -0600 (Wed, 02 Feb 2005) | 11 lines +r14914 | etxrab | 2005-07-13 16:38:07 -0500 (Wed, 13 Jul 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-afp.c - M /trunk/epan/dissectors/packet-afs.c - M /trunk/epan/dissectors/packet-ajp13.c - M /trunk/epan/dissectors/packet-aoe.c - M /trunk/epan/dissectors/packet-atalk.c - M /trunk/epan/dissectors/packet-beep.c - M /trunk/epan/dissectors/packet-bittorrent.c - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-dcm.c - M /trunk/epan/dissectors/packet-eap.c - M /trunk/epan/dissectors/packet-fc.c - M /trunk/epan/dissectors/packet-fcdns.c - M /trunk/epan/dissectors/packet-fcels.c - M /trunk/epan/dissectors/packet-fcfcs.c - M /trunk/epan/dissectors/packet-fcfzs.c - M /trunk/epan/dissectors/packet-fcp.c - M /trunk/epan/dissectors/packet-fcsb3.c - M /trunk/epan/dissectors/packet-fcswils.c - M /trunk/epan/dissectors/packet-ftp.c - M /trunk/epan/dissectors/packet-gssapi.c - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h225.h - M /trunk/epan/dissectors/packet-ipx.c - M /trunk/epan/dissectors/packet-iscsi.c - M /trunk/epan/dissectors/packet-isns.c - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-ldap.c - M /trunk/epan/dissectors/packet-mq.c - M /trunk/epan/dissectors/packet-msproxy.c - M /trunk/epan/dissectors/packet-mysql.c - M /trunk/epan/dissectors/packet-ncp.c - M /trunk/epan/dissectors/packet-ncp2222.inc - M /trunk/epan/dissectors/packet-ndmp.c - M /trunk/epan/dissectors/packet-ndps.c - M /trunk/epan/dissectors/packet-ntlmssp.c - M /trunk/epan/dissectors/packet-pgsql.c - M /trunk/epan/dissectors/packet-portmap.c - M /trunk/epan/dissectors/packet-quake.c - M /trunk/epan/dissectors/packet-rlogin.c - M /trunk/epan/dissectors/packet-rpc.c - M /trunk/epan/dissectors/packet-rsync.c - M /trunk/epan/dissectors/packet-rtcp.c - M /trunk/epan/dissectors/packet-rtp.c - M /trunk/epan/dissectors/packet-rtsp.c - M /trunk/epan/dissectors/packet-sdp.c - M /trunk/epan/dissectors/packet-smb.c - M /trunk/epan/dissectors/packet-smtp.c - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/dissectors/packet-socks.c - M /trunk/epan/dissectors/packet-spnego.c - M /trunk/epan/dissectors/packet-ssh.c - M /trunk/epan/dissectors/packet-ssl.c - M /trunk/epan/dissectors/packet-t38.c - M /trunk/epan/dissectors/packet-tcp.c - M /trunk/epan/dissectors/packet-tds.c - M /trunk/epan/dissectors/packet-tftp.c - M /trunk/epan/dissectors/packet-tuxedo.c - M /trunk/epan/dissectors/packet-wsp.c - M /trunk/epan/dissectors/packet-x11.c - M /trunk/epan/dissectors/packet-xyplex.c + M /trunk/epan/dissectors/packet-aim-messaging.c -From Jon Ringle: - 1) Added a setup_frame parameter to conversation_t -2) Used the conversation_t next to maintain a list of conversations with the -same src/dest tuple but different setup_frame number. -3) Changed the signature of find_conversation() and conversation_new() to pass -in the frame number. -4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image -are present, and T.38 conversation if only m=image is present. I expect that -RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 -packets. +From Ilya Konstantinov : +fixes a tiny bug which caused the boolean fields not to refer to the same offset as their +parent. ------------------------------------------------------------------------ -r13242 | etxrab | 2005-02-02 14:02:46 -0600 (Wed, 02 Feb 2005) | 11 lines +r14915 | lego | 2005-07-13 18:40:06 -0500 (Wed, 13 Jul 2005) | 3 lines Changed paths: - M /trunk/asn1/h225/h225.cnf - M /trunk/asn1/h225/packet-h225-template.c + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/epan/dissectors/packet-h248.c + +fix a string -From Jon Ringle: - 1) Added a setup_frame parameter to conversation_t -2) Used the conversation_t next to maintain a list of conversations with the -same src/dest tuple but different setup_frame number. -3) Changed the signature of find_conversation() and conversation_new() to pass -in the frame number. -4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image -are present, and T.38 conversation if only m=image is present. I expect that -RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 -packets. ------------------------------------------------------------------------ -r13241 | tuexen | 2005-02-02 07:37:04 -0600 (Wed, 02 Feb 2005) | 3 lines +r14916 | jmayer | 2005-07-14 03:03:59 -0500 (Thu, 14 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-mtp3.c + M /trunk/plugins/v5ua/packet-v5ua.c -Add mtp3.pc as suggested by Luis Ontanon. -Cleanups +moduleinfo.h was included twice. ------------------------------------------------------------------------ -r13240 | guy | 2005-02-02 04:28:51 -0600 (Wed, 02 Feb 2005) | 16 lines +r14917 | sahlberg | 2005-07-14 03:10:30 -0500 (Thu, 14 Jul 2005) | 9 lines Changed paths: - M /trunk/gtk/follow_dlg.c - M /trunk/print.c - M /trunk/print.h + M /trunk/epan/dissectors/packet-isakmp.c + +ISAKMP version2 has changed the payload format of a CertificateRequest. -Writing the raw data of a TCP stream to a file isn't printing it, so -don't use the print mechanism for that - do the writing directly in the -"follow stream" code. +In version 2 this is just a concatenation of 20 byte SHA-1 hashes with no other encxapsulation. -Use "size_t" for character counts. +this resolves bug 281 -Make the "hexchars" array static and const, as it's not written to, and -there's probably no point in copying it to the stack (unless that -improves cache locality). -There's no need to explain why we're subtracting the number of bytes -actually read, rather than the number of bytes asked for, from the data -length. -Note an issue with printing lines. ------------------------------------------------------------------------ -r13239 | guy | 2005-02-02 04:19:35 -0600 (Wed, 02 Feb 2005) | 2 lines +r14918 | etxrab | 2005-07-14 16:05:38 -0500 (Thu, 14 Jul 2005) | 3 lines Changed paths: - M /trunk/gtk/graph_analysis.c - M /trunk/gtk/rtp_analysis.c - M /trunk/gtk/rtp_stream_dlg.c - M /trunk/gtk/voip_calls_dlg.c - -Get rid of an unused typedef. + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-gsm_a.h + M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/dissectors/packet-uma.c +Packet-gtp.c - Fix up decoding of the rest of the IE:s use routines from packet-gsm_a.c +Packet-uma.c Let packet-gsm_a handle som IE dissection. +Packet-gsm.a add some IE dissection and export some routines. ------------------------------------------------------------------------ -r13238 | guy | 2005-02-02 03:08:42 -0600 (Wed, 02 Feb 2005) | 2 lines +r14919 | ulfl | 2005-07-14 16:45:18 -0500 (Thu, 14 Jul 2005) | 1 line Changed paths: - M /trunk/gtk/graph_analysis.c - M /trunk/gtk/graph_analysis.h - M /trunk/gtk/voip_calls.c - M /trunk/gtk/voip_calls.h - -Use C89 syntax, not C++ syntax, for functions that take no arguments. + M /trunk/docbook/eug_src/EUG_chapter_capture.xml + M /trunk/docbook/user-guide.xml +minor change: add TcpdumpManpage entity ------------------------------------------------------------------------ -r13237 | guy | 2005-02-02 02:53:08 -0600 (Wed, 02 Feb 2005) | 12 lines +r14920 | sahlberg | 2005-07-15 03:29:26 -0500 (Fri, 15 Jul 2005) | 8 lines Changed paths: - M /trunk/gtk/voip_calls_dlg.c + M /trunk/gtk/io_stat.c -Don't assume that the only blank filter expression is empty - check for -an all-space-character string. +make io-stat able to do SUM(*) for FT_RELATIVE_TIME fields + + +Example: SUM(tcp.analysis.rto) +so one can plot the total amount of time that TCP sessions were idle due to waiting for a retransmission to occur. -Don't use "filter_string" both for the (unfreeable, unmodifiable) value -fetched from the text entry and the new filter expression; use it only -for the former, and make it a "const" pointer to avoid compiler -warnings. -Use a GString to construct the stuff to be added to the new filter -expression - the old code, when appending stuff to the filter expression -in a loop, would leak the pre-append value. ------------------------------------------------------------------------ -r13236 | sahlberg | 2005-02-02 02:50:40 -0600 (Wed, 02 Feb 2005) | 10 lines +r14921 | kukosa | 2005-07-15 10:20:40 -0500 (Fri, 15 Jul 2005) | 5 lines Changed paths: - M /trunk/AUTHORS - M /trunk/gtk/follow_dlg.c - M /trunk/print.c - M /trunk/print.h + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-h450.c + M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/packet-per.h + M /trunk/tools/asn2eth.py -from chris eagle +- PER helper functions for SET/SEQUENCE OF dissection were changed to have prototype similar to BER (per_sequence_t is used as parameter) +- asn2eth was updated to support new PER helper functions for SET/SEQUENCE OF +- #.FN_PARS implemented for SET/SEQUENCE OF and REAL +- PER SET/SEQUENCE OF field can be FT_UINTxx to display number of items +- PER dissectors regenerated +------------------------------------------------------------------------ +r14922 | etxrab | 2005-07-15 15:26:36 -0500 (Fri, 15 Jul 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-uma.c -add radiobutton to allow saving raw tcpstreams +Updare Id, and a comment. +------------------------------------------------------------------------ +r14923 | gerald | 2005-07-15 15:50:34 -0500 (Fri, 15 Jul 2005) | 2 lines +Changed paths: + M /trunk/Makefile.nmake + M /trunk/config.nmake + M /trunk/tools/win32-setup.sh + +Point to the latest Windows library tag and versions. + +------------------------------------------------------------------------ +r14924 | lego | 2005-07-15 16:03:13 -0500 (Fri, 15 Jul 2005) | 4 lines +Changed paths: + A /trunk/radius + A /trunk/radius/dictionary + A /trunk/radius/dictionary.3com + A /trunk/radius/dictionary.3gpp + A /trunk/radius/dictionary.3gpp2 + A /trunk/radius/dictionary.acc + A /trunk/radius/dictionary.alcatel + A /trunk/radius/dictionary.alteon + A /trunk/radius/dictionary.altiga + A /trunk/radius/dictionary.aptis + A /trunk/radius/dictionary.ascend + A /trunk/radius/dictionary.bay + A /trunk/radius/dictionary.bintec + A /trunk/radius/dictionary.bristol + A /trunk/radius/dictionary.cablelabs + A /trunk/radius/dictionary.cabletron + A /trunk/radius/dictionary.cisco + A /trunk/radius/dictionary.cisco.bbsm + A /trunk/radius/dictionary.cisco.vpn3000 + A /trunk/radius/dictionary.cisco.vpn5000 + A /trunk/radius/dictionary.colubris + A /trunk/radius/dictionary.columbia_university + A /trunk/radius/dictionary.compat + A /trunk/radius/dictionary.cosine + A /trunk/radius/dictionary.erx + A /trunk/radius/dictionary.extreme + A /trunk/radius/dictionary.foundry + A /trunk/radius/dictionary.freeradius + A /trunk/radius/dictionary.gandalf + A /trunk/radius/dictionary.garderos + A /trunk/radius/dictionary.gemtek + A /trunk/radius/dictionary.itk + A /trunk/radius/dictionary.juniper + A /trunk/radius/dictionary.karlnet + A /trunk/radius/dictionary.livingston + A /trunk/radius/dictionary.localweb + A /trunk/radius/dictionary.merit + A /trunk/radius/dictionary.microsoft + A /trunk/radius/dictionary.mikrotik + A /trunk/radius/dictionary.navini + A /trunk/radius/dictionary.netscreen + A /trunk/radius/dictionary.nokia + A /trunk/radius/dictionary.nomadix + A /trunk/radius/dictionary.propel + A /trunk/radius/dictionary.quintum + A /trunk/radius/dictionary.redback + A /trunk/radius/dictionary.redcreek + A /trunk/radius/dictionary.shasta + A /trunk/radius/dictionary.shiva + A /trunk/radius/dictionary.sonicwall + A /trunk/radius/dictionary.springtide + A /trunk/radius/dictionary.t_systems_nova + A /trunk/radius/dictionary.telebit + A /trunk/radius/dictionary.trapeze + A /trunk/radius/dictionary.tunnel + A /trunk/radius/dictionary.unisphere + A /trunk/radius/dictionary.unix + A /trunk/radius/dictionary.usr + A /trunk/radius/dictionary.valemount + A /trunk/radius/dictionary.versanet + A /trunk/radius/dictionary.wispr + A /trunk/radius/dictionary.xedia + +Radius dictionary support +Part 1: the dictionary + + +------------------------------------------------------------------------ +r14925 | lego | 2005-07-15 16:12:27 -0500 (Fri, 15 Jul 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-gtp.c + D /trunk/epan/dissectors/packet-gtp.h + M /trunk/epan/dissectors/packet-radius.c + A /trunk/epan/dissectors/packet-radius.h + A /trunk/epan/dissectors/packet-radius_packetcable.c + A /trunk/epan/radius_dict.l +Radius Dictionary Support +Part 2: the code -these radiobuttons should, by someone that uses, this feature be changed into -a menu instead. +------------------------------------------------------------------------ +r14926 | lego | 2005-07-15 16:18:32 -0500 (Fri, 15 Jul 2005) | 4 lines +Changed paths: + M /trunk/Makefile.am + M /trunk/epan/Makefile.am + M /trunk/epan/Makefile.common + M /trunk/epan/Makefile.nmake + M /trunk/packaging/nsis/ethereal.nsi +Radius Dictionary Support +Part 3: the makefiles ------------------------------------------------------------------------ -r13235 | guy | 2005-02-02 02:08:53 -0600 (Wed, 02 Feb 2005) | 4 lines +r14927 | lego | 2005-07-15 16:32:12 -0500 (Fri, 15 Jul 2005) | 3 lines Changed paths: - M /trunk/gtk/voip_calls.c + M /trunk/epan/dissectors/packet-ranap.c -Make sure "comment" is set. +register the dissector by name -Get rid of an unused variable. ------------------------------------------------------------------------ -r13234 | guy | 2005-02-02 02:02:46 -0600 (Wed, 02 Feb 2005) | 4 lines +r14928 | lego | 2005-07-15 16:41:47 -0500 (Fri, 15 Jul 2005) | 3 lines Changed paths: - M /trunk/gtk/graph_analysis.c + M /trunk/epan/dissectors/packet-radius.h + M /trunk/epan/radius_dict.l -Clean up white space. +forgot to add the (c) notice -Get rid of an unused variable and two #includes that aren't needed. ------------------------------------------------------------------------ -r13233 | guy | 2005-02-02 02:01:27 -0600 (Wed, 02 Feb 2005) | 3 lines +r14929 | lego | 2005-07-15 16:45:34 -0500 (Fri, 15 Jul 2005) | 2 lines Changed paths: - M /trunk/gtk/voip_calls_dlg.c + M /trunk/epan/dissectors/packet-radius_packetcable.c -"filter_string_fwd" is assigned a "const" pointer, so make it a "const" -pointer. +propset and fix the filename ------------------------------------------------------------------------ -r13232 | lroland | 2005-02-01 19:02:09 -0600 (Tue, 01 Feb 2005) | 13 lines +r14930 | lego | 2005-07-15 17:36:21 -0500 (Fri, 15 Jul 2005) | 3 lines Changed paths: - M /trunk/gtk/Makefile.am - M /trunk/gtk/Makefile.common - M /trunk/gtk/voip_calls.c - M /trunk/gtk/voip_calls.h - M /trunk/gtk/voip_calls_dlg.c - M /trunk/gtk/voip_calls_dlg.h - -for VoIP Call Analysis: -- make VoIP Call Analysis work if, called from command line -- should also work now while capturing with packet list - updated in "real time" (to be tested) -- give each tap listener a unique identifier, so ethereal - won't mix them up -- various cleanups -- compile by default - -Todo: -- add support for "tap display filter" -- reimplement function to add rtp streams to the call flow. - + M /trunk/packaging/nsis/ethereal.nsi + +comments are ";" not ":" + + ------------------------------------------------------------------------ -r13231 | ulfl | 2005-02-01 17:49:02 -0600 (Tue, 01 Feb 2005) | 1 line +r14931 | guy | 2005-07-15 19:26:07 -0500 (Fri, 15 Jul 2005) | 2 lines Changed paths: - M /trunk/docbook/eug_src/EUG_app_files.xml + M /trunk/epan/dissectors/packet-radius_packetcable.c + +Fix the RCS ID. -by more specific about unix configuration files ------------------------------------------------------------------------ -r13230 | sahlberg | 2005-02-01 17:33:04 -0600 (Tue, 01 Feb 2005) | 4 lines +r14932 | guy | 2005-07-15 19:27:53 -0500 (Fri, 15 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-smb-mailslot.c + M /trunk/epan/dissectors/packet-radius_packetcable.c -the old netlogon protocol is now called smb_netlogon +Fix the name of the "svn:keywords" property. +------------------------------------------------------------------------ +r14933 | guy | 2005-07-15 19:37:44 -0500 (Fri, 15 Jul 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/Makefile.common +epan/dissectors/packet-gtp.h has rung down the curtain and joined the +Choir Invisible. ------------------------------------------------------------------------ -r13229 | sahlberg | 2005-02-01 17:30:18 -0600 (Tue, 01 Feb 2005) | 4 lines +r14934 | guy | 2005-07-15 19:45:22 -0500 (Fri, 15 Jul 2005) | 2 lines Changed paths: - M /trunk/asn1/h245/packet-h245-template.c - M /trunk/epan/dissectors/packet-h245.c + M /trunk/Makefile.am + +It's "plugins", not "Plugins". + +------------------------------------------------------------------------ +r14935 | sahlberg | 2005-07-15 20:04:36 -0500 (Fri, 15 Jul 2005) | 5 lines +Changed paths: + A /trunk/asn1/wlancertextn + A /trunk/asn1/wlancertextn/Makefile + A /trunk/asn1/wlancertextn/Makefile.nmake + A /trunk/asn1/wlancertextn/WLANCERTEXTN.asn + A /trunk/asn1/wlancertextn/packet-wlancertextn-template.c + A /trunk/asn1/wlancertextn/packet-wlancertextn-template.h + A /trunk/asn1/wlancertextn/wlancertextn.cnf + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-wlancertextn.c + A /trunk/epan/dissectors/packet-wlancertextn.h -g_strlcpy does not exist in gtk 1.2 -use strncpy instead +new protocol + +RFC3770 Wlan Certificate Extensions ------------------------------------------------------------------------ -r13228 | etxrab | 2005-02-01 16:57:22 -0600 (Tue, 01 Feb 2005) | 1 line +r14936 | guy | 2005-07-15 20:33:22 -0500 (Fri, 15 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/radius_dict.l + +Throw in some casts to squelch warnings, at least with some compilers +(the values are const because nobody's supposed to modify them once +they've been allocated, but they *can* be freed - by us - when we're +done with them). -Improve handling of pinfo->private_data ------------------------------------------------------------------------ -r13227 | jmayer | 2005-02-01 09:45:03 -0600 (Tue, 01 Feb 2005) | 1 line +r14937 | guy | 2005-07-15 20:55:58 -0500 (Fri, 15 Jul 2005) | 7 lines Changed paths: - M /trunk/doc/README.developer + M /trunk/epan/dissectors/packet-radius.c + +Get rid of the newline between "radius:" and the error when trying to +read the RADIUS directory. + +The error string from "radius_load_dictionary()" is g_malloced; free it, +and g_strdup the "Could not find the radius directory" error, so we +don't have to worry about constant vs. g_malloced strings. -Add boolean to the list of non-portable types ------------------------------------------------------------------------ -r13226 | lroland | 2005-02-01 08:00:25 -0600 (Tue, 01 Feb 2005) | 4 lines +r14938 | guy | 2005-07-16 01:20:56 -0500 (Sat, 16 Jul 2005) | 2 lines Changed paths: M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-sdp.h - M /trunk/gtk/graph_analysis.c -add packet-sdp.h -and from Julien Leproust: -fix graph_analysis.c +List the new "packet-radius.h" file so it's included in the tarball. ------------------------------------------------------------------------ -r13225 | lroland | 2005-02-01 06:12:35 -0600 (Tue, 01 Feb 2005) | 7 lines +r14939 | etxrab | 2005-07-16 14:58:23 -0500 (Sat, 16 Jul 2005) | 1 line Changed paths: - M /trunk/AUTHORS - M /trunk/asn1/h225/h225.cnf - M /trunk/asn1/h225/packet-h225-template.c - M /trunk/asn1/h225/packet-h225-template.h - M /trunk/asn1/h245/h245.cnf - M /trunk/asn1/h245/packet-h245-template.c - M /trunk/asn1/h245/packet-h245-template.h - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h225.h - M /trunk/epan/dissectors/packet-h245.c - M /trunk/epan/dissectors/packet-h245.h - M /trunk/epan/dissectors/packet-isup.c - M /trunk/epan/dissectors/packet-isup.h - M /trunk/epan/dissectors/packet-q931.c - M /trunk/epan/dissectors/packet-q931.h - M /trunk/epan/dissectors/packet-rtp.c - M /trunk/epan/dissectors/packet-sdp.c - M /trunk/epan/dissectors/packet-sip.c - M /trunk/epan/dissectors/packet-sip.h M /trunk/epan/libethereal.def - A /trunk/gtk/graph_analysis.c - A /trunk/gtk/graph_analysis.h - M /trunk/gtk/rtp_stream.c - M /trunk/gtk/rtp_stream.h - A /trunk/gtk/voip_calls.c - A /trunk/gtk/voip_calls.h - A /trunk/gtk/voip_calls_dlg.c - A /trunk/gtk/voip_calls_dlg.h - M /trunk/rtp_pt.h -From Alejandro Vaquero: -h323 taps support up to 5 messages per packet now. - -VoIP call analysis: - - Collect ISUP, SIP and H323 calls from a capture and show them in window with the following info: - - Start and Stop time of the call - - Init +Remove an unused export ------------------------------------------------------------------------ -r13224 | guy | 2005-02-01 05:11:15 -0600 (Tue, 01 Feb 2005) | 2 lines +r14940 | etxrab | 2005-07-16 14:59:21 -0500 (Sat, 16 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-diameter-defs.h + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-gsm_a.h + M /trunk/epan/dissectors/packet-uma.c -Add some comments noting issues with some of the items in here. +Remove some unused variables. +------------------------------------------------------------------------ +r14941 | etxrab | 2005-07-16 16:34:19 -0500 (Sat, 16 Jul 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-t38.c +Update to the new per signatures. ------------------------------------------------------------------------ -r13223 | guy | 2005-01-31 23:21:08 -0600 (Mon, 31 Jan 2005) | 3 lines +r14942 | guy | 2005-07-17 03:39:51 -0500 (Sun, 17 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-netlogon.c - M /trunk/epan/dissectors/packet-dcerpc-nt.c - M /trunk/epan/dissectors/packet-dcerpc-nt.h + M /trunk/epan/dissectors/packet-uma.c -Move "dissect_nt_GUID()" into "packet-dcerpc-nt.c", as it's used by the -LSA dissector as well, and declare it in "packet-dcerpc-nt.h". +Fix the RCS ID. ------------------------------------------------------------------------ -r13222 | guy | 2005-01-31 23:19:53 -0600 (Mon, 31 Jan 2005) | 6 lines +r14943 | guy | 2005-07-17 03:41:07 -0500 (Sun, 17 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-atm.c + M /trunk/epan/dissectors/packet-uma.c -If the VCI and payload type indicate that a cell is an OAM cell, dissect -it as such. +It's "svn:keywords", not "svn:keyword". -Clear the Info column when dissecting cells for an AAL we handle before -dissecting the cell, and set the Info column for OAM cells. +------------------------------------------------------------------------ +r14944 | ulfl | 2005-07-17 08:39:24 -0500 (Sun, 17 Jul 2005) | 1 line +Changed paths: + M /trunk/epan/Makefile.nmake +add radius_dict.c to the distclean target, don't know how to do this for Makefile.am ------------------------------------------------------------------------ -r13221 | ulfl | 2005-01-31 18:52:38 -0600 (Mon, 31 Jan 2005) | 6 lines +r14945 | jmayer | 2005-07-17 08:55:46 -0500 (Sun, 17 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-redback.c - M /trunk/epan/dissectors/packet-rmt-fec.c + M /trunk/epan/Makefile.am + +Add radius_dict.c to DISTCLEAN -removed MSVC warnings: -packet-redback.c(63) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data -packet-redback.c(64) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data -packet-redback.c(65) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data -packet-rmt-fec.c(108) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data ------------------------------------------------------------------------ -r13220 | ulfl | 2005-01-31 18:51:42 -0600 (Mon, 31 Jan 2005) | 3 lines +r14946 | gerald | 2005-07-17 17:16:59 -0500 (Sun, 17 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-juniper.c + M /trunk/epan/dissectors/packet-radius.c + +Make the recent RADIUS changes work on IA64. -removed MSVC warnings: -packet-juniper.c(262) : warning C4761: integral size mismatch in argument; conversion supplied -packet-juniper.c(289) : warning C4761: integral size mismatch in argument; conversion supplied ------------------------------------------------------------------------ -r13219 | etxrab | 2005-01-31 15:40:51 -0600 (Mon, 31 Jan 2005) | 1 line +r14947 | gerald | 2005-07-17 17:30:56 -0500 (Sun, 17 Jul 2005) | 2 lines Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/dissectors/packet-radius.c + +Tweak the previous fix. -Prepare for handling of different versions of the protocol. ------------------------------------------------------------------------ -r13218 | etxrab | 2005-01-31 15:38:56 -0600 (Mon, 31 Jan 2005) | 1 line +r14948 | lego | 2005-07-17 18:12:12 -0500 (Sun, 17 Jul 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-tcap.c + M /trunk/gtk/Makefile.common + A /trunk/gtk/flow_graph.c + M /trunk/gtk/graph_analysis.c + +From Francisco Alcoba +Flow Graphs for any protocol + -Put application context OID in pinfo->private data to be used by sub-dissector(s). ------------------------------------------------------------------------ -r13217 | etxrab | 2005-01-31 15:37:11 -0600 (Mon, 31 Jan 2005) | 1 line +r14949 | sahlberg | 2005-07-18 03:29:03 -0500 (Mon, 18 Jul 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-diameter-defs.h + M /trunk/gtk/graph_analysis.c + +GTK 1.2 does not define the macro GDK_IS_DRAWABLE which made compilation of the recent flow analysis fail to compile. + +For the time being, just add a dummy define for this symbol making it always TRUE for gtk-1.x users so that it compiles. + +this should be fixed properly at a later stage, but i guess there are very few users of gtk-1.2 anyway so no urgency. + -Update som valuse strings ------------------------------------------------------------------------ -r13216 | etxrab | 2005-01-31 15:36:31 -0600 (Mon, 31 Jan 2005) | 4 lines +r14950 | guy | 2005-07-18 04:55:54 -0500 (Mon, 18 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-dis.c -From LEGO: - - remove duplicate fields from VSAs (every defined field in VSAs was set twice) - - dissect radius packet with avplen == 0 (did not decode authenticator when no AVPs were present) +DIS packets must be at least 12 bytes long. DIS uses port 3000, by +default, but the Cisco Redundant Link Management protocol can also use +that port; RLM packets are 8 bytes long, so we use this to distinguish +between them. ------------------------------------------------------------------------ -r13215 | sahlberg | 2005-01-31 03:56:42 -0600 (Mon, 31 Jan 2005) | 17 lines +r14951 | kukosa | 2005-07-18 15:45:46 -0500 (Mon, 18 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-smb-logon.c - -there are two NETLOGON protocols + M /trunk/tools/asn2eth.py + M /trunk/tools/lex.py + M /trunk/tools/yacc.py -the really really old one which is never used -and there is the DCE/RPC one that is used by all windows/cifs implementations. +PLY package updated to version 1.6 +------------------------------------------------------------------------ +r14952 | sahlberg | 2005-07-19 03:58:20 -0500 (Tue, 19 Jul 2005) | 8 lines +Changed paths: + M /trunk/epan/dissectors/packet-smb.c -We used to reserve the protocol name NETLOGON for the old obsolete protocol -and since we can not have two protocols with the same name, called -the current protocol RPC_NETLOGON instead. +minor fix to add required alignment for AueryPathInfo level 0x107 -that does not exactly make sense. +it decodes "better" but might still be broken since none of the packets I have match any of the "standards" -This renames the old obsolete protocol to SMB_NETLOGON to make way and allow -the real netlogon protocol take the name NETLOGON ------------------------------------------------------------------------ -r13214 | sahlberg | 2005-01-31 03:43:07 -0600 (Mon, 31 Jan 2005) | 3 lines +r14953 | etxrab | 2005-07-19 14:47:17 -0500 (Tue, 19 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-lsa-ds.c - M /trunk/epan/dissectors/packet-dcerpc-nt.h - -call dissect_ndr_uuit_t directly and avoid a dependency on packet-dcerpc-netlogon - + M /trunk/asn1/gsmmap/packet-gsm_map-template.c +Fix an unpack_digits off by one error. ------------------------------------------------------------------------ -r13213 | sahlberg | 2005-01-30 21:31:13 -0600 (Sun, 30 Jan 2005) | 3 lines +r14954 | etxrab | 2005-07-19 14:48:02 -0500 (Tue, 19 Jul 2005) | 1 line Changed paths: - M /trunk/asn1/h248/packet-h248-template.c - M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-gsm_map.c -support H.248 BER over SCTP PPID 7 +Fix an unpack_digits off by one error. +------------------------------------------------------------------------ +r14955 | ulfl | 2005-07-19 15:06:19 -0500 (Tue, 19 Jul 2005) | 1 line +Changed paths: + M /trunk/docbook/developer-guide.xml + M /trunk/docbook/edg_src/EDG_chapter_env_intro.xml + M /trunk/docbook/edg_src/EDG_preface.xml +from Jaap Keuter: "Syncing info from User Guide into Dev Guide" +------------------------------------------------------------------------ +r14956 | ulfl | 2005-07-19 15:44:45 -0500 (Tue, 19 Jul 2005) | 1 line +Changed paths: + M /trunk/disabled_protos.c + M /trunk/doc/ethereal.pod + M /trunk/epan/addr_resolv.c + M /trunk/gtk/main.c +from Graeme Hewson: "Fixes for ethereal config files" ------------------------------------------------------------------------ -r13212 | guy | 2005-01-30 21:03:02 -0600 (Sun, 30 Jan 2005) | 2 lines +r14957 | sahlberg | 2005-07-19 15:45:17 -0500 (Tue, 19 Jul 2005) | 5 lines Changed paths: M /trunk/AUTHORS M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-redback.c - M /trunk/wiretap/libpcap.c - M /trunk/wiretap/wtap.c - M /trunk/wiretap/wtap.h + A /trunk/epan/dissectors/packet-ifcp.c + +From Aboo + +New protocol : iFCP protocol -From Florian Lohoff: Redback SmartEdge SE400/800 tcpdump disassembly. ------------------------------------------------------------------------ -r13211 | guy | 2005-01-30 18:28:02 -0600 (Sun, 30 Jan 2005) | 23 lines +r14958 | ulfl | 2005-07-19 15:46:38 -0500 (Tue, 19 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-gnutella.c - M /trunk/epan/dissectors/packet-gnutella.h + M /trunk/gtk/compat_macros.h + M /trunk/gtk/help_dlg.h + M /trunk/gtk/main.h + M /trunk/gtk/menu.h + M /trunk/gtk/recent.h -Add a URL for Gnutella specs. +fix various doxygen warnings +------------------------------------------------------------------------ +r14959 | ulfl | 2005-07-19 15:49:28 -0500 (Tue, 19 Jul 2005) | 1 line +Changed paths: + M /trunk/epan/proto.h -Don't check, in the dissectors for particular Gnutella packets, whether -the packet goes past the end of the tvbuff - let that throw an exception -so unreassembled packets are shown as such. +fix three doxygen warnings +------------------------------------------------------------------------ +r14960 | ulfl | 2005-07-19 16:05:17 -0500 (Tue, 19 Jul 2005) | 1 line +Changed paths: + M /trunk/docbook/developer-guide.xml + M /trunk/docbook/user-guide.xml -Clean up indentation. +current Ethereal version is 0.10.11 +------------------------------------------------------------------------ +r14961 | lego | 2005-07-19 16:40:12 -0500 (Tue, 19 Jul 2005) | 4 lines +Changed paths: + M /trunk/gtk/graph_analysis.c + +Avoid the selected item been white on white by making all analysis widows colored. +Fixes bug 286. -Boost GNUTELLA_MAX_SNAP_SIZE to 4096 (one Gnutella spec suggests that -packets should be < 4K), and use it to - 1) clamp the length of packets (so we don't do huge reassembly - or have problems when the total packet length, including the - header, overflows 32 bits) +------------------------------------------------------------------------ +r14962 | gerald | 2005-07-19 17:24:28 -0500 (Tue, 19 Jul 2005) | 3 lines +Changed paths: + M /trunk/epan/addr_resolv.c -and +Move Win32-specific variable declaration to the beginning of a function. +Fixes a recent buildbot failure. - 2) check the length of packets before using tcp_dissect_pdus(), - to distinguish between packets to be reassembled and a - transfer stream. +------------------------------------------------------------------------ +r14963 | ulfl | 2005-07-19 19:47:58 -0500 (Tue, 19 Jul 2005) | 3 lines +Changed paths: + M /trunk/docbook/Makefile -Pass the correct value to tcp_dissect_pdus() as the header length. +print in the first target output line also which kind of target is in the making: "EUG" or "EDG" +remove obsolete HHC setting ------------------------------------------------------------------------ -r13210 | sahlberg | 2005-01-30 17:15:10 -0600 (Sun, 30 Jan 2005) | 3 lines +r14964 | sahlberg | 2005-07-20 02:51:24 -0500 (Wed, 20 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-windows-common.c + M /trunk/epan/dissectors/packet-isakmp.c + +fix for bug 285 -add dissection of three new flags in the security descriptor +decode isakmp nat keepalive packets properly ------------------------------------------------------------------------ -r13209 | etxrab | 2005-01-30 12:00:48 -0600 (Sun, 30 Jan 2005) | 1 line +r14965 | jmayer | 2005-07-20 06:00:01 -0500 (Wed, 20 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan -Add OID:s to old dissector, for comparison reasons. +Add radius_dict.c to svn:ignore ------------------------------------------------------------------------ -r13208 | etxrab | 2005-01-30 11:48:18 -0600 (Sun, 30 Jan 2005) | 1 line +r14966 | jmayer | 2005-07-20 06:01:35 -0500 (Wed, 20 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/proto.c + M /trunk/epan/proto.h -In case of "faulty" BER tag:s return tvb = NULL +Change proto_register_protocol to use 'const char*' instead of 'char*' ------------------------------------------------------------------------ -r13207 | sahlberg | 2005-01-30 07:00:35 -0600 (Sun, 30 Jan 2005) | 9 lines +r14967 | sahlberg | 2005-07-20 06:44:57 -0500 (Wed, 20 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-lsa.c - M /trunk/epan/dissectors/packet-dcerpc-lsa.h - M /trunk/epan/dissectors/packet-dcerpc-netlogon.c + M /trunk/epan/dissectors/packet-dhcpv6.c -rename lsa_dissect_LSA_SECURITY_DESCRIPTOR to lsa_dissect_sec_desc_buf -change its signature to match the autogenerated signatures. +add proper decoding and presentation of domain strings in dhcpv6 -add a small wrapper function so tha tthe handwritten lsa can still call the -function through dissect_ndr_pointer() +this fixes bug 273 -no changes in functionality, essentially just a rename of a function and signature change +------------------------------------------------------------------------ +r14968 | jmayer | 2005-07-20 07:05:14 -0500 (Wed, 20 Jul 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-dis-enums.h +Fix: packet-dis-enums.h:248: warning: comma at end of enumerator list ------------------------------------------------------------------------ -r13206 | sahlberg | 2005-01-30 06:38:38 -0600 (Sun, 30 Jan 2005) | 6 lines +r14969 | sahlberg | 2005-07-20 07:20:56 -0500 (Wed, 20 Jul 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-lsa.c - M /trunk/epan/dissectors/packet-dcerpc-lsa.h - M /trunk/epan/dissectors/packet-dcerpc-srvsvc.c + M /trunk/epan/dissectors/packet-dhcpv6.c -rename lsa_dissect_LSA_SECURITY_DESCRIPTOR_data to lsa_dissect_sec_desc_buf_data -to make the symbol compatible with an autogenerated LSA dissector. +prettify the HW type and address printouts slightly. -no changes to the code, just a rename. ------------------------------------------------------------------------ -r13205 | sahlberg | 2005-01-30 06:21:17 -0600 (Sun, 30 Jan 2005) | 5 lines +r14970 | jmayer | 2005-07-20 10:08:29 -0500 (Wed, 20 Jul 2005) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-lsa.c - M /trunk/epan/dissectors/packet-dcerpc-lsa.h - M /trunk/epan/dissectors/packet-dcerpc-netlogon.c + M /trunk/epan/dissectors/packet-radiotap.c -rename lsa_dissect_POLICY_DNS_DOMAIN_INFO to lsa_dissect_DnsDomainInfo and change the signature slightly. -the signature change is to make it compatilbe with the signatures the idl compiler generates. +Convert the result of tvb_get_guint8 to (gint8) so that the display +as FT_INT32 shows a negative number if appropriate. +Is there a better way to solve this? +Does this problem occur in other places too? ------------------------------------------------------------------------ -r13204 | sahlberg | 2005-01-30 05:56:37 -0600 (Sun, 30 Jan 2005) | 4 lines +r14971 | gerald | 2005-07-20 15:57:04 -0500 (Wed, 20 Jul 2005) | 12 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-nt.c - M /trunk/epan/dissectors/packet-dcerpc-nt.h + M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-uma.c -add a new dissect_ndr_counted_ascii_string() that mimics dissect_ndr_counted_string() but handles an ASCII string instead of a Unicode one. +In packet-gsm_a.c: + - Make sure every function that has an "add_string" argument, make sure + it isn't NULL before we write to it. + a null "add_string". + - Use "_U_" instead of "add_string = add_string" to squelch compiler + warnings. + - Fix other compiler warnings. +In packet-uma.c, pass NULL instead of "" for the add_string argument to +de_mid(). Fixes bug 287. ------------------------------------------------------------------------ -r13203 | guy | 2005-01-29 21:43:03 -0600 (Sat, 29 Jan 2005) | 2 lines +r14972 | ulfl | 2005-07-20 17:11:48 -0500 (Wed, 20 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-nt.c - -Byte arrays are byte arrays, not strings. + M /trunk/epan/dissectors/packet-llc.c +"fix" bug #244: the implementation was correct but a bit hard to understand. I've added some small explanations, so it should be understandable somewhat better ------------------------------------------------------------------------ -r13202 | sahlberg | 2005-01-29 20:52:25 -0600 (Sat, 29 Jan 2005) | 3 lines +r14973 | jmayer | 2005-07-21 12:04:10 -0500 (Thu, 21 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-netlogon.c - M /trunk/epan/dissectors/packet-dcerpc-nt.c - M /trunk/epan/dissectors/packet-dcerpc-nt.h - -change dissect_ndr_counted_byte_array to be more consistent with dissect_ndr_counted_string - + M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/prefs.h +small warning fixes ------------------------------------------------------------------------ -r13201 | guy | 2005-01-29 17:45:53 -0600 (Sat, 29 Jan 2005) | 16 lines +r14974 | jmayer | 2005-07-21 12:17:16 -0500 (Thu, 21 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-l2tp.c + M /trunk/epan/dissectors/packet-bootp.c -Add the I-D name for L2TPv3 to a comment. +One forgotten warning fix +------------------------------------------------------------------------ +r14975 | jmayer | 2005-07-21 12:21:48 -0500 (Thu, 21 Jul 2005) | 1 line +Changed paths: + M /trunk/epan/tap.c + M /trunk/epan/tap.h -Do more, and more careful, AVP length checks. +More warining fixes: char -> const char +------------------------------------------------------------------------ +r14976 | jmayer | 2005-07-21 12:23:29 -0500 (Thu, 21 Jul 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-dhcp-failover.c -Use tvb_format_text() to display strings. +More warining fixes: char -> const char +------------------------------------------------------------------------ +r14977 | ulfl | 2005-07-21 15:05:37 -0500 (Thu, 21 Jul 2005) | 3 lines +Changed paths: + M /trunk/packaging/nsis/ethereal.nsi -Just use "col_add_fstr()" to set the Info column - there's no need to -format into a buffer and then set the column to that buffer. +Make GTK Wimp the default, so the installation type isn't always "Custom" on recent OS like 2K or XP (it will be disabled, if an "unappropriate" OS like Win98 is detected) -Make the L2TP dissector a "new-style" dissector and have it reject -packets with an unknown version number - the dissection effect is the -same if no other dissector claims the packet (it just gets displayed as -data), but this allows other dissectors to claim it. +Grouping the sections together, so getting an idea of the available sections become an easier task +------------------------------------------------------------------------ +r14978 | ulfl | 2005-07-21 15:17:52 -0500 (Thu, 21 Jul 2005) | 1 line +Changed paths: + M /trunk/packaging/nsis/ethereal.nsi -Don't use the length field if the length bit isn't set. +remove the radius dir and all it's files while uninstalling +------------------------------------------------------------------------ +r14979 | ulfl | 2005-07-21 15:32:25 -0500 (Thu, 21 Jul 2005) | 1 line +Changed paths: + M /trunk/COPYING +make the prefix "Just to avoid some misunderstandings..." a little bit more NSIS installer friendly (without making it odd looking) ------------------------------------------------------------------------ -r13200 | guy | 2005-01-29 16:21:09 -0600 (Sat, 29 Jan 2005) | 9 lines +r14980 | sahlberg | 2005-07-21 16:12:09 -0500 (Thu, 21 Jul 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-juniper.c + M /trunk/asn1/camel/packet-camel-template.c + M /trunk/asn1/cmip/cmip.cnf + M /trunk/asn1/cms/cms-exp.cnf + M /trunk/asn1/ftam/ftam.cnf + M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/asn1/inap/packet-inap-template.c + M /trunk/asn1/pkixcmp/cmp-exp.cnf + M /trunk/asn1/pkixcrmf/crmf-exp.cnf + M /trunk/asn1/tcap/tcap.cnf + M /trunk/asn1/x509af/x509af-exp.cnf + M /trunk/asn1/x509ce/x509ce-exp.cnf + M /trunk/asn1/x509if/x509if-exp.cnf + M /trunk/asn1/x509sat/x509sat-exp.cnf + M /trunk/epan/dissectors/packet-MAP_DialoguePDU.c + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-ber.h + M /trunk/epan/dissectors/packet-camel.c + M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-cmp.c + M /trunk/epan/dissectors/packet-cms.c + M /trunk/epan/dissectors/packet-crmf.c + M /trunk/epan/dissectors/packet-ess.c + M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-gsm_map.h + M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-inap.c + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-logotypecertextn.c + M /trunk/epan/dissectors/packet-mms.c + M /trunk/epan/dissectors/packet-ocsp.c + M /trunk/epan/dissectors/packet-pkinit.c + M /trunk/epan/dissectors/packet-pkix1implicit.c + M /trunk/epan/dissectors/packet-pkixqualified.c + M /trunk/epan/dissectors/packet-smrse.c + M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/dissectors/packet-x509af.c + M /trunk/epan/dissectors/packet-x509ce.c + M /trunk/epan/dissectors/packet-x509if.c + M /trunk/epan/dissectors/packet-x509sat.c + M /trunk/epan/libethereal.def + M /trunk/tools/asn2eth.py -Put the dissection of the payload at the top level. +change the symbol dissect_ber_CHOICE back into dissect_ber_choice -If the information that we used to guess the payload type is part of the -payload, don't make it correspond to the "Payload Type" protocol tree -item - it's covered by the dissected payload. -If we don't succeed in guessing the protocol type, just dissect the -payload as data. ------------------------------------------------------------------------ -r13199 | guy | 2005-01-29 14:56:20 -0600 (Sat, 29 Jan 2005) | 3 lines +r14981 | gerald | 2005-07-21 16:40:57 -0500 (Thu, 21 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-scsi.c + M /trunk/epan/tvbuff.c -Treat the command opcodes as SBC-2 for CD-ROMs as well as for block -devices. +When trying to handle gzip-compressed data, don't seek past the end of our +compressed data buffer. Fixes bug 288. ------------------------------------------------------------------------ -r13198 | guy | 2005-01-29 14:39:14 -0600 (Sat, 29 Jan 2005) | 2 lines +r14982 | sahlberg | 2005-07-21 21:00:04 -0500 (Thu, 21 Jul 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-ndr.c - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-dcerpc.h - M /trunk/epan/dissectors/packet-dcom-cba-acco.c - M /trunk/epan/dissectors/packet-dcom-oxid.c - M /trunk/epan/dissectors/packet-dcom-remact.c - M /trunk/epan/dissectors/packet-dcom.c - M /trunk/epan/dissectors/packet-dcom.h + M /trunk/epan/dissectors/packet-isakmp.c + +fix for bug 290 + +v2 exchange code 37 is "INFORMATIONAL" + -Use the 64-bit integer fetch routines to support 64-bit NDR integers. ------------------------------------------------------------------------ -r13197 | guy | 2005-01-29 14:35:42 -0600 (Sat, 29 Jan 2005) | 2 lines +r14983 | sahlberg | 2005-07-21 21:07:43 -0500 (Thu, 21 Jul 2005) | 6 lines Changed paths: - M /trunk/gtk/packet_list.c + M /trunk/epan/dissectors/packet-isakmp.c + +fix some bugs in a value string + +this fixes bug 291 + -Mark unused arguments as such. ------------------------------------------------------------------------ -r13196 | ulfl | 2005-01-29 09:38:15 -0600 (Sat, 29 Jan 2005) | 1 line +r14984 | sahlberg | 2005-07-22 02:46:58 -0500 (Fri, 22 Jul 2005) | 14 lines Changed paths: - M /trunk/docbook/Makefile - M /trunk/docbook/developer-guide.xml - A /trunk/docbook/edg_graphics/ethereal-logo.png - M /trunk/docbook/user-guide.xml + M /trunk/epan/Makefile.common + A /trunk/epan/emem.c + A /trunk/epan/emem.h + M /trunk/epan/epan.c + M /trunk/epan/to_str.c + M /trunk/gtk/main.c + M /trunk/tethereal.c + +EMEM : a simple and FAST api to allocate memory that will be automatically freed() when the next packet is dissected. + +This offesr memory allocation with a packet scope making memory leaks less likely and memory management faster. + + +Add initialization calls for both tethereal and ethereal. + +Convert the ip_to_str() function to use this and avoid doing the silly rotating buffers thing it previously did. + + +We also need an equivalent set of functions for allocation with capture file scope (free when next capture is loaded) but i dont know where to put the free_all call. + + -various versioning related things (like using the svn version number), fix a broken link in the developer-guide ------------------------------------------------------------------------ -r13195 | ulfl | 2005-01-29 08:43:33 -0600 (Sat, 29 Jan 2005) | 1 line +r14985 | jmayer | 2005-07-22 02:54:18 -0500 (Fri, 22 Jul 2005) | 1 line Changed paths: - M /trunk/docbook/eug_src/EUG_chapter_capture.xml - M /trunk/docbook/eug_src/EUG_chapter_customize.xml - M /trunk/docbook/eug_src/EUG_chapter_work.xml - M /trunk/docbook/user-guide.xml + M /trunk/epan/dissectors/packet-radiotap.c -add links to wiki example pages (Capture/Display Filters and Coloring Rules) +Beginning of radiotap's header dissection ------------------------------------------------------------------------ -r13194 | guy | 2005-01-29 04:48:16 -0600 (Sat, 29 Jan 2005) | 2 lines +r14986 | jmayer | 2005-07-22 02:55:51 -0500 (Fri, 22 Jul 2005) | 1 line Changed paths: - M /trunk/wiretap/netxray.c - -Add some notes about stuff discovered by Ken Mann. + M /trunk/epan/prefs.c + M /trunk/rdps.c + M /trunk/tools/lemon/lemon.c + M /trunk/wiretap/airopeek9.c + M /trunk/wiretap/ascend.c +More 'char*' -> 'const char*' warning fixes ------------------------------------------------------------------------ -r13193 | sahlberg | 2005-01-28 22:44:40 -0600 (Fri, 28 Jan 2005) | 3 lines +r14987 | sahlberg | 2005-07-22 03:27:20 -0500 (Fri, 22 Jul 2005) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-iscsi.c + M /trunk/epan/to_str.c + +convert all other nasty "rotating static array" from to_str.c and make them use the new emem api. -only add 4 bytes to the pdu length IFF header digest/crc32 is actually used. ------------------------------------------------------------------------ -r13192 | ulfl | 2005-01-28 20:14:25 -0600 (Fri, 28 Jan 2005) | 4 lines +r14988 | etxrab | 2005-07-22 03:55:06 -0500 (Fri, 22 Jul 2005) | 1 line Changed paths: - M /trunk/gtk/menu.c - M /trunk/gtk/packet_list.c - M /trunk/gtk/packet_list.h + M /trunk/epan/libethereal.def -Add a new menu item "View/Resize Columns" to, well, resize columns. As this might take a long time, I've provided a progress bar with the option to cancel the operation. +Add ep_init_chunk. +------------------------------------------------------------------------ +r14989 | etxrab | 2005-07-22 03:56:41 -0500 (Fri, 22 Jul 2005) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-uma.c -I might later add something like "View/Auto Resize Columns" with a checkbox menu item, so this is done everytime a capture file finished loading. However, I don't know how well this will work together with "Update list of packets in real time" while doing a capture. +Use NULL intead of "" in all calls to packet-gsm_a.c +------------------------------------------------------------------------ +r14990 | kukosa | 2005-07-22 05:38:22 -0500 (Fri, 22 Jul 2005) | 1 line +Changed paths: + M /trunk/asn1/tcap/tcap.cnf +fix for new asn2eth ------------------------------------------------------------------------ -r13191 | ulfl | 2005-01-28 17:24:04 -0600 (Fri, 28 Jan 2005) | 1 line +r14991 | etxrab | 2005-07-22 08:37:19 -0500 (Fri, 22 Jul 2005) | 1 line Changed paths: - M /trunk/plugins/mate/packet-mate.c + M /trunk/epan/dissectors/packet-bssgp.c -use MATE (not mate) for protocol name and protocol tree +From Maynard, Chris. ------------------------------------------------------------------------ -r13190 | lroland | 2005-01-28 07:53:14 -0600 (Fri, 28 Jan 2005) | 3 lines +r14992 | etxrab | 2005-07-22 10:20:57 -0500 (Fri, 22 Jul 2005) | 2 lines Changed paths: - M /trunk/plugins/mate/mate.h - M /trunk/plugins/mate/mate_runtime.c - M /trunk/plugins/mate/packet-mate.c + M /trunk/epan/dissectors/packet-dnp.c -A new patch for mate from Luis Ontanon: - - move mate_packet into packet-mate.c and remove it frome mate.h - - supressed some warnings +From Graham Bloice +updates. ------------------------------------------------------------------------ -r13189 | guy | 2005-01-28 05:31:19 -0600 (Fri, 28 Jan 2005) | 4 lines +r14993 | gerald | 2005-07-22 10:51:20 -0500 (Fri, 22 Jul 2005) | 2 lines Changed paths: - M /trunk/wiretap/AUTHORS - M /trunk/wiretap/file_access.c - M /trunk/wiretap/wtap.c - M /trunk/wiretap/wtap.h + M /trunk/epan/dissectors/packet-ldap.c -From Yoshihiro Oyama: support "-" as a file name, referring to the -standard input. Opening it for random access isn't supported; we add a -new error for that. +Fix a potential memory leak. ------------------------------------------------------------------------ -r13188 | guy | 2005-01-28 04:15:03 -0600 (Fri, 28 Jan 2005) | 3 lines +r14994 | etxrab | 2005-07-22 10:55:06 -0500 (Fri, 22 Jul 2005) | 3 lines Changed paths: - M /trunk/plugins/mate/mate.h + M /trunk/wiretap/libpcap.c + M /trunk/wiretap/wtap.c + M /trunk/wiretap/wtap.h -From Yoshihiro Oyama: get rid of _U_s in prototype declarations that -lack variable names. +From Hannes Gredler: +support for support for DLT_JUNIPER_MLPPP ------------------------------------------------------------------------ -r13187 | guy | 2005-01-28 03:55:24 -0600 (Fri, 28 Jan 2005) | 4 lines +r14995 | gerald | 2005-07-22 11:43:05 -0500 (Fri, 22 Jul 2005) | 2 lines Changed paths: - M /trunk/Makefile.am + M /trunk/NEWS + M /trunk/config.nmake + M /trunk/configure.in -From Yoshihiro Oyama: include the names of all the IrDA plugin's .o -files in the ENABLE_STATIC plugin_ldadd list. (This one was missing -from the previous checkin.) +Bump the version and add a few entries to the NEWS file. ------------------------------------------------------------------------ -r13186 | guy | 2005-01-28 03:47:52 -0600 (Fri, 28 Jan 2005) | 3 lines +r14996 | jmayer | 2005-07-22 12:55:47 -0500 (Fri, 22 Jul 2005) | 1 line Changed paths: - M /trunk/AUTHORS - M /trunk/Makefile.am + M /trunk/epan/emem.c + M /trunk/epan/emem.h -From Yoshihiro Oyama: include the names of all the IrDA plugin's .o -files in the ENABLE_STATIC plugin_ldadd list. +Set svn:keywords and svn:eol-style +------------------------------------------------------------------------ +r14997 | jmayer | 2005-07-22 12:57:40 -0500 (Fri, 22 Jul 2005) | 1 line +Changed paths: + M /trunk/epan/prefs.c + M /trunk/tools/lemon/lemon.c + M /trunk/wiretap/ascend-grammar.y + M /trunk/wiretap/ascend-int.h + M /trunk/wiretap/wtap.h +Fix some warnings (and one of my previous 'fixes') ------------------------------------------------------------------------ -r13185 | sahlberg | 2005-01-28 03:37:47 -0600 (Fri, 28 Jan 2005) | 3 lines +r14998 | sahlberg | 2005-07-22 17:45:36 -0500 (Fri, 22 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-ndr.c - M /trunk/epan/dissectors/packet-dcerpc.h + M /trunk/epan/dissectors/packet-armagetronad.c -we need a dissect_ndr_uint64() that dissects an NDR hyper +replace one tvb_memdup() with a tvb_memcpy() using an automatically freed emem buffer ------------------------------------------------------------------------ -r13184 | sahlberg | 2005-01-28 03:29:49 -0600 (Fri, 28 Jan 2005) | 9 lines +r14999 | sahlberg | 2005-07-22 17:56:08 -0500 (Fri, 22 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-browser.c - M /trunk/epan/dissectors/packet-dcerpc-lsa.c - M /trunk/epan/dissectors/packet-dcerpc-ndr.c - M /trunk/epan/dissectors/packet-dcerpc-netlogon.c - M /trunk/epan/dissectors/packet-dcerpc-samr.c - M /trunk/epan/dissectors/packet-dcerpc-srvsvc.c - M /trunk/epan/dissectors/packet-dcerpc.h - M /trunk/epan/dissectors/packet-dcom.h + M /trunk/epan/dissectors/packet-ipdc.c + +remove a redundant tvb_memdup() and fix a potential buffer overflow at the same time. -older MS DCE/RPC interfaces often use a construct that is to be treated as a 64 bit integer but in reality is a struct containing 2 32bit integers. -this construct is aligned on 4 byte boundaries in ndr and NOT -8 bytes as a real uint64 (== hyper) would be. +------------------------------------------------------------------------ +r15000 | sahlberg | 2005-07-22 18:04:52 -0500 (Fri, 22 Jul 2005) | 4 lines +Changed paths: + M /trunk/epan/dissectors/packet-mmse.c -rename the existing dissect_ndr_uint64 ro dissect_ndr_duint32 (double uint32) to make it reflect better the alignment of the type. +recode the tvb_memdup() to use emem calls. ------------------------------------------------------------------------ -r13183 | sahlberg | 2005-01-28 03:12:40 -0600 (Fri, 28 Jan 2005) | 3 lines +r15001 | etxrab | 2005-07-22 18:11:11 -0500 (Fri, 22 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-nt.h + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-ms-mms.c -add a macro for aligning NDR datastreams to 8 byte boundaries +From Martin Mathieson: +Collapsed the control and data protocols into dissector to cope with commands and data over the same TCP connection. I've also prettified things a bit and now decoded a few more command parameters. +------------------------------------------------------------------------ +r15002 | etxrab | 2005-07-22 18:12:26 -0500 (Fri, 22 Jul 2005) | 1 line +Changed paths: + D /trunk/epan/dissectors/packet-mms-control.c + D /trunk/epan/dissectors/packet-mms-data.c +No longer needed ------------------------------------------------------------------------ -r13182 | guy | 2005-01-27 05:23:06 -0600 (Thu, 27 Jan 2005) | 3 lines +r15003 | sahlberg | 2005-07-22 18:33:12 -0500 (Fri, 22 Jul 2005) | 5 lines Changed paths: - M /trunk/gtk/file_dlg.c + M /trunk/epan/dissectors/packet-rpc.c + +recode tvb_memdup() into more efficient emem fucntions. +Now that we dont have to free() the memory explicitely we got rid of a few unnessecary g_strdup() as well. + -We use the range utilities regardless of whether we're built with -libpcap or not. ------------------------------------------------------------------------ -r13181 | guy | 2005-01-27 04:47:27 -0600 (Thu, 27 Jan 2005) | 2 lines +r15004 | sahlberg | 2005-07-22 18:38:51 -0500 (Fri, 22 Jul 2005) | 2 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/epan/emem.c -Fix a problem with building with libpcap disabled. +include stdlib instead of malloc.h ------------------------------------------------------------------------ -r13180 | ulfl | 2005-01-26 17:17:00 -0600 (Wed, 26 Jan 2005) | 2 lines +r15005 | sahlberg | 2005-07-22 19:22:02 -0500 (Fri, 22 Jul 2005) | 6 lines Changed paths: - M /trunk/epan/proto.c + M /trunk/epan/dissectors/packet-hclnfsd.c + M /trunk/epan/dissectors/packet-mount.c + M /trunk/epan/dissectors/packet-nfs.c + M /trunk/epan/dissectors/packet-pcnfsd.c + M /trunk/epan/dissectors/packet-ypserv.c + +we no longer need to g_free() teh string returned by dissect_rpc_string. + +when checking the calls in packet-ndmp.c we must have had a memleak there since it never freed those strings. + + -add another REPORT_DISSECTOR_BUG() call, if tfi->tree_type is existing and not in valid range. -Question remains: Is it safe to continue in that case? ------------------------------------------------------------------------ -r13179 | ulfl | 2005-01-26 17:14:54 -0600 (Wed, 26 Jan 2005) | 1 line +r15006 | sahlberg | 2005-07-22 19:42:31 -0500 (Fri, 22 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-icq.c + M /trunk/AUTHORS + +add back two entries that must have been removed by mistake + -if there must be an unknown version message, use hex instead of decimal to print the unknown version number ------------------------------------------------------------------------ -r13178 | ulfl | 2005-01-26 17:13:36 -0600 (Wed, 26 Jan 2005) | 1 line +r15007 | sahlberg | 2005-07-22 19:46:14 -0500 (Fri, 22 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-rtsp.c + M /trunk/epan/dissectors/packet-ip.c + +ICMP MPLS updates and a new preference option from +Brice Augustin and Maria-Luiza + + -if there must be an "unknown transport" message, at least print the transport name ------------------------------------------------------------------------ -r13177 | ulfl | 2005-01-26 16:37:04 -0600 (Wed, 26 Jan 2005) | 3 lines +r15008 | lego | 2005-07-22 21:07:02 -0500 (Fri, 22 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-daap.c + M /trunk/epan/dissectors/packet-wsp.c + +avoid a crash when tree is null -bugfix of crash_00001_20050124142515.cap: dissector packet-daap.c displayed [Dissector Bug] as it dissected a length field and used it without checking it first. -use tvb_ensure_bytes_exist() before using this length value, so [Malformed Packet] will be displayed ------------------------------------------------------------------------ -r13176 | ulfl | 2005-01-26 16:24:42 -0600 (Wed, 26 Jan 2005) | 3 lines +r15009 | jmayer | 2005-07-23 01:19:08 -0500 (Sat, 23 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-etheric.c + M /trunk/epan/ftypes/ftypes.h -bugfix of crash_00026_20050124150108.cap: three places with possible write behind the end of fixed arrays +Fix lots of warnings of type: +ftypes.c:257: warning: passing argument 1 of 'logfunc' discards + qualifiers from pointer target type +by changing 'char*' -> 'const char*' -used g_malloc instead of a fixed array ------------------------------------------------------------------------ -r13175 | etxrab | 2005-01-26 14:07:35 -0600 (Wed, 26 Jan 2005) | 1 line +r15010 | jmayer | 2005-07-23 01:21:17 -0500 (Sat, 23 Jul 2005) | 6 lines Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/ftypes/ftype-bytes.c + M /trunk/epan/ftypes/ftypes-int.h + M /trunk/epan/ftypes/ftypes.c + +Move declaration of void ftype_register_* to ftypes-int.h. + +This fixes some warnings like +ftype-bytes.c:52: warning: no previous declaration for 'bytes_fvalue_free' + -Unpack and display digits, Decode SS-status. ------------------------------------------------------------------------ -r13174 | etxrab | 2005-01-26 14:06:09 -0600 (Wed, 26 Jan 2005) | 1 line +r15011 | jmayer | 2005-07-23 01:49:07 -0500 (Sat, 23 Jul 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dfilter/syntax-tree.c + M /trunk/epan/dfilter/syntax-tree.h + +Move declaration of sttype_register_* functions from +syntax-tree.c to syntax-tree.h. + +This fixes some warning of type +sttype-integer.c:33: warning: no previous declaration for + 'sttype_register_integer' + -Fix a typo leading to no conversation set up for RTCP ------------------------------------------------------------------------ -r13173 | etxrab | 2005-01-26 14:05:26 -0600 (Wed, 26 Jan 2005) | 1 line +r15012 | jmayer | 2005-07-23 01:51:57 -0500 (Sat, 23 Jul 2005) | 4 lines Changed paths: - M /trunk/asn1/h245/h245.cnf + M /trunk/epan/dfilter/gencode.c + M /trunk/epan/dfilter/semcheck.c + +Add includes to fix warnings of type +gencode.c:383: warning: no previous declaration for + 'dfw_interesting_fields' -Fix a typo leading to no conversation set up for RTCP ------------------------------------------------------------------------ -r13172 | guy | 2005-01-25 14:53:27 -0600 (Tue, 25 Jan 2005) | 2 lines +r15013 | jmayer | 2005-07-23 01:53:59 -0500 (Sat, 23 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-text-media.c + M /trunk/epan/dfilter/dfilter-int.h + M /trunk/epan/dfilter/dfilter.c + +Some more 'char*' -> 'const char*' changes -Add "applications/soap+xml" as a text media type. ------------------------------------------------------------------------ -r13171 | etxrab | 2005-01-24 16:33:36 -0600 (Mon, 24 Jan 2005) | 1 line +r15014 | jmayer | 2005-07-23 03:18:44 -0500 (Sat, 23 Jul 2005) | 1 line Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/plugins/asn1/packet-asn1.c -Add calling of sms dissector and make ssn number selection preferences. +'char*' -> 'const char*' to fix warnings ------------------------------------------------------------------------ -r13170 | etxrab | 2005-01-24 14:41:19 -0600 (Mon, 24 Jan 2005) | 1 line +r15015 | jmayer | 2005-07-23 06:41:25 -0500 (Sat, 23 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/clopts_common.c + M /trunk/clopts_common.h + M /trunk/disabled_protos.c + M /trunk/epan/addr_resolv.c + M /trunk/epan/asn1.c + M /trunk/epan/asn1.h + M /trunk/epan/column.c + M /trunk/epan/column.h + M /trunk/epan/dissectors/packet-dcerpc.h + M /trunk/epan/dissectors/packet-giop.c + M /trunk/epan/dissectors/packet-giop.h + M /trunk/epan/filesystem.c + M /trunk/epan/filesystem.h + M /trunk/epan/packet.c + M /trunk/epan/packet.h + M /trunk/epan/packet_info.h + M /trunk/epan/prefs.c + M /trunk/epan/prefs.h + M /trunk/epan/proto.c + M /trunk/epan/proto.h + M /trunk/epan/stats_tree.c + M /trunk/epan/stats_tree.h + M /trunk/epan/tap.c + M /trunk/epan/tap.h + M /trunk/epan/to_str.c + M /trunk/epan/xdlc.c + M /trunk/plugins/gryphon/packet-gryphon.c + M /trunk/plugins/gryphon/packet-gryphon.h + M /trunk/plugins/irda/irda-appl.h + M /trunk/plugins/mate/mate.h + M /trunk/plugins/mate/mate_grammar.lemon + M /trunk/plugins/mate/mate_parser.l + M /trunk/plugins/mate/mate_setup.c + M /trunk/plugins/mate/mate_util.c + M /trunk/plugins/mate/mate_util.h + M /trunk/plugins/mate/packet-mate.c + M /trunk/plugins/mgcp/packet-mgcp.c + M /trunk/plugins/opsi/packet-opsi.h + M /trunk/plugins/profinet/packet-pn-dcp.c + M /trunk/plugins/rlm/packet-rlm.c + M /trunk/print.c + M /trunk/randpkt.c + M /trunk/tap-iousers.c + M /trunk/tethereal.c + M /trunk/text2pcap.c + M /trunk/tools/lemon/lempar.c + +More 'char*' -> 'const char*' changes to fix warnings. -Make the sub system number (ssn) settings preferences. ------------------------------------------------------------------------ -r13169 | ulfl | 2005-01-24 13:33:47 -0600 (Mon, 24 Jan 2005) | 3 lines +r15016 | ulfl | 2005-07-23 15:34:43 -0500 (Sat, 23 Jul 2005) | 12 lines Changed paths: - M /trunk/gtk/main.h - M /trunk/gtk/menu.c - M /trunk/gtk/print_dlg.c + A /trunk/packaging/nsis/AdditionalTasksPage.ini + M /trunk/packaging/nsis/Makefile.am + M /trunk/packaging/nsis/Makefile.nmake + A /trunk/packaging/nsis/WinPcapPage.ini + A /trunk/packaging/nsis/WinPcap_3_0.exe + M /trunk/packaging/nsis/ethereal.nsi + A /trunk/packaging/nsis/servicelib.nsh + -if context menu item "Print" is clicked from the packet list context menu, it should use the selected range setting as default. As we currently have only one packet selectable, this will print only this one. +Installer: +- Installer now includes and installs WinPcap 3.0 (with detection) +- Install Sections are grouped now +- New Seperate page to select additional tasks like: icons, file extensions ... +- New Seperate page for WinPcap detection/installation +- Start WinPcap "NPF" service doesn't require a reboot -If we would allow selecting multiple packets in the packet list in the future, this option would print all selected packets. +Uninstaller: +- New Uninstall sections page (uninstall, settings, plugins, WinPcap) +- If uninstallation selected, plugins will now be completely uninstalled (all versions, not only the current one) +- If selected, uninstallation of WinPcap ------------------------------------------------------------------------ -r13168 | ulfl | 2005-01-24 13:30:07 -0600 (Mon, 24 Jan 2005) | 1 line +r15017 | ulfl | 2005-07-23 15:37:00 -0500 (Sat, 23 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dcom-remact.c - M /trunk/epan/dissectors/packet-dcom-remunkn.c + M /trunk/packaging/nsis/ethereal.nsi -the methods from these interfaces were missing the DCOM this/that header and therefore were missdissected +... I should switch compression back on, the installer would otherwise become a bit large ... ------------------------------------------------------------------------ -r13167 | etxrab | 2005-01-24 13:26:04 -0600 (Mon, 24 Jan 2005) | 1 line +r15018 | lego | 2005-07-23 19:29:57 -0500 (Sat, 23 Jul 2005) | 8 lines Changed paths: - M /trunk/AUTHORS + M /trunk/epan/emem.c + M /trunk/epan/emem.h + +add some utility functions that use ep_alloc instead of g_malloc. + +ep_memdup +ep_strdup +ep_strndup +ep_strdup_printf + -Add Mutsuya Irie ------------------------------------------------------------------------ -r13166 | etxrab | 2005-01-24 13:25:28 -0600 (Mon, 24 Jan 2005) | 1 line +r15019 | lego | 2005-07-23 20:21:38 -0500 (Sat, 23 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/sigcomp_state_hdlr.c + M /trunk/epan/emem.c + +I believe we should use DISSECTOR_ASSERT instead of g_assert. + +fix and clean g_strdup_printf() + -Bugfix incorect while condition from Mutsuya Irie ------------------------------------------------------------------------ -r13165 | guy | 2005-01-23 19:20:14 -0600 (Sun, 23 Jan 2005) | 3 lines +r15020 | lego | 2005-07-23 20:31:59 -0500 (Sat, 23 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-gnutella.c + M /trunk/gtk/Makefile.common + D /trunk/gtk/http_stat.c + +remove the old http packet count tap as it has been superceeded by the new stats tree tap -Add support for reassembly of Gnutella packets that cross TCP segment -boundaries. ------------------------------------------------------------------------ -r13164 | guy | 2005-01-23 18:18:13 -0600 (Sun, 23 Jan 2005) | 3 lines +r15021 | lego | 2005-07-23 20:39:04 -0500 (Sat, 23 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-tcp.c + M /trunk/plugins/stats_tree/Makefile.am + M /trunk/plugins/stats_tree/Makefile.nmake + D /trunk/plugins/stats_tree/http_stats_tree.c + M /trunk/plugins/stats_tree/stats_tree_plugin.c + +http_stats_tree is moving to a new home (packet-http.c) -Get rid of an extra space after the edge value of a SACK item if -relative sequence numbers aren't being used. ------------------------------------------------------------------------ -r13163 | ulfl | 2005-01-22 15:46:35 -0600 (Sat, 22 Jan 2005) | 1 line +r15022 | lego | 2005-07-23 20:42:41 -0500 (Sat, 23 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/libethereal.def + M /trunk/epan/dissectors/packet-http.c + +move the stats_tree tap into the http dissector (not anymore in the plugin) + +change several calls to g_memdup into ep_strndup, fix the free calls + -Some dcerpc related stuff needed to write dcerpc plugin ------------------------------------------------------------------------ -r13162 | sahlberg | 2005-01-22 13:56:12 -0600 (Sat, 22 Jan 2005) | 3 lines +r15023 | lego | 2005-07-23 20:48:01 -0500 (Sat, 23 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-nt.h + M /trunk/gtk/graph_analysis.c + +From Alejandro Vaquero: -needs an ALIGN_TO_2_BYTES to make the idl compiler happy +fix a crash when graphing packets whose src and dst is the same address ------------------------------------------------------------------------ -r13161 | ulfl | 2005-01-21 19:03:21 -0600 (Fri, 21 Jan 2005) | 1 line +r15024 | sahlberg | 2005-07-23 20:56:01 -0500 (Sat, 23 Jul 2005) | 6 lines Changed paths: - M /trunk/gtk/menu.c + M /trunk/epan/tvbuff.c + M /trunk/epan/tvbuff.h + +add +ep_tvb_get_string +that acts the same as tvb_get_string but the buffer returned need not be freed. + + -first proposal: try to rearrange context menus to be more context relevant ------------------------------------------------------------------------ -r13160 | etxrab | 2005-01-21 16:49:13 -0600 (Fri, 21 Jan 2005) | 1 line +r15025 | lego | 2005-07-23 21:12:33 -0500 (Sat, 23 Jul 2005) | 3 lines Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/gtk/Makefile.common + D /trunk/gtk/isup_stat.c + +Remove the isup messages tap as it's been superceeded by the stats_tree one + -Fix of asn1 code for one opcode to new spec used? ------------------------------------------------------------------------ -r13159 | etxrab | 2005-01-21 16:46:14 -0600 (Fri, 21 Jan 2005) | 1 line +r15026 | lego | 2005-07-23 21:43:20 -0500 (Sat, 23 Jul 2005) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-h450.c - M /trunk/epan/dissectors/packet-h450.h + M /trunk/epan/dissectors/packet-http.c + +Replace two calls to tvb_get_string with the new ep_tvb_get_string (this fixes a leak I introdduced at the last checkin) + +remove the stat_infos PtrArray as we do not need to free our tap data anymore, YEAH! + -Handle some more op codes. ------------------------------------------------------------------------ -r13158 | etxrab | 2005-01-21 16:45:20 -0600 (Fri, 21 Jan 2005) | 1 line +r15027 | sahlberg | 2005-07-23 21:43:41 -0500 (Sat, 23 Jul 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-3g-a11.c + M /trunk/epan/dissectors/packet-afp.c + M /trunk/epan/dissectors/packet-aim-messaging.c + M /trunk/epan/dissectors/packet-aim.c + M /trunk/epan/dissectors/packet-ansi_a.c + M /trunk/epan/dissectors/packet-atalk.c + M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-dsi.c + M /trunk/epan/dissectors/packet-fix.c + M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/dissectors/packet-icep.c + +convert some uses of tvb_get_string() to ep_tvb_get_string() + +there was at least one obvious memleak in one of the uses of tvb_get_string() + + -Fixed bugs with conversations and t35 ------------------------------------------------------------------------ -r13157 | etxrab | 2005-01-21 16:44:14 -0600 (Fri, 21 Jan 2005) | 1 line +r15028 | lego | 2005-07-23 21:53:09 -0500 (Sat, 23 Jul 2005) | 6 lines Changed paths: - M /trunk/asn1/h450/h450.cnf - M /trunk/asn1/h450/h4501.asn - M /trunk/asn1/h450/packet-h450-template.c + M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-radius.h + +- change the report_failure dialog for a less painful g_warning +- use ep_alloc for reassemling eap fragments instead of a static buffer +- use ep_strdup_printf() instead of a static buffe to return the cosine's VP/VC AVP label +- add few TODO comments + -asn1 done for h450.1 - h450.12, remains to tie to Operations and Responses. ------------------------------------------------------------------------ -r13156 | etxrab | 2005-01-21 16:42:32 -0600 (Fri, 21 Jan 2005) | 1 line +r15029 | lego | 2005-07-23 21:56:41 -0500 (Sat, 23 Jul 2005) | 2 lines Changed paths: - M /trunk/asn1/h245/h245.cnf - M /trunk/asn1/h245/packet-h245-template.c + M /trunk/epan/dissectors/packet-actrace.c + +change g_strdup() calls with ep_strdup calls (fixing a significant leakage of tap data) -Fix buggs with conversations not beeing set up in some cases. Decoding of t35 ------------------------------------------------------------------------ -r13155 | lroland | 2005-01-21 13:16:05 -0600 (Fri, 21 Jan 2005) | 2 lines +r15030 | lego | 2005-07-23 21:59:17 -0500 (Sat, 23 Jul 2005) | 3 lines Changed paths: - M /trunk/packaging/nsis/Makefile.nmake - M /trunk/packaging/nsis/ethereal.nsi + M /trunk/epan/dissectors/packet-alcap.c + +use ep_alloc instead of statically allocated buffers + -Add mate.dll to the installer. -However it won't be installed by default. ------------------------------------------------------------------------ -r13154 | lroland | 2005-01-21 13:11:59 -0600 (Fri, 21 Jan 2005) | 3 lines +r15031 | sahlberg | 2005-07-23 22:01:41 -0500 (Sat, 23 Jul 2005) | 6 lines Changed paths: - M /trunk/plugins/mate/mate.h - M /trunk/plugins/mate/mate_runtime.c - M /trunk/plugins/mate/mate_setup.c - M /trunk/plugins/mate/mate_util.c + M /trunk/epan/dissectors/packet-msrp.c + M /trunk/epan/dissectors/packet-pagp.c + M /trunk/epan/dissectors/packet-q931.c + M /trunk/epan/dissectors/packet-quake2.c + M /trunk/epan/dissectors/packet-rsvp.c + M /trunk/epan/dissectors/packet-rtcp.c + M /trunk/epan/dissectors/packet-rtsp.c + +some more dissectors converted to ep_tvb_get_string + +again at least one obvious memleak was found in the old code + + -From Luis Ontanon for Mate: -- supress some solaris compiler warnings -- adds GopExpiration, GopIdleTimeout and GopLifetime parameters ------------------------------------------------------------------------ -r13153 | lroland | 2005-01-21 12:50:12 -0600 (Fri, 21 Jan 2005) | 2 lines +r15032 | lego | 2005-07-23 22:05:08 -0500 (Sat, 23 Jul 2005) | 3 lines Changed paths: - M /trunk/config.nmake + M /trunk/epan/dissectors/packet-isup.c + +fix a leak of tap info data by replacing g_strdup with ep_strdup + -Another step towards getting the old plugin API retired: -Official plugins get linked with libethereal.dll's import library by default now. ------------------------------------------------------------------------ -r13152 | ulfl | 2005-01-20 17:17:23 -0600 (Thu, 20 Jan 2005) | 1 line +r15033 | lego | 2005-07-23 22:36:21 -0500 (Sat, 23 Jul 2005) | 3 lines Changed paths: - M /trunk/gtk/capture_dlg.c - M /trunk/gtk/capture_if_dlg.c - M /trunk/gtk/color_dlg.c - M /trunk/gtk/conversations_table.c - M /trunk/gtk/decode_as_dlg.c - M /trunk/gtk/filter_dlg.c - M /trunk/gtk/find_dlg.c - M /trunk/gtk/goto_dlg.c - M /trunk/gtk/help_dlg.c - M /trunk/gtk/help_dlg.h - M /trunk/gtk/hostlist_table.c - M /trunk/gtk/io_stat.c - M /trunk/gtk/menu.c - M /trunk/gtk/print_dlg.c - M /trunk/gtk/proto_dlg.c - M /trunk/gtk/proto_hier_stats_dlg.c - M /trunk/gtk/summary_dlg.c - M /trunk/gtk/toolbar.c - M /trunk/gtk/webbrowser.c + M /trunk/epan/Makefile.am + M /trunk/epan/Makefile.nmake + A /trunk/epan/enterprise-numbers + A /trunk/epan/make-sminmpec.pl + D /trunk/epan/sminmpec.c + +Autogenerate the sminmpec.c file from iana's enterprise-numbers file + -add some more online help functionality and help buttons at various dialog boxes, if a help page *is* available. However, the new help system needs a lot more work before completed. ------------------------------------------------------------------------ -r13149 | ulfl | 2005-01-20 13:26:24 -0600 (Thu, 20 Jan 2005) | 1 line +r15034 | sahlberg | 2005-07-23 23:24:30 -0500 (Sat, 23 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-mq.c + M /trunk/epan/dissectors/packet-sdp.c + M /trunk/epan/dissectors/packet-slsk.c + M /trunk/epan/dissectors/packet-tacacs.c + M /trunk/epan/dissectors/packet-ucp.c + M /trunk/epan/dissectors/packet-uma.c + +some more ep_tvb_get_string updates + -use col_set_fence for COL_INFO, if multiple DCE/RPC requests/responses are in one (TCP)PDU. I've used " # " as the delimiter string, BTW: do we have an "official" one yet? ------------------------------------------------------------------------ -r13148 | guy | 2005-01-20 12:34:48 -0600 (Thu, 20 Jan 2005) | 2 lines +r15035 | guy | 2005-07-24 05:32:22 -0500 (Sun, 24 Jul 2005) | 9 lines Changed paths: - M /trunk/AUTHORS + M /trunk/plugins/stats_tree/Makefile.am + M /trunk/plugins/stats_tree/pinfo_stats_tree.c + A /trunk/plugins/stats_tree/pinfo_stats_tree.h + M /trunk/plugins/stats_tree/stats_tree_plugin.c -Fix Julien Leproust's e-mail address. +Add "pinfo_stats_tree.h" to declare "register_pinfo_stat_trees()", and +include it in "pinfo_stats_tree.c" (which defines it) and +"stats_tree_plugin.c" (which refers to it). + +Make all the other routines defined in "pinfo_stats_tree.c" static, as +they're not used outside "pinfo_stats_tree.c". + +Get rid of declaration of unused "register_http_stat_trees()". ------------------------------------------------------------------------ -r13141 | sahlberg | 2005-01-20 07:19:11 -0600 (Thu, 20 Jan 2005) | 3 lines +r15036 | lego | 2005-07-24 05:32:37 -0500 (Sun, 24 Jul 2005) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-sndcp.c -SACK prettyfication +register the dissector by name ------------------------------------------------------------------------ -r13140 | sahlberg | 2005-01-20 06:29:11 -0600 (Thu, 20 Jan 2005) | 3 lines +r15037 | guy | 2005-07-24 06:14:13 -0500 (Sun, 24 Jul 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-tcp.c + M /trunk/plugins/asn1/packet-asn1.c -make TCP SACK option handle relative sequence numbers +Register the port range preferences as such, rather than doing our own +range implementation. +Make string preferences "const", to squelch compiler warnings, and make +other variables and arguments "const" to match. + +Port numbers are unsigned; display them as such. ------------------------------------------------------------------------ -r13139 | kukosa | 2005-01-20 06:16:53 -0600 (Thu, 20 Jan 2005) | 2 lines +r15038 | jmayer | 2005-07-24 06:35:41 -0500 (Sun, 24 Jul 2005) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-ieee80211.c + +Lars Ruoff: + Use correct offsets to decode bssid in all cases: + Depending on the packet type the header contains + up to 4 addresses but may contain less. The position/ + definition of the bssid changes as a result of this. -NonStandardData and TunnelledProtocol reimplemented and tested -H225 dissector regenerated with new asn2eth version ------------------------------------------------------------------------ -r13138 | kukosa | 2005-01-20 06:02:08 -0600 (Thu, 20 Jan 2005) | 1 line +r15039 | ulfl | 2005-07-24 08:54:19 -0500 (Sun, 24 Jul 2005) | 1 line Changed paths: - M /trunk/asn1/h225/h225.cnf - M /trunk/asn1/h225/packet-h225-template.c + M /trunk/Makefile.nmake -NonStandardData and TunnelledProtocol reimplemented and tested +Update to zlib 1.2.3 ------------------------------------------------------------------------ -r13137 | kukosa | 2005-01-20 05:56:33 -0600 (Thu, 20 Jan 2005) | 1 line +r15040 | ulfl | 2005-07-24 09:16:54 -0500 (Sun, 24 Jul 2005) | 1 line Changed paths: - M /trunk/tools/asn2eth.py + M /trunk/NEWS + M /trunk/tools/win32-setup.sh -Fix bug in SEQUENCE/SET OF handling +Update to zlib 1.2.3 ------------------------------------------------------------------------ -r13136 | guy | 2005-01-20 05:35:45 -0600 (Thu, 20 Jan 2005) | 2 lines +r15041 | ulfl | 2005-07-24 09:35:12 -0500 (Sun, 24 Jul 2005) | 1 line Changed paths: - M /trunk/epan/packet.c + M /trunk/doc/ethereal.pod + M /trunk/doc/tethereal.pod -Squelch a compiler warning. +from Graeme Hewson: "Fixes for ethereal config files" +------------------------------------------------------------------------ +r15042 | guy | 2005-07-24 12:48:10 -0500 (Sun, 24 Jul 2005) | 7 lines +Changed paths: + M /trunk/epan/reassemble.c + +"fragment_add_common()" isn't used outside this file - make it static. + +Move to "show_fragment()" the code to append the fragment information to +the top-level item. + +Fix indentation. ------------------------------------------------------------------------ -r13135 | guy | 2005-01-20 05:05:06 -0600 (Thu, 20 Jan 2005) | 6 lines +r15043 | guy | 2005-07-24 14:01:28 -0500 (Sun, 24 Jul 2005) | 9 lines Changed paths: - M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-aim.h + M /trunk/epan/dissectors/packet-dcerpc-epm.c + M /trunk/epan/dissectors/packet-dcerpc-samr.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-dcerpc.h + M /trunk/epan/dissectors/packet-dcom.c + M /trunk/epan/dissectors/packet-dcom.h + M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-giop.h + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-k12.c + M /trunk/epan/dissectors/packet-ntlmssp.c + M /trunk/epan/dissectors/packet-portmap.c + M /trunk/epan/dissectors/packet-pres.c + M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-rpc.h + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/packet-tacacs.c + M /trunk/epan/dissectors/packet-tzsp.c + M /trunk/epan/dissectors/packet-user_encap.c M /trunk/epan/packet.c + M /trunk/epan/packet.h + M /trunk/epan/prefs-int.h + M /trunk/epan/prefs.c + M /trunk/epan/proto.c + M /trunk/epan/proto.h + M /trunk/gtk/dcerpc_stat.c + M /trunk/gtk/decode_as_dcerpc.h + M /trunk/gtk/decode_as_dlg.c + M /trunk/gtk/dfilter_expr_dlg.c + M /trunk/gtk/prefs_dlg.c + M /trunk/gtk/proto_dlg.c + M /trunk/gtk/rpc_stat.c + M /trunk/gtk/supported_protos_dlg.c + M /trunk/tap-dcerpcstat.c + M /trunk/tap-rpcstat.c + M /trunk/tethereal.c -From Julien Leproust: add heuristic dissectors' protocol names to the -layers string. +Constify to remove a bunch of warnings. Add some casts to squelch +(presumably-)harmless-but-otherwise-unremovable const-to-nonconst +warnings. -Remove protocol names from the layer names string if the dissector -rejects the frame. +In the TACACS dissector, clean up the variables used in option parsing +to avoid some const-to-nonconst warnings. + +Clean up some white space. ------------------------------------------------------------------------ -r13134 | guy | 2005-01-20 03:44:29 -0600 (Thu, 20 Jan 2005) | 5 lines +r15044 | tuexen | 2005-07-24 14:58:05 -0500 (Sun, 24 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dnp.c + M /trunk/epan/dissectors/packet-sctp.c -Free the chunk of reassembled DNP data iff there was a CRC error; -otherwise, we're using it in a tvbuff and shouldn't free it (even if the -next level of reassembly isn't complete, so that al_tvb is ultimately -null). +Fix a typo. ------------------------------------------------------------------------ -r13133 | guy | 2005-01-20 01:58:23 -0600 (Thu, 20 Jan 2005) | 2 lines +r15045 | guy | 2005-07-24 15:10:05 -0500 (Sun, 24 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan -Squelch some compiler warnings. +sminmpec.c is now a generated file, so add it to the ignore list. ------------------------------------------------------------------------ -r13132 | guy | 2005-01-20 01:02:08 -0600 (Thu, 20 Jan 2005) | 7 lines +r15046 | guy | 2005-07-24 15:39:19 -0500 (Sun, 24 Jul 2005) | 39 lines Changed paths: - M /trunk/epan/dissectors/packet-juniper.c + M /trunk/epan/dissectors/packet-eap.c + M /trunk/epan/dissectors/packet-radius.c + +Fix some typoes. + +Call "dissect_attribute_value_pairs()" regardless of whether we're +building a protocol tree, so the EAP subdissector is always called. + +"dissect_attribute_value_pairs()" is only called when the length of AVPs +in the packet is non-zero; don't bother checking for a zero length. + +Don't put two items in for each AVP - one is sufficient. -Make some routines static that aren't used outside this module. +Add some more length checks when processing AVPs. Don't require AVPs to +be at least 3 bytes long - they might have just a type and length; let +an exception be thrown if that's a problem. -Use "guint16" instead of "u_int16_t", "guint8" instead of "u_int8_t", -and "guint" instead of "u_int", to handle platforms lacking the latter -types. Make "ppp_heuristic_guess()" reeturn a Boolean, as it just -returns a "yes or no" answer. +Don't require that the entire AVP be available in the tvbuff before +processing it; let an exception be thrown as we're processing the AVP if +we don't have all the data, so the stuff before the end is processed. + +Give the tvbuff for the AVP data a length that reflects the length of +data left in the tvbuff, so that the appropriate exception is thrown if +the packet was cut short by a snapshot length. + +Don't have a fixed-length buffer for reassembled EAP messages; grow it +as necessary. + +Don't special-case the initial part of the processing of EAP messages; +put in the standard length item, as well as, for fragments, an item for +the fragment data. + +Check for non-consecutive EAP-Message attributes. + +Set the columns non-writable while dissecting the EAP message, so +Protocol and Info reflect the RADIUS packet. + +Doing the reassembly by gluing together all the consecutive EAP-Message +attributes means we don't need help from the EAP dissector, returning +the total length of the EAP message. Get rid of the no-longer-needed +eap_fragment dissector; just call the regular EAP dissector. ------------------------------------------------------------------------ -r13131 | guy | 2005-01-20 00:22:20 -0600 (Thu, 20 Jan 2005) | 3 lines +r15047 | gerald | 2005-07-24 16:02:40 -0500 (Sun, 24 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h + M /trunk/plugins/megaco/packet-megaco.c -Back out the asn2eth-generated GSM MAP dissector for now, at Anders -Broman's request, as it has a number of problems. +Break out of another infinite loop. Fixes bug 293. ------------------------------------------------------------------------ -r13130 | guy | 2005-01-19 23:40:56 -0600 (Wed, 19 Jan 2005) | 2 lines +r15048 | ulfl | 2005-07-24 16:23:10 -0500 (Sun, 24 Jul 2005) | 3 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-ip.c - M /trunk/epan/dissectors/packet-ipv6.c - A /trunk/epan/dissectors/packet-juniper.c - M /trunk/epan/dissectors/packet-osi.c - M /trunk/epan/dissectors/packet-ppp.c - M /trunk/wiretap/libpcap.c - M /trunk/wiretap/wtap.c - M /trunk/wiretap/wtap.h + M /trunk/plugins/stats_tree/Makefile.nmake + M /trunk/plugins/stats_tree/pinfo_stats_tree.c -From Hannes Gredler: support for Juniper's DLT_JUNIPER_ATM{1,2} values. +include pinfo_stats_tree.c in the build process, so MSVC compiles again +don't use extern before a function body, that don't make sense ------------------------------------------------------------------------ -r13129 | guy | 2005-01-19 23:06:38 -0600 (Wed, 19 Jan 2005) | 3 lines +r15049 | ulfl | 2005-07-24 16:25:29 -0500 (Sun, 24 Jul 2005) | 1 line Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-dcerpc-pnp.c - A /trunk/epan/dissectors/packet-dcerpc-pnp.h - A /trunk/epan/dissectors/packet-dcerpc-rras.c - A /trunk/epan/dissectors/packet-dcerpc-rras.h + M /trunk/packaging/nsis/ethereal.nsi -From Jean-Baptiste Marchand: stub dissectors for rras and pnp MSRPC -interfaces. +make the default to not use the /SOLID switch for SetCompressor, so buildbot is working again +------------------------------------------------------------------------ +r15050 | guy | 2005-07-24 17:01:14 -0500 (Sun, 24 Jul 2005) | 2 lines +Changed paths: + M /trunk/epan/reassemble.c + +Fix indentation. ------------------------------------------------------------------------ -r13128 | guy | 2005-01-19 22:37:03 -0600 (Wed, 19 Jan 2005) | 4 lines +r15051 | ulfl | 2005-07-24 20:22:03 -0500 (Sun, 24 Jul 2005) | 3 lines Changed paths: M /trunk/epan/dissectors/packet-http.c - M /trunk/epan/dissectors/packet-rtsp.c - M /trunk/epan/req_resp_hdrs.c - M /trunk/epan/req_resp_hdrs.h - -There's no guaranteee that "req_resp_hdrs_do_reassembly()" gets called -only at the beginning of a tvbuff, so it needs an argument that's the -starting offset in the tvbuff. + M /trunk/epan/dissectors/packet-kink.c +packet-http.c(484) : warning C4101: 'i' : unreferenced local variable +packet-http.c(486) : warning C4101: 'si' : unreferenced local variable +packet-kink.c(628) : warning C4101: 'quick_mode_payloads_length' : unreferenced local variable ------------------------------------------------------------------------ -r13127 | guy | 2005-01-19 19:26:34 -0600 (Wed, 19 Jan 2005) | 3 lines +r15052 | ulfl | 2005-07-25 02:42:06 -0500 (Mon, 25 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-multipart.c + M /trunk/packaging/nsis/ethereal.nsi -From Ruud Linders: support short names in multipart headers; SIP-T -requires this. +as the buildbot is updated now: +using the /SOLID switch in SetCompressor again, making NSIS at least 2.07 a requirement +------------------------------------------------------------------------ +r15053 | ulfl | 2005-07-25 02:50:11 -0500 (Mon, 25 Jul 2005) | 1 line +Changed paths: + M /trunk/README.win32 +add a section about the Developer's Guide ------------------------------------------------------------------------ -r13126 | ulfl | 2005-01-19 17:41:07 -0600 (Wed, 19 Jan 2005) | 1 line +r15054 | gerald | 2005-07-25 10:43:38 -0500 (Mon, 25 Jul 2005) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-radius.c + +Break out of an infinite loop. Fixes bugs 296 and 297. -try to defragment DCE/RPC fragments (simply one after the other), if alloc_hint is zero ------------------------------------------------------------------------ -r13123 | etxrab | 2005-01-19 16:44:09 -0600 (Wed, 19 Jan 2005) | 2 lines +r15055 | ulfl | 2005-07-25 12:56:19 -0500 (Mon, 25 Jul 2005) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h225.h + M /trunk/packaging/nsis/AdditionalTasksPage.ini + M /trunk/packaging/nsis/WinPcapPage.ini + M /trunk/packaging/nsis/ethereal.nsi + +bugfix: default for NPF service was default on for NT and above, but it has to be off (secure default) + +stop NPF service and set it back to "On demand" if user deselected the corresponding checkbox + +when upgrading from a previous Ethereal install, try to detect which choices of icons and alike was used last time, and set this as default (e.g. don't install desktop icon if I choose not to install last time) + +minor text changes -Attempt to reimplement "non standard data/parameter" and "tunnelled -protocol" ------------------------------------------------------------------------ -r13122 | etxrab | 2005-01-19 16:43:15 -0600 (Wed, 19 Jan 2005) | 2 lines +r15056 | ulfl | 2005-07-25 13:02:32 -0500 (Mon, 25 Jul 2005) | 3 lines Changed paths: - M /trunk/asn1/h225/h225-exp.cnf - M /trunk/asn1/h225/h225.cnf - M /trunk/asn1/h225/packet-h225-template.c + M /trunk/gtk/drag_and_drop.c + M /trunk/gtk/main.h -Attempt to reimplement "non standard data/parameter" and "tunnelled -protocol" +two bugfixes: +- don't use GtkSelectionData after returned to GTK, as it might free this data immediately (copy the data instead and free it after usage) +- fix return value handling for DnD merge, so it will work again ------------------------------------------------------------------------ -r13118 | gerald | 2005-01-18 22:49:29 -0600 (Tue, 18 Jan 2005) | 6 lines +r15057 | guy | 2005-07-25 13:03:19 -0500 (Mon, 25 Jul 2005) | 15 lines Changed paths: - M /trunk/epan/dissectors/packet-frame.c - M /trunk/epan/packet.c - M /trunk/epan/packet_info.h + M /trunk/epan/reassemble.c -Add a field called "frame.protocols" which shows the protocols present -in the frame. The filter "frame.protocols contains ip:icmp:ip" could -be used to find any ICMP packets containing IP headers. +When reassembling a packet, all data, including data with +FD_NOT_MALLOCED set, has to be copied - all FD_NOT_MALLOCED means is +that the fragment's data is part of the old reassembled data, rather +than a malloced chunk of its own (this happens if, after reassembly, the +dissector says more reassembly is necessary, as can happen, for example, +in the case of HTTP and other protocols where reassembly continues until +a terminator is seen). Not copying the data means that the reassembled +data is, in part, whatever random junk happens to be in the +newly-allocated buffer. -Clean up whitespace. +Back out the change not to copy the data, but add some sanity checks, in +the hopes of preventing the crash that caused the change not to copy the +data to be added, and in the hopes of discovering the ultimate source of +that crash and fixing it. ------------------------------------------------------------------------ -r13117 | ulfl | 2005-01-18 19:12:45 -0600 (Tue, 18 Jan 2005) | 1 line +r15058 | ulfl | 2005-07-25 13:03:38 -0500 (Mon, 25 Jul 2005) | 1 line Changed paths: - M /trunk/gtk/main.c - M /trunk/gtk/main.h - M /trunk/gtk/menu.c + M /trunk/plugins/stats_tree/pinfo_stats_tree.c -while I'm at it, add another packet details context menu item, which will link to the specific display filter reference page (just try it out :-) +fix a typo: lenght -> length ------------------------------------------------------------------------ -r13116 | ulfl | 2005-01-18 17:06:10 -0600 (Tue, 18 Jan 2005) | 1 line +r15059 | ulfl | 2005-07-25 13:27:35 -0500 (Mon, 25 Jul 2005) | 1 line Changed paths: - M /trunk/docbook/eug_src/EUG_app_files.xml - M /trunk/docbook/eug_src/EUG_app_tools.xml - M /trunk/docbook/eug_src/EUG_chapter_build_install.xml - M /trunk/docbook/eug_src/EUG_chapter_capture.xml - M /trunk/docbook/eug_src/EUG_chapter_introduction.xml - M /trunk/docbook/eug_src/EUG_chapter_io.xml - M /trunk/docbook/eug_src/EUG_chapter_statistics.xml - M /trunk/docbook/eug_src/EUG_chapter_use.xml - M /trunk/docbook/eug_src/EUG_chapter_work.xml + M /trunk/README.win32 + M /trunk/doc/README.plugins -noticed by Nicolas Kaiser: fix various typos +from Thomas Boehne: update README's to reflect latest changes ------------------------------------------------------------------------ -r13115 | ulfl | 2005-01-18 16:24:07 -0600 (Tue, 18 Jan 2005) | 1 line +r15060 | ulfl | 2005-07-25 13:30:35 -0500 (Mon, 25 Jul 2005) | 1 line Changed paths: - M /trunk/gtk/main.c - M /trunk/gtk/menu.c + M /trunk/config.nmake -added the "Online Protocol Info" to the packet details context menu with a simple_dialog doing some explanation. +update to latest zlib version 123 ------------------------------------------------------------------------ -r13113 | ulfl | 2005-01-18 14:44:11 -0600 (Tue, 18 Jan 2005) | 1 line +r15061 | ulfl | 2005-07-25 13:44:59 -0500 (Mon, 25 Jul 2005) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dcom-oxid.c + M /trunk/config.nmake -slightly improve dissection of complex_ping response +found by Thomas Boehne: corrected GTK_WIMP_DIR, used by the NSIS installer ------------------------------------------------------------------------ -r13112 | ulfl | 2005-01-18 14:42:47 -0600 (Tue, 18 Jan 2005) | 1 line +r15062 | ulfl | 2005-07-25 13:54:21 -0500 (Mon, 25 Jul 2005) | 1 line Changed paths: - M /trunk/doc/mergecap.pod + M /trunk/README.win32 -we can merge more than two files with mergecap +updated GTK-Wimp section to reflect GTK 2.4 ------------------------------------------------------------------------ -r13109 | gerald | 2005-01-18 10:00:57 -0600 (Tue, 18 Jan 2005) | 2 lines +r15063 | lego | 2005-07-25 14:03:57 -0500 (Mon, 25 Jul 2005) | 3 lines Changed paths: - M /trunk/make-version.pl + M /trunk/epan/dissectors/packet-radius.c + +Fix the IP address representation string (was inverted on little endians) + + +------------------------------------------------------------------------ +r15064 | lego | 2005-07-25 14:06:02 -0500 (Mon, 25 Jul 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-user_encap.c + +Make the DLT an option, reduce the number of instances and rename them. + + +------------------------------------------------------------------------ +r15065 | lego | 2005-07-25 14:19:34 -0500 (Mon, 25 Jul 2005) | 3 lines +Changed paths: + M /trunk/epan/dissectors/packet-radius.c + +Get rid of a unused variable -Fix the handling of "enable: 0" in version.conf. ------------------------------------------------------------------------ |