diff options
author | Michael Mann <mmann78@netscape.net> | 2017-12-28 10:27:17 -0500 |
---|---|---|
committer | Michael Mann <mmann78@netscape.net> | 2017-12-28 18:26:42 +0000 |
commit | 2980e2523ada89017037e2125cebbfb47e2f3578 (patch) | |
tree | 1425c1eee379b25aaad45fc5d1232febf5d3a586 | |
parent | 005ddc1d8b2aa079a39ace6cd65a5d2ed24aed11 (diff) |
recent.c: Make some capture_remote_* APIs static
capture_remote_combo_add_recent and capture_remote_combo_recent_write_all
aren't used outside of ui/recent.c (and shouldn't be)
Change-Id: Iaef374edfa0b2c7afa8e76cd6403d3f56dfc5539
Reviewed-on: https://code.wireshark.org/review/25038
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>
-rw-r--r-- | ui/recent.c | 15 | ||||
-rw-r--r-- | ui/recent.h | 15 | ||||
-rw-r--r-- | ui/recent_utils.h | 17 |
3 files changed, 13 insertions, 34 deletions
diff --git a/ui/recent.c b/ui/recent.c index 0b7562621e..93e15715df 100644 --- a/ui/recent.c +++ b/ui/recent.c @@ -421,7 +421,12 @@ recent_print_remote_host (gpointer key _U_, gpointer value, gpointer user) fprintf (rf, RECENT_KEY_REMOTE_HOST ": %s,%s,%d\n", ri->remote_host, ri->remote_port, ri->auth_type); } -void +/** + * Write the contents of the remote_host_list to the 'recent' file. + * + * @param rf File to write to. + */ +static void capture_remote_combo_recent_write_all(FILE *rf) { if (remote_host_list && g_hash_table_size (remote_host_list) > 0) { @@ -448,7 +453,13 @@ recent_get_remote_host(const gchar *host) return (struct remote_host *)g_hash_table_lookup(remote_host_list, host); } -gboolean +/** + * Fill the remote_host_list with the entries stored in the 'recent' file. + * + * @param s String to be filled from the 'recent' file. + * @return True, if the list was written successfully, False otherwise. + */ +static gboolean capture_remote_combo_add_recent(const gchar *s) { GList *vals = prefs_get_string_list (s); diff --git a/ui/recent.h b/ui/recent.h index 1d3296659d..5ee7e14f9c 100644 --- a/ui/recent.h +++ b/ui/recent.h @@ -244,21 +244,6 @@ extern void recent_free_remote_host_list(void); */ extern void recent_add_remote_host(gchar *host, struct remote_host *rh); -/** - * Fill the remote_host_list with the entries stored in the 'recent' file. - * - * @param s String to be filled from the 'recent' file. - * @return True, if the list was written successfully, False otherwise. - */ -extern gboolean capture_remote_combo_add_recent(const gchar *s); - -/** - * Write the contents of the remote_host_list to the 'recent' file. - * - * @param rf File to write to. - */ -extern void capture_remote_combo_recent_write_all(FILE *rf); - #ifdef __cplusplus } #endif /* __cplusplus */ diff --git a/ui/recent_utils.h b/ui/recent_utils.h index 5cd817234e..51b6d105b3 100644 --- a/ui/recent_utils.h +++ b/ui/recent_utils.h @@ -57,23 +57,6 @@ extern gboolean dfilter_combo_add_recent(const gchar *dftext); */ extern void dfilter_recent_combo_write_all(FILE *rf); -#ifdef HAVE_PCAP_REMOTE -/** Write all remote hosts to the recent file - * - * @param rf recent file - */ -void -capture_remote_combo_recent_write_all(FILE *rf); - -/** Add a new remote host from the recent file - * - * @param s string with hostname,port,auth_type - * @return TRUE if correctly added - */ -gboolean -capture_remote_combo_add_recent(const gchar *s); -#endif - /** Write all packet list geometry values to the recent file. * * @param rf recent file handle from caller |