aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbalrog <balrog@c046a42c-6fe2-441c-8c8c-71466251a162>2008-09-20 01:15:04 +0000
committerbalrog <balrog@c046a42c-6fe2-441c-8c8c-71466251a162>2008-09-20 01:15:04 +0000
commitc9a33054bf589f1d78315100c645713b04bddc31 (patch)
tree27fde9b9d5388ad945a6ee735f961861d8b2472c
parent75554a3ca10a7ad295d2a3d2e14ee6ba90f94c8b (diff)
Add a comment about masking of CTI interrupt in 16550A UART.
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5264 c046a42c-6fe2-441c-8c8c-71466251a162
-rw-r--r--hw/serial.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/hw/serial.c b/hw/serial.c
index 28d99f26c..2167b7983 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -192,6 +192,9 @@ static void serial_update_irq(SerialState *s)
if ((s->ier & UART_IER_RLSI) && (s->lsr & UART_LSR_INT_ANY)) {
tmp_iir = UART_IIR_RLSI;
} else if ((s->ier & UART_IER_RDI) && s->timeout_ipending) {
+ /* Note that(s->ier & UART_IER_RDI) can mask this interrupt,
+ * this is not in the specification but is observed on existing
+ * hardware. */
tmp_iir = UART_IIR_CTI;
} else if ((s->ier & UART_IER_RDI) && (s->lsr & UART_LSR_DR)) {
if (!(s->fcr & UART_FCR_FE)) {