diff options
| author | Igor V. Kovalenko <igor.v.kovalenko@gmail.com> | 2010-01-14 01:53:25 +0300 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2010-01-19 16:31:02 -0600 |
| commit | 4ef1a3d3b37080c9c523c403e32caff26fdd0aa4 (patch) | |
| tree | 86b1f7ca196407dfcbed95cdbc6ed08b62140fdd | |
| parent | 7b8737de0316397566c3d61de370ec7a3c24e86b (diff) | |
rtl8139: fix clang reporting unused assignment of VLAN tagging data
Currently we do not implement VLAN tagging for rtl8139(C+),
still data is read from ring buffer headers.
- augment unused assignment with TODO item
- cast txdw1 to void for now
Signed-off-by: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| -rw-r--r-- | hw/rtl8139.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/hw/rtl8139.c b/hw/rtl8139.c index 1f4f58590..f04dd5484 100644 --- a/hw/rtl8139.c +++ b/hw/rtl8139.c @@ -1909,6 +1909,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) cpu_physical_memory_read(cplus_tx_ring_desc, (uint8_t *)&val, 4); txdw0 = le32_to_cpu(val); + /* TODO: implement VLAN tagging support, VLAN tag data is read to txdw1 */ cpu_physical_memory_read(cplus_tx_ring_desc+4, (uint8_t *)&val, 4); txdw1 = le32_to_cpu(val); cpu_physical_memory_read(cplus_tx_ring_desc+8, (uint8_t *)&val, 4); @@ -1920,6 +1921,9 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) descriptor, txdw0, txdw1, txbufLO, txbufHI)); + /* TODO: the following discard cast should clean clang analyzer output */ + (void)txdw1; + /* w0 ownership flag */ #define CP_TX_OWN (1<<31) /* w0 end of ring flag */ @@ -2045,6 +2049,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) /* update ring data */ val = cpu_to_le32(txdw0); cpu_physical_memory_write(cplus_tx_ring_desc, (uint8_t *)&val, 4); + /* TODO: implement VLAN tagging support, VLAN tag data is read to txdw1 */ // val = cpu_to_le32(txdw1); // cpu_physical_memory_write(cplus_tx_ring_desc+4, &val, 4); |