diff options
| author | Harald Welte <laforge@gnumonks.org> | 2019-04-12 16:56:04 +0200 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2019-04-24 15:42:36 +0200 |
| commit | af779d2ab29235ad2ffa4701b64e8ee70f2dc048 (patch) | |
| tree | ebc41609166b01ea4d3df9e40b335bcecf466675 /include/osmocom/sgsn/gprs_llc.h | |
| parent | 1f60bbe8a218f6948520c41e6671fec59c53ef04 (diff) | |
LLC: Store the XID inside the LLC Entity, not LLC Mgmg Entity
For every logical session between a MS and the SGSN, there is one LLME
(LLC Management Entity) and a set of LLEs (Logical Link Entities): One
for each SAPI.
The XID procedure used to establish LLC configuration values such as
N201 (MTU) parameters happens on each LLE separately. The negotiated
parameters only affect that one LLE (SAPI) and are not global.
Still, the OsmoSGSN LLC code has the "struct llist_head *xid" member as
part of the gprs_llc_llme, and not as part of the gprs_llc_lle. This
list is a cache of the XID fields we have sent with the last XID
request, which is used in processing the response from the MS.
If two XID handshakes were to occur concurrently on two LLEs, the state
between them would get messed up. It must be maintained separately for
each LLE.
Closes: OS#3955
Change-Id: Iaeb54ca5ac58391be45e56c2e721f531969f3a9e
Diffstat (limited to 'include/osmocom/sgsn/gprs_llc.h')
| -rw-r--r-- | include/osmocom/sgsn/gprs_llc.h | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/include/osmocom/sgsn/gprs_llc.h b/include/osmocom/sgsn/gprs_llc.h index 376ae9a1a..711bcd6fd 100644 --- a/include/osmocom/sgsn/gprs_llc.h +++ b/include/osmocom/sgsn/gprs_llc.h @@ -145,6 +145,13 @@ struct gprs_llc_lle { unsigned int retrans_ctr; struct gprs_llc_params params; + + /* Copy of the XID fields we have sent with the last + * network originated XID-Request. Since the phone + * may strip the optional fields in the confirmation + * we need to remeber those fields in order to be + * able to create the compression entity. */ + struct llist_head *xid; }; #define NUM_SAPIS 16 @@ -169,13 +176,6 @@ struct gprs_llc_llme { uint16_t nsei; struct gprs_llc_lle lle[NUM_SAPIS]; - /* Copy of the XID fields we have sent with the last - * network originated XID-Request. Since the phone - * may strip the optional fields in the confirmation - * we need to remeber those fields in order to be - * able to create the compression entity. */ - struct llist_head *xid; - /* Compression entities */ struct { /* In these two list_heads we will store the |