diff options
| author | Vadim Yanitskiy <axilirator@gmail.com> | 2019-05-29 22:34:13 +0700 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2019-06-03 07:18:41 +0000 |
| commit | dcf2868e62f2ca5e8c81fdb20bbc4c5c5be94392 (patch) | |
| tree | 8763f37815234d8cbd4a719a5a0141629fe85767 | |
| parent | 8014917f0a803d0f5be97bc77d3dc1dcd03e176b (diff) | |
libmsc/msc_vty.c: do not abuse strlen() to check char buffers
In the most cases we need to check whether particular char buffer
is empty or not. Using strlen() for that involves more CPU power,
so let's just check the first character against '\0'.
Change-Id: I8728876b80c870e82247e6e56f719e10ed322a95
| -rw-r--r-- | src/libmsc/msc_vty.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index 5b0cfc4af..8a976cb43 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -793,11 +793,11 @@ static void vty_dump_one_subscr(struct vty *vty, struct vlr_subscr *vsub, { char buf[128]; - if (strlen(vsub->name)) { + if (vsub->name[0] != '\0') { MSC_VTY_DUMP(vty, offset, "Name: '%s'%s", vsub->name, VTY_NEWLINE); } - if (strlen(vsub->msisdn)) { + if (vsub->msisdn[0] != '\0') { MSC_VTY_DUMP(vty, offset, "MSISDN: %s%s", vsub->msisdn, VTY_NEWLINE); } @@ -873,8 +873,7 @@ static void vty_dump_one_subscr(struct vty *vty, struct vlr_subscr *vsub, osmo_fsm_inst_state_name(vsub->sgs_fsm), VTY_NEWLINE); MSC_VTY_DUMP(vty, offset, "SGs-MME: %s%s", - strlen(vsub->sgs.mme_name) ? - vsub->sgs.mme_name : "(none)", + vsub->sgs.mme_name[0] != '\0' ? vsub->sgs.mme_name : "(none)", VTY_NEWLINE); MSC_VTY_DUMP(vty, offset, "Use count total: %d%s", |