aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorPhilipp Maier <pmaier@sysmocom.de>2023-08-08 17:01:29 +0200
committerPhilipp Maier <pmaier@sysmocom.de>2023-08-08 17:04:12 +0200
commitff085f63c96b7ae9e7477aa8ed14d51ec44e6622 (patch)
treec76288052147bb76c1944943143c5ffad69777f4 /src
parentbbb3a1ed17961c433e874b799c4e34002bc11392 (diff)
pcu_sock: get rid of fn parameter in pcu_tx_pch_data_cnf
The function pcu_tx_pch_data_cnf() gets a parameter fn (frame number). This parameter is then used to populate the member fn in gsm_pcu_if_data_cnf_dt of the PCUIF protocol. However, the PCU only uses this parameter for logging and nothing else. Hence it it is not needed and we can remove it. Related: OS#5927 Depends: osmo-pcu.git I35bc99eaec5d0287ae3916bc668f0babaddfd6ce Change-Id: Id1c8fa77725129ec2ea7e92e1df493f35a277659
Diffstat (limited to 'src')
-rw-r--r--src/common/paging.c2
-rw-r--r--src/common/pcu_sock.c3
2 files changed, 2 insertions, 3 deletions
diff --git a/src/common/paging.c b/src/common/paging.c
index ebfb84b3..9738bd64 100644
--- a/src/common/paging.c
+++ b/src/common/paging.c
@@ -734,7 +734,7 @@ int paging_gen_msg(struct paging_state *ps, uint8_t *out_buf, struct gsm_time *g
GSM_MACBLOCK_LEN);
/* send a confirmation back (if required) */
if (pr[num_pr]->u.macblock.confirm)
- pcu_tx_pch_data_cnf(gt->fn, pr[num_pr]->u.macblock.msg_id);
+ pcu_tx_pch_data_cnf(pr[num_pr]->u.macblock.msg_id);
talloc_free(pr[num_pr]);
return GSM_MACBLOCK_LEN;
}
diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index ad645a0b..67958f67 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -618,7 +618,7 @@ int pcu_tx_pag_req(const uint8_t *identity_lv, uint8_t chan_needed)
return pcu_sock_send(msg);
}
-int pcu_tx_pch_data_cnf(uint32_t fn, uint32_t msg_id)
+int pcu_tx_pch_data_cnf(uint32_t msg_id)
{
struct gsm_bts *bts;
struct msgb *msg;
@@ -636,7 +636,6 @@ int pcu_tx_pch_data_cnf(uint32_t fn, uint32_t msg_id)
pcu_prim->u.data_cnf_dt = (struct gsm_pcu_if_data_cnf_dt) {
.sapi = PCU_IF_SAPI_PCH_DT,
.msg_id = msg_id,
- .fn = fn,
};
return pcu_sock_send(msg);