aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeels Hofmeyr <neels@hofmeyr.de>2020-10-10 19:02:03 +0200
committerNeels Hofmeyr <neels@hofmeyr.de>2020-10-15 05:39:10 +0200
commit737bb2f47b3547c05f4ed6b5da99d058eebfabcf (patch)
treeb1081fed107021aa03849be4b455f59e05ed2ec1
parentd3d1cb6dbc468bb8e1701092c8dabb32907a3c09 (diff)
LCS: Lb startup: no need to re-use existing SCCP user
This bit of code was borrowed from MSC handling, where multiple MSC might tap on the same SCCP user. There is only one remote SMLC, so there is no need to osmo_sccp_user_find(), just bind it and be done. Change-Id: Ia05c27c13dfb9df4f89c87b8477eea4e62fbe349
-rw-r--r--src/osmo-bsc/lb.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c
index f27a8138f..654f26144 100644
--- a/src/osmo-bsc/lb.c
+++ b/src/osmo-bsc/lb.c
@@ -465,12 +465,7 @@ static int lb_start()
LOGP(DLCS, LOGL_NOTICE, "Lb: %s %s: remote (SMLC) SCCP address: %s\n",
inst_name, smlc_name, osmo_sccp_inst_addr_name(sccp, &bsc_gsmnet->smlc->smlc_addr));
- /* Bind SCCP user. */
- bsc_gsmnet->smlc->sccp_user = osmo_sccp_user_find(sccp, bsc_gsmnet->smlc->bsc_addr.ssn, bsc_gsmnet->smlc->bsc_addr.pc);
- LOGP(DLCS, LOGL_NOTICE, "%s %s: %s\n", inst_name, smlc_name,
- bsc_gsmnet->smlc->sccp_user ? "user already bound for this SCCP instance" : "binding SCCP user");
- if (!bsc_gsmnet->smlc->sccp_user)
- bsc_gsmnet->smlc->sccp_user = osmo_sccp_user_bind(sccp, smlc_name, sccp_sap_up, bsc_gsmnet->smlc->bsc_addr.ssn);
+ bsc_gsmnet->smlc->sccp_user = osmo_sccp_user_bind(sccp, smlc_name, sccp_sap_up, bsc_gsmnet->smlc->bsc_addr.ssn);
if (!bsc_gsmnet->smlc->sccp_user)
return -EINVAL;