aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPhilipp Maier <pmaier@sysmocom.de>2018-09-25 13:18:08 +0200
committerHarald Welte <laforge@gnumonks.org>2018-09-26 17:42:37 +0000
commit0d4a98ae24eb0369605cce857284343e52de8df2 (patch)
treedbd1cb6497725f5417cd3a17abfbfe513a750bcd
parent65c62e50335b500ac9e4658530ca5a1b4f5328d8 (diff)
lcls: log channel type and lchan names on LCLS codec mismatch
When a codec mismatch (lchan type or tch_mode does not match) occurs, we do not know which of the two lchan had which type or tch_mode. Lets print that information as well to make debugging easier. Change-Id: I3fd22fef50d8944ca8c003c6114fdda37417b2ea Related: OS#1602
-rw-r--r--src/osmo-bsc/osmo_bsc_lcls.c15
1 files changed, 13 insertions, 2 deletions
diff --git a/src/osmo-bsc/osmo_bsc_lcls.c b/src/osmo-bsc/osmo_bsc_lcls.c
index 00c329683..b8bf60103 100644
--- a/src/osmo-bsc/osmo_bsc_lcls.c
+++ b/src/osmo-bsc/osmo_bsc_lcls.c
@@ -276,13 +276,24 @@ static bool lcls_enable_possible(struct gsm_subscriber_connection *conn)
if (conn->lchan->type != conn->lcls.other->lchan->type
&& conn->sccp.msc->lcls_codec_mismatch_allow == false) {
- LOGPFSM(conn->lcls.fi, "Not enabling LS due to codec mismatch (channel type)\n");
+ LOGPFSM(conn->lcls.fi,
+ "Not enabling LS due to channel type mismatch: %s:%s != %s:%s\n",
+ gsm_lchan_name(conn->lchan),
+ gsm_chan_t_name(conn->lchan->type),
+ gsm_lchan_name(conn->lcls.other->lchan),
+ gsm_chan_t_name(conn->lcls.other->lchan->type));
return false;
}
if (conn->lchan->tch_mode != conn->lcls.other->lchan->tch_mode
&& conn->sccp.msc->lcls_codec_mismatch_allow == false) {
- LOGPFSM(conn->lcls.fi, "Not enabling LS due to codec mismatch (TCH-Mode)\n");
+ LOGPFSM(conn->lcls.fi,
+ "Not enabling LS due to TCH-mode mismatch: %s:%s != %s:%s\n",
+ gsm_lchan_name(conn->lchan),
+ gsm48_chan_mode_name(conn->lchan->tch_mode),
+ gsm_lchan_name(conn->lcls.other->lchan),
+ gsm48_chan_mode_name(conn->lcls.other->lchan->
+ tch_mode));
return false;
}