diff options
| author | Jacob Erlbeck <jerlbeck@sysmocom.de> | 2014-10-28 16:23:46 +0100 |
|---|---|---|
| committer | Holger Hans Peter Freyther <holger@moiji-mobile.com> | 2014-11-14 09:12:10 +0100 |
| commit | 0074a77424c95d2d7d0608dc0dfabc1948e62fe0 (patch) | |
| tree | 13b91adf9c7e8620b94cdb1908f74b73dffe4f0d /openbsc/tests/sgsn/sgsn_test.c | |
| parent | 93eae8ec78d145cf87b7858ebee60c72da7a2d20 (diff) | |
sgsn: Cleanup GMM state transitions
Currently the GMM state is set to GMM-REGISTERED when an Attach
Accept or a RA Update Accept message is sent, even if a new P-TMSI is
included. In this case 04.08 requires (see 4.7.3.1.3 and 4.7.5.1.3),
that the state is set to GMM-COMMON-PROCEDURE-INITIATED when the
Accept is sent. When the Complete is received, the SGSN shall set
the state to GMM-REGISTERED.
This patch modifies the state updates accordingly.
Sponsored-by: On-Waves ehf
Diffstat (limited to 'openbsc/tests/sgsn/sgsn_test.c')
| -rw-r--r-- | openbsc/tests/sgsn/sgsn_test.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/openbsc/tests/sgsn/sgsn_test.c b/openbsc/tests/sgsn/sgsn_test.c index 814b45740..49ee2df20 100644 --- a/openbsc/tests/sgsn/sgsn_test.c +++ b/openbsc/tests/sgsn/sgsn_test.c @@ -376,11 +376,7 @@ static void test_gmm_attach(void) * authorization */ OSMO_ASSERT(ctx == sgsn_mm_ctx_by_tlli(foreign_tlli, &raid)); - /* FIXME: If we were authorized, the state should be - * GMM_COMMON_PROC_INIT until the Attach Complete is received, since a - * P-TMSI is included, fix state handling in gprs_gmm.c */ - - /* OSMO_ASSERT(ctx->mm_state == GMM_COMMON_PROC_INIT); */ + OSMO_ASSERT(ctx->mm_state == GMM_COMMON_PROC_INIT); /* we expect an attach accept/reject */ OSMO_ASSERT(sgsn_tx_counter == 1); |